View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004027 | Slicer4 | Core: Extensions | public | 2015-08-04 14:04 | 2018-03-02 11:06 |
Reporter | msmolens | Assigned To | msmolens | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | OS | Windows | OS Version | 8 | |
Product Version | Slicer 4.4.0 | ||||
Target Version | Slicer 4.5.0-1 | Fixed in Version | Slicer 4.5.0-1 | ||
Summary | 0004027: slicerExtensionWizard creates invalid icon files (Windows) | ||||
Description | On Windows, slicerExtensionWizard creates invalid icon files for extensions and modules. For example, the icon file for a default extension is only 6 bytes: $ ls -al Slicer/Utilities/Templates/Extensions/Default/TemplateKey.png $ ./S4D/Slicer-build/bin/slicerExtensionWizard --create MyExtension $ ls -la MyExtension This happens because the script treats all files as text when opening them to replace the template key. One fix is to open and write the files as binary. | ||||
Steps To Reproduce | $ slicerExtensionWizard --create MyExtension See that MyExtension/MyExtension.png is an invalid PNG file. | ||||
Tags | No tags attached. | ||||
Import 2017-06-07 23:51:09: master 9efd5856 2015-08-05 11:56:12 Details Diff |
BUG: Fix Extension Wizard to write icon files correctly on Windows On Windows, slicerExtensionWizard creates invalid icon files for extensions and modules. This happens because the script treats all template files as text when opening them to replace the template key, including the PNG icon files. This changes the script to open and write files in binary mode. Fixes 0004027. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24485 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Utilities/Scripts/SlicerWizard/TemplateManager.py | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-08-04 14:04 | msmolens | New Issue | |
2015-08-04 14:04 | msmolens | Status | new => assigned |
2015-08-04 14:04 | msmolens | Assigned To | => msmolens |
2015-08-04 14:52 | jcfr | Target Version | => Slicer 4.4.1 |
2015-08-05 09:31 | jcfr | Note Added: 0013227 | |
2015-08-05 09:31 | jcfr | Status | assigned => resolved |
2015-08-05 09:31 | jcfr | Fixed in Version | => Slicer 4.4.1 |
2015-08-05 09:31 | jcfr | Resolution | open => fixed |
2015-09-09 08:29 | jcfr | Fixed in Version | Slicer 4.4.1 => Slicer 4.5.0-1 |
2015-09-09 08:29 | jcfr | Target Version | Slicer 4.4.1 => Slicer 4.5.0-1 |
2017-06-10 08:51 | msmolens | Changeset attached | => Slicer master 9efd5856 |
2018-03-02 11:06 | jcfr | Status | resolved => closed |