Changesets: Import 2017-06-07 23:51:09

master 2a0621da

2016-10-31 18:27:05

lassoan

Details Diff
STYLE: Renamed vtkMRMLSegmentationDisplayNode method to be more accurate

Renamed GetAllSegmentIDs to GetSegmentIDs, as it does not always return all segment IDs.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25490 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSegmentationDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSegmentationDisplayNode.h Diff File

master 5000b37f

2016-10-28 21:25:32

jcfr

Details Diff
STYLE: TerminologyNavigatorWidget: Fix unused variable warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25489 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File

master df0d1511

2016-10-28 21:25:30

jcfr

Details Diff
COMP: TerminologyNavigatorWidget: Fix Gcc compilation error

This commit fixes a compilation error introduced in r25487 (BUG: Added
missing null-pointer checks to terminology widget)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25488 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File

master 6c0ece43

2016-10-28 19:03:07

lassoan

Details Diff
BUG: Added missing null-pointer checks to terminology widget

Caused qt designer to crash on startup.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25487 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File

master 44b61b54

2016-10-28 19:03:02

lassoan

Details Diff
BUG: Fixed regression in slicerrc file loading

There was a missing import.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25486 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/slicerqt.py Diff File

master 181644f1

2016-10-28 17:13:30

jcfr

Details Diff
BUG: Use Spline order for 3 template parameter.

This commit fixes common mistake of using dimension for spline order. It
was discovered while working on a fix for 0004290 (introduced after integrating
r25482 (ENH: Updating DCMTK to 3.6.1_2016.10.12).

Reviewed-by: Andras Lasso <lasso@queensu.ca>

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25485 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkITKTransformInverse.h Diff File

master 80ac804c

2016-10-28 12:36:25

jcfr

Details Diff
BUG: DiffusionTensor3DExtended should not use itkTypeMacro

DiffusionTensor3DExtended is not derived from itkLightObject so
it should not use itkTypeMacro.

From: Francois Budin <francois.budin@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25484 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DExtended.h Diff File

master a747a40b

2016-10-27 23:55:49

jcfr

Details Diff
ENH: Restore non-DTI part of NeurosurgicalPlanningTutorialMarkupsSelfTest

Restore the non-DTI parts of the
NeuroSurgicalPlanningTutorialMarkupsSelfTest that were removed
in r25419 (COMP: remove vtkTeem/DMRI-related tests.)

Because it is a useful test of a variety of functionality.

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25483 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Testing/Python/CMakeLists.txt Diff File
add - Modules/Loadable/Markups/Testing/Python/NeurosurgicalPlanningTutorialMarkupsSelfTest.py Diff File

master 275af16d

2016-10-27 21:33:38

jcfr

Details Diff
ENH: Updating DCMTK to 3.6.1_2016.10.12

Diff for DCMTK:
https://github.com/InsightSoftwareConsortium/DCMTK/compare/271f1e9731cfb29d9451b484ff50a39e32e2c90a...efe1a177eac040b6d41aae0db7714cd970e12bc5

A new version of ITK is required to compile Slicer with DCMTK updated:
https://github.com/Slicer/ITK/compare/16df9b689856cd4a8dd22a2cef92f5ee7222da0c...1168eba261e6a3c71c0372cc4cd833dd2d8fd693

A new version of CTK is required:
https://github.com/commontk/CTK/compare/afe8505a8286a701900fca1c97a4ad8876bbbe1a...d2b30cd1d525bd7f3856503373760921ea82dfde

A new version of BRAINSTools is required:
https://github.com/BRAINSia/BRAINSTools/compare/47dc8e66860be2bb074d17de18129978cb1ca93a...a5cfa21addf98d86da72f216d93e08913fa396d7

From: Francois Budin <francois.budin@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25482 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.txx Diff File
mod - Modules/CLI/PETStandardUptakeValueComputation/itkDCMTKFileReader.cxx Diff File
mod - Modules/CLI/PETStandardUptakeValueComputation/itkDCMTKFileReader.h Diff File
mod - SuperBuild.cmake Diff File
mod - SuperBuild/External_CTK.cmake Diff File
mod - SuperBuild/External_DCMTK.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File

master 6b315183

2016-10-27 12:55:48

johan.andruejol

Details Diff
BUG: Fix issue with qMRMLNodeComboBox when removing an attribute filter

Since QHash [] operator inserts a default-constructed value into the map
if the key is not found and because the [] operator was systematically
used, removing an attribute filter could lead the combobox to never show
anything.

The bug was as follow in pseudo-code:
combobox = slicer.qMRMLComboBox()
combobox.removeAttribute('vtkMRMLVolumeNode', 'MyAttribute')
-> Because of the [] operator, the map now has an entry for
'vtkMRMLVolumeNode' with nothing in it. It now expects nodes to have that
attribute declared (and it can have any value though).

The fix is to not use the [] operator when accessing values simply for
reading but to use the value() method instead.

Added a test along to make sure everything works properly.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25481 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/CMakeLists.txt Diff File
add - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest9.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSortFilterProxyModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSortFilterProxyModel.h Diff File

master d4b177c3

2016-10-26 12:20:58

lassoan

Details Diff
BUG: Disable view node add/delete in camera module

View nodes are created by the layout manager automatically. Users should not manipulate them.

Fixed qMRMLDisplayNodeComboBox to not crash on scene close when there are orphan view nodes.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25480 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLDisplayNodeViewComboBox.cxx Diff File
mod - Modules/Loadable/Cameras/Resources/UI/qSlicerCamerasModuleWidget.ui Diff File

master 14924da6

2016-10-26 12:20:55

lassoan

Details Diff
ENH: Made slicer startip script more discoverable

Show slicerrc file location in application settings and add a button to open it.
If the file does not exist then a default file is created.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25479 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/slicerqt.py Diff File
mod - Base/QTGUI/Resources/UI/qSlicerSettingsGeneralPanel.ui Diff File
mod - Base/QTGUI/qSlicerSettingsGeneralPanel.cxx Diff File
mod - Base/QTGUI/qSlicerSettingsGeneralPanel.h Diff File

master 5c697f42

2016-10-26 12:20:51

lassoan

Details Diff
COMP: Fixed build warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25478 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/MRMLDM/vtkMRMLSegmentationsDisplayableManager3D.cxx Diff File

master a259b83c

2016-10-24 23:01:02

lassoan

Details Diff
ENH: Enable setting larger GPU memory than 4GB

Fixes http://www.na-mic.org/Bug/view.php?id=4286

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25477 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.h Diff File
mod - Modules/Loadable/VolumeRendering/Testing/Cxx/vtkMRMLVolumeRenderingDisplayableManagerTest1.cxx Diff File

master 66719853

2016-10-24 00:27:19

lassoan

Details Diff
ENH: Reduced memory use of auto-complete effect

clippedMasterImageData is only needed for growcut, don't create it if a different method is used

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25476 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorAutoCompleteEffect.py Diff File

master 95178823

2016-10-24 00:27:16

lassoan

Details Diff
BUG: Fixed segmentation general 3D visibility option

Segmentation general 3D visibility option was ignored.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25475 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/MRMLDM/vtkMRMLSegmentationsDisplayableManager3D.cxx Diff File

master 6e4f1998

2016-10-24 00:27:12

lassoan

Details Diff
ENH: Fixed full-row selection in qMRMLSegmentsTableView

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25474 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.cxx Diff File

master db305b58

2016-10-23 07:59:35

lassoan

Details Diff
ENH: Preserve segment display properties during auto-complete effect updates

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25473 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorAutoCompleteEffect.py Diff File

master a72cc950

2016-10-21 14:43:48

lassoan

Details Diff
BUG: Fixed memory leak in auto-complete effect

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25472 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorAutoCompleteEffect.py Diff File

master 5a070c8c

2016-10-21 14:31:16

lassoan

Details Diff
ENH: Added more segment editor shortcuts

1-6 = switch effects
q w = switch active label
z y = undo redo

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25471 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.h Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.cxx Diff File
mod - Modules/Scripted/SegmentEditor/SegmentEditor.py Diff File

master 62bce492

2016-10-21 14:31:12

lassoan

Details Diff
ENH: Removed verbose logging from auto-complete effect

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25470 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorAutoCompleteEffect.py Diff File
mod - Modules/Loadable/Segmentations/Logic/vtkImageGrowCutSegment.cxx Diff File

master 1c34ab95

2016-10-21 11:03:42

lassoan

Details Diff
ENH: Improved auto-complete effect

* Fixed fast growcut update jitter. Regions that were set to a certain label sometimes changed to another on update.
* Improved auto-complete effect auto-update performance. Multiple updates are prevented by delayed update.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25469 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorAutoCompleteEffect.py Diff File
mod - Modules/Loadable/Segmentations/Logic/vtkImageGrowCutSegment.cxx Diff File

master 33581343

2016-10-20 21:18:12

lassoan

Details Diff
ENH: Added larger GPU memory options

Also translated Mo, Go to English.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25468 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/MultiVolumeRendering/MRML/vtkMRMLMultiVolumeRenderingDisplayNode.h Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumeRenderingDisplayNode.h Diff File
mod - Modules/Loadable/VolumeRendering/Resources/UI/qSlicerVolumeRenderingModuleWidget.ui Diff File
mod - Modules/Loadable/VolumeRendering/Resources/UI/qSlicerVolumeRenderingSettingsPanel.ui Diff File
mod - Modules/Loadable/VolumeRendering/Widgets/qSlicerVolumeRenderingModuleWidget.cxx Diff File
mod - Modules/Loadable/VolumeRendering/qSlicerVolumeRenderingSettingsPanel.cxx Diff File

master 01c2ca87

2016-10-20 21:18:08

lassoan

Details Diff
ENH: Improved segmentation auto-complete opacity setting GUI

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25467 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorAutoCompleteEffect.py Diff File

master af8c39f5

2016-10-20 21:18:05

lassoan

Details Diff
ENH: Use segmentation Opacity attribute only for 2D

Users most often want to tune 2D opacities (fill and outline together), while
keeping 3D opacities at 1.0 (transparency often does not help in 3D and since depth peeling does not work in
the current OpenGL1 backend, semi-transparent results are not even correct).

By using Opacity property for 2D only (fill and outline) we can show/hide segments in slice viewers without impacting 3D visibility.
It's also very convenient that slice view controller adjust this Opacity property.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25466 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/MRMLDM/vtkMRMLSegmentationsDisplayableManager3D.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 21 22 23 24 25 26 27 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last