Changesets: Import 2017-06-07 23:51:09

master 8dac11d7

2016-11-23 14:00:58

lassoan

Details Diff
BUG: Revert "BUG: ExtensionBuildSystem: Fix ExperimentalUpload on VS2013"

This reverts commit 4f45e6c05f14335a0d4c19f64b6f172bb43cb387.

It caused build errors in extensions, such as SlicerRT:

CMake Error at C:/D/N/Slicer-0-build/Slicer-build/SlicerConfig.cmake:96 (message):
To be effective, 'find_package(Slicer COMPONENTS ConfigurePrerequisites)'
should be placed before any calls to 'project()' or
'enable_language()'.Before re-configuring, make sure to clean the build
directory: C:/D/N/E-0/SlicerRT-build
Call Stack (most recent call first):
CMakeLists.txt:24 (find_package)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25572 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File

master 3d1618b2

2016-11-22 17:51:33

jcfr

Details Diff
ENH: Add python cli automating versioning of Slicer wiki documentation

See https://www.slicer.org/wiki/Documentation/Nightly/Developers/ReleaseProcess#Update_Slicer_wiki

```
$ python wiki.py --help
usage: wiki.py [-h] [--log-level LOG_LEVEL] [--password PASSWORD]
{query,copy,update} ...

This command-line tool allows to `version` Slicer mediawiki documentation. It
has three main modes of operation: ``query``, `copy` and ``update``.

positional arguments:
{query,copy,update} available sub-commands
query obtain version information
copy copy Nightly pages into RELEASE_VERSION namespace
update create and/or update wiki pages with RELEASE_VERSION

optional arguments:
-h, --help show this help message and exit
--log-level LOG_LEVEL
Level of debug verbosity. DEBUG, INFO, WARNING, ERROR,
CRITICAL.
--password PASSWORD password for 'UpdateBot' user. By default, try to get
password from 'SLICER_WIKI_UPDATEBOT_PWD' environment
variable.
```

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25571 3bd1e089-480b-0410-8dfb-8563597acbee
add - Base/Python/slicer/release/wiki.py Diff File

master 7e555562

2016-11-22 13:42:14

pinter

Details Diff
ENH: Making qSlicerTerminologyNavigatorWidget::deserializeTerminologyEntry accessible from python

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25570 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.h Diff File

master b6549477

2016-11-22 12:10:13

pinter

Details Diff
ENH: Added read-only option to segments table view and segment editor widget

If read-only is enabled in segments table view, then double-click and edit key press now do not trigger editing (selection and show/hide are still possible). Segment editor widget disables the Add and Remove segment buttons, as well as Create surface, and sets read-only flag to the table if read-only is set to true

Re https://github.com/QIICR/Reporting/issues/90

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25569 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.h Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.h Diff File

master e4efafa3

2016-11-22 12:06:29

pinter

Details Diff
BUG: Fixed category-only selection issue in Terminologies

Crash occurred if only category was selected without a type, then clicked again on the selector button. Crash is now fixed, and also the Select button is only active if the selection is invalid (it doesn't make sense to allow the user to select only a category without a type)

Fixes https://github.com/QIICR/Reporting/issues/98

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25568 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorDialog.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorDialog.h Diff File

master 51220abe

2016-11-22 09:55:31

pieper

Details Diff
ENH: 0004146 add advisor for dicom extensions

After an import to the dicom database the contents
are checked against a pre-configured file that suggests
possible extensions.

See:

http://www.na-mic.org/Bug/view.php?id=4146

https://github.com/QIICR/Reporting/pull/71#

ENH: improve message about dicom extensions

Now the datatype is described in a human readable form.

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25567 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOM/CMakeLists.txt Diff File
add - Modules/Scripted/DICOM/DICOMExtensions.json Diff File
mod - Modules/Scripted/DICOMLib/DICOMPlugin.py Diff File
mod - Modules/Scripted/DICOMLib/DICOMWidgets.py Diff File

master aaa8aa5b

2016-11-22 01:03:37

lassoan

Details Diff
BUG: Segment editor create default segmentation fixed

After scene close new default segmentation node or existing segmentation node is correctly created/selected.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25566 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/SegmentEditor/SegmentEditor.py Diff File

master 5b3834ec

2016-11-22 01:03:30

lassoan

Details Diff
BUG: Fixed segmentation controller slice view widget

Segmentation state is correctly updated on scene close or when segmentation is deleted.
Visible segments list state is correctly displayed when adding/removing segments.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25565 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Resources/UI/qMRMLSegmentSelectorWidget.ui Diff File
mod - Libs/MRML/Widgets/qMRMLSegmentSelectorWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File

master ffd102a4

2016-11-21 21:22:18

fedorov

Details Diff
BUG: remove deprecated DICOM SEG export from Editor

This functionality depended on now deprecated and non-existing functionality in
the Reporting module. The updated version of the Reporting module uses dcmqi,
https://github.com/QIICR/dcmqi, for DICOM SEG conversion, which in turn has an
interface different from what is used in this implementation.

DICOM SEG export will be provided in the updated Reporting extension, which is
reusing Segment Editor components for editing. It is possible that this export
functionality will be available in the main application in the future.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25564 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File
mod - Modules/Scripted/EditorLib/LabelStructureListWidget.py Diff File

master 9c318571

2016-11-21 16:58:04

pinter

Details Diff
ENH: Added capability to load terminology from DICOM SEG descriptor

Needed for adding terminology information from DICOM SEG loading. The DICOM plugin that employs this feature is currently located at https://github.com/QIICR/Reporting/blob/master/Py/DICOMSegmentationPlugin.py

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25563 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.h Diff File

master 2ad07586

2016-11-21 14:16:47

lassoan

Details Diff
ENH: Add mirror and normals auto-orient to Surface Toolbox

Author: Beatriz Paniagua <beatriz.paniagua@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25562 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.h Diff File
mod - Modules/Scripted/SurfaceToolbox/SurfaceToolbox.py Diff File

master 82cacf74

2016-11-20 20:20:57

lassoan

Details Diff
COMP: Fixed build error

CMake Error at Modules/Loadable/CMakeLists.txt:37 (add_subdirectory):

The binary directory



C:/D/E/Slicer-0-build/Slicer-build/Modules/Loadable/SubjectHierarchy



is already used to build a source directory. It cannot be used to build

source directory



C:/D/E/Slicer-0/Modules/Loadable/SubjectHierarchy

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25561 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CMakeLists.txt Diff File

master 634e6ac1

2016-11-20 06:49:59

lassoan

Details Diff
COMP: Fixed build error

34>c:\d\n\slicer-1-build\slicer-build\modules\loadable\markups\subjecthierarchyplugins\../../../../../../Slicer-1/Modules/Loadable/Markups/SubjectHierarchyPlugins/qSlicerSubjectHierarchyMarkupsPlugin.h(27): fatal error C1083: Cannot open include file: 'qSlicerSubjectHierarchyAbstractPlugin.h': No such file or directory (C:\D\N\Slicer-1-build\Slicer-build\Modules\Loadable\Markups\SubjectHierarchyPlugins\moc_qSlicerSubjectHierarchyMarkupsPlugin.cxx) [C:\D\N\Slicer-1-build\Slicer-build\Modules\Loadable\Markups\SubjectHierarchyPlugins\qSlicerMarkupsSubjectHierarchyPlugins.vcxproj] [C:\D\N\Slicer-1-build\Slicer.vcxproj]

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25560 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CMakeLists.txt Diff File

master 880cce00

2016-11-20 03:00:28

jcfr

Details Diff
COMP: Fix Markups build error ensuring SH headers are available

This commit fixes a build error caused by a change in the build order
of the loadable module and introduced by r25551 (ENH: Allow display
transform glyphs at markup positions).

Before r25551:

[...]
Colors
SubjectHierarchy
Transforms
Annotations
Data
DoubleArrays
Markups
[...]


After r25551:

[...]
Colors
Annotations
Markups
Transforms
SubjectHierarchy
Data
DoubleArrays
[...]

Build error fixed by this commit:

/path/to/Slicer/Modules/Loadable/Markups/SubjectHierarchyPlugins/qSlicerSubjectHierarchyMarkupsPlugin.cxx:28:50: fatal error: qSlicerSubjectHierarchyPluginHandler.h: No such file or directory
compilation terminated.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25559 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CMakeLists.txt Diff File

master 3348b0bd

2016-11-20 03:00:26

jcfr

Details Diff
STYLE: vtkSlicerTransformLogic: Fix unused variable warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25558 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Transforms/Logic/vtkSlicerTransformLogic.cxx Diff File

master 62431b3d

2016-11-19 15:11:54

pinter

Details Diff
ENH: Terminology now uses code to identify entry

Instead of only using CodeMeaning, terminology logic now uses CodingSchemeDesignator and CodeValue to identify an entry. As a side effect, redundant members were removed and lookup became faster. Segments only contain one tag with the whole serialized terminology entry instead of 8 tags, and it does not contain recommended color any more. Terminology JSON files were changed so that capitalization is consistent across terminology dictionary files

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25557 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkSegment.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegment.h Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.h Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.h Diff File
mod - Modules/Loadable/Terminologies/Resources/AnatomicRegionModifier-Master.json Diff File
mod - Modules/Loadable/Terminologies/Resources/SegmentationCategoryTypeModifier-DICOM-Master.json Diff File
mod - Modules/Loadable/Terminologies/Resources/SegmentationCategoryTypeModifier-SlicerGeneralAnatomy.json Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyItemDelegate.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorButton.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorButton.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorDialog.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorDialog.h Diff File

master a3c8f8bd

2016-11-19 08:16:52

lassoan

Details Diff
COMP: Fixed build error

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25556 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File

master a214874e

2016-11-19 07:55:40

lassoan

Details Diff
COMP: Fixed build error caused by transform logic relocation

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25555 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.h Diff File
mod - Modules/CLI/ProbeVolumeWithModel/CMakeLists.txt Diff File
mod - Modules/Loadable/Data/CMakeLists.txt Diff File
mod - Modules/Loadable/Data/qSlicerDataModuleWidget.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Logic/CMakeLists.txt Diff File
mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx Diff File
mod - Modules/Loadable/Transforms/Logic/vtkSlicerTransformLogic.cxx Diff File
mod - Modules/Loadable/Transforms/Logic/vtkSlicerTransformLogic.h Diff File

master 4f45e6c0

2016-11-18 16:06:54

jcfr

Details Diff
BUG: ExtensionBuildSystem: Fix ExperimentalUpload on VS2013

This commit fixes the following error:

CUSTOMBUILD : error : could not find CMAKE_PROJECT_NAME in Cache [C:\D\N\exStone-build\ExperimentalUpload.vcxproj]

More details: http://slicer-devel.65872.n3.nabble.com/error-during-ExperimentalUpload-build-could-not-find-CMAKE-PROJECT-NAME-in-Cache-tt4037574.html

Reported-by: Hammond, Emily M <emily-hammond@uiowa.edu>
Reported-by: qimo601 <qimo601@126.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25554 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File

master 4e6b9d2d

2016-11-18 14:49:39

jcfr

Details Diff
STYLE: CMake: Remove unused and unmaintained custom FindCuda module

Originally introduced in 2008 by r7552 (ENH:added cuda CMake scripts) and
last updated in 2009 by r9363 (COMP: fix cmake file for machines that
don't have cuda sdk installed ), this module and associated file
are removed.

Up-to-date and maintained version is available in CMake:

https://cmake.org/cmake/help/v3.7/module/FindCUDA.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25553 3bd1e089-480b-0410-8dfb-8563597acbee
rm - CMake/cuda/CudaDependency.cmake Diff File
rm - CMake/cuda/FindCuda.cmake Diff File
rm - CMake/cuda/empty.depend.in Diff File
rm - CMake/cuda/make2cmake.cmake Diff File
rm - CMake/cuda/parse_cubin.cmake Diff File

master b25d2f40

2016-11-18 14:41:07

jcfr

Details Diff
BUG: ExtensionBuildSystem: Ensure GIT_EXECUTABLE set in SliceConfig is used

This problem is not revealed when Slicer extensions are
configured and built automatically by the Extensions build system setup
on the factory machines. In that case, variables like git and svn paths
are explicitly passed to the extension and added to the cache
using the "-D" cmake arguments.

Instead, this commit fixes a problem occurring when an extension is
configured manually by only passing "-DSlicer_DIR:PATH=/path/to/Slicer-SuperBuild-Release/Slicer-build/"

In that case, because the value of GIT_EXECUTABLE is set in
SlicerConfig (see r25523) and then mark_as_advanced is used
in FindGit module, it triggered https://gitlab.kitware.com/cmake/cmake/issues/15448

This commit workaround the problem commenting "mark_as_advanced"

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25552 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/FindGit.cmake Diff File

master 215aecd9

2016-11-18 13:44:48

lassoan

Details Diff
ENH: Allow display transform glyphs at markup positions

It is now possible to show where a markup point is transformed to using transform visualization.
Select "Glyph" visualization mode, open "Advanced" section and set "Source points".
Glyphs are updated in real-time as markups are moved, so this can be also used for probing the transformation
by drag-and-dropping markups in 2D and 3D views.

Transform logic needed access to Markups node, therefore module logic was moved to Modules/Loadable/Transforms/Logic.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25551 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/CMakeLists.txt Diff File
mod - Base/Logic/Testing/CMakeLists.txt Diff File
mod - Libs/MRML/Core/vtkMRMLTransformDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformDisplayNode.h Diff File
mod - Modules/Loadable/CMakeLists.txt Diff File
mod - Modules/Loadable/Data/CMakeLists.txt Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Logic/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/CMakeLists.txt Diff File
add - Modules/Loadable/Transforms/Logic/CMakeLists.txt Diff File
add - Modules/Loadable/Transforms/Logic/Testing/CMakeLists.txt Diff File
add - Modules/Loadable/Transforms/Logic/Testing/Cxx/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/MRMLDM/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/MRMLDM/vtkMRMLTransformsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Transforms/MRMLDM/vtkMRMLTransformsDisplayableManager3D.cxx Diff File
mod - Modules/Loadable/Transforms/Widgets/Resources/UI/qMRMLTransformDisplayNodeWidget.ui Diff File
mod - Modules/Loadable/Transforms/Widgets/qMRMLTransformDisplayNodeWidget.cxx Diff File
mod - Modules/Loadable/Transforms/Widgets/qMRMLTransformDisplayNodeWidget.h Diff File

master ac503f49

2016-11-18 02:56:26

jcfr

Details Diff
STYLE: Fix spelling 'additonal' -> 'additional'

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25550 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File
mod - Base/QTCore/Testing/Cxx/qSlicerExtensionsManagerModelTest.cxx Diff File
mod - Base/QTCore/qSlicerCoreCommandOptions.cxx Diff File
mod - Base/QTCore/qSlicerCoreCommandOptions.h Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Extensions/CMake/SlicerBlockAdditionalLauncherSettings.cmake Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.h Diff File

master a9518b13

2016-11-18 02:14:53

jcfr

Details Diff
STYLE: vtkSegmentationHistory: Fix typo in doxygen

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25549 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkSegmentationHistory.h Diff File

master 1e9db297

2016-11-18 01:34:04

jcfr

Details Diff
STYLE: External_SlicerExecutionModel: Simplify enabling of Param Serializer

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25548 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File
 First  Prev  1 2 3 ... 10 ... 18 19 20 21 22 23 24 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last