Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master f96c2639

2016-12-23 10:40:15

lassoan

Details Diff 		BUG: Fixed crash in scene view node saving

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25622 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File

master fd7074c7

2016-12-22 16:19:56

lassoan

Details Diff 		BUG: Fixed error message in segment editor threshold effect deactivation

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25621 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorThresholdEffect.py Diff File

master f0b4c7c6

2016-12-21 23:46:07

lassoan

Details Diff 		ENH: Improved backward compatibility of segment color loading

In older scenes, segment color is stored in ColorX attributes, while in new scenes override segment color is stored in OverrideColorX attributes.
To better preserve segment color, interpret ColorX attributes as override color.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25620 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSegmentationDisplayNode.cxx Diff File

master 671bbc05

2016-12-21 12:48:48

lassoan

Details Diff 		ENH: Added option to hide segments from segments table

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25619 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Testing/Python/CMakeLists.txt Diff File
add - Modules/Loadable/Segmentations/Testing/Python/SegmentationWidgetsTest1.py Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.h Diff File

master b2be8f35

2016-12-21 08:07:50

lassoan

Details Diff 		ENH: Force extension description generator to use LF as newline

It makes generated description file contents more predictable.
This fixes tension tests on platforms where newline is CRLF.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25618 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerFunctionGenerateExtensionDescription.cmake Diff File

master c9007334

2016-12-21 08:07:46

lassoan

Details Diff 		ENH: Made py_CLIEventTest more robust

cli.Running event may or may not be fired. Ignore it to prevent random test failures.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25617 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CLIEventTest.py Diff File

master 89ccc01b

2016-12-20 20:42:45

lassoan

Details Diff 		ENH: Turned on output testing for MRML logic tests

Output testing makes the test fail if any unexpected VTK errors or warnings are logged (and it also makes VTK logs visible on the dashboard).
Fixed test failures (they were all test errors).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25616 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SliceLinkLogic.py Diff File
mod - Libs/MRML/Logic/Testing/Cxx/CMakeLists.txt Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLAbstractLogicSceneEventsTest.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLDisplayableHierarchyLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicCompareTest.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest3.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest5.cxx Diff File

master dfd5c06c

2016-12-20 20:42:37

lassoan

Details Diff 		BUG: Fixed error in file extension parsing

The bug was introduced yesterday as a side effect.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25615 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLStorageNode.cxx Diff File

master 74c9c6b1

2016-12-20 15:17:43

naucoin

Details Diff 		ENH: Add missing python load utility methods

The python utility file was missing methods to load Annotation
rulers and ROIs, this change adds:
loadAnnotationRuler('ruler.acsv')
loadAnnotationROI('box.acsv')

Issue 0004319

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25614 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File

master fbca8d66

2016-12-19 21:27:07

lassoan

Details Diff 		BUG: Fixed file extension extraction logic

For transform file sometransform_version2.0_some.h5 it returned .0_some.h5 as extension (instead of the correct .h5).

Solution: wildcard matching is only used if no specific extension is matched.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25613 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/Testing/Cxx/qSlicerCoreIOManagerTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLStorageNode.cxx Diff File

master b7f1a5f2

2016-12-14 21:40:35

jcfr

Details Diff 		ENH: Update CTK to include ctkSettings python wrapping improvements

$ git shortlog 9743ee2..fc0b1b7 --no-merges
Andras Lasso (1):
ENH: Improved python wrapping for ctkSettings

Nicolas Vuaille (1):
Fixes warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25612 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 7112b229

2016-12-14 21:32:59

lassoan

Details Diff 		ENH: DICOM Browser implementation as window, dialog, dock

- window mode:
- DICOM Browser lost behind mainWindow user can just
click on DCM icon for bringing it to the front
- DICOMWidget:
- added setter/getter for widget type
- new mixin class: SizePositionSettingsMixin
- saving/restoring dialog size and position
- used for DICOM Browser and DICOMHeaderPopup
- taking care of z window ordering

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25611 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOM/DICOM.py Diff File
mod - Modules/Scripted/DICOMLib/DICOMWidgets.py Diff File

master 00f4d75d

2016-12-14 13:17:58

pinter

Details Diff 		ENH: Default segment names and terminologies; changed terminology selector layout

By default segments get consecutive colors from the generic anatomy color table, Tissue/Tissue terminology entry, and the same name as before (Segment_N). They now store whether name and color are automatically generated, and the auto-generated values only override these values if they were not manually changed.
Terminology selector layout has been changed, and name field added on the bottom.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25610 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSegmentationDisplayNode.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegment.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegment.h Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentsTableView.h Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologyCategory.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologyCategory.h Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologyEntry.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologyEntry.h Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologyType.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologyType.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/CMakeLists.txt Diff File
add - Modules/Loadable/Terminologies/Widgets/Resources/Icons/ResetProperty.png Diff File
mod - Modules/Loadable/Terminologies/Widgets/Resources/UI/qSlicerTerminologyNavigatorWidget.ui Diff File
add - Modules/Loadable/Terminologies/Widgets/Resources/qSlicerTerminologiesModuleWidgets.qrc Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyItemDelegate.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyItemDelegate.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorButton.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorButton.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorDialog.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologySelectorDialog.h Diff File

master c3006a4d

2016-12-13 21:46:22

lassoan

Details Diff 		ENH: Added DICOMPatcher module for fixing up DICOM files before importing

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25609 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/CMakeLists.txt Diff File
add - Modules/Scripted/DICOMPatcher/CMakeLists.txt Diff File
add - Modules/Scripted/DICOMPatcher/DICOMPatcher.py Diff File
add - Modules/Scripted/DICOMPatcher/Resources/Icons/DICOMPatcher.png Diff File

master e568f213

2016-12-13 09:52:07

jcfr

Details Diff 		STYLE: External_python-pydicom: Remove unused patch code

This commit removes code obsoleted by previous commit.

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25608 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_python-pydicom.cmake Diff File

master e0b4654f

2016-12-13 09:52:06

jcfr

Details Diff 		ENH: Update pydicom from 0.9.8 to 0.9.9

The main reason is that 0.9.8 fails to load files that have special characters in their name.

0.9.9 doesn't need patching of setup.py anymore (in 0.9.8, first 3 lines of setup.py had to be removed to avoid loading some old dependencies).

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25607 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_python-pydicom.cmake Diff File

master 8b5647e1

2016-12-12 09:46:17

jcfr

Details Diff 		ENH: Update CTK to include fix for multiple view display in layouts

$ git shortlog d2b30cd..9743ee2 --no-merges
Amir Kalali (2):
Add a DICOM database query to retrieve SOPInstanceUIDs via a SeriesInstanceUID
Renamed 'sopsForSeries' to 'instancesForSeries' to be more consistent with other methods

Andras Lasso (1):
BUG: Fixed multiple view display in layouts

Jean-Christophe Fillion-Robin (1):
ENH: Update to DCMTK-3.6.1_20161102

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25606 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master b8aff4e5

2016-12-11 08:38:57

lassoan

Details Diff 		BUG: Restored previous layout behavior

Enabling cached views in layouts caused regression in compare layouts.
Restoring previous behavior until fix is implemented in CTK.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25605 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx Diff File

master e316f4a9

2016-12-10 21:49:15

lassoan

Details Diff 		BUG: Fixed tabbed slice and 3D view layouts

Problem: only one view shows up in Tabbed slice and Tabbed 3D layouts.

Root cause: UseCachedViews in layout factory was disabled, which prevented reusing views created by other layouts in tabbed layouts.

Solution: Use default UseCachedViews setting (caching enabled).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25604 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx Diff File

master fca1f0ca

2016-12-08 17:41:36

jcfr

Details Diff 		ENH: vtkMRMLVolumeNodeTest1: Test "IJKtoRAS to/from ScanOrder" conversion

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25603 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLVolumeNodeTest1.cxx Diff File

master 0833beea

2016-12-08 17:37:51

jcfr

Details Diff 		STYLE: qSlicerSegmentEditorScissorsEffect: Fix "unused-variable" warning

This commit fixes this warning:

/path/to/Slicer/Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorScissorsEffect.cxx:376:16: warning: unused variable ‘position’ [-Wunused-variable]
double position[3] = { 0 };
^

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25602 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorScissorsEffect.cxx Diff File

master 4ca110e9

2016-12-08 17:37:49

jcfr

Details Diff 		STYLE: qSlicerSegmentEditorPaintEffect: Fix "pointer-arith" warning

This commit fixes this warning:

/path/to/Slicer/Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx:614:78: warning: NULL used in arithmetic [-Wpointer-arith]
if (this->BrushToWorldOriginTransformer->GetNumberOfInputConnections(0) == NULL || q->integerParameter("BrushPixelMode"))

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25601 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File

master d0fb1efa

2016-12-08 17:37:48

jcfr

Details Diff 		STYLE: qSlicerSegmentEditorAbstractEffect: Fix "reorder" warnings

This commit fixes warnings like this one:

qSlicerSegmentEditorAbstractEffect.h:377:61: warning: ‘qSlicerSegmentEditorAbstractEffect::d_ptr’ will be initialized after [-Wreorder]
QScopedPointer<qSlicerSegmentEditorAbstractEffectPrivate> d_ptr;
^

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25600 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorAbstractEffect.cxx Diff File

master a2ca6f97

2016-12-08 17:37:47

jcfr

Details Diff 		STYLE: vtkMRMLSegmentationNode: Fix unused-parameter segmentId warnings

This commit fixes these warnings:

/path/to/Slicer/Libs/MRML/Core/vtkMRMLSegmentationNode.cxx:265:58: warning: unused parameter ‘segmentId’ [-Wunused-parameter]
void vtkMRMLSegmentationNode::OnSegmentAdded(const char* segmentId)
^
/path/to/Slicer/Libs/MRML/Core/vtkMRMLSegmentationNode.cxx:270:60: warning: unused parameter ‘segmentId’ [-Wunused-parameter]
void vtkMRMLSegmentationNode::OnSegmentRemoved(const char* segmentId)
^
/path/to/Slicer/Libs/MRML/Core/vtkMRMLSegmentationNode.cxx:275:61: warning: unused parameter ‘segmentId’ [-Wunused-parameter]
void vtkMRMLSegmentationNode::OnSegmentModified(const char* segmentId)
^

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25599 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSegmentationNode.cxx Diff File

master 0ae228cf

2016-12-08 17:22:11

jcfr

Details Diff 		STYLE: SegmentEditorPaintEffect: Minor simplification to ease code reading

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25598 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 16 17 18 19 20 21 22 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last