Changesets: Import 2017-06-07 23:51:09

master 3292cc1e

2017-03-06 10:49:03

lassoan

Details Diff
ENH: Set segment editor length spinbox step size based on volume spacing

Step size in millimeter value selectors for margin effect and smoothing effect is set based on output volume spacing.
This makes it easier to set values for volumes with very small or very large spacing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25747 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorLogicalEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorMarginEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorSmoothingEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorAbstractEffect.cxx Diff File

master 285d77c5

2017-03-06 10:49:00

lassoan

Details Diff
ENH: Improved segment order in split to islands effect result

Updated Segment editor / Islands effect / Split to segments so that the new segments are
inserted into the segmentation right after the segment that was split.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25746 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorIslandsEffect.py Diff File

master 328b5a3d

2017-03-06 10:48:56

lassoan

Details Diff
BUG: Fixed segmentation undo/redo to preserve segment order

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25745 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkSegmentation.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegmentation.h Diff File
mod - Libs/vtkSegmentationCore/vtkSegmentationHistory.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegmentationHistory.h Diff File
mod - Modules/Loadable/Segmentations/Logic/vtkSlicerSegmentationsModuleLogic.cxx Diff File
mod - Modules/Loadable/Segmentations/Logic/vtkSlicerSegmentationsModuleLogic.h Diff File

master 3c131550

2017-03-03 17:26:09

jcfr

Details Diff
BUG: Fix setting of slice viewer offset

This commit fixes a regression introduced in r25741 (ENH: Remove
sliceBounds assert from qMRMLSliceControllerWidgetPrivate) where
the logic originally captured by the Q_ASSERT was incorrectly
adapted.

Reported-by: Neal Siekierski <neal.siekierski@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25744 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File

master afeba986

2017-03-03 01:21:28

lassoan

Details Diff
ENH: Added test for SegmentStatistics, fixed CSV export

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25743 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/SegmentStatistics/SegmentStatistics.py Diff File

master 48a32d6a

2017-03-01 15:25:41

pinter

Details Diff
ENH: Added option to load terminology json files from GUI

The loaded json file is copied to the settings directory, from where it is automatically loaded at startup

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25742 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.h Diff File
mod - Modules/Loadable/Terminologies/Widgets/Resources/UI/qSlicerTerminologyNavigatorWidget.ui Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.h Diff File
mod - Modules/Loadable/Terminologies/qSlicerTerminologiesModule.cxx Diff File

master 533f2c7f

2017-03-01 13:59:52

lassoan

Details Diff
ENH: Remove sliceBounds assert from qMRMLSliceControllerWidgetPrivate

Removed Q_ASSERT(sliceBounds[4] <= sliceBounds[5]), as invalid slice bounds is not an error (it just means there is no content in the slice view).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25741 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File

master 40265e5f

2017-03-01 13:59:49

lassoan

Details Diff
BUG: Fixed duplicate items in DICOM plugin advisor

The same extensions and data types were reported several times.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25740 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMLib/DICOMWidgets.py Diff File

master 55a6a845

2017-03-01 13:59:46

lassoan

Details Diff
ENH: Updated to latest CTK

* ENH: Implemented justified style for flow layout

It allows variable sized items (so that they use the space optimally) and nice visual alignment at the same time
(all rows have the same width).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25739 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master a2176d90

2017-03-01 13:59:43

lassoan

Details Diff
COMP: Fixed build warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25738 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx Diff File

master 62e0ff14

2017-03-01 13:59:40

lassoan

Details Diff
BUG: Fixed Island effect split method

Island effect split method was failing on linux and mac because vtkITKIslandMath filter does not work with long input scalar type on linux and mac

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25737 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/vtkITKIslandMath.h Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorIslandsEffect.py Diff File

master b357ac07

2017-03-01 13:59:36

lassoan

Details Diff
BUG: Fixed scene saving

Saved scene was corrupted due to missing " character

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25736 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLClipModelsNode.cxx Diff File

master 40559d1c

2017-03-01 11:58:44

pinter

Details Diff
BUG: Removed Apply button from draw effect

The Apply button did not work after closing scene. It could have been fixed by keeping track of the slice view on which the user drew last and then call apply on that pipeline, but we decided to remove the Apply button instead, and force the user to use the much simpler mouse right button and Enter key shortcuts

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25735 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorDrawEffect.py Diff File

master 0fed8940

2017-02-28 12:42:01

pieper

Details Diff
ENH: 0004347 add confirmation dialog loading dicom with warnings

Only display the dialog in non-advanced mode since the warnings
are already visible to the user in advanced mode.

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25734 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMLib/DICOMWidgets.py Diff File

master eee645ce

2017-02-27 19:09:08

agirault

Details Diff
ENH: Added straight vs whole cell clipping option for meshes

See: http://na-mic.org/Mantis/view.php?id=4335

From: Sam Horvath <sam.horvath@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25733 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLClipModelsNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLClipModelsNode.h Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLClipNodeWidget.ui Diff File
mod - Libs/MRML/Widgets/qMRMLClipNodeWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLClipNodeWidget.h Diff File

master 07b4b431

2017-02-27 10:15:28

pieper

Details Diff
COMP: add custom widget declaration to get correct case

Without this declaration, a linux build results in a missing
header ctksliderwidget.h. On windows or on mac with a non-case
sensitive file system this wouldn't be an error.

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25732 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Resources/UI/qMRMLDisplayNodeWidget.ui Diff File

master 50c3f3af

2017-02-27 09:22:02

agirault

Details Diff
ENH: Added opacity setting for 2D slice intersections

See: http://na-mic.org/Mantis/view.php?id=4334

From: Sam Horvath <sam.horvath@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25731 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayNode.h Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLDisplayNodeWidget.ui Diff File
mod - Libs/MRML/Widgets/qMRMLDisplayNodeWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLDisplayNodeWidget.h Diff File

master 54698ba4

2017-02-26 16:47:15

lassoan

Details Diff
ENH: Improved segment editor GUI

* Show effect name in toolbar by default: it makes effects easier to recognize (especially on HiDPI screens). Style can be changed by calling setEffectButtonStyle method.
* Auto-complete effect is split to two effects: grow from seeds, fill between slices (based on feedback of several users).
* Scissors effect uses radio buttons

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25730 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/Python/CMakeLists.txt Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorDrawEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorEffects.__init__.py.in Diff File
add - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorFillBetweenSlicesEffect.py Diff File
add - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorGrowFromSeedsEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorLevelTracingEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorLogicalEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorThresholdEffect.py Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorAbstractEffect.cxx Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorScissorsEffect.cxx Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorScissorsEffect.h Diff File
mod - Modules/Loadable/Segmentations/Widgets/Resources/UI/qMRMLSegmentEditorWidget.ui Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.h Diff File

master e0a230a2

2017-02-26 10:10:16

lassoan

Details Diff
ENH: Removed false positive error message

Setting an empty labelmap in a segment is a valid operation, no need to report it as an error.
Now logged at debug level instead.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25729 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Logic/vtkSlicerSegmentationsModuleLogic.cxx Diff File

master 03e2de94

2017-02-24 17:20:13

jcfr

Details Diff
ENH: Update CTK to include ctkFittedTextBrowser fix

git shortlog fc0b1b7..443dc27 --no-merges
Andras Lasso (1):
BUG: Fixed ctkFittedTextBrowser height computation for wide content

Jean-Christophe Fillion-Robin (6):
circleci: Rename image "ctk-test:opengl" into "ctk-test:opengl-qt4"
circleci/Dockerfile-qt4: Speed up package install and optimize image size
circleci: Add support for testing Qt5 build
DICOM/Widgets: Fix "unused-but-set-variable" warning
XNAT/Core: Fix warnings
XNAT/Core: Fix unused warning in ctkXnatObject::fetchResources

Julien Finet (2):
Increment QtTesting version
Fix compilation with Qt < 5.1.1

Stephen R. Aylward (1):
BUG: Missing vtkRenderingFreeType library option

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25728 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLTreeViewEventPlayer.cpp Diff File
mod - Libs/MRML/Widgets/qMRMLTreeViewEventPlayer.h Diff File
mod - Libs/MRML/Widgets/qMRMLTreeViewEventTranslator.cpp Diff File
mod - Libs/MRML/Widgets/qMRMLTreeViewEventTranslator.h Diff File
mod - SuperBuild/External_CTK.cmake Diff File

master 54c17843

2017-02-24 17:11:35

jcfr

Details Diff
BUG: Update ITK to fix building of SlicerPathology extension

Reported-by: Andriy Fedorov <fedorov@bwh.harvard.edu>

// -------------------------------------
commit Slicer/ITK@1619816
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Mon Jan 23 13:47:32 2017 -0500

COMP: Add missing headers in OpenCVImageBridge

These are required when building the ITKExamples Superbuild.
// -------------------------------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25727 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

master e1fa0c72

2017-02-24 11:53:43

jcfr

Details Diff
BUG: Update ITK to fix ITKExternalMod/SlicerExt additional config (ITK-3529)

commit Slicer/ITK@3f7ce93
Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date: Fri Feb 24 11:46:58 2017 -0500

Revert "BUG: Include installed modules in ITK_MODULES_ENABLED"

References:
* https://issues.itk.org/jira/browse/ITK-3529
* https://github.com/Slicer/Slicer/pull/674

This reverts commit InsightSoftwareConsortium/ITK@4f8b60f

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25726 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

master 64adf78c

2017-02-24 10:33:37

pinter

Details Diff
BUG: Proper cleanup when exiting in case layout is destroyed before module

Update of fix in rev25723

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25725 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File

master 594440b3

2017-02-23 19:57:13

jcfr

Details Diff
STYLE: Add message error CircleCI does not build changes to Slicer dependencies

This error appears when the slicer/slicer-build-deps docker image is not
updated with the actual version of slicer.

In order to fix the issue, please create a Pull Request like this one
https://github.com/thewtex/SlicerDocker/pull/21

This will build and push all images based on the newer version of Slicer

From: Mayeul Chassagnard <mayeul.chassagnard@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25724 3bd1e089-480b-0410-8dfb-8563597acbee
mod - circle.yml Diff File

master e5413061

2017-02-23 17:34:46

pinter

Details Diff
BUG: Fixed crash when restarting Slicer after using paint effect in Segment Editor

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25723 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File
 First  Prev  1 2 3 ... 10 11 12 13 14 15 16 17 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last