Posted notices to slicer-devel Feb 16:

http://massmail.spl.harvard.edu/public-archives/slicer-devel/2017/041438.html

No objections, so we'll take that to mean go ahead (people can complain later if they don't like it).

Fix committed in r25734

There are problems with this change when loading RT dose for example, because the scalar volume plugin logs warning, but then the RT plugin can load it without problems. I think we should only show this confirmation if the plugin returning the highest confidence logs warnings.

(Actually this seems to have been suggested by Andrey as well: "...if the highest priority loadable has warnings...")

Steve, if you agree then I'll commit a fix.

Good point - I missed that case. Yes, if you want to address that go ahead or I can do it in a bit.

I made a commit (25768) that should address this. Thanks!

It would also be great if I could disable the popup in Applicaiton Settings or similar, because some of my test data gives warnings, and the popup stops the test script from finishing, but I'd like it to use that data throughout the test.

Thanks for the fix Csaba!

Regarding not having the popup, I thought about adding a special flag for that but there's already a conditional for self.advancedView and I thought that anyone who wants to bypass the dialog could just put the window into advancedView model to save having yet another configuration option. What do you think of that solution?

BTW, looking at it now that class has gotten pretty huge and it would probably make sense to refactor out the load logic from the widget.

If I can just enable advancedView it's fine! Do I have to then make extra calls (like examine) in that case? Thanks!