Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master 2ed4ee2a

2017-03-12 15:44:27

jcfr

Details Diff 		ENH: slicerMacroBuildAppLibrary: Add support for WRAP_PYTHONQT

Suggested-by: Alexis Girault <alexis.girault@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25822 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroBuildApplication.cmake Diff File

master 48930175

2017-03-12 15:44:26

jcfr

Details Diff 		BUG: Update CTK to allow ctkMacroWrapPythonQt working with absolute paths

$ git shortlog a6738bd..18019ae --no-merges
Jean-Christophe Fillion-Robin (1):
BUG: ctkMacroWrapPythonQt: Fix handling of absolute input file paths

Reported-by: Alexis Girault <alexis.girault@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25821 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 9295173f

2017-03-12 15:44:24

jcfr

Details Diff 		COMP: Update SlicerExecutionModel to include warning fixes

git shortlog 62d0121..61bb14d --no-merges
Jean-Christophe Fillion-Robin (9):
STYLE: GenerateCLPTest: Update print_command_as_string to display working dir
BUG: Fix GenerateCLP tests when JsonCpp and Serializer support are ON
STYLE: GenerateCLP tests: Consistently use GenerateCLP_TEST_PROJECT macros
ENH: ci: Run tests against ITK v4.10.1
ENH: ci: Speedup testing caching docker images using scikit-ci-addons
STYLE: circle: Update indent to facilitate reading of configuration file
ENH: Add test building and running test with Serializer and JsonCpp ON
COMP: GenerateCLP: Fix -Wunused-variable warning
COMP: GenerateCLP: Fix -Wshadow warning

Stephen Aylward (1):
BUG: ModuleDescription: Param LibraryLoader shadows this->LibraryLoader

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25820 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File

master 40790a04

2017-03-12 15:44:22

jcfr

Details Diff 		COMP: Update CTK to fix unused variable warning

$ git shortlog 3b68bff..a6738bd --no-merges
Jean-Christophe Fillion-Robin (1):
COMP: ctkVTKDataSetArrayComboBox: Fix unused variable warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25819 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 486883c4

2017-03-12 15:44:21

jcfr

Details Diff 		BUG: Update EMSegment to fix -Winfinite-recursion warning

This commit fixes the following warning:

/path/to/Slicer-build/EMSegment/MRML/vtkMRMLEMSVolumeCollectionNode.h:64:3: warning: all paths through this function will call itself [-Winfinite-recursion]
{
^

Updates:

* r17126 | jcfr | 2017-03-12 14:33:29 -0400 (Sun, 12 Mar 2017) | 1 line
COMP: vtkMRMLEMSVolumeCollectionNode: Fix -Winfinite-recursion warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25818 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 09e6f551

2017-03-12 15:44:19

jcfr

Details Diff 		COMP: qMRMLModelDisplayNodeWidget.cxx: Fix -Wsometimes-uninitialized

/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:483:7: warning: variable 'newMin' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
if (precision != 0.0)
^~~~~~~~~~~~~~~~
/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:499:43: note: uninitialized use occurs here
d->DisplayedScalarRangeWidget->setRange(newMin, newMax);
^~~~~~
/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:483:3: note: remove the 'if' if its condition is always true
if (precision != 0.0)
^~~~~~~~~~~~~~~~~~~~~
/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:480:16: note: initialize the variable 'newMin' to silence this warning
double newMin;
^
= 0.0
/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:483:7: warning: variable 'newMax' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
if (precision != 0.0)
^~~~~~~~~~~~~~~~
/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:499:51: note: uninitialized use occurs here
d->DisplayedScalarRangeWidget->setRange(newMin, newMax);
^~~~~~
/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:483:3: note: remove the 'if' if its condition is always true
if (precision != 0.0)
^~~~~~~~~~~~~~~~~~~~~
/path/to/Slicer/Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx:481:16: note: initialize the variable 'newMax' to silence this warning
double newMax;
^
= 0.0

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25817 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx Diff File

master 862391ef

2017-03-12 15:44:17

jcfr

Details Diff 		BUG: vtkMRMLMarkupsNode::DeleteText(): Fix -Wfor-loop-analysis

/path/to/Slicer/Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx:320:20: warning: variables 'id' and 'n' used in loop condition not modified in loop body [-Wfor-loop-analysis]
for (int i = id; id < n-1; i++ )
^~ ~

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25816 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/Testing/Cxx/vtkMRMLMarkupsNodeTest1.cxx Diff File

master ae6db971

2017-03-12 15:44:15

jcfr

Details Diff 		BUG: Update OpenIGTLinkIF to include UnpackIGTLMessage fix

$ git shortlog c45030e..bfe21de --no-merges
Jean-Christophe Fillion-Robin (2):
COMP: vtkIGTLToMRMLBase: Fix unused variable warnings
COMP: vtkMRMLIGTLConnectorNode: Fix sign-compare warning

Longquan Chen (2):
EHN: UnpackIGTLMessage needs to be performed if the IGTLToMRML is called from outside projects. otherwize, the InImageMessage is not initialized and causes an invalid memory access bug,
ENN: removed unused variable, refer to ISSUE#62

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25815 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 5feba474

2017-03-12 15:44:14

jcfr

Details Diff 		COMP: vtkMRMLMarkupsDisplayNode: Fix -Wpointer-bool-conversion

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25814 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsDisplayNode.cxx Diff File

master cac2ceed

2017-03-12 15:44:12

jcfr

Details Diff 		COMP: vtkAnnotationROIRepresentation: Fix -Wpointer-bool-conversion

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25813 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.cxx Diff File

master 3ddbbd6a

2017-03-12 15:44:10

jcfr

Details Diff 		COMP: vtkMRMLAnnotation(Point|Line)DisplayNode: Fix -Wpointer-bool-conversion

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25812 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationLineDisplayNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationPointDisplayNode.cxx Diff File

master 9afe366f

2017-03-12 15:44:08

jcfr

Details Diff 		COMP: qMRMLDisplayNodeWidget.ui: Fix invalid buddy assignment warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25811 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Resources/UI/qMRMLDisplayNodeWidget.ui Diff File

master f9ba546c

2017-03-12 15:44:06

jcfr

Details Diff 		COMP: itkMRMLIDImageIO: Fix -Wsometimes-uninitialized warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25810 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIO.cxx Diff File

master 43983f23

2017-03-12 15:44:04

jcfr

Details Diff 		COMP: vtkTransformVisualizerGlyph3D: Fix -Wunused-const-variable warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25809 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkTransformVisualizerGlyph3D.cxx Diff File

master e5db9d35

2017-03-12 15:44:03

jcfr

Details Diff 		COMP: vtkSlicerApplicationLogic: Fix -Wself-assign warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25808 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File

master 4e873be3

2017-03-12 15:44:00

jcfr

Details Diff 		COMP: vtkSlicerSceneViewsModuleLogic: Fix -Wunused-const-variable warning

This commit remove unused variable introduced in r24952 (ENH: Improved
axes-type orientation marker size and position)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25807 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLOrientationMarkerDisplayableManager.cxx Diff File

master bc1e64da

2017-03-12 15:43:58

jcfr

Details Diff 		COMP: vtkSlicerCropVolumeLogic::CropInterpolated: Fix -Wmissing-braces

suggest braces around initialization of subobject [-Wmissing-braces]
double outputDirectionColRow[3][3] = { 0 };
^

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25806 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CropVolume/Logic/vtkSlicerCropVolumeLogic.cxx Diff File

master 729b8bbe

2017-03-12 15:43:56

jcfr

Details Diff 		COMP: CLI/ExtractSkeleton/SkelGraph: Fix -Wmismatched-new-delete warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25805 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ExtractSkeleton/SkelGraph.cxx Diff File

master d5355b33

2017-03-12 15:43:53

jcfr

Details Diff 		COMP: vtkPolyDataToFractionalLabelmapFilter: Fix -Wbool-conversion warning

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25804 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilter.cxx Diff File

master c79cc7a5

2017-03-12 15:43:51

jcfr

Details Diff 		COMP: vtkSlicerSceneViewsModuleLogic: Fix unused constant warning

This commit removes unused constant obsoleted by r23160 (ENH: html
facelift for SceneViews)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25803 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.cxx Diff File

master 75aa85f2

2017-03-12 15:43:49

jcfr

Details Diff 		COMP: vtkITK: Fix -Wabsolute-value warning using std::abs

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25802 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkMorphologicalContourInterpolator.hxx Diff File

master b86e3c35

2017-03-12 15:43:48

jcfr

Details Diff 		ENH: Update EMSegment to include Qt5 support and fix Clang warning

* r17125 | jcfr | 2017-03-11 18:18:35 -0500 (Sat, 11 Mar 2017) | 1 line
STYLE: vtkEMSegmentLogic: Fix -Wabsolute-value warning using std::abs

* r17124 | jcfr | 2017-01-17 07:58:32 -0500 (Tue, 17 Jan 2017) | 1 line
ENH: Add support for Qt5

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25801 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 66eab25d

2017-03-12 15:43:46

jcfr

Details Diff 		STYLE: Specify "this->" when invoking instance function.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25800 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Widgets/qSlicerMarkupsPlaceWidget.cxx Diff File
mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyComboBox.cxx Diff File

master 864fb80e

2017-03-12 15:43:43

jcfr

Details Diff 		COMP: Fix unused variable warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25799 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerDirectoryListView.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLCrosshairDisplayableManager.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLCaptureToolBar.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLayoutManager.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLayoutWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLTransformSliders.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkFractionalLabelmapToClosedSurfaceConversionRule.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilter.cxx Diff File
mod - Modules/Loadable/CropVolume/MRML/vtkMRMLCropVolumeParametersNode.h Diff File
mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/Widgets/qSlicerMarkupsPlaceWidget.cxx Diff File
mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx Diff File
mod - Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx Diff File
mod - Modules/Loadable/Models/qSlicerModelsModuleWidget.cxx Diff File
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorAbstractEffect.cxx Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorAbstractLabelEffect.cxx Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyComboBox.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx Diff File
mod - Modules/Loadable/Tables/qSlicerTablesModuleWidget.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.cxx Diff File
mod - Modules/Loadable/Units/qSlicerUnitsSettingsPanel.cxx Diff File
mod - Modules/Loadable/Volumes/Widgets/qSlicerDiffusionTensorVolumeDisplayWidget.cxx Diff File
mod - Modules/Loadable/Volumes/Widgets/qSlicerLabelMapVolumeDisplayWidget.cxx Diff File

master a61cbc75

2017-03-11 18:59:23

lassoan

Details Diff 		ENH: Added vtkMRMLSubjectHierarchyNode:RequestOwnerPluginSearch for dataNodes

It works for data nodes that are not in the subject hierarchy yet.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25798 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.h Diff File
 First  Prev  1 2 3 ... 8 9 10 11 12 13 14 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last