View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001349Slicer4Core: GUIpublic2011-08-20 19:172017-06-07 23:27
Reporterkikinis Assigned Tojcfr  
PriorityhighSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.0.0 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0001349: Error icon is missing from main window
Description

http://www.slicer.org/slicerWiki/index.php/Modules:MainApplicationGUI-Documentation-3.6#Error_Log

see red icon in lower right.

Having this become visible when there are error messages, would be a good way to alert users to the fact that something is not working. Perhaps moving it from the lower right to the icons in the tool bars would be a better location in slicer 4

TagsNo tags attached.

Relationships

related to 0001153 assignedjcfr Report scene loading errors 
related to 0001310 closedfinetjul the pull down menu called Window 
related to 0003016 closedjcfr Saving to network drive/mount does not work (vtkPNGWriter, both Linux and Windows) -- and no error message 
related to 0003151 closedjcfr toolbars for error log and extension manager 
related to 0002537 closedjcfr expose output and error logs to the slicer.app.errorlogmodel object 

Activities

finetjul

finetjul

2011-08-20 19:22

administrator   ~0002760

I'm not sure having an "error status" icon has its place in a toolbar. The error logger is already available from the View menu.

I kind of I liked the location in Slicer3, maybe we could make it more visible if it was on the left side of the status bar.

As an implementation point, we might want to have ctkErrorLogWidget emitting a separate signal when it receives an "error", a "warning" or an "info".
kikinis

kikinis

2011-08-21 06:06

developer   ~0002761

same location as in slicer 3 is ok.has to be sufficiently far from the right corner that the corner graphic in snowleopard does not overlap.
Having the error logger in the view menu is good, but there it is hidden from view. When an error occurs its not visible. So you have to know to look for it, which users might not. If there is an error, we should alert the user, but not panic them.
btw: slicer 3 let you email the entire error log. Slicer 4 currently only lets you access one error message at a time.
jcfr

jcfr

2012-02-16 09:46

administrator   ~0003649

1) Select one or more item in the log widget, they will all be displayed in the description below. The widget understand the usual CTRL/Shift key modified. (Like in a excel spreadsheet)

2) Select text in the description box .. then CTRL-C (or corresponding copy command on mac) to copy .. then paste in your favorite email client.
kikinis

kikinis

2012-05-09 20:16

developer   ~0004282

The error log icon should be visible somewhere on the main gui. When an error occurs, it should change its appearance. This was the case in Slicer 3 and is still missing from Slicer 4.

2012-05-09 20:18

 

RaiseErrorLog.png (75,074 bytes)
RaiseErrorLog.png (75,074 bytes)
blowekamp

blowekamp

2013-08-19 10:38

developer   ~0009517

Posted to the dev-list:

I have been introducing a number of new users to Slicer over the past couple of weeks. One of the common things that happens, is they say something didn't work. Nothing happened, and are mystified. I then usually explain to them the error log an how to check it when things don't go as expected.

The users not getting a visible feedback as to something went wrong, or they simply forgetting to set a parameter is very frustrating to them. This occurs in may places such as in the Model Maker module when forgetting to select/create a MoodelHierarchy.

At minimal it'd be great to add error/warning/info icon to say the bottom right to indicate that there was a new message. Or perhaps toggle the saturation of the error log button in the tool bar for a period after the message occurs. As of not I don't see how they are suppose to be notified.
jcfr

jcfr

2013-08-20 11:44

administrator   ~0009533

Change currently being reviewed - See https://github.com/jcfr/Slicer/commit/a619c4648566d1b6d7ddf6084d035334d114f616 and https://github.com/jcfr/CTK/commit/0ab3178f06da5279626a1e631ea16ffe3087cacd
jcfr

jcfr

2013-08-20 15:28

administrator   ~0009537

Fixed in r22304
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22304
jcfr

jcfr

2013-08-21 12:16

administrator   ~0009542

Tweaked in r22305
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22305
jcfr

jcfr

2013-08-21 20:56

administrator   ~0009545

Tweaker in r22307
See See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22307
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014608

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file cfacb19c

2013-08-20 19:27:13

jcfr

Details Diff 		BUG: Add error log button to mainwindow

Each time a Warning/Error/Fatal message is logged, the tool button
associated with the error icon is highlighted.

If the user either

(1) click on the button

or

(2) focus on the error log widget in case it was already visible, the
icon associated with the tool button is "un-highlighted".

Fixes 0001349
Fixes 0002537

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22304 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Resources/UI/qSlicerAppMainWindow.ui Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.h Diff File
mod - SuperBuild/External_CTK.cmake Diff File

Slicer: 2145-support-for-installing-extension-from-file 8aed71ab

2013-08-21 16:15:20

jcfr

Details Diff 		STYLE: Simplify error log widget eventFilter

Instead of creating a specific event filter class "qSlicerErrorLogWidgetEventFilter",
re-use the already installed eventFilter associated with the main window.
See "qSlicerAppMainWindow::eventFilter"

See issue 0001349

Co-authored-by: Julien Finet <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22305 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.h Diff File

Slicer: 2145-support-for-installing-extension-from-file e7da80d6

2013-08-22 00:47:58

jcfr

Details Diff 		BUG: Ensure ErrorLog/PythonConsole menu entry bring dialog to foreground

This commit partly revert commit r19500 making sure the errorLog and
pythonconsole menu entry are non-checkable. It means that if one of the
dialog is already shown but in the background, selecting the menu entry
will bring the dialog to the foreground instead of hiding it.

Also simplify who the errorLog button interact with its associated
ErrorLog dialog by simply associated the corresponding QAction.

Note also that the QAction icon is the one that is now
highlighted/unhighlighted based on the addition of new
warning/error/cricial messages. The icon is now updated both
in the bottom right corner (Error log button) and in the menu entries.

See issue 0001349

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22307 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Resources/UI/qSlicerAppMainWindow.ui Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.h Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindowCore.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindowCore.h Diff File

Issue History

Date Modified Username Field Change
2011-08-20 19:17 finetjul New Issue
2011-08-20 19:17 finetjul Status new => assigned
2011-08-20 19:17 finetjul Assigned To => jcfr
2011-08-20 19:18 finetjul Reporter finetjul => kikinis
2011-08-20 19:18 finetjul Relationship added related to 0001310
2011-08-20 19:22 finetjul Note Added: 0002760
2011-08-21 06:06 kikinis Note Added: 0002761
2011-08-25 09:27 finetjul Target Version => Slicer 4.0 RSNA
2012-02-16 09:16 finetjul Relationship added related to 0001153
2012-02-16 09:46 jcfr Note Added: 0003649
2012-05-09 20:16 kikinis Note Added: 0004282
2012-05-09 20:18 kikinis File Added: RaiseErrorLog.png
2012-05-10 14:19 jcfr Assigned To jcfr => crmullin
2012-10-22 07:36 jcfr Target Version Slicer 4.0.0 => Slicer 4.3.0
2013-03-23 11:38 jcfr Relationship added related to 0003016
2013-07-09 07:51 finetjul Relationship added related to 0003151
2013-08-19 10:38 blowekamp Note Added: 0009517
2013-08-19 11:01 jcfr Priority normal => high
2013-08-19 11:01 jcfr Assigned To crmullin => jcfr
2013-08-20 06:46 jcfr Relationship added related to 0002537
2013-08-20 11:44 jcfr Note Added: 0009533
2013-08-20 11:44 jcfr Status assigned => feedback
2013-08-20 15:28 jcfr Note Added: 0009537
2013-08-20 15:28 jcfr Status feedback => resolved
2013-08-20 15:28 jcfr Fixed in Version => Slicer 4.3.0
2013-08-20 15:28 jcfr Resolution open => fixed
2013-08-21 12:16 jcfr Note Added: 0009542
2013-08-21 20:56 jcfr Note Added: 0009545
2013-08-31 04:39 kikinis Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file e7da80d6
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 8aed71ab
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file cfacb19c
2017-06-07 23:27 jcfr Note Added: 0014608