Changesets: Slicer

2145-support-for-installing-extension-from-file a6934aae

2014-01-07 13:13:10

finetjul

Details Diff
STYLE: Add X,O,M and S documentation for VolumeRendering module

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22805 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Documentation/VolumeRendering.xml Diff File

2145-support-for-installing-extension-from-file 7d1c27fa

2014-01-07 13:12:49

finetjul

Details Diff
BUG: Cleanup ROI widget and representation

This reverts commit r22803 inadvertently pushed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22804 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeDisplayNode.h Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationROIDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.h Diff File

2145-support-for-installing-extension-from-file ba09f5dc

2014-01-07 13:09:37

finetjul

Details Diff
STYLE: Cleanup ROI widget and representation

Add vtkMRMLDisplayNode::GetBounds() utility method.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22803 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeDisplayNode.h Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationROIDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.h Diff File

2145-support-for-installing-extension-from-file 95ac0418

2014-01-07 00:44:32

jcfr

Details Diff
STYLE: Consistently report error in vtkMRMLNRRDStorageNode read/write method

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22802 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNRRDStorageNode.cxx Diff File

2145-support-for-installing-extension-from-file 2a1f15b2

2014-01-07 00:44:27

jcfr

Details Diff
BUG: Fix reading of DWI files. Fixes 0003545

This commit fixes regression introduced by commit r22753 fixing issue 0003511
that was preventing "vtkNRRDReader::CanReadFile" from returning the correct
value.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22801 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkNRRDReader.cxx Diff File

2145-support-for-installing-extension-from-file 894bbb07

2014-01-06 13:16:30

naucoin

Details Diff
BUG: fix updating fiducials after scene load

After loading a scene, changing the display properties of
a fiducial list was not being reflected in the 2d and 3d
views. There was a missing event observation in the
Markups displayable managers, adding in
vtkMRMLDisplayableNode::DisplayModifiedEvent
to the list of events observed on a markups node
fixed the problem.

Issue 0003480



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22800 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager3D.cxx Diff File

2145-support-for-installing-extension-from-file 16c7b04d

2014-01-06 12:50:04

jcfr

Details Diff
COMP: Fix error when building against Qt not having SSL support.

Commit r22782 was done under the assumption that Qt would be built with SSL
support. This commit ensures Qt with/without SSL support is supported.

Note that the build system could be improved to detect with Qt has
OpenSSL support, if this is the case, the OpenSSL project could be
automatically enabled unless explicitly disabled.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22799 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerWebWidget.cxx Diff File
mod - Base/QTGUI/qSlicerWebWidget.h Diff File

2145-support-for-installing-extension-from-file 355c8e06

2014-01-06 10:05:26

jcfr

Details Diff
COMP: Ensure python is forced to Release when built on single config system

Following previous commit (r22797), since CMAKE_BUILD_TYPE is now properly
passed to all projects, it is important to force the value associated to
python to Release.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22798 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_python.cmake Diff File

2145-support-for-installing-extension-from-file a04374a2

2014-01-06 09:54:35

jcfr

Details Diff
COMP: Pass CMAKE_BUILD_TYPE to external project for all configurations

Thanks to Hans Johnson <hans-johnson@uiowa.edu> for reporting the problem.

Before this commit, CMAKE_BUILD_TYPE was passed to external project only
the first configuration if it wasn't already defined (by passing -D option).

Co-authored-by: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22797 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file 9f0833be

2014-01-05 21:16:04

jcfr

Details Diff
ENH: Kill CLI executable process on Slicer exit.

The use of a MutexLock is required because the process have been
initiated from a thread and they are killed by calling "itksysProcess_Kill()"
from the main thread.

In "ApplyTask()", the MutexLock is Locked/Unlocked at the position:

1) After calling "itksysProcess_Kill()" in "KillProcesses()", the call to
"itksysProcess_WaitForExit()" in "ApplyTask()" leads to a call
"kwsysProcessCleanup". Since calling "kwsysProcessCleanup" frees the memory
(i.e free ForkPIDs, RealWorkingDirectory and also cleanup descriptor)
and that "kwsysProcess_Kill" expects the ForkPIDs array to be available,
it is required to use a mutex to make sure the call to "kwsysProcess_Kill"
completes before "itksysProcess_WaitForExit" is executed.

2) When calling "itksysProcess_Delete()" and updating the vector of
"Processes" that is accessed from both the main thread and the ApplyTask
thread.

Fixes 0003395

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22796 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIExecutableModuleFactory.cxx Diff File
mod - Base/QTCLI/qSlicerCLIExecutableModuleFactory.h Diff File
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.h Diff File

2145-support-for-installing-extension-from-file 3200d4f2

2014-01-05 21:15:58

jcfr

Details Diff
STYLE: Simplify code using "vtkNew" to create "vtkSlicerTask" in CLI logic

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22795 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File

2145-support-for-installing-extension-from-file ce2f6c1e

2014-01-03 16:02:29

pieper

Details Diff
COMP: fix warnings in cmake/ctk/python

See:
https://github.com/commontk/CTK/pull/430

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22794 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file b7c81385

2014-01-03 14:05:19

pieper

Details Diff
COMP: handle case where TCL is disabled but EM is set to ON.

If you have first configured with TCL on, then EMSegment is on
by default too. But turning off TCL does not turn off EMSegment,
so the linker was failing to find the EMSegment logic library.

This patch is consistent with the rest of the logic in the
CMakeLists, but longer term EMSegment should be explicitly
disabled if it doesn't have the right prerequisites.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22793 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Cpp/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file 9e230ada

2013-12-31 17:21:06

pieper

Details Diff
ENH: update LandmarkRegistration to support RegistrationPlugins

Still some work to do on the built-in plugins, but the framework
is now in place for extensions (like SlicerRT/Plastimatch) to provide
registration plugins.

Affine registration is now a plugin and it works like the previous
version of LandmarkRegistration which supported only Affine.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22792 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

2145-support-for-installing-extension-from-file 95fd51ff

2013-12-19 22:21:24

jcfr

Details Diff
ENH: Fix module history to keep most recent selected module last

The current implementation is a dysfunctional mix between
a "module history navigator" and "fixed workflow navigator".

This commit implements "module history navigator" behavior,
which is useful for generic Slicer use.

A "fixed workflow navigator" is a very special case, it is only
applicable when all the modules are part of the workflow,
there are no loops, skipping of steps, auxiliary modules, etc.

Considering the following convention, the update is illustrated
below.

Legend:

-> X : Go to module X
P : List of module in the "previous stack"
N : List of module in the "next stack"

Current behaviour:

A P: - | N: -
-> B P: A | N: -
-> C P: BA | N: -
-> D P: CBA | N: -
-> A P: - | N: BCD
-> E P: A | N: -

After integrating this commit, the behaviour is then:

A P: - | N: -
-> B P: A | N: -
-> C P: BA | N: -
-> D P: CBA | N: -
-> A P: DCB | N: -
-> E P: ADCB | N: -

where

A: Welcome module
B: Annotations
C: Data
D: DataStore
E: SampleData

Fixes 0003533

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22791 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerModuleSelectorToolBar.cxx Diff File

2145-support-for-installing-extension-from-file b2a88002

2013-12-19 21:47:04

jcfr

Details Diff
STYLE: Update doxygen comment of vtkMRMLScene::AddReferencedNodeID

The comment document the changes introduced by commit r22669

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22790 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File

2145-support-for-installing-extension-from-file e70b1b07

2013-12-19 21:46:54

jcfr

Details Diff
STYLE: Improve readability of vtkMRMLScene::AddReferencedNodeID method

This commit does not introduced any functional change, it just makes
the code cleaner.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22789 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLModelNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File

2145-support-for-installing-extension-from-file 19bc562f

2013-12-19 21:46:42

jcfr

Details Diff
BUG: Added missing node references update to scene->AddNode methods

Fixes http://na-mic.org/Mantis/view.php?id=3539.

Problem was that node references were not updated in the scene when
node->SetScene(scene) was called for the node before scene->AddNode(node).

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22788 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File

2145-support-for-installing-extension-from-file af65ff60

2013-12-18 16:40:09

jcfr

Details Diff
ENH: Add 'DataStore' to top-level module category.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22787 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

2145-support-for-installing-extension-from-file 63fef02a

2013-12-18 10:30:42

fedorov

Details Diff
BUG: check that the frame image has been initialized

Fixes 0003535


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22786 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

2145-support-for-installing-extension-from-file e7102b54

2013-12-17 18:42:15

pieper

Details Diff
ENH: Add prototype LandmarkRegistration and CompareVolumes modules

These are still work-in-progress modules, but should be usable to
support interatcive registration.

See https://github.com/pieper/LandmarkRegistration

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22785 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

2145-support-for-installing-extension-from-file a44d8757

2013-12-17 16:05:36

jcfr

Details Diff
COMP: Remove 'python_install_chmod_library' external project install step

Since the transition to CMake'ified python, this extra step is not
required anymore because the installed file has the expected
permissions.

Because the timestamp of the library is not systematically modified, it
will avoid the systematic recompilation of all project linking against
python library and speed up the overall MacOSX developer experience.


Before the update:

[...]
-- Installing: /path/to/python-install/lib/python2.7/zipfile.py
Performing python_install_chmod_library step for 'python'
Performing python_customPython_configure step for 'python'
Completed 'python'
$ ls -als python-install/lib/
total 3688
0 drwxr-xr-x 5 kitware staff 170 Dec 17 16:00 .
0 drwxr-xr-x 6 kitware staff 204 Dec 17 16:00 ..
3688 -rwxr-xr-x 1 kitware staff 1886288 Dec 17 16:00 libpython2.7.dylib
0 drwxr-xr-x 5 kitware staff 170 Dec 17 16:00 pkgconfig
0 drwxr-xr-x 234 kitware staff 7956 Dec 17 16:00 python2.7


After the update:

[...]
-- Installing: /path/to/python-install/lib/python2.7/zipfile.py
[ 18%] Performing python_customPython_configure step for 'python'
[ 18%] Completed 'python'
$ ls -als python-install/lib/
total 3688
0 drwxr-xr-x 5 kitware staff 170 Dec 17 16:02 .
0 drwxr-xr-x 6 kitware staff 204 Dec 17 16:02 ..
3688 -rwxr-xr-x 1 kitware staff 1886288 Dec 17 16:02 libpython2.7.dylib
0 drwxr-xr-x 5 kitware staff 170 Dec 17 16:02 pkgconfig
0 drwxr-xr-x 234 kitware staff 7956 Dec 17 16:02 python2.7

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22784 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_python.cmake Diff File

2145-support-for-installing-extension-from-file 35f3bf01

2013-12-17 12:09:54

jcfr

Details Diff
COMP: Fix build issue 0003522 due to nice() and getpid() calls.

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22783 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File

2145-support-for-installing-extension-from-file 10f2c02c

2013-12-17 12:09:05

jcfr

Details Diff
BUG: Fix "No handleSslErrors" slot run time error

Since by default moc (MetaObject compiler) doesn't understand ifdef, let
simply expect that SSL headers are available and unconditionally include
the "handleSslErrors". For this to work, we would have to associated a
compile definition with moc.

Since the QSslError header was already unconditionally included, defining
the slot is not a problem.

Error was:
Object::connect: No such slot qSlicerWebWidget::handleSslErrors(QNetworkReply*, const QList<QSslError> & ) in /home/jchris/Projects/Slicer/Base/QTGUI/qSlicerWebWidget.cxx:99
Object::connect: (receiver name: 'qSlicerWebWidget')

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22782 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerWebWidget.cxx Diff File
mod - Base/QTGUI/qSlicerWebWidget.h Diff File

2145-support-for-installing-extension-from-file eb412957

2013-12-17 10:16:17

jcfr

Details Diff
COMP: Fix configuration adding missing parameter to ExternalProject_Add_Source

Following commit r22776, the macro ExternalProject_Add_Source has been
added and jqPlot retrieved using it but the URL and URL_MD5 parameters
were not considered. This probably happens because the jqPlot directory
was already existing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22781 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/ExternalProjectAddSource.cmake Diff File
 First  Prev  1 2 3 4 5 6 7 8 9 10 ... 20 ... 30 ... 40 ... 50 ... 55 56 57  Next  Last