View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003533 | Slicer4 | Core: GUI | public | 2013-12-16 16:11 | 2017-06-10 08:51 |
Reporter | lassoan | Assigned To | jcfr | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.4.0 | Fixed in Version | Slicer 4.4.0 | ||
Summary | 0003533: Module selector drops modules from the next list | ||||
Description | The current module selector history works like an undo/redo action history: if we go back in the history and perform a different action that it was originally in the history it removes all the "next" actions. This is a necessary behavior for undo/redo stacks (as it is not possible to apply a "next" action on a changed current state), but it is an unnecessary inconvenience for a module history. In case of a model history we can simply insert a new module into the history, as there is no actual processing action is performed, so there is no inconsistency in application state (we can switch to another module regardless of what previous modules we visited in what order). Example: Current behavior:
Correct behavior:
| ||||
Tags | No tags attached. | ||||
The fix is very simple, see pull request: |
|
Fixed in r22791 |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Fix committed to 2145-support-for-installing-extension-from-file branch. |
|
Slicer: 2145-support-for-installing-extension-from-file 95fd51ff 2013-12-19 22:21:24 Details Diff |
ENH: Fix module history to keep most recent selected module last The current implementation is a dysfunctional mix between a "module history navigator" and "fixed workflow navigator". This commit implements "module history navigator" behavior, which is useful for generic Slicer use. A "fixed workflow navigator" is a very special case, it is only applicable when all the modules are part of the workflow, there are no loops, skipping of steps, auxiliary modules, etc. Considering the following convention, the update is illustrated below. Legend: -> X : Go to module X P : List of module in the "previous stack" N : List of module in the "next stack" Current behaviour: A P: - | N: - -> B P: A | N: - -> C P: BA | N: - -> D P: CBA | N: - -> A P: - | N: BCD -> E P: A | N: - After integrating this commit, the behaviour is then: A P: - | N: - -> B P: A | N: - -> C P: BA | N: - -> D P: CBA | N: - -> A P: DCB | N: - -> E P: ADCB | N: - where A: Welcome module B: Annotations C: Data D: DataStore E: SampleData Fixes 0003533 From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22791 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Base/QTGUI/qSlicerModuleSelectorToolBar.cxx | Diff File | ||
Import 2017-06-07 23:51:09: master 95fd51ff 2013-12-19 22:21:24 Details Diff |
ENH: Fix module history to keep most recent selected module last The current implementation is a dysfunctional mix between a "module history navigator" and "fixed workflow navigator". This commit implements "module history navigator" behavior, which is useful for generic Slicer use. A "fixed workflow navigator" is a very special case, it is only applicable when all the modules are part of the workflow, there are no loops, skipping of steps, auxiliary modules, etc. Considering the following convention, the update is illustrated below. Legend: -> X : Go to module X P : List of module in the "previous stack" N : List of module in the "next stack" Current behaviour: A P: - | N: - -> B P: A | N: - -> C P: BA | N: - -> D P: CBA | N: - -> A P: - | N: BCD -> E P: A | N: - After integrating this commit, the behaviour is then: A P: - | N: - -> B P: A | N: - -> C P: BA | N: - -> D P: CBA | N: - -> A P: DCB | N: - -> E P: ADCB | N: - where A: Welcome module B: Annotations C: Data D: DataStore E: SampleData Fixes 0003533 From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22791 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Base/QTGUI/qSlicerModuleSelectorToolBar.cxx | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-12-16 16:11 | lassoan | New Issue | |
2013-12-16 16:13 | lassoan | Note Added: 0010438 | |
2013-12-19 17:13 | jcfr | Assigned To | => lassoan |
2013-12-19 17:13 | jcfr | Status | new => assigned |
2013-12-19 17:13 | jcfr | Target Version | => Slicer 4.4.0 |
2013-12-19 17:24 | jcfr | Note Added: 0010454 | |
2013-12-19 17:24 | jcfr | Status | assigned => resolved |
2013-12-19 17:24 | jcfr | Fixed in Version | => Slicer 4.4.0 |
2013-12-19 17:24 | jcfr | Resolution | open => fixed |
2014-03-06 05:25 | jcfr | Note Added: 0011225 | |
2014-03-06 05:28 | jcfr | Status | resolved => closed |
2017-06-07 23:27 | jcfr | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file 95fd51ff |
2017-06-07 23:27 | jcfr | Note Added: 0014559 | |
2017-06-07 23:27 | jcfr | Assigned To | lassoan => jcfr |
2017-06-10 08:51 | jcfr | Changeset attached | => Slicer master 95fd51ff |