Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master 3d5ce6c2

2014-10-20 13:52:23

jcfr

Details Diff 		BUG: The items in the label statistics table should not be edit-able

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23751 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/LabelStatistics/LabelStatistics.py Diff File

master c4aa610a

2014-10-20 13:49:56

jcfr

Details Diff 		BUG: Update CTK to fix issue with ctkMenuComboBox

$ git lg 19c9668..68a1ce2 --no-merges
* a2cce54 - ctkXnatResource download function implemented (11 days ago) <Tom Doel>
* 6ab9b11 - BUG: Fixed missing list elements problem (25 hours ago) <Andras Lasso>
* d3af228 - Replaced Qt5::Gui dependency with Qt5::Widgets. (4 days ago) <Stefan Kislinskiy>
* b9393da - Set QT_INSTALLED_LIBRARY_DIR in case of Qt5. (7 days ago) <Stefan Kislinskiy>
* 055c319 - Change sleep duration from 200ms to 250ms. (11 days ago) <Stefan Kislinskiy>
* 30d745a - Add NOMINMAX definition to global compile flags. (11 days ago) <Stefan Kislinskiy>
* 5002282 - Fixed incompatibilities between Windows.h and Qt 5 (NOMINMAX). (12 days ago) <Stefan Kislinskiy>
* a1f5a9e - Fixed Qt4/5 MOC issues regarding QIconEngineV2. (13 days ago) <Stefan Kislinskiy>
* 8f8208d - Add missing error log context parameter. (13 days ago) <Stefan Kislinskiy>
* 4f9073e - ENH: Clear box icon replaced with a less harsh one, a simple 'x' that does not indicate error (3 weeks ago) <Csaba Pitner>
* c2b9c56 - Add ctkCollapsibleButton::flat property (3 weeks ago) <Julien Finet>
* 553ecd7 - Add documentation for ctk*PopupWidget (8 weeks ago) <Julien Finet>
* 8e9b0a0 - Added a Signal which is used to do something before the session is closed. (8 weeks ago) <Daniel Knorr>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23750 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 5961065e

2014-10-17 17:10:55

jcfr

Details Diff 		ENH: Add function "removeObserver" to slicer.util.VTKObservationMixin

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23749 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File

master e2da2ccf

2014-10-17 16:08:35

pohl

Details Diff 		BUG: 0003561 did not check if index < 0, which causes crashes

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23748 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 0a4eae1d

2014-10-16 15:24:15

pieper

Details Diff 		BUG: 0003873 lingering vtk5 code broke module

Need to use the newer pipeline calls for vtk 6

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23743 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/VectorToScalarVolume/VectorToScalarVolume.py Diff File

master c9f1ca46

2014-10-16 15:14:38

pinter

Details Diff 		BUG: Prevent SliceViewAnnotations from dividing by zero

It can happen in some cases and it is important to recover gracefully, not just get a long python error.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23742 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py Diff File

master a5843995

2014-10-14 15:52:31

lassoan

Details Diff 		ENH: Added links to scripted module base classes

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23741 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/ScriptedLoadableModuleTemplate/ScriptedLoadableModuleTemplate.py Diff File
mod - Utilities/Templates/Modules/Scripted/TemplateKey.py Diff File

master aad45820

2014-10-13 18:53:42

pohl

Details Diff 		BUG: 0003561 tcl file was not updated to VTK6

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23738 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 0959f77c

2014-10-10 17:32:45

naucoin

Details Diff 		BUG: fix loading of derived items

A typo in a python call was masked by the catching
off an attribute error meant to catch if there
were no derived items. Fixed the call to processEvents
and now derived items will load.

Issue 3806

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23737 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOM/DICOMLib/DICOMWidgets.py Diff File

master 5a4abcf2

2014-10-09 23:01:32

fedorov

Details Diff 		BUG: fix static charting


git-svn-id: http://svn.slicer.org/Slicer4/trunk@23736 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 7c123458

2014-10-02 15:07:51

naucoin

Details Diff 		COMP: fix linux compilation of Models test

Remove include of QPushButton which is causing a compilation
error on the linux factories.

File added in svn 23734.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@23735 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Testing/Cxx/qSlicerModelsModuleWidgetTest.cxx Diff File

master 13297996

2014-09-30 23:30:39

finetjul

Details Diff 		BUG: Do not use QItemSelectionModel::currentRowChanged()

The signal is not reliable, ot might not be triggered at the right time.
Indeed the signal is for "key" events and has not a "selection" role.
The lack of trigger can lead to a crash due to widgets still observing
nodes that are not in the scene anymore.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23734 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLTreeView.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLTreeView.h Diff File
mod - Modules/Loadable/Annotations/Widgets/qMRMLAnnotationTreeView.cxx Diff File
mod - Modules/Loadable/Annotations/Widgets/qMRMLAnnotationTreeView.h Diff File
mod - Modules/Loadable/Models/Testing/Cxx/CMakeLists.txt Diff File
add - Modules/Loadable/Models/Testing/Cxx/qSlicerModelsModuleWidgetTest.cxx Diff File
mod - Modules/Loadable/Models/qSlicerModelsModule.cxx Diff File

master f70d076d

2014-09-26 22:09:31

jcfr

Details Diff 		COMP: Update BRAINSTools to fix build issue related to ITKDeprecated.

This commit is a follow-up of r23729 where BRAINSTools hasn't been updated
by mistake.

The update of BRAINSTools now includes the following commit:

// ----------------
Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date: Thu Sep 25 10:52:17 2014 -0400

COMP: Remove ITKDeprecated from the list of ITK components.

This commit is a follow-up of BRAINSia/BRAINSTools@13969f3

An issue has been reported upstream, see BRAINSia/BRAINSTools#154
// ----------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23733 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master bfb8ece6

2014-09-25 15:56:17

jcfr

Details Diff 		ENH: Add option Slicer_ITKV3_COMPATIBILITY. See 0003825

This option enabled by default will allow (if disabled) to build Slicer
with ITKv3 compatibility later disabled and ITK_USE_64BITS_IDS enabled.

Co-authored-by: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23730 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File

master 687e9cd6

2014-09-25 15:49:02

jcfr

Details Diff 		COMP: Remove dependency on ITKDeprecated. See 0003830

This commit updates ITK to include custom Slicer patch ensuring that
independently of the value of the ITKV3_COMPATIBILITY option,
ITKDeprecated is not include in the list of default modules.

It updates

(1) BRAINSTools to remove ITKDeprecated from the list
of required ITK components.

(2) EMSegment to explicitly call find_package(ITK..) and use
ITK_LIBRARIES variable when executable and library are added.

Note that at the time of this commit the pull request updating the
LASegmenter extension to remove ITKDeprecated dependency is pending.
See https://github.com/ljzhu/LASegmenter/pull/2

// -------------
BRAINSTools updates:

$ git shortlog 6f99866..b82c7c8
Jean-Christophe Fillion-Robin (1):
COMP: Remove ITKDeprecated from the list of ITK components.

// -------------
ITKv4 updates:

$ git shortlog baf8174bb..56fae278
Jean-Christophe Fillion-Robin (1):
Ensure ITKDeprecated is always excluded from the default module list.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23729 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File

master 73ee9d58

2014-09-25 15:49:00

jcfr

Details Diff 		ENH: Update ITKv4 to include fix for repeated call to "find_package(ITK ..)"

Associated gerrit topic is:

http://review.source.kitware.com/#/c/16963/

// ----------
Author: Brad King <brad.king@kitware.com>
Date: Wed Sep 10 09:22:34 2014 -0400

BUG: Fix itk_module_config for repeated calls

Fix use of _${ns}_${mod}_USED settings to block reporting a module more
than once in a single itk_module_config call. Do not leak the
_${ns}_${mod}_USED settings outside a single call to itk_module_config
so that a future call to the macro with the same ${ns} will use a fresh
set of modules.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23728 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

master bbe1939b

2014-09-25 15:48:58

jcfr

Details Diff 		ENH: Update ITKv4 project to include latest release branch changes

This commit updates the version of ITK to what will be the 4.6.1 patch
release.
$ git shortlog 056d97b66..554e46a1
Christopher Mullins (1):
COMP: Wrap MeshBase templates

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23727 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

master b44d2663

2014-09-24 17:55:01

pinter

Details Diff 		BUG: Fixed minor issues in subject hierarchy parse local data plugin

Show/hide icons didn't show up for non-volume displayables; If the user did a parsing, loaded further data and did a new parsing, the first batch appeared twice in the list. Both issues have been fixed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23726 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx Diff File

master a74f8b44

2014-09-24 15:36:11

jcfr

Details Diff 		ENH: Refactor management of external project launcher settings.

This commit moves the definition of launcher setting into each external
projects.

The different type of setting (listed below) are passed to the the main
project (Slicer) using labels set using "mark_as_superbuild" function.

Type of settings and associated labels:

Build tree:

* LIBRARY_PATHS_LAUNCHER_BUILD
* PATHS_LAUNCHER_BUILD
* PYTHONPATH_LAUNCHER_BUILD
* ENVVARS_LAUNCHER_BUILD

Install tree:

* LIBRARY_PATHS_LAUNCHER_INSTALLED
* PYTHONPATH_LAUNCHER_INSTALLED
* PATHS_LAUNCHER_INSTALLED
* ENVVARS_LAUNCHER_INSTALLED

This patch has been tested on factory-win7, factory-south-ubuntu and
factory. The SlicerLauncherSetting.ini and SlicerLauncherSettingToInstall.ini
file have been compared with / without this patch and the file are
similar. The few differences are explained below:
* nonexistent path are not configured anymore
* on unix, following r23613, a new version of incrTcl is used and path
have been updated to reflect this. Since there are to version of incrTcl
(4.0.0 and 4.0.1), the path to "4.0.1" are considered.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23724 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockCTKAppLauncherSettings.cmake Diff File
mod - SuperBuild/External_CTK.cmake Diff File
mod - SuperBuild/External_DCMTK.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File
mod - SuperBuild/External_LibArchive.cmake Diff File
mod - SuperBuild/External_NUMPY.cmake Diff File
mod - SuperBuild/External_OpenIGTLink.cmake Diff File
mod - SuperBuild/External_OpenSSL.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File
mod - SuperBuild/External_VTKv5.cmake Diff File
mod - SuperBuild/External_VTKv6.cmake Diff File
mod - SuperBuild/External_incrTcl.cmake Diff File
mod - SuperBuild/External_python.cmake Diff File
mod - SuperBuild/External_tcl.cmake Diff File
mod - SuperBuild/External_teem.cmake Diff File

master cc9188c2

2014-09-24 15:36:08

jcfr

Details Diff 		STYLE: Rename variable used to configure python launcher

This change is done anticipating a simplification of how additional
library path and python path are associated with either the different
launchers.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23723 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/python_customPythonLauncherSettings.ini.in Diff File
mod - SuperBuild/python_customPython_configure.cmake.in Diff File

master 4c57d087

2014-09-24 12:33:59

pinter

Details Diff 		BUG: Re-enable scrollbar for Subject hierarchy tree view

It's better to have a double scrollbar than being confused about the layout (if there are many nodes in the tree, then a scrollbar is added to both the module widget and the tree view), so I re-add the scrollbar temporarily until a better fix is made.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23722 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Resources/UI/qSlicerSubjectHierarchyModule.ui Diff File

master 39dca5c8

2014-09-23 00:43:52

jcfr

Details Diff 		ENH: Set objectName with editor PaintEffect UI element

This is particularly useful when recording macro using QtTesting or
when one need to get a reference to a widget associated with the effect
using its name.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23721 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/PaintEffect.py Diff File

master 69631dcf

2014-09-22 22:31:02

jcfr

Details Diff 		STYLE: Fix spelling of variable "childern" -> "children"

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23720 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayableHierarchyNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLHierarchyNode.h Diff File

master 04701e69

2014-09-22 22:30:58

jcfr

Details Diff 		BUG: Associate ChildNodeRemovedEvent with RemoveAllHierarchyChildrenNodes

See 0003854

This commit ensure the event "ChildNodeRemovedEvent" is invoked
for each child removed using the method RemoveAllHierarchyChildrenNodes.

Thanks to "Nicole Aucoin <nicole@bwh.harvard.edu>" and
"Csaba Pinter <csaba.pinter@queensu.ca>" for reviewing the associated
changes.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23719 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLHierarchyNode.cxx Diff File

master 1e984ad0

2014-09-22 22:30:55

jcfr

Details Diff 		BUG: Fix RemoveHierarchyChildrenNodes to send correct ChildNodeRemovedEvent

See 0003854

This commit udpates the method so that the event "ChildNodeRemovedEvent"
is send for each child that has been removed. It also associate the
appropriate call data.

Thanks to "Nicole Aucoin <nicole@bwh.harvard.edu>" and
"Csaba Pinter <csaba.pinter@queensu.ca>" for reviewing the associated
changes.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23718 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLHierarchyNode.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 91 92 93 94 95 96 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last