Changesets: Import 2017-06-07 23:51:09

master 931725ee

2015-05-28 16:46:59

pieper

Details Diff
ENH: Editor - Ensure a related merge volume is selected after a structure delete

ENH: Editor - Add function to select a structure in the structuresView and call it when deleting and adding structures

ENH: Editor - Select the 'next' structure in list instead of 0th on delete

From: Robin Weiss <robinweiss@uchicago.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24279 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

master 3f8b9569

2015-05-28 16:38:58

naucoin

Details Diff
BUG: use ruler end point scale and opacity

The ruler displayble manager wasn't adjusting the scale and opacity
of the ruler end points, this change applies the point display
node glyph scale and opacity settings to the end point handles.

Issue 0003195


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24278 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationRulerDisplayableManager.cxx Diff File

master 3bfa2fc2

2015-05-27 17:14:26

pinter

Details Diff
BUG: Better solution for previous quick fix for DICOM exportables

Instead of setting the slicer application as parent for exportables, they are handled in the same block where they are read out, and the export dialog itself is set as parent, so the exportables are destroyed when the export dialog is closed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24277 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.cxx Diff File
mod - Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py Diff File

master 03dcf6bc

2015-05-27 10:13:53

pinter

Details Diff
BUG: Instantiate DICOM exportables with a parent to avoid deconstruction

The crash was in DICOM export, at the following line:
https://github.com/Slicer/Slicer/blob/master/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.cxx#L263
Also if there was no crash (sometimes it happened), the exportables were the same in the list (i.e. the same series is displayed 3 times instead of showing the 3 series in the study). The issue was most probably that the exportable objects get deconstructed during passing from python to C++. I downloaded a nightly just before this commit
https://github.com/Slicer/Slicer/commit/9b7171d097ad0cfa1fe89780a2ef0758cf2ae80e
and indeed, the crash was not there, the exportables showed up correctly. This commit fixes the issue, but may not be the best solution overall.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24276 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py Diff File

master c441ba64

2015-05-26 16:51:38

pieper

Details Diff
BUG: 0003994 fix issue switching between master volumes

Since subject hierarchy nodes have the same names, we filter
for volume nodes.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24275 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

master 86140599

2015-05-26 16:51:37

pieper

Details Diff
ENH: only update Bg and Lb layers when switching editor volumes

Suggested and tested by Andrew Yung

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24274 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File

master a9cbfd17

2015-05-26 11:23:27

alexy

Details Diff
BUG: 3857. Added support for Parallel and Perpendicular Diffusivity.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24273 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkPolyDataTensorToColor.cxx Diff File

master c560f575

2015-05-21 12:30:05

pieper

Details Diff
BUG: 0003993 fix update of render window when transform changes

Full credit to Andras Lasso for debugging this at the VTK level!

Issue is described on the bug report:

http://na-mic.org/Mantis/view.php?id=3993

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24272 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTKv6.cmake Diff File

master 708a6f81

2015-05-21 11:37:31

pieper

Details Diff
ENH: 0003996 accept broader range of DICOM transfers

Adds flag to "accept all supported transfer syntaxes
other network options" to storescp.

Thanks to mcgee23 for the suggestion!

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24271 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMLib/DICOMProcesses.py Diff File

master 32d8d12a

2015-05-20 14:19:15

lassoan

Details Diff
BUG: Fixed application information logging

displayApplicationInformations() was called in qSlicerApplication before initializing the logging.
Therefore the application information (that is essential for troubleshooting) was not included in the application log.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24270 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 5cbd16be

2015-05-20 12:19:57

fedorov

Details Diff
BUG: added VTK libraries missing from the package

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24269 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master 65cfea39

2015-05-20 10:41:03

fedorov

Details Diff
BUG: ensure libvtkGUISupportQtOpenGL is packaged on mac

The library is not packaged, and this appears to be a regression
from the earlier fix here

https://github.com/Slicer/Slicer/commit/17564f2aba3c59c9cc45ee6d38e321cf878caa11

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24268 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master 497aac2d

2015-05-19 18:14:01

pieper

Details Diff
BUG: Avoid error on shutdown

When the layoutManager is destroyed check that there is a new one
before trying to connect.

Traceback (most recent call last):
File "/Users/pieper/slicer4/latest/Slicer-superbuild/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/DataProbeLib/SliceViewAnnotations.py", line 232, in onLayoutManagerDestroyed
self.layoutManager.connect("destroyed()", self.onLayoutManagerDestroyed)
AttributeError: 'NoneType' object has no attribute 'connect'

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24267 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py Diff File

master d7ec00d8

2015-05-19 17:55:01

pieper

Details Diff
BUG: 0003954 fixes slicer bundle scene import/export

* zip file size could not be correctly passed, so now
there is an alternate encoding (hack) that works well.

* missing storage nodes prevented correct export

* export widget embedded python code had a missing
import of DICOMLib

Special Thanks to Xia, Wenyao <wenyao.xia@rmp.uhn.ca>
for his bug fixes!

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24266 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMLib/DICOMExportScene.py Diff File
mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.cxx Diff File
mod - Modules/Scripted/DICOMPlugins/DICOMSlicerDataBundlePlugin.py Diff File

master d376a669

2015-05-19 17:17:58

pinter

Details Diff
STYLE: Added doxygen comments to simple markups widget header

Also fixed compilation warning by removing Z order tag from ui file.
From: Matthew Holden

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24265 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Widgets/Resources/UI/qSlicerSimpleMarkupsWidget.ui Diff File
mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.h Diff File

master f92c26f2

2015-05-19 14:10:21

pinter

Details Diff
BUG: Handle layout manager deletion in slice view annotations

Fix crash when closing Slicer, or when closing an application that uses custom layout manager with slice view annotations. It was caused by using an invalid instance of the layout manager that was previously destroyed.

Fixes 3995

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24264 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py Diff File

master 59622950

2015-05-19 12:19:05

lassoan

Details Diff
ENH: Made disclaimer popup configurable

Disclaimer popup is shown by default at the first startup of the application. The disclaimer text has to be configurable when custom applications are built on the Slicer platform.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24263 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - CMake/vtkSlicerConfigure.h.in Diff File
mod - CMakeLists.txt Diff File

master 87d94126

2015-05-16 12:01:45

alexy

Details Diff
BUG: 3983. Reverted to version 23690 that fixes the crash introduced in the JC's commits since that revision.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24262 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/TractographyInteractiveSeeding/Logic/vtkSlicerTractographyInteractiveSeedingLogic.cxx Diff File

master 59dde26e

2015-05-15 19:12:19

jcfr

Details Diff
COMP: Update BRAINSTools to fix windows build error

// ----------------------------------------------------------------
Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date: Fri May 15 19:09:32 2015 -0400

COMP: Fix windows build error related to non existing std::isnan function

std::isnan has been introduced in C++11 and Visual Studio 2008 doesn't
support it.

// ----------------------------------------------------------------
Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date: Fri May 15 18:56:16 2015 -0400

COMP: Fix windows build error due to already defined GetBValue macro

This commit applies as fix similar to InsightSoftwareConsortium/ITK@8ec410c0

It avoids the windows macro "GetBValue" to conflict with the
declaration of DWIMetaDataDictionaryValidator::GetBValue()

On windows, the macro is usually defined in "WinGDI.h" itself included by
"Windows.h".

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24261 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master f99c9f00

2015-05-15 15:54:58

pieper

Details Diff
BUG: 0002267 fix symmetry of label outline thickness

There was a miscalculation of the array indices that caused
the lines to be wider and thicker on the left and top of a
label region.

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24260 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkImageLabelOutline.cxx Diff File

master 1b176328

2015-05-15 12:51:32

pinter

Details Diff
ENH: Enable slice view annotations to work on external layouts

Slicelets use a different layout manager than the default one in slicer.app. Option added to initialize SliceAnnotations with a different layout manager. If no layout manager is specified (no arguments for constructor), then it will use the slicer.app one as before.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24259 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py Diff File

master ba18bbb6

2015-05-15 11:49:35

pinter

Details Diff
ENH: Added reusable simple markups widget

The simple markups widget facilitates using a markups list in external modules, e.g. slicelets or modules working with fiducials. This widget has been moved from https://github.com/SlicerIGT/SlicerIGT/tree/master/FiducialRegistrationWizard/Widgets after making minor changes.
Will also add a Qt designer plugin and doxygen documentation in the header.

Minor addition to DICOMWidgets, enclosing statements that tend to fail in try/except.

Fixes 0003496

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24258 3bd1e089-480b-0410-8dfb-8563597acbee
add - Modules/Loadable/Markups/Resources/Icons/Ellipsis.png Diff File
mod - Modules/Loadable/Markups/Resources/qSlicerMarkupsModule.qrc Diff File
mod - Modules/Loadable/Markups/Widgets/CMakeLists.txt Diff File
add - Modules/Loadable/Markups/Widgets/Resources/UI/qSlicerSimpleMarkupsWidget.ui Diff File
add - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx Diff File
add - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.h Diff File
mod - Modules/Scripted/DICOMLib/DICOMWidgets.py Diff File

master 1e52c8fb

2015-05-14 18:46:36

pieper

Details Diff
BUG: 0002267 - remove mask code from vtkImageLabelOutline

Since vtkImageLabelOutline inherits from vtkImageNeighborhoodFilter
it has a fixed size mask for defining 4-connect vs 8-connect
kernels. When we tried to use bigger kernels this caused overstepping
outside the mask which can lead to an access violation.

From: Steve Pieper <pieper@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24257 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkImageLabelOutline.cxx Diff File

master 92d7129b

2015-05-14 18:26:08

pieper

Details Diff
BUG: 0002267 image label outline incorrect

There was a logic error in the outline kernel calculation
from a previous commit.

https://github.com/Slicer/Slicer/commit/cd654faa89279694af12f5d7bbaa053281594881

From: Steve Pieper <pieper@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24256 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkImageLabelOutline.cxx Diff File

master 580fdf3f

2015-05-14 18:26:06

pieper

Details Diff
BUG: use file name match, not regular expression 0003994

Since mrml node names may contain characters that are meaningful
in regular expressions (such as parens) use a more limited
form of matching.

From: Steve Pieper <pieper@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24255 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 69 70 71 72 73 74 75 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last