View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003994Slicer4Module Editorpublic2015-05-14 12:092017-06-10 08:51
Reporterfedorov Assigned Topieper  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionFixed in VersionSlicer 4.5.0-1 
Summary0003994: Not able to set merge volume with certain node names
Description

Steps to reproduce:

1) assign a name to the master volume 100:()-()
2) assign name to the label volume 100:()-()-label
3) call HelperBox::setVolumes(master,label)

result is merge dialog box popup

TagsNo tags attached.

Relationships

related to 0003962 closedpieper Working with multiple volumes imported from .nrrd files in the Editor causes Slicer to crash 

Activities

pieper

pieper

2015-05-14 14:16

administrator   ~0013048

Here's a snippet of test code to replicate the issue:

testName = '100:()-()'

from SampleData import SampleDataLogic
slicer.util.delayDisplay('loading...',100)
SampleDataLogic().downloadMRHead()

labelName = testName+'-label'

h = getNode('MRHead*')
h.SetName(testName)

vl = slicer.modules.volumes.logic()
vl.CreateLabelVolume(h, labelName)

hl = getNode(labelName)

ms = slicer.util.mainWindow().moduleSelector()
ms.selectModule('Editor')
slicer.util.delayDisplay('selecting...',100)

slicer.util.delayDisplay('setting...',100)
editorWidget = slicer.modules.EditorWidget
editorWidget.helper.setVolumes(h,hl)
pieper

pieper

2015-05-14 14:19

administrator   ~0013049

The issue was a side effect of this commit:

https://github.com/Slicer/Slicer/commit/f0bcf9b2788fc92140d98a4ce412937ec11710dd

Andrey, please try this commit:

https://github.com/pieper/Slicer/commit/5005d88dc330cbf774f1aebed62b7958e90de606

(from this branch)
https://github.com/pieper/Slicer/tree/3994-regexp-node-name
fedorov

fedorov

2015-05-14 14:31

developer   ~0013051

Confirmed, this fixes the issue, please integrate!
pieper

pieper

2015-05-14 15:18

administrator   ~0013054

https://github.com/Slicer/Slicer/commit/580fdf3fca41a30b83ec1babbe494b8eb21d6af3
pieper

pieper

2015-05-26 13:16

administrator   ~0013102

Found that switching between loaded volumes wasn't working due to having subject hierarchy nodes of the same name.
pieper

pieper

2015-05-26 13:18

administrator   ~0013103

r24275

Related Changesets

Import 2017-06-07 23:51:09: master c441ba64

2015-05-26 16:51:38

pieper

Details Diff 		BUG: 0003994 fix issue switching between master volumes

Since subject hierarchy nodes have the same names, we filter
for volume nodes.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24275 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

Issue History

Date Modified Username Field Change
2015-05-14 12:09 fedorov New Issue
2015-05-14 12:09 fedorov Status new => assigned
2015-05-14 12:09 fedorov Assigned To => pieper
2015-05-14 14:16 pieper Note Added: 0013048
2015-05-14 14:19 pieper Note Added: 0013049
2015-05-14 14:31 fedorov Note Added: 0013051
2015-05-14 15:18 pieper Note Added: 0013054
2015-05-14 15:18 pieper Status assigned => closed
2015-05-14 15:18 pieper Resolution open => fixed
2015-05-14 15:18 pieper Fixed in Version => Slicer 4.4.1
2015-05-26 13:16 pieper Note Added: 0013102
2015-05-26 13:16 pieper Status closed => feedback
2015-05-26 13:16 pieper Resolution fixed => reopened
2015-05-26 13:18 pieper Note Added: 0013103
2015-05-26 13:18 pieper Status feedback => closed
2015-05-26 13:18 pieper Resolution reopened => fixed
2015-05-27 07:21 pieper Relationship added related to 0003962
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1
2017-06-10 08:51 pieper Changeset attached => Slicer master c441ba64