Changesets: Import 2017-06-07 23:51:09

master 1e597d82

2015-06-23 15:52:53

jcfr

Details Diff
STYLE: Remove unused ivar from qSlicerSubjectHierarchyModuleWidget

The "ModuleWindowInitialized" ivar has been introduced as part of
commit r23235 (ENH: Subject hierarchy module added) and is not used
anywhere.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24354 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModuleWidget.cxx Diff File

master 91cfdee5

2015-06-22 14:12:06

jcfr

Details Diff
ENH: Expose SH plugin "setDisplayVisibility()" method to python

This commit will allow scripted module to update the visibility
associated with a given SubjectHierarchy node doing the following:

shNode = [...]
shPluginHandler = slicer.qSlicerSubjectHierarchyPluginHandler.instance()
shPlugin = shPluginHandler.getOwnerPluginForSubjectHierarchyNode(shNode)
shPlugin.setDisplayVisibility(shNode, visible)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24353 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyAbstractPlugin.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginHandler.h Diff File

master b1f28404

2015-06-22 06:53:16

naucoin

Details Diff
BUG: expand null pointer checking

Extend ResampleVolumeToReferenceVolume to check that input and
reference volumes have transforms defined before trying to use
them.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@24352 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File

master 298f56ba

2015-06-19 18:06:26

jcfr

Details Diff
ENH: Improve CLI image widget type handling

* show both LabelMap and scalar volume nodes if "scalar" type
is specified (to restore behavior before vtkMRMLLabelMapVolumeNode
was added)

* allow adding either vtkMRMLScalarVolumeNode or vtkMRMLLabelMapVolumeNode
if "scalar" type is specified

* allow adding of multiple output node types if "any" type is specified
as output

Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24351 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIModuleUIHelper.cxx Diff File

master faaf0dab

2015-06-19 18:06:25

jcfr

Details Diff
ENH: Multiple node types can be created in qMRMLNodeComboBox

Now any of the supported node types can be created in a qMRMLNodeComboBox
- as it was available in Slicer3 and requested for Slicer4.

Note also that the combo box special entry "Create and Rename new <node>"
has been changed into "Create new <node> as...".

Fixes http://www.na-mic.org/Bug/view.php?id=3748

Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24350 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest4.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest8.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.h Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox_p.h Diff File

master fd352e78

2015-06-19 17:08:00

jcfr

Details Diff
BUG: sitkUtils: Add 'LabelMap' to list of volume types supported by SimpleITK

This commit fixes support for vtkMRMLLabelMapVolumeNode added
in r24291 (ENH: Use vtkMRMLLabelMapVolumeNode class for labelmap volumes)

Fixes 0004004

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24349 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/sitkUtils.py Diff File

master 9d16f3d7

2015-06-19 16:35:53

jcfr

Details Diff
BUG: Update BRAINSTools to fix loading of bspline transform

Note that the corresponding change has also been submitted as
a pull request in the official BRAINSTools repo.
See https://github.com/BRAINSia/BRAINSTools/pull/194

// -------------
Author: Andras Lasso <lasso@queensu.ca>
Date: Fri Jun 19 15:33:03 2015 -0400

BUG: Fixed loading of bspline transform

The transformFileType and typename were inconsistent.
// -------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24348 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 0d80c498

2015-06-19 14:53:27

jcfr

Details Diff
STYLE: Remove unused import statement from util.py

This commit removes an unused import statement introduced in r24320 (STYLE:
Editor-helperBox: Add "getNodeByName()" to slicer.util and rename it)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24347 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File

master ae51ebc0

2015-06-19 14:53:25

jcfr

Details Diff
STYLE: Update volume info widget to track volume node using a weak pointer

Use a weak pointer to make sure no dangling pointers are accidentally used.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24346 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLVolumeInfoWidget.cxx Diff File

master a9f81168

2015-06-19 14:53:24

jcfr

Details Diff
BUG: Remove duplicate connection to node selector in Volumes module widget

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24345 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/Resources/UI/qSlicerVolumesModuleWidget.ui Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModuleWidget.cxx Diff File

master b46c1031

2015-06-19 11:31:45

alexy

Details Diff
BUG: 3857. Fixed parallel/perpendicular diffusivity on glyphs, interactive seeding line display.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24344 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkDiffusionTensorGlyph.cxx Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/Logic/vtkSlicerTractographyInteractiveSeedingLogic.cxx Diff File

master 680d14df

2015-06-19 00:12:32

jcfr

Details Diff
BUG: String containing list of dependencies was not split. Fixes 0004007

If one was creating an extension that depended on multiple other
extensions and was giving, as specified in the s4ext files, a list of
extensions separated by spaces, Slicer did not split that list when
looking for dependencies upon download, and was trying to find an
extension with all the names.

e.g. If your s4ext file contained the following line:

depends DTIProcess ResampleDTIlogEuclidean

Slicer was trying to resolve the dependencies and was trying
to find the extension named "DTIProcess ResampleDTIlogEuclidean",
instead of finding both extensions separately.

From: Francois Budin <fbudin@email.unc.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24343 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerExtensionsManagerModel.cxx Diff File

master 8ce6e341

2015-06-18 16:05:42

naucoin

Details Diff
BUG: expand null pointer checking

Add a test for null image data in input and output images
in ResampleVolumeToReferenceVolume since it is not checked
before access in the method.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@24342 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File

master f5f47394

2015-06-17 22:52:07

lassoan

Details Diff
STYLE: Removed remnants of non-existent qMRMLNodeSelector class

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24341 3bd1e089-480b-0410-8dfb-8563597acbee
rm - Libs/MRML/Widgets/DesignerPlugins/qMRMLNodeSelectorPlugin.cxx Diff File
rm - Libs/MRML/Widgets/DesignerPlugins/qMRMLNodeSelectorPlugin.h Diff File
rm - Libs/MRML/Widgets/Testing/qMRMLNodeSelectorTest1.cxx Diff File

master e7d00f33

2015-06-17 22:46:29

lassoan

Details Diff
ENH: Added warning if obsolete LabelMap flag used in node selector

If the obsolete LabelMap attribute is used in qMRMLNodeComboBox then the attribute is ignored and a warning is logged.
This way modules that are not yet updated to use vtkMRMLLabelMapVolumeNode will still work reasonably well.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24340 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File

master 857fd7c5

2015-06-17 13:22:49

jcfr

Details Diff
BUG: Ensure effect FastGrowCut can use EditorLib.LabelEffectLogic

This commit fixes the following error:

//-----------
File "/home/jcfr/.config/NA-MIC/Extensions-24309/FastGrowCutEffect/lib/Slicer-4.4/qt-scripted-modules/FastGrowCutEffect.py", line 10, in <module>
from EditorLib import LabelEffectLogic
ImportError: cannot import name LabelEffectLogic
//-----------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24339 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/__init__.py Diff File

master 74d4eded

2015-06-17 12:05:11

jcfr

Details Diff
ENH: Backwards compatible FixedParameters

This patch provides alternatives for both
defining the m_FixedParameters of a transfor
as either the old-style ParametersType or
preferably the new-style FixedParametersType
when it is available in ITK.

Prepare for post ITK4.8 TransformFix

This patch makes Slicer prepared for future changes to
ITK that can not be backwards compatible.

http://review.source.kitware.com/#/c/19921/

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24338 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkITKTransformConverter.h Diff File

master c3894435

2015-06-17 11:45:03

jcfr

Details Diff
BUG: EditorLib: Avoid circular dependency and optimize effect imports

This commit has two roles:

(1) do not import "EditorLib" from module themselve imported in
"EditorLib/__init__.py"

(2) update effects to specify the __all__ attribute, this will
ensure only the expected objects are imported when calling
"from NameEffect import *" and will avoid clobbering the caller scope.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24337 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/ChangeIslandEffect.py Diff File
mod - Modules/Scripted/EditorLib/ChangeLabelEffect.py Diff File
mod - Modules/Scripted/EditorLib/ColorBox.py Diff File
mod - Modules/Scripted/EditorLib/DilateEffect.py Diff File
mod - Modules/Scripted/EditorLib/DrawEffect.py Diff File
mod - Modules/Scripted/EditorLib/EditColor.py Diff File
mod - Modules/Scripted/EditorLib/EditOptions.py Diff File
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File
mod - Modules/Scripted/EditorLib/Effect.py Diff File
mod - Modules/Scripted/EditorLib/ErodeEffect.py Diff File
mod - Modules/Scripted/EditorLib/FastMarchingEffect.py Diff File
mod - Modules/Scripted/EditorLib/GrowCutEffect.py Diff File
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File
mod - Modules/Scripted/EditorLib/IdentifyIslandsEffect.py Diff File
mod - Modules/Scripted/EditorLib/IslandEffect.py Diff File
mod - Modules/Scripted/EditorLib/LabelEffect.py Diff File
mod - Modules/Scripted/EditorLib/LevelTracingEffect.py Diff File
mod - Modules/Scripted/EditorLib/MakeModelEffect.py Diff File
mod - Modules/Scripted/EditorLib/MorphologyEffect.py Diff File
mod - Modules/Scripted/EditorLib/PaintEffect.py Diff File
mod - Modules/Scripted/EditorLib/RectangleEffect.py Diff File
mod - Modules/Scripted/EditorLib/RemoveIslandsEffect.py Diff File
mod - Modules/Scripted/EditorLib/SaveIslandEffect.py Diff File
mod - Modules/Scripted/EditorLib/ThresholdEffect.py Diff File
mod - Modules/Scripted/EditorLib/WandEffect.py Diff File
mod - Modules/Scripted/EditorLib/WatershedFromMarkerEffect.py Diff File
mod - Modules/Scripted/EditorLib/__init__.py Diff File

master c8970c52

2015-06-17 11:44:56

jcfr

Details Diff
STYLE: Editor-Effect: Simplify updateMRMLFromGUI using NodeModify context

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24336 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/Effect.py Diff File

master 0facd61b

2015-06-17 11:44:54

jcfr

Details Diff
STYLE: Editor-EditColor: Use VTKObservationMixin for scene observation

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24335 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditColor.py Diff File

master fc3339a2

2015-06-17 11:44:52

jcfr

Details Diff
STYLE: Editor-EditOptions: Use VTKObservationMixin for scene observation

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24334 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditOptions.py Diff File

master 45d27143

2015-06-17 11:44:50

jcfr

Details Diff
BUG: Editor-helpBox: Maintain backward compatibility for structures widget

This commit fixes PCampReview@b3d3d29 extension

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24333 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

master 043f3985

2015-06-17 11:44:48

jcfr

Details Diff
STYLE: Editor-helperBox: Refactor code adding LabelStructureListWidget

This commit move all functionality specific to "per-structure" management
into a reusable widget named "LabelStructureListWidget"

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24332 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/CMakeLists.txt Diff File
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File
add - Modules/Scripted/EditorLib/LabelStructureListWidget.py Diff File

master 87ba3811

2015-06-17 11:44:46

jcfr

Details Diff
STYLE: Editor-helperBox: Refactor and simplify code using VTKObservationMixin

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24331 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

master a0bcbfdc

2015-06-17 11:44:44

jcfr

Details Diff
STYLE: Editor-helperBox: Refactor code adding "EditUtil.setActiveVolumes()"

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24330 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 66 67 68 69 70 71 72 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last