Changesets: Import 2017-06-07 23:51:09

master a0f86c3d

2014-05-01 17:14:01

naucoin

Details Diff
BUG: disable alternate color editors

The color module was just collapsing the color table and
continuous color transfer viewer/editors when the other type
of node was active. User feedback showed this to be confusing
as valid looking data was visible if the sections were
expanded. This change disables the invalid editor on
selection of a color node.

Issue 0003573


git-svn-id: http://svn.slicer.org/Slicer4/trunk@23117 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.cxx Diff File

master b0818264

2014-04-25 10:06:13

jcfr

Details Diff
BUG: Fix dashboard submission removing subproject settings

When copied over from CTK, some of the setting related to
"SubProject" were still set. This was causing some issue on the CDash
server. This commit is an attempt to fix the submission error.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23116 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerDashboardDriverScript.cmake Diff File

master bb200bcb

2014-04-23 18:07:24

naucoin

Details Diff
COMP: remove compiler warnings

Remove unused variable, mark parameter as unused.

Issue 0003632


git-svn-id: http://svn.slicer.org/Slicer4/trunk@23115 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File

master cd30d886

2014-04-23 17:06:52

naucoin

Details Diff
BUG: fix behaviour of gui when markup inside transform

When editing the coordinates of a markup that's inside of a
transform, the pairing of getting the untransformed
coordinate and then saving it as transformed was leading to
incorrect values.
Added in a checkbox to select if the GUI table shows the
markup coordinates in transformed or untransformed versions.

Issue 0003632

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23114 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h Diff File

master 95d4a17c

2014-04-23 17:06:48

naucoin

Details Diff
ENH: label change from XYZ to RAS

After discussion on Slicer Developer hangout, change the GUI
coordinate labels to RAS instead of XYZ.

Issue 0003367

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23113 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File

master b0d6897d

2014-04-23 17:06:44

naucoin

Details Diff
ENH: add check box to show/hide coordinate columns

When box is checked, hide the markup coordiante columns in the
table, when unchecked show them.

Issue 0003667

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23112 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h Diff File

master edb69cd0

2014-04-23 17:06:39

naucoin

Details Diff
ENH: add coordinates to right click menu

When select rows in the Markups table, right click will now add the
coordinate points to the top of the context menu. Works for
multi select, and will work for multiple points per markup.
Adds the label of the markup if there are multiple rows selected.
Adds a separator after the coordinates and before the command
actions.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23111 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h Diff File

master 0930adf0

2014-04-22 13:29:35

lassoan

Details Diff
STYLE: Added comments describing the grid transform reader behavior

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23110 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.h Diff File

master ffebbe12

2014-04-22 10:12:05

pieper

Details Diff
ENH: Store a list of disabled plugins when user disable plugins in
advanced mode. All plugins would be enabled by default (both in simple and
advanced mode).

From: Alireza Mehrtash <mehrtash@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23109 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOM/DICOMLib/DICOMWidgets.py Diff File

master 78663af2

2014-04-18 18:25:06

alexy

Details Diff
BUG: 3660. Fixed faulty logic checking for coordinate changes in the vtkMRMLMarkupsFiducialDisplayableManager3D.cxx

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23108 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager3D.cxx Diff File

master c485d693

2014-04-17 16:35:11

jcfr

Details Diff
ENH: Update OpenIGTLinkIF SHA1 to add color image support. See 0003649

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23107 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master b743a088

2014-04-17 15:52:32

jcfr

Details Diff
ENH: Update CTK do not display ctkWorkflow debug message

$ git shortlog 2f1ff4..880bdd --no-merges
Jean-Christophe Fillion-Robin (1):
Introduce ctkWorkflow verbose property to print debug msg when needed

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23106 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 34e6e789

2014-04-17 12:39:37

lassoan

Details Diff
COMP: Fixed linux build warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23105 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerTransformLogic.cxx Diff File
mod - Base/Logic/vtkSlicerTransformLogic.h Diff File
mod - Base/Logic/vtkTransformVisualizerGlyph3D.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.h Diff File

master c5e0044c

2014-04-16 22:43:24

lassoan

Details Diff
BUG: Fixed transform info widget test name

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23104 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Transforms/Widgets/Testing/CMakeLists.txt Diff File

master bbba7a88

2014-04-16 13:48:22

jcfr

Details Diff
BUG: ResampleDTIlog Euclidean was using the measurement frame to transform tensors from local coordinates to world coordinates

It should be using the space direction of the image instead. The measurement frame should only transform gradient vectors from DWI to world coordinates. To be backward compatible, if a measurement frame is detected in the MetaData of the image, the measurement frame is still used as the transform matrix from local to world coordinate unless --noMeasurementFrame is specified. If no measurement frame information is available in the image MetaData, the image space direction is used instead (as well as if --noMeasurementFrame is specified).

From: fbudin69500 <fbudin@unc.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23103 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ResampleDTIVolume/ResampleDTIVolume.cxx Diff File
mod - Modules/CLI/ResampleDTIVolume/ResampleDTIVolume.xml Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRead.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRead.txx Diff File

master 39dc9a88

2014-04-16 13:40:24

lassoan

Details Diff
ENH: Added visualization of transforms

New features:
* Support non-linear transforms in the Transforms module: allow Apply, Harden, Invert transform
* Transform information displayed in the Transforms module (type of transform, basic properties)
* Transform visualization:
** Built into the Transforms module
** Three main modes: Glyphs (show an array of arrows, cones, spheres), Grid (show a deformed grid), or Contour (show isolines/isosurfaces for specified displacement magnitude values)
** All transform types are supported (chains of transforms as well)
** Visualization in the slice viewers
** Visualization in the 3D viewers, in the specified region (region can be a slice viewer, a volume, or a ROI widget)
** Real-time update: if the transform (or any visualization parameter) is changed then the visualization is updated immediately (interactive visualization while editing the transform)
** Built-in colormap editor
* MetaImage (mha), NIFTI (nii) vector volumes can be loaded as displacement field (grid) transform


git-svn-id: http://svn.slicer.org/Slicer4/trunk@23102 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/CMakeLists.txt Diff File
mod - Base/Logic/vtkSlicerTransformLogic.cxx Diff File
mod - Base/Logic/vtkSlicerTransformLogic.h Diff File
add - Base/Logic/vtkTransformVisualizerGlyph3D.cxx Diff File
add - Base/Logic/vtkTransformVisualizerGlyph3D.h Diff File
mod - Libs/MRML/Core/CMakeLists.txt Diff File
mod - Libs/MRML/Core/Testing/CMakeLists.txt Diff File
add - Libs/MRML/Core/Testing/vtkMRMLTransformDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelNode.h Diff File
rm - Libs/MRML/Core/vtkMRMLNonlinearTransformNode.cxx Diff File
rm - Libs/MRML/Core/vtkMRMLNonlinearTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLProceduralColorNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLProceduralColorNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
add - Libs/MRML/Core/vtkMRMLTransformDisplayNode.cxx Diff File
add - Libs/MRML/Core/vtkMRMLTransformDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLinearTransformSlider.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationROINode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationROINode.h Diff File
mod - Modules/Loadable/Transforms/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/Documentation/Transforms.dox Diff File
mod - Modules/Loadable/Transforms/Documentation/Transforms.xml Diff File
add - Modules/Loadable/Transforms/MRMLDM/CMakeLists.txt Diff File
add - Modules/Loadable/Transforms/MRMLDM/vtkMRMLTransformsDisplayableManager2D.cxx Diff File
add - Modules/Loadable/Transforms/MRMLDM/vtkMRMLTransformsDisplayableManager2D.h Diff File
add - Modules/Loadable/Transforms/MRMLDM/vtkMRMLTransformsDisplayableManager3D.cxx Diff File
add - Modules/Loadable/Transforms/MRMLDM/vtkMRMLTransformsDisplayableManager3D.h Diff File
mod - Modules/Loadable/Transforms/Resources/UI/qSlicerTransformsModuleWidget.ui Diff File
add - Modules/Loadable/Transforms/Widgets/CMakeLists.txt Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/CMakeLists.txt Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qMRMLTransformDisplayNodeWidgetPlugin.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qMRMLTransformDisplayNodeWidgetPlugin.h Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qMRMLTransformInfoWidgetPlugin.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qMRMLTransformInfoWidgetPlugin.h Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qSlicerTransformsModuleWidgetsAbstractPlugin.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qSlicerTransformsModuleWidgetsAbstractPlugin.h Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qSlicerTransformsModuleWidgetsPlugin.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/DesignerPlugins/qSlicerTransformsModuleWidgetsPlugin.h Diff File
add - Modules/Loadable/Transforms/Widgets/Resources/Icons/ContourIcon.png Diff File
add - Modules/Loadable/Transforms/Widgets/Resources/Icons/GlyphIcon.png Diff File
add - Modules/Loadable/Transforms/Widgets/Resources/Icons/GridIcon.png Diff File
add - Modules/Loadable/Transforms/Widgets/Resources/UI/qMRMLTransformDisplayNodeWidget.ui Diff File
add - Modules/Loadable/Transforms/Widgets/Resources/UI/qMRMLTransformInfoWidget.ui Diff File
add - Modules/Loadable/Transforms/Widgets/Resources/qSlicerTransformsModuleWidgets.qrc Diff File
add - Modules/Loadable/Transforms/Widgets/Testing/CMakeLists.txt Diff File
add - Modules/Loadable/Transforms/Widgets/Testing/qMRMLTransformDisplayNodeWidgetTest1.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/Testing/qMRMLTransformInfoWidgetTest1.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/qMRMLTransformDisplayNodeWidget.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/qMRMLTransformDisplayNodeWidget.h Diff File
add - Modules/Loadable/Transforms/Widgets/qMRMLTransformInfoWidget.cxx Diff File
add - Modules/Loadable/Transforms/Widgets/qMRMLTransformInfoWidget.h Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModule.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.h Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsReader.cxx Diff File

master 23befd1d

2014-04-16 04:38:35

jcfr

Details Diff
COMP: Fix CTK compilation error expecting moc_ file to have cpp/cxx extension

This commit fixes issue introduced by r23100

$ git shortlog 909073..2f1ff44 --no-merges
Jean-Christophe Fillion-Robin (1):
Fix compilation error introduced by 130deabb4. See 0000449

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23101 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master f8b64dc6

2014-04-16 03:58:13

jcfr

Details Diff
ENH: Update CTK project to include CMake configuration speedup

On Ubuntu 13.10 using CMake 2.8.11.2, an improvement of 0000009:0000010%
can be observed.

Without CTK tweaks:

real 2m32.996s
user 2m26.225s
sys 0m6.820s

With CTK tweak:

real 2m19.957s
user 2m15.908s
sys 0m3.768s


$ git shortlog 233d87..909073a --no-merges
Jean-Christophe Fillion-Robin (18):
Remove unused FindCTK.cmake module
Ensure CTK_ENABLE_Python_Wrapping remain set when CTK_BUILD_ALL is ON
Print message if CTK_{APP, LIB, PLUGIN} options set to ON because of BUILD_ALL options
Fix dependency of Scripting/Python/{Core, Widgets} options
Remove code referencing unexisting variable. See 0000449
Remove 'CTK_WRAP_PYTHONQT_FULL' obsolete option. See 0000449
Remove setting of INCLUDE_DIRS variable specific to PythonQtGenerator
Move all PythonQt wrapping code into one script. See 0000449
Optimize ctkMacroWrapPythonQt creating required source list in a single loop.
Configure module init file at configure times. See 0000449
Simplify how path of generated file are specified. See 0000449
Simplify moc'ing of generated PythonQt wrapper. See 0000449
Remove Light wrapping CMake script and directly invoke python executable
Do not log PythonQt wrapping output. See 0000449
Optimize QT4_GENERATE_MOCS macro getting moc flags only when needed
Simplify QT4_GENERATE_MOCS. See 0000449
Re-create python compile script only if needed and fix dependency. See 0000449
Fix python script compilation removing inputs from custom target deps. See 0000449

Julien Finet (2):
Fix ctkPushButton text alignment with no icon
Emit ctkSearchBox::textEdited() signal when clear icon is clicked

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23100 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master e8ffbe24

2014-04-16 03:58:11

jcfr

Details Diff
BUG: Fix CMake 3.x configuration warnings

Test done using CMake 3.0.20140413 (g94d5a)

Since project version is explicitly set, avoid warning by setting
policy CMP0048

Since ITKConfig.cmake append value to "ITK_LIBRARIES" and "ITK_INCLUDE_DIRS"
variables, let's make sure that "ITKFactoryRegistration" is not in the list
when configuring "ITKFactoryRegistration". This fixes the following
warnings:

//--------------
CMake Warning (dev) at Libs/ITKFactoryRegistration/CMakeLists.txt:55 (add_library):
Policy CMP0038 is not set: Targets may not link directly to themselves.
Run "cmake --help-policy CMP0038" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.

Target "ITKFactoryRegistration" links to itself.
This warning is for project developers. Use -Wno-dev to suppress it.
//--------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23099 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - Libs/ITKFactoryRegistration/CMakeLists.txt Diff File

master 5f625e63

2014-04-14 17:11:00

naucoin

Details Diff
ENH: add view node combo box for models

Gives users a GUI element to set models visible in selected
views.
Updated the displayable manager so that the model slice intersection
honors the overall display node visibility setting.

Issue 0003216



git-svn-id: http://svn.slicer.org/Slicer4/trunk@23098 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLDisplayNodeWidget.ui Diff File
mod - Libs/MRML/Widgets/qMRMLDisplayNodeWidget.cxx Diff File

master bef38aaf

2014-04-14 15:59:09

mccormic

Details Diff
ENH: Fix python source URL.

The Python tarball http URL sends a 301 Moved Permanently response to
the https version.

Placing the real URL makes errors such as:

-- downloading...
src='http://www.python.org/ftp/python/2.7.3/Python-2.7.3.tgz'
dst='/home/matt/bin/Slicer-GCC-MinSizeRel/Python-2.7.3.tgz'
timeout='none'
CMake Error at
python-source-prefix/src/python-source-stamp/download-python-source.cmake:9
(file):
file DOWNLOAD HASH mismatch

for file: [/home/matt/bin/Slicer-GCC-MinSizeRel/Python-2.7.3.tgz]
expected hash: [2cf641732ac23b18d139be077bd906cd]
actual hash: [d41d8cd98f00b204e9800998ecf8427e]
status: [1;"unsupported protocol"]

More informative (HTTPS is not supported).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23097 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_python.cmake Diff File

master d89b2cc6

2014-04-13 22:20:52

jcfr

Details Diff
BUG: Fix unix installation of SSL libraries

This commit ensures that only the ssl libraries are installed without
additional empty directories.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23096 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockInstallOpenSSL.cmake Diff File

master a074c42a

2014-04-13 22:14:12

naucoin

Details Diff
COMP: revert windows compilation change

A fix was already checked in



git-svn-id: http://svn.slicer.org/Slicer4/trunk@23095 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File

master 66cbdfe1

2014-04-13 22:09:53

naucoin

Details Diff
COMP: memory allocation on windows

Issue 0003573



git-svn-id: http://svn.slicer.org/Slicer4/trunk@23094 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File

master 98114542

2014-04-12 12:37:25

lassoan

Details Diff
COMP: Fixed Windows build error

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23093 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 115 116 117 118 119 120 121 ... 130 ... 133 134 135  Next  Last