View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003632Slicer4Module Markupspublic2014-03-19 07:092017-06-10 08:51
Reporterinorton Assigned Tonicole  
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003632: Markup transformation incorrect
Description

When a markup list is put inside of a transformation, the markup coordinates are directly altered. Among other issues, this leads to strange interaction modes when editing coordinates, for example under a [-x -y] transform, the sign of edited coordinates is corrupted after editing.

Original coordinates should be preserved and editable in the original reference frame. The transformation should be applied at the display level.

Additional Information

nightly win64, 2014-03-14

TagsNo tags attached.

Relationships

related to 0003662 closednicole B-spline transform applied to a fiducial list does not change the coordinates of the fiducial 

Activities

nicole

nicole

2014-04-23 10:51

administrator   ~0011649

I was looking at this after yesterday's Slicer developer hangout - we decided to allow users to switch between seeing transformed and untransformed coordinates in the Markups table - and I found what I think it the source of this bug: a mismatch between getting the untransformed point, and then setting it as the transformed point. Should be fixed soon in the nightly build.
nicole

nicole

2014-04-23 13:17

administrator   ~0011651

I found and fixed a bug with the setting of fiducial coordinates and offered the user the option to set the GUi to show/edit the coordinates in transformed or non transformed space in svn 23114:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23114
jcfr

jcfr

2014-09-17 23:01

administrator   ~0012551

Closing resolved issues that have not been updated in more than 3 months.

Related Changesets

Import 2017-06-07 23:51:09: master cd30d886

2014-04-23 17:06:52

naucoin

Details Diff 		BUG: fix behaviour of gui when markup inside transform

When editing the coordinates of a markup that's inside of a
transform, the pairing of getting the untransformed
coordinate and then saving it as transformed was leading to
incorrect values.
Added in a checkbox to select if the GUI table shows the
markup coordinates in transformed or untransformed versions.

Issue 0003632

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23114 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h Diff File

Import 2017-06-07 23:51:09: master bb200bcb

2014-04-23 18:07:24

naucoin

Details Diff 		COMP: remove compiler warnings

Remove unused variable, mark parameter as unused.

Issue 0003632


git-svn-id: http://svn.slicer.org/Slicer4/trunk@23115 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File

Issue History

Date Modified Username Field Change
2014-03-19 07:09 inorton New Issue
2014-03-19 07:09 inorton Status new => assigned
2014-03-19 07:09 inorton Assigned To => nicole
2014-04-23 10:51 nicole Note Added: 0011649
2014-04-23 10:51 nicole Target Version => Slicer 4.4.0
2014-04-23 13:10 nicole Relationship added related to 0003662
2014-04-23 13:17 nicole Note Added: 0011651
2014-04-23 13:17 nicole Status assigned => resolved
2014-04-23 13:17 nicole Fixed in Version => Slicer 4.4.0
2014-04-23 13:17 nicole Resolution open => fixed
2014-09-17 22:59 jcfr Status resolved => closed
2014-09-17 23:01 jcfr Note Added: 0012551
2017-06-10 08:51 Changeset attached => Slicer master bb200bcb
2017-06-10 08:51 Changeset attached => Slicer master cd30d886