Changesets: Slicer

2145-support-for-installing-extension-from-file 385a6347

2013-02-12 15:53:23

jcfr

Details Diff
STYLE: Update template dashboard driver script comment to suggest using "-j -lN"

As suggested in [1], using the -l flag allow to keep the machine responsive
while maximizing the use of the cores when possible.

[1] http://www.kitware.com/blog/home/post/434

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21692 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerDashboardScript.TEMPLATE.cmake Diff File
mod - Extensions/CMake/SlicerExtensionsDashboardScript.TEMPLATE.cmake Diff File

2145-support-for-installing-extension-from-file 36455cc3

2013-02-12 14:26:09

jcfr

Details Diff
BUG: Update CLI test driver to ensure registration of ITKv4 IO Factories

See 0002813 - http://www.na-mic.org/Bug/view.php?id=2813

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21691 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/CLI/Testing/itkTestMain.h Diff File

2145-support-for-installing-extension-from-file 62920033

2013-02-12 11:23:06

jcfr

Details Diff
COMP: Extension driver script now fails if vtkSlicerVersionConfigure.h does not exist.

Making the script fail will minimize confusion and will give an hint to
the dashboard maintainer.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21690 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerExtensionsDashboardDriverScript.cmake Diff File

2145-support-for-installing-extension-from-file 94a71c3d

2013-02-11 19:38:18

jcfr

Details Diff
COMP: Exclude Slicer test involving GPU to prevent dashboard client issue.

Running GPU based tests simultaneously from multiple VM is not recommended.
Time we exclude the test by updating the dashboard script, let's simply
disable the test within the code base itself.

This will prevent the dashboard from failing while checking that the transition
to ITKv4 is working as expected.

Re-enabling of GPU based tests is captured by issue 0002939
See http://www.na-mic.org/Bug/view.php?id=2939

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21689 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Testing/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file c4b444db

2013-02-11 17:50:21

jcfr

Details Diff
COMP: Set ITKv4 as default version. Update SimpleITK version to v0.6.1

Thanks to the work of the ITK, Slicer and DCMTK community members :),
the default version of ITK built wihtin Slicer will be:

ITK 4.3 based of commit c31337 (01-06-2013)


Remarks
=======

- While this is a major change from the developer perspective, from
the user perspective, we expect the functionality to behave similarly
or better. That is why we maintained the major version number to "4".


- In your EXISTING build tree, consider:

a) manually updating the CMake option ITK_VERSION_MAJOR from 3 to 4

b) deleting ITKv3* directories. That would help minimizing future
confusion.


- Extensions superbuild-ing ITKv4 SHOULD be updated.


- It is known that some test are failing exclusively with ITKv4,
these ones will be addressed by the respective module/code maintainers.
See [1] for more details.


- Test have been done to ensure the extension build system was behaving
as expected when using ITKv4. That said, it is possible we experience
some glitch. Make sure to report any issue so that we can solve them
as soon as possible.


- Issue building extension depending on DCMTK has been identified.
For example, extension "houghTransformCLI" failed to build. This will
be addressed as soon as possible by working with ITKv4 and DCMTK
community.


- Enabling SimpleITK is *NOT* enabled by default and has *NOT* been
tested. That said, if you enable the option Slicer_USE_SimpleITK,
the latest version of SimpleITK will be built.


- On windows, if you encounter strange link/build error. Consider
running the following script. We are in the process of identifying
what would be the optimum build and source folder length and your
help and comments are welcome.
See https://github.com/jcfr/list-longest-paths#readme


[1] https://docs.google.com/a/kitware.com/spreadsheet/ccc?key=0AqcFo-C6Ob4-dFJRdWw3LVN6R1VYQlotNXRVaGVVT1E#gid=0

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21688 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File

2145-support-for-installing-extension-from-file 4fe83f1d

2013-02-11 17:31:01

naucoin

Details Diff
BUG: clean up the model node logic for toggling visibility.

Model slice nodes are distinguished by name rather than class, make that a more easily set string.
Don't toggle annotations or fiber bundle nodes or any other sub classes of
model nodes.

Issue 0002576



git-svn-id: http://svn.slicer.org/Slicer4/trunk@21687 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.h Diff File
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.cxx Diff File

2145-support-for-installing-extension-from-file 6fe971ca

2013-02-11 14:44:14

jcfr

Details Diff
COMP: Remove debug statement introduced to help resolving issue 2491

Commit r21682 changed how parameter are passed to ctest script and, base
on the initial dashboard results, it most likely solved the problem.

Fixes 0002491
See http://www.na-mic.org/Bug/view.php?id=2491

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21686 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtensions.cmake Diff File

2145-support-for-installing-extension-from-file 98ec8ede

2013-02-11 14:44:12

jcfr

Details Diff
COMP: Remove code specific to CMake 2.8.7 in PackageAndUploadExtension script.

Since commit r21682, CMake 2.8.9 is required to build extensions.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21685 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File

2145-support-for-installing-extension-from-file 8e4bdfe5

2013-02-11 09:09:03

jcfr

Details Diff
COMP: Download jqplot source package from slicer.kitware.com

Since github.com deprecated its download api [1], the package
is now downloaded from slicer.kitware.com.

[1] https://github.com/blog/1302-goodbye-uploads

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21684 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_jqPlot.cmake Diff File

2145-support-for-installing-extension-from-file 45a3a5bb

2013-02-10 21:40:50

jcfr

Details Diff
STYLE: Remove extra include and properly name variables in Reformat module

See 0002926 - http://www.na-mic.org/Bug/view.php?id=2926

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21683 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Reformat/qSlicerReformatModule.cxx Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModuleWidget.cxx Diff File

2145-support-for-installing-extension-from-file 379ce8ac

2013-02-10 21:27:57

jcfr

Details Diff
COMP: Simplify how arguments are passed to PackageAndUploadExtensions script

Parameter are now written into files like:
<extension-name>-test-command-args.cmake
<extension-name>-upload-command-args.cmake
<extension-name>-upload-only-command-args.cmake

This file are then passed to the ctest using argument:

-DSCRIPT_ARGS_FILE:FILEPATH=<path-to-args-file>

and include within the ctest script using:

include(${SCRIPT_ARGS_FILE})

This approach has the advantages of:
1) being simpler in the sens it avoids escaping arguments
2) preventing issue related to the command line length on windows by passing
arguments "through a file"

See 0002491 - http://www.na-mic.org/Bug/view.php?id=2491

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21682 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerExtensionCPack.cmake Diff File
mod - CMakeLists.txt Diff File
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File
mod - Extensions/CMake/SlicerBlockUploadExtension.cmake Diff File

2145-support-for-installing-extension-from-file c2e1ca9a

2013-02-10 18:04:40

pieper

Details Diff
ENH: update the editor template to use (dis)connectWidgets convention

This makes the template match the way the rest of the editor
effects are written.

Thanks Andrey for pointing this out!

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21681 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/EditorExtensionTemplate/EditorExtensionTemplate.py Diff File

2145-support-for-installing-extension-from-file cb1699f6

2013-02-10 10:57:40

finetjul

Details Diff
STYLE: Cleanup vtkMRMLDisplayNode PrintSelf output

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21680 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayNode.h Diff File

2145-support-for-installing-extension-from-file 8eed7494

2013-02-10 10:57:38

finetjul

Details Diff
BUG: Fix auto scalar range for model scalar arrays

When changing the active scalar field array, the range was not updated.
Note that the location where the scalar range might not be best,
it probably would have to be revisited at some point.
Closes 0002897

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21679 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.cxx Diff File

2145-support-for-installing-extension-from-file c3e628d4

2013-02-10 00:04:48

finetjul

Details Diff
STYLE: Add doc to new Harden Transform button

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21678 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Transforms/Documentation/Transforms.xml Diff File

2145-support-for-installing-extension-from-file 16195f99

2013-02-09 23:53:24

finetjul

Details Diff
ENH: Add Harden transform into Transforms module

+ Change "Transformed nodes" collapsible groupbox title.

Closes 0002909

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21677 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Transforms/Resources/UI/qSlicerTransformsModuleWidget.ui Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.h Diff File

2145-support-for-installing-extension-from-file 5695c716

2013-02-08 19:48:46

fedorov

Details Diff
ENH: disable switching to quantitative layout on entering the module; resolves 0002845


git-svn-id: http://svn.slicer.org/Slicer4/trunk@21676 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_MultiVolumeExplorer.cmake Diff File

2145-support-for-installing-extension-from-file 00e22939

2013-02-08 19:27:32

jcfr

Details Diff
COMP: Add debug statement helping to track problem related to issue 2491

See 0002491 - http://www.na-mic.org/Bug/view.php?id=2491

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21675 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtensions.cmake Diff File
mod - Extensions/CMake/SlicerBlockUploadExtension.cmake Diff File

2145-support-for-installing-extension-from-file 10e39173

2013-02-08 17:27:39

jcfr

Details Diff
COMP: Update External_SimpleITK to use "git" protocol when possible

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21674 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SimpleITK.cmake Diff File

2145-support-for-installing-extension-from-file a811d777

2013-02-08 13:40:51

naucoin

Details Diff
BUG: fix the detection of models with extensions orig and inflated.

The concatenated string list was mushing the two extensions together and
they were not being detected on loading data.

Issue 0002924


git-svn-id: http://svn.slicer.org/Slicer4/trunk@21673 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/qSlicerModelsIO.cxx Diff File

2145-support-for-installing-extension-from-file 0fa5f089

2013-02-08 12:38:22

pieper

Details Diff
BUG: prevent crash reported in 0002925 - missing annotation point

The fiducials did not load correctly so no coordinate exists.

The underling question of why the fiducials do not correctly
load from that scene is not resolved.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21672 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx Diff File

2145-support-for-installing-extension-from-file d5339486

2013-02-08 11:11:34

jcfr

Details Diff
COMP: On MacOSX, force bundling of ITKv3 IOReview library to ensure proper loading of extension

Thanks to Csaba Pinter for testing that the patch worked as expected.

See http://slicer-devel.65872.n3.nabble.com/ITK-lib-missing-from-Mac-Slicer-package-needed-for-Plastimatch-tt4027274.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21671 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file f789e693

2013-02-07 16:39:12

naucoin

Details Diff
ENH: add buttons to show/hide all models. Issue 0002576

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21670 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.cxx Diff File
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.h Diff File
mod - Modules/Loadable/Models/Resources/UI/qSlicerModelsModuleWidget.ui Diff File
mod - Modules/Loadable/Models/qSlicerModelsModuleWidget.cxx Diff File
mod - Modules/Loadable/Models/qSlicerModelsModuleWidget.h Diff File

2145-support-for-installing-extension-from-file ff1baa17

2013-02-07 11:33:30

jcfr

Details Diff
COMP: Update "External_python_unix.cmake" to comply if changes introduced in r21667

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21669 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_python_unix.cmake Diff File

2145-support-for-installing-extension-from-file 81ca0cce

2013-02-07 11:13:07

pieper

Details Diff
BUG: fix the self-test registration for tractography tests

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21668 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/test_tractography_display.py Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 42 43 44 45 46 47 48 ... 50 ... 55 56 57  Next  Last