Locations where factory registration needs to be optimized.

Brad L. <=====

$ find -name itkTransformIOFactoryRegisterManager.h
./Slicer-build/Libs/ITKFactoryRegistration/ITKIOFactoryRegistration/itkTransformIOFactoryRegisterManager.h
./CTK-build/CTK-build/Libs/ImageProcessing/ITK/Core/ITKIOFactoryRegistration/itkTransformIOFactoryRegisterManager.h
./SlicerExecutionModel-build/GenerateCLP/ITKIOFactoryRegistration/itkTransformIOFactoryRegisterManager.h
./SlicerExecutionModel-build/ModuleDescriptionParser/ITKIOFactoryRegistration/itkTransformIOFactoryRegisterManager.h

Hans

To optimize windows loading of images (and also potentially decrease the size of packages) the topic that should be tested on windows, macosx and linux are the following:
XXXX IGNORE - https://github.com/jcfr/Slicer/tree/ITKv4-shared-library-for-factory-initialization
XXXX IGNORE - https://github.com/jcfr/SlicerExecutionModel/tree/mechanism-to-link-executable-against-extra-libraries

=====
NOTE: See note below:

UPDATE:

Both patches from jcfr have been incorporated into a monolithic ITKv4 patch set.

git@github.com:BRAINSia/Slicer43.git

under the next-slicer43 branch

As of 2012-12-05, this was also in sync with the svn repository.

Hi Hans,

I did a fresh build with the BRAINSia/Slicer43/next-slicer43 branch with Visual Studio 2008 Express 64. However, it cannot load a file. In the "Log messages" there is a "Factories size: 3". Does this branch have a patch that still disables all factory registration?

Thanks,
Matt

Hi Folks,

You should check with Brad Lowekamp, if I remember properly, the assumption was that simply linking Slicer against the shared library should be enough to ensure the default ITK IO Factory are loaded.

Seems this doesn't work as expected on windows. Would be nice to confirm it works on Linux/MacOSX. This the platform where Brad did his testing.

I have started a fresh Linux build. Will report the results.

Sounds great. Thanks

Hmmm. Worked fine on Linux.

"Factories size: 21".

Just pushed something on my fork. If you try to apply the following patch on your windows checkout .. I am curious to see if the factory are loaded.

See https://github.com/jcfr/Slicer/commit/5b368c22c92a4005b84d0f69facb37bc55a185cd

To apply the patch:
save https://github.com/jcfr/Slicer/commit/5b368c22c92a4005b84d0f69facb37bc55a185cd.patch

Not I didn't tested it ...

apply using:
patch -p1 < 5b368c22c92a4005b84d0f69facb37bc55a185cd.patch

Update the associated topic. See https://github.com/jcfr/Slicer/tree/ITKv4-shared-library-for-factory-initialization

Topic has been updated with a commit allowing the factory to also be registered for CLI executable on Windows..

See https://github.com/jcfr/Slicer/commit/be6075a286d1a31aa3f9bee4abf154b82b223b1c

To test it, there are two options:
1) the option "Prefer CLI Executable" could be set in Slicer settings, then using a module like "GaussianBlur", the ITK factory should be loaded.
2) start a CLI from the command line using something like: C:\path\to\Slicer.exe --launch GaussianBlur.exe --param1 .. --param2 ...

After integrating the previous slicer patch, you should also consider updating the SHA1 of the Slicer execution model to: https://github.com/jcfr/SlicerExecutionModel/commit/fded7173cdab39e399e6e0a53706c17b40d53c94

Great, thank you JC!

I have added the bump to 20130107-next-slicer43.

There are a number of IO related errors on the Windows build today (after the ITKv4 switch).

The following patch should resolve that specific issue: https://github.com/jcfr/Slicer/commit/6a7effe2403fc4056808e1821878decd4340a629.patch

Well done!

Should be fixed in r21691
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=21691

Please, re-open if there are still issue.

// ------------------------------------
Commit r21721:

BUG: Ensure ITKv4 IO Factory are registered within tests

• Include directories associated with ITKFactoryRegistration are also
  appended to ITK_INLCUDE_DIRS to ensure that the method itk::itkFactoryRegistration
  could be called.

• Code allowing to register the factory has been manually added to the
  tests.

• Would it make sens to have this library ITKFactoryIORegistration
  being built/provided by ITKv4 proper ?

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=21721
// ------------------------------------

// ------------------------------------
Commit r21723:

COMP: Ensure ITKFactoryRegistration is considered when setting ITK_INCLUDE_DIRS at top-level.

This will fix build errors of the form:

.../Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx:49:38: error: itkFactoryRegistration.h: No such file or directory
.../Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx: In function 'int vtkMRMLSliceLogicTest2(int, char**)':
.../Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx:56: error: 'itkFactoryRegistration' is not a member of 'itk'

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=21723
// ------------------------------------

// ------------------------------------
Commit r21725:

COMP: Fix missing "itkFactoryRegistrationConfigure.h" build error

This will fix build errors of the form:

../ITKFactoryRegistration/itkFactoryRegistration.h:6:45: error: itkFactoryRegistrationConfigure.h: No such file or directory
../Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx:49:
../Libs/ITKFactoryRegistration/itkFactoryRegistration.h:10: error: expected constructor, destructor, or type conversion before 'void'
../Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx: In function 'int vtkMRMLSliceLogicTest2(int, char**)':
../Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx:56: error: 'itkFactoryRegistration' is not a member of 'itk'

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=21725
// ------------------------------------

Closing resolved issues that have not been updated in more than 3 months

Fix committed to 2145-support-for-installing-extension-from-file branch.