View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002951 | Slicer4 | Core: Base Code | public | 2013-02-14 09:39 | 2013-02-18 08:52 |
Reporter | pinter | Assigned To | jcfr | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0002951: Update test framework to call initialize ITKIOFactoryRegistration when needed | ||||
Description | Hi Csaba, The failing cli tests associated with Slicer build you pointed out, should be fixed by this commit: http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Base/CLI/Testing/itkTestMain.h?r1=21691&r2=21690&pathrev=21691 The same approach will have to be applied for other test. I will be looking into adding a generic solution based on "CMAKE_TESTDRIVER_BEFORE_TESTMAIN ". See http://www.cmake.org/cmake/help/v2.8.10/cmake.html#command:create_test_sourcelist All of that said, while test test are failing, Slicer itself should be able to load nrrd. Let me know if it's not the case. | ||||
Tags | ITKv4 | ||||
Introduction of a new macro named "slicerMacroAddModuleCxxTestDriver" would help simplifying how test are written. Waiting for feedback from the community. |
|
The following commits should resolve the last problem associated with Slicer tests. That said, I thought about few different approaches: 1) Extent the "create_test_sourcelist" CMake command and add a parameter named EXTRA_INCLUDES. With that new feature it would then be easier to pass additional header to the test driver. Writing of macro like "slicerMacroAddModuleCxxTestDriver" would be easier. 2) Instead of trying to work around the issue, it would probably make sens to add such library into ITKv4 proper. [1] http://www.cmake.org/cmake/help/v2.8.10/cmake.html#command:create_test_sourcelist In the mean time, the solution is to include "itkFactoryRegistration.h" and call "itk::itkFactoryRegistration()" // ------------------------------------ BUG: Ensure ITKv4 IO Factory are registered within tests
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21721 // ------------------------------------ COMP: Ensure ITKFactoryRegistration is considered when setting ITK_INCLUDE_DIRS at top-level. This will fix build errors of the form: .../Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx:49:38: error: itkFactoryRegistration.h: No such file or directory See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21723 // ------------------------------------ COMP: Fix missing "itkFactoryRegistrationConfigure.h" build error This will fix build errors of the form: ../ITKFactoryRegistration/itkFactoryRegistration.h:6:45: error: itkFactoryRegistrationConfigure.h: No such file or directory See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21725 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2013-02-14 09:39 | jcfr | New Issue | |
2013-02-14 09:39 | jcfr | Status | new => assigned |
2013-02-14 09:39 | jcfr | Assigned To | => pieper |
2013-02-14 09:41 | jcfr | Reporter | jcfr => pinter |
2013-02-14 09:41 | jcfr | Assigned To | pieper => jcfr |
2013-02-14 09:41 | jcfr | Target Version | => Slicer 4.3.0 |
2013-02-14 09:47 | jcfr | Tag Attached: ITKv4 | |
2013-02-14 13:09 | jcfr | Note Added: 0007935 | |
2013-02-14 13:09 | jcfr | Note Edited: 0007935 | |
2013-02-16 09:47 | jcfr | Relationship added | related to 0002813 |
2013-02-16 09:53 | jcfr | Note Added: 0007969 | |
2013-02-16 09:53 | jcfr | Status | assigned => resolved |
2013-02-16 09:53 | jcfr | Fixed in Version | => Slicer 4.3.0 |
2013-02-16 09:53 | jcfr | Resolution | open => fixed |
2013-02-18 08:52 | pinter | Status | resolved => closed |