View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002926Slicer4Core: Base Codepublic2013-02-09 19:162016-06-09 00:53
Reporterfinetjul Assigned Tojcfr  
PrioritylowSeverityfeatureReproducibilityN/A
Status acknowledgedResolutionopen 
Product VersionSlicer 4.2.2-1 
Target VersionFixed in Version 
Summary0002926: Move vtkSlicerTransformLogic into Transforms module
Description

To be consistent, the vtkSlicerTransformLogic logic should be in the Transforms module Logic directory/project.
It would have to be renamed and its superclass be changed to be consistent with the other module logics.

Tagshelp-wanted

Activities

jcfr

jcfr

2013-02-10 16:41

administrator   ~0007865

STYLE: Remove extra include and properly name variables in Reformat module
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21683
jcfr

jcfr

2013-02-10 16:52

administrator   ~0007866

API change roadmap updated - See http://www.slicer.org/slicerWiki/index.php/Roadmap#4.3.0
finetjul

finetjul

2013-08-27 05:44

administrator   ~0009613

Be careful with backward compatibility, if extension use the transform logic, you would break those. I would suggest to wait 4.3 to be cut to change this cosmetic issue.
jcfr

jcfr

2013-08-27 07:12

administrator   ~0009615

Re-targeted for 4.4. Roadmap updated. See http://www.slicer.org/slicerWiki/index.php/Roadmap#4.4.0
jcfr

jcfr

2016-06-09 00:52

administrator   ~0013959

As of June 9, here are the extension using "vtkSlicerTransformLogic":

./AnglePlanesExtension/AnglePlanes/AnglePlanes.py:819: logic = slicer.vtkSlicerTransformLogic()
./AnglePlanesExtension/AnglePlanes/AnglePlanes.py:876: logic = slicer.vtkSlicerTransformLogic()

./CMFreg/SurfaceRegistration/SurfaceRegistration.py:742: logic = slicer.vtkSlicerTransformLogic()
./CMFreg/SurfaceRegistration/SurfaceRegistration.py:856: logic = slicer.vtkSlicerTransformLogic()

./EasyClip/EasyClip/EasyClip.py:411: logic = slicer.vtkSlicerTransformLogic()
./EasyClip/EasyClip/EasyClip.py:449: harden = slicer.vtkSlicerTransformLogic()

./PickAndPaintExtension/PickAndPaint/PickAndPaint.py:365: logic = slicer.vtkSlicerTransformLogic()
./PickAndPaintExtension/PickAndPaint/PickAndPaint.py:422: logic = slicer.vtkSlicerTransformLogic()

./Q3DC/Q3DC/Q3DC.py:613: logic = slicer.vtkSlicerTransformLogic()
./Q3DC/Q3DC/Q3DC.py:670: logic = slicer.vtkSlicerTransformLogic()
jcfr

jcfr

2016-06-09 00:53

administrator   ~0013960

A first step could be to relocate the code in the transform module while keeping its name. That way existing extension would still work as expected.

Issue History

Date Modified Username Field Change
2013-02-09 19:16 finetjul New Issue
2013-02-09 19:16 finetjul Status new => assigned
2013-02-09 19:16 finetjul Assigned To => jcfr
2013-02-10 16:41 jcfr Note Added: 0007865
2013-02-10 16:52 jcfr Note Added: 0007866
2013-02-11 07:09 jcfr Target Version => Slicer 4.3.0
2013-08-27 05:39 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2013-08-27 05:40 jcfr Target Version Slicer 4.4.0 => Slicer 4.3.0
2013-08-27 05:44 finetjul Note Added: 0009613
2013-08-27 07:09 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2013-08-27 07:12 jcfr Note Added: 0009615
2014-05-12 23:55 jcfr Status assigned => acknowledged
2014-05-12 23:55 jcfr Target Version Slicer 4.4.0 =>
2016-06-09 00:52 jcfr Note Added: 0013959
2016-06-09 00:53 jcfr Note Added: 0013960
2016-06-09 00:53 jcfr Tag Attached: help-wanted