 |
Consider talking with Nicole with you think the recent change in Annotation caused this issue. Thanks |
 |
If I try to change ROI visibility from Annotations module, this does not work either. The ROI shows up in the annotations list, but clicking eye icon has no effect. I will email Nicole (I am working from home today because the city is shutting down because of coming storm). |
|
|
to reproduce, it is sufficient to create vtkMRMLROIAnnotationNode in the python console and add to the scene: it will show up in the Annotations module list, but will not respond to visibility toggles. |
 |
When creating an annotation node programatically, the display nodes need to be added as well, usually by calling Initialize. If I do the following in hte python console, the ROI appears in all the viewers: roi = slicer.mrmlScene.CreateNodeByClass("vtkMRMLAnnotationROINode") (having some difficulty staying connected to the SPL from home, sorry I missed this until now!) |
|
|
The annotation logic should listen to the scene and call these initialize methods if needed. |
|
|
The .mrml file may have to have it's annotation display node settings tweaked, where can I find a copy to test? The link on the planning page just points to the tutorial pdf. |
|
|
Nicole, there's no mrml file, it's a step-by-step tutorial. When was this change introduced? I do not have display node added manually, and it worked fine for the last year or so. |
|
|
JC: the display nodes always get added to the scene after the annotation nodes, the logic listening just for a node added event may over ride display nodes that are about to be added. Historically, I think we've checked in displayable managers when we're about to render to see if display nodes are needed. |
|
|
Andrey: I was going by: |
|
|
Nicole: Part 3 of tutorial "Slicer4QuantitativeImaging.pdf", slide 67 |
|
|
The dataset is linked here: http://wiki.slicer.org/slicerWiki/index.php/Documentation/4.1/Training#Slicer4_Quantitative_Imaging_tutorial But it should not have any ROI-related nodes in the scene, just the data. I confirm that adding Initialize() resolves the issue in ChangeTracker Step2. |
|
|
JC: no link to data in it, beyond a link to a C: drive Documents and Settings directory on slide 5 |
|
|
Nicole: Data available here: http://www.na-mic.org/Bug/view.php?id=2511#c6250 |
|
|
Initialize() call added in http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21274 Also, Nicole: SetROIAnnotationVisibility() no longer works, but it does not trigger any errors or warnings, after you changed visibility toggle API. As discussed with Steve, maybe you should add an empty call that would print some warning message alerting the developer/user of the API change so that the code could be updated accordingly if needed? https://github.com/fedorov/ChangeTrackerPy/commit/b4fa890c98e162ee51394a52f6577fc1a4eed7a5 |
 |
Andrei: The new behavior has been added in r21159: The ROI nodes are unique because they can be displayed without the need for a display node. However, since r21159 a display node is mandatory to control the visibility. (though no display node makes the ROI visible) |
|
|
Julien: I thought we were in a feature freeze on the trunk since Sept 1, no?! |
|
|
SetROIAnnotationVisibility was just setting the visibility of any text associated with the ROI, not the visibility on the whole ROI. Looks like there was a copy/paste error in the header file Doxygen comment(s). |
|
|
Andriy: Reading the commit message, new behavior associated with r21159 is a side effect of bug fix for issue 0002473. "BUG: mantis issue 0002473 unify the visibility setting on the annotation nodes. Needed to have the data module displayable tree show the correct visibility flag and for calculating widget visibility in the displayable managers" |
|
|
Andrey: that was part of a bug fix. |
|
|
Closing resolved issues that have not been updated in more than 3 months |
- Anonymous
