View Issue Details

IDProjectCategoryView StatusLast Update
0001243Slicer4Core: Base Codepublic2012-09-15 10:04
Reporterkikinis Assigned Tonicole  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.1.0 
Summary0001243: hierarchy display in slicer 4 is not the same as in slicer 3 mac 7-1 2011
Description

-In slicer 3 you had drag and drop capability to create and edit hierarchies for models. This is not the case in slicer 4.
-When selecting a parent you could turn visibility on and off for the parent and all children with a single click on the visibility of the parent in slicer 3. this is missing in slicer 4.
-when collapsing an hierachy, all children were assigned the color of the parent. This is not working in Slicer 4

The knee atlas can be used to look at these issues.

TagsNo tags attached.

Relationships

duplicate of 0001249 closednicole parents in the model hierarchy do not have colors and can not be used to turn all their children on and off. 
related to 0002163 closedfinetjul models hierarchy is not workable 
related to 0001758 closednicole Loading Model hierarchy scene while having the Model module open result in bad hierarchy 

Activities

finetjul

finetjul

2011-08-15 06:52

administrator   ~0002706

Drag&Drop + Insert hierarchy fixed in r1782:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=17582

nicole

nicole

2011-08-16 13:59

administrator   ~0002715

Collapse/Expand Hierarchy:

  1. Problem with adding new hierarchies:
    • Add Data -> add a model
    • Go to the models module
    • right click on Scene and Insert Hierarchy
    • click on the new hieararchy and change the colour in the display tab
    • drag the model into the new hierarchy (currently the tree view is too small for me to see more than one row at a time, so can't drag and drop in Models, but you can switch to the Displayable scene view in the Data module and drag it there)
    • the hierarchy is collapsed, but it's not updating the Expanded flag on the hierarchy node so the model doesn't get assigned the hierarchy display node colour

Julien suggested looking for the model reset or layout changed events on the tree view, as connecting the rowsInserted signal on the sort filter doesn't get the added slot called in qSlicerModelsModuleWidget.cxx:

connect(d->ModelHierarchyTreeView->sortFilterProxyModel(), SIGNAL(rowsInserted(const QModelIndex&, int, int)), this, SLOT(onRowsInserted(const QModelIndex&, int, int)));

nicole

nicole

2011-08-16 14:02

administrator   ~0002716

Changing the visibility on the model hierarchy's display node while the hierarchy is collapsed does not hide/show the models in the hierarchy. Neither do changes to Selected/Clip/Slice Intersections Visible propagate.
It works when changing the elements in the Material Properties.

nicole

nicole

2011-08-16 14:21

administrator   ~0002717

Also: look at exposing the bugs through tests in Slicer4/QTModules/Models/Testing/Cxx

nicole

nicole

2011-09-14 09:33

administrator   ~0003026

Need to add the visibility column to the scene model for the hierarchy nodes.

nicole

nicole

2011-09-15 14:40

administrator   ~0003053

Visibility should be fixed in svn 18069.

finetjul

finetjul

2011-09-15 19:46

administrator   ~0003054

r18076:

kikinis

kikinis

2011-09-16 04:55

developer   ~0003060

Using knee atlas and mac nightly 9-16:
-still no eye icon for parents in hierarchy
-The display section allows to check visibility for a parent, but this has no effect.
-When collapsing a branch of a hierarchy, the children become invisible. This is reversible upon uncollapsing. Try clicking on the plus to the left of the vascular system in the knee atlas.
-drag and drop results in dropping the structure twice. see screenshot

2011-09-16 04:56

 

kikinis

kikinis

2011-09-26 11:10

developer   ~0003117

-the eye icon has appeared for parents, but it is still not doing anything.

finetjul

finetjul

2011-09-26 11:11

administrator   ~0003118

Eye icons don't do anything for parent in the Models module or in the Data module ?

nicole

nicole

2011-10-17 10:34

administrator   ~0003184

2+ level hierarchy checked against Slicer3 behaviour and it is the same. It will use the colour of the first collapsed parent node above the model, rather than the one highest in the tree (see the vessels hierarchy in the knee atlas).
Still tracking down visibility changes on hierarchy nodes (mrml nodes are changing, the displayable manager isn't reflecting it).

nicole

nicole

2011-10-25 13:41

administrator   ~0003208

svn 18468 fixes the hierarchy visibility flag when it's expanded for the knee atlas when it's loaded while not in the Models module. More testing/debugging required to figure out why the tree doesn't render properly when in the Models module while loading a scene.
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=18468

nicole

nicole

2012-08-22 11:39

administrator   ~0005722

svn 20827 fixed the load knee atlas while the Models module is open

Issue History

Date Modified Username Field Change
2011-07-01 19:20 kikinis New Issue
2011-07-05 16:38 finetjul Relationship added duplicate of 0001249
2011-07-05 16:38 finetjul Status new => assigned
2011-07-05 16:38 finetjul Assigned To => finetjul
2011-07-29 19:11 finetjul Assigned To finetjul => nicole
2011-08-15 06:52 finetjul Note Added: 0002706
2011-08-16 13:59 nicole Note Added: 0002715
2011-08-16 14:02 nicole Note Added: 0002716
2011-08-16 14:21 nicole Note Added: 0002717
2011-08-25 09:27 finetjul Target Version => Slicer 4.0 RSNA
2011-09-14 09:33 nicole Note Added: 0003026
2011-09-15 14:40 nicole Note Added: 0003053
2011-09-15 19:46 finetjul Note Added: 0003054
2011-09-16 04:55 kikinis Note Added: 0003060
2011-09-16 04:56 kikinis File Added: Screen Shot 2011-09-16 at 8.55.35 AM.png
2011-09-26 11:10 kikinis Note Added: 0003117
2011-09-26 11:11 finetjul Note Added: 0003118
2011-10-17 10:34 nicole Note Added: 0003184
2011-10-25 13:41 nicole Note Added: 0003208
2012-02-28 14:09 nicole Relationship added related to 0001758
2012-08-20 09:26 nicole Relationship added related to 0002163
2012-08-20 09:27 nicole Target Version Slicer 4.0.0 => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-08-22 11:39 nicole Note Added: 0005722
2012-08-22 11:39 nicole Status assigned => resolved
2012-08-22 11:39 nicole Fixed in Version => Slicer 4.1.0
2012-08-22 11:39 nicole Resolution open => fixed
2012-09-15 10:04 kikinis Status resolved => closed