View Issue Details

IDProjectCategoryView StatusLast Update
0002163Slicer4Core: GUIpublic2018-03-02 11:06
Reporterkikinis Assigned Tofinetjul  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionunable to reproduce 
PlatformmacOSOS XOS Version10.7.4
Product VersionSlicer 4.1.0 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.5.0-1 
Summary0002163: models hierarchy is not workable
Description

We are trying to organize models into an hierarchy. When you have a lot of models this is not working for me.

  1. load the scene in dropbox ronsexamples 2012-06-05-hn+cma...
  2. go to the models module
  3. right click at the top to create an hierarchy called ventricles
  4. try to drag all the models with ventricle in the name into that hierarchy
    I was not able to drop them on first, second, third or fourth attempt.
  5. if the model is outside the visible area, there is no way to drag and scroll at the same time.
    I qualified it as crash, because its not working at all for me. This is work for the upcoming sitevisit.
TagsNo tags attached.

Relationships

related to 0001723 closedfinetjul qMRMLTreeView::fitToVisibleIndexes should support drag&drop when view is higher than what's visible 
parent of 0002433 closedfinetjul the Model Hierarchy View window does not fit to the size of the expanded tree. 
related to 0001249 closednicole parents in the model hierarchy do not have colors and can not be used to turn all their children on and off. 
related to 0001243 closednicole hierarchy display in slicer 4 is not the same as in slicer 3 mac 7-1 2011 
related to 0001759 closednicole Crash when "Clipping" tissue model 
child of 0002430 closedfinetjul Models jump around in the MRML tree view when visibility is changed 

Activities

kikinis

kikinis

2012-06-05 06:31

developer   ~0004765

Is it possible to select multiple models and drag all of them as a group?

nicole

nicole

2012-06-05 06:40

administrator   ~0004766

I talked to Marianna on the phone about this issue, she was able to drag and drop, as well as scroll while dragging, when I had her switch the Data module scene model to Displayable and build the tree there.

jcfr

jcfr

2012-06-05 15:20

administrator   ~0004773

Nicole,
As discussed, Julien will be providing you support through email.

nicole

nicole

2012-06-13 11:13

administrator   ~0004814

svn 20352 should fix the "drag past the end of the visible tree" problem:
d->ModelHierarchyTreeView->setFitSizeToVisibleIndexes(false);

Enabled selection of multiple models at once (selection mode set to QAbstractItemView::ExtendedSelection), with delete and rename working.
Still to do: get dropping working more robustly for single models, and get it working for multiple models.

inorton

inorton

2012-06-20 11:33

developer   ~0004867

Clicking between models to select will frequently change the visibility state of the model and other models in the hierarchy. for example, set one model to visible and the other invisible, then click the visibility button for the first model. The visibility state of both models will be switched.

inorton

inorton

2012-06-20 12:27

developer   ~0004868

Also, it seems that it is no longer possible to change colors and opacity from the hierarchy list slider/button. In the case of colors, the selector pops up, but the color choice is not applied.

marianna

marianna

2012-06-27 13:53

reporter   ~0004955

in Slicer 4.1.0-2012-06-26 the Model Hierarchy View window does not fit to the size of the expanded tree.

nicole

nicole

2012-07-11 14:47

administrator   ~0005123

Julien figured out why drag and drop in the models module wasn't working well (icon comparison via cache keys changed to using a decoration role). svn 20604 fixes it for me.

Isiah: I havne't been able to reproduce your colour setting bug, is it still an issue?

pieper

pieper

2012-08-14 08:56

administrator   ~0005548

After discussion, Julien explained that in Qt, using the open/close state of the treeview is not 'meant' to control aspects of the underlying model.

Instead, we discussed adding an "override" checkbox (or similar) to parent nodes -- this would make it explicit for users. The rule would be that the highest parent in the hierarchy that has the override property should define the view of the children (and grandchildren...)

finetjul

finetjul

2012-08-15 10:43

administrator   ~0005556

Last edited: 2012-08-15 10:56

Checkbox is controlling the "Expanding" property as of r20768

Nonetheless there are inconsistencies at the MRML level:
a) GetUnExpandedParentNode: see failing test from r20766.
b) DisplayModifiedEvent: see failing test from r20766.
c) model Visibility is not behaving the same way colors behave (qMRMLTreeView is calling vtkMRMLModelHierarchyLogic::SetChildrenVisibility)
d)(bonus): Rename "UnExpanded" into "Collapsed"
e)(bonus): Add utility methods (GetColor/Visibility or GetCollapsedDisplayNode)... in vtkMRMLDisplayableHierarchyNode that returns the the collapsed hierarchy display node properties.

kikinis

kikinis

2012-08-16 04:50

developer   ~0005558

I am not quite clear what the checkbox does. I tried it on 8-15 nightly on linux.
it would be good to have a tooltip

nicole

nicole

2012-08-22 09:36

administrator   ~0005704

b - svn 20825, test vtkMRMLDisplayableHierarchyNodeTest1 now passes.

nicole

nicole

2012-08-22 09:57

administrator   ~0005706

a) adding a few print outs into the test, this is correct (or at least consistent with Slicer3 behaviour): when there is a hierarchy tree multiple levels deep and sub hierarchies are collapsed as well as the top level hierarchy, the collapsed sub hierarchy closest to the model is returned by GetUnExpandedParentNode.

So current behaviour is:
H1
m1
H2
m2
If H2 and H1 are collapsed, model m2 will be displayed using the color from the display node associated with H2.
If only H1 is collapsed, models m1 and m2 will be displayed using the color from the display node associated with H1.

I agree that it's confusing, pointing the email thread back to the bug to get feedback on changing it.

nicole

nicole

2012-08-22 09:59

administrator   ~0005707

c) is related to a), what's the desired behaviour, to just use the model hierarchy display node properties for the models or to actually change the model display nodes under the hierarchy (currently it's inconsistent, visibility is done differently than color). Waiting on feedback.

nicole

nicole

2012-08-27 11:30

administrator   ~0005812

Last edited: 2012-08-27 11:31

updated the failing test vtkMRMLDisplayableHierarchyNodeDisplayPropertiesTest to give expected values, svn 20874.

nicole

nicole

2012-08-30 12:19

administrator   ~0005892

Talking to Ron on the NAMIC Eng t-con:
Re: comment 0005706, he wants m2 to be coloured by H1 if both H1 and H2 are collapsed.
Re: comment 0005707, the changing of the model visibility is desired, but we need a more intuitive UI to make it clear what's going on.

nicole

nicole

2012-08-31 07:18

administrator   ~0005904

svn 20898 fixes getting the UnExpanded parent node, and renames it to Collapsed.

nicole

nicole

2012-09-05 15:17

administrator   ~0005987

Marianna need the tree to adjust to the number of nodes and drag and drop working past the end of the window.

finetjul

finetjul

2012-09-15 11:35

administrator   ~0006097

Moved the checkbox in the color column in r20991

finetjul

finetjul

2012-09-17 15:33

administrator   ~0006115

Moved the checkbox in own column in r20999

kikinis

kikinis

2012-09-17 18:16

developer   ~0006116

it would be good to have all colors stay in a single column. See image why this does not work.

2012-09-17 18:17

 

finetjul

finetjul

2012-09-21 06:04

administrator   ~0006159

Colors staying in a single column has been fixed in r20999 (see comment 0006115)

jcfr

jcfr

2015-11-10 14:47

administrator   ~0013585

As of r24719, unable to reproduce the problem.

Issue History

Date Modified Username Field Change
2012-06-05 06:29 kikinis New Issue
2012-06-05 06:31 kikinis Note Added: 0004765
2012-06-05 06:39 jcfr Assigned To => nicole
2012-06-05 06:39 jcfr Status new => assigned
2012-06-05 06:39 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-06-05 06:40 nicole Note Added: 0004766
2012-06-05 06:40 nicole Assigned To nicole => finetjul
2012-06-05 06:40 nicole Target Version Slicer 4.2.0 - Sept 1st 2012 =>
2012-06-05 07:04 jcfr Target Version => Slicer 4.1.0-2012-06-23 - Site Visit
2012-06-05 15:19 jcfr Target Version Slicer 4.1.0-2012-06-21 - Site Visit => Slicer 4.2.0 - Sept 1st 2012
2012-06-05 15:19 jcfr Assigned To finetjul => nicole
2012-06-05 15:20 jcfr Note Added: 0004773
2012-06-13 11:13 nicole Note Added: 0004814
2012-06-20 11:33 inorton Note Added: 0004867
2012-06-20 12:27 inorton Note Added: 0004868
2012-06-27 13:53 marianna Note Added: 0004955
2012-07-11 14:47 nicole Note Added: 0005123
2012-08-07 12:52 nicole Assigned To nicole => finetjul
2012-08-14 08:56 pieper Note Added: 0005548
2012-08-15 10:43 finetjul Note Added: 0005556
2012-08-15 10:53 finetjul Note Edited: 0005556
2012-08-15 10:54 finetjul Note Edited: 0005556
2012-08-15 10:56 finetjul Note Edited: 0005556
2012-08-15 14:16 finetjul Assigned To finetjul => nicole
2012-08-16 04:50 kikinis Note Added: 0005558
2012-08-20 09:15 nicole Relationship added related to 0001249
2012-08-20 09:26 nicole Relationship added related to 0001243
2012-08-21 13:17 nicole Relationship added related to 0001759
2012-08-22 09:36 nicole Note Added: 0005704
2012-08-22 09:57 nicole Note Added: 0005706
2012-08-22 09:59 nicole Note Added: 0005707
2012-08-22 10:00 nicole Status assigned => feedback
2012-08-22 13:33 finetjul Relationship added child of 0002430
2012-08-27 11:30 nicole Note Added: 0005812
2012-08-27 11:31 nicole Note Edited: 0005812
2012-08-30 12:19 nicole Note Added: 0005892
2012-08-31 07:18 nicole Note Added: 0005904
2012-09-05 15:17 nicole Note Added: 0005987
2012-09-05 15:17 nicole Assigned To nicole => finetjul
2012-09-05 15:17 nicole Status feedback => assigned
2012-09-15 11:35 finetjul Note Added: 0006097
2012-09-17 15:33 finetjul Note Added: 0006115
2012-09-17 18:16 kikinis Note Added: 0006116
2012-09-17 18:17 kikinis File Added: Screen Shot 2012-09-17 at 2.35.43 PM.png
2012-09-20 09:01 nicole Relationship added parent of 0002433
2012-09-20 09:03 nicole Relationship added related to 0001723
2012-09-21 06:03 finetjul Status assigned => resolved
2012-09-21 06:03 finetjul Fixed in Version => Slicer 4.2.0 - coming release
2012-09-21 06:03 finetjul Resolution open => fixed
2012-09-21 06:04 finetjul Note Added: 0006159
2012-09-21 06:04 kikinis Status resolved => closed
2015-11-10 14:47 jcfr Note Added: 0013585
2015-11-10 14:47 jcfr Status closed => resolved
2015-11-10 14:47 jcfr Fixed in Version Slicer 4.2.0 => Slicer 4.5.0-1
2015-11-10 14:47 jcfr Resolution fixed => unable to reproduce
2018-03-02 11:06 jcfr Status resolved => closed