Changesets: Import 2017-06-07 23:51:09

master f278821c

2015-03-10 17:44:07

jcfr

Details Diff
BUG: Do not expect log file to exist to try to append text for the first time

This commit fixes a regression introduced in r24051 (ENH: Add convenience
function to append text to current log file.)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24054 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 16260ced

2015-03-10 17:30:42

jcfr

Details Diff
STYLE: Fix help message layout removing logging of application name

This commit removes the debug message added in r24004 (ENH: Allow
application name to be defined by argv0)

Prior to this commit, the name of the application was displayed
between the launcher help message and the application one:

8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---
[...]
--xterm Start xterm
--gdb Start gdb
applicationName: "Slicer"
--, --ignore-rest Ignores the rest of the labeled arguments following this flag. (default: false)
-h, --help Display available command line arguments
[...]
8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24053 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File

master eedd2811

2015-03-10 17:30:41

jcfr

Details Diff
ENH: Append module loading stats to log file.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24052 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 89f4b4de

2015-03-10 17:30:27

jcfr

Details Diff
ENH: Add convenience function to append text to current log file.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24051 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.h Diff File

master 9a5cbf17

2015-03-10 17:30:25

jcfr

Details Diff
ENH: Display module loading stats only if verbose module discovery is set.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24050 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File

master 014dc19e

2015-03-10 14:18:25

jcfr

Details Diff
STYLE: Fix typo in comment

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24049 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerModulePanel.cxx Diff File

master 0be60664

2015-03-10 13:10:49

jcfr

Details Diff
ENH: Update VTK to v6.2.0

$ git shortlog d733280..v6.2.0 --no-merges
Aashish Chaudhary (6):
Do not assume initial min and max values
Attempt to fix failing independent component tests
GLSL 120 does not support sampler arrays
Added missing header
Fixed errors found using valgrind leak check
Silenced compiler warnings

Andrew Bauer (1):
Getting rid of compiler warnings.

Andrew Maclean (2):
Visual Studio 2013 requires the <algorithm> header.
Remove the unnecessary find_package command.

Arnaud Gelas (1):
Limiting number of ModifiedEvent when calling vtkTransform::SetMatrix

Ben Boeckel (19):
IOXdmf3: remove excess MPI stuff
install: install missing module-related files
netcdf: support a system netcdf
cmake: reformat java compilation commands
java: add an option to set the target for java compiles
wxVTKRenderWindow: support wxPython 3.0
wrapping: find superclasses that are templates
examples: add shebang lines
doxygen: remove obsolete options
doxygen: add an option to disable CHM files
release: add scripts for release maintenance
python: don't export Python modules as targets
maint: use "git checkout" rather than reset
maint: ignore css files for ctags as well
metaio: remove stray reject file
vtkModuleTop: handle UsrMove-like setups
vtkWrap: use size_t for sizes
vtkPistonMapper: fix a overload-virtual warning
vtkWrapTcl: hide dString when there are no methods

Dan Lipsa (1):
BUG: Fix mispelled excluded class and print out all exclusions.

Dave DeMarle (2):
per bug 14586 fix external vtkLocal
allow examples to be built without tests

David C. Lonie (4):
Fix an error in setting an array length.
Fix conic point identification in the path renderer.
Fix warning in vtkLabeledContourMapper.cxx
Allow the initial GL2PS buffer size to be set.

David Gobbi (1):
Fix arg conversion of const ref arg via constructor.

Jean-Christophe Fillion-Robin (4):
vtkRenderer: Fix null pointer crash in ViewToWorld() with no active camera
vtkhdf5: Fix build error when building on system with glic >= 2.19
per bug 14826 make find_package vtk more lenient
vtkCornerAnnotation: Add convenience TextPosition enum

John Tourtellott (6):
Set geo-origin and -spacing in RequestInformation() call
Add vtkGDAL class & MAP_PROJECTION key for pipeline data and field data
Change missing geotransform from error to warning.
Fix ctest errors
Turn off wrapping for vtkGDAL.h
Declare vtkGDAL constructor & destructor private, since class is static

Ken Martin (6):
Some updates to the timing test
Fix molecular rendering in parallel projection
Fix an issue with mapper requiring a polydata input
Update to a cleaner way of solving the issue
Fix a couple issues
A fix for shader link error reporting an molecules with lightkit

Sean McBride (1):
Remove the addition of a few inappropriate vtkErrorMacro

Shawn Waldon (3):
Add an option to set default radius of point gaussian
Fix triangle size for sprites with radius > 1
Made Point Gaussian mapper handle scale arrays not in dataset

Sujin Philip (4):
VTK SMP implementation of SynchronizedTemplates3D
Fix SMP compile warning in VC++
Use the correct TBB lib based on the build config
Fix for SMP examples compile issues

Tim Thirion (2):
Update Android toolchain file (now support NDKs r5 through r10d)
Add one-pass Android build

acbauer (1):
Fixing issue of wrong celldata output order from vtkGeometryFilter.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24048 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTKv6.cmake Diff File

master c68ee668

2015-03-10 11:50:52

jcfr

Details Diff
ENH: Add scene static method to set storable nodes modified since read

Add a convenience function that takes a collection of nodes and
call it from the function that creates the collection of storable
nodes.

Issue 0003698

Inspired-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Nicole Aucoin <nicole@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24047 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File

master 4c39e0c6

2015-03-10 11:50:50

jcfr

Details Diff
BUG: Set scene to MRB directory instead of temp

When loading an MRB the MRML scene url was left pointing to
the deleted temporary directory. This change resets the URL
to point to a mrml file in the same location as the MRB so
that on subsequent saves the default location is correct.
Since the temporary directory is deleted after loading,
mark all the storable nodes as modified since read so that
they will be properly flagged in the save data dialog for
writing.
Support relative paths for loading MRBs (the unzip call
needs an absolute path).

Issue 0003698

From: Nicole Aucoin <nicole@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24046 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerSceneBundleReader.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File

master 64790658

2015-03-10 10:43:47

jcfr

Details Diff
BUG: Fix py_nomainwindow_qSlicerDICOMModuleGenericTest

Fix the failing test ensuring "qt loadable modules" are also discovered
when executing generic scripted module tests.

Inspired-by: Nicole Aucoin <nicole@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24045 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroBuildScriptedModule.cmake Diff File

master 17012a1a

2015-03-10 01:20:47

jcfr

Details Diff
BUG: Update EMSegment to fix "EMSeg_MRML_DiffReadWriteNodes" test

// -----------------
r17095 | jcfr | 2015-03-10 00:46:54 -0400 (Tue, 10 Mar 2015) | 3 lines

BUG: Fix EMSeg_MRML_DiffReadWriteNodes test

Add missing attribute 'placeModePersistence' into mrml scene used for the Tutorial tests
// -----------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24044 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 4fb432e6

2015-03-09 23:52:04

jcfr

Details Diff
BUG: Update CTK to include fix for VTK log message parsing regexp

$ git shortlog 6983ecc..a358caf --no-merges
Andras Lasso (1):
Fixed VTK log message parsing regexp

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24043 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master afea6b9b

2015-03-09 23:40:06

jcfr

Details Diff
STYLE: Add inclusion to guard to vtkAddon.h

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24042 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkAddon/vtkAddon.h Diff File

master 61a1a9b0

2015-03-09 23:27:02

lassoan

Details Diff
COMP: Added missing file to source control

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24041 3bd1e089-480b-0410-8dfb-8563597acbee
add - Libs/vtkAddon/vtkAddon.h Diff File

master 49f9958e

2015-03-09 22:46:17

jcfr

Details Diff
BUG: Remove obsolete NeurosurgicalPlanningTutorial QtTesting based test

QtTesting XML tests are hard to maintain. Considering tutorial tests are
now all written in python as SelfTest, this commit removes the last QtTesting
tests.

For example, in the case of the NeurosurgicalPlanningTutorial test, the
play back is failing because the tree indices first recorded are now
invalid. Most likely because the associated widget has been updated.
Considering that (1) the XML is hard to manually update and debug and
(2) is is difficult to re-record only a section of the test starting from
the expected state, it would usually require the developer to re-record
the full test. This is time consuming and sub-optimal. With better
instrumentation or by using the QtTesting python based test (instead of
the XML), it may be worth reconsidering.

Also remove DiffusionTensorImagingTutorial related files (the associated
test has been disabled in r22388)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24040 3bd1e089-480b-0410-8dfb-8563597acbee
rm - Applications/SlicerApp/Data/Input/NeurosurgicalPlanningTutorial.xml Diff File
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
rm - Applications/SlicerApp/Testing/Python/DiffusionTensorImagingTutorial.py Diff File
rm - Applications/SlicerApp/Testing/Python/NeurosurgicalPlanningTutorial.py Diff File
rm - Applications/SlicerApp/Testing/Python/slicerappdatapaths.py.in Diff File

master 6871f58b

2015-03-09 22:30:03

lassoan

Details Diff
ENH: Added vtkInfoMacro

Added in a new vtkAddon library, which contains Slicer's VTK add-ons that eventually could be moved to VTK proper.

Resolves https://github.com/Slicer/Slicer/pull/205

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24039 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Resources/UI/qSlicerAppErrorReportDialog.ui Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerModulePanel.cxx Diff File
mod - Libs/CMakeLists.txt Diff File
mod - Libs/MRML/Core/CMakeLists.txt Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeArchetypeStorageNode.cxx Diff File
add - Libs/vtkAddon/CMakeLists.txt Diff File
add - Libs/vtkAddon/Testing/CMakeLists.txt Diff File
add - Libs/vtkAddon/Testing/vtkLoggingMacrosTest1.cxx Diff File
add - Libs/vtkAddon/vtkAddonConfig.cmake.in Diff File
add - Libs/vtkAddon/vtkAddonConfigure.h.in Diff File
add - Libs/vtkAddon/vtkAddonWin32Header.h Diff File
add - Libs/vtkAddon/vtkLoggingMacros.h Diff File

master 36eaeaff

2015-03-09 13:27:59

jcfr

Details Diff
STYLE: Remove unused ivar from qMRMLLayoutManagerPrivate

* GridLayout became obsolete following r15995 (ENH: Add
support for layout XML descriptions.)

* SavedCurrentViewArrangement became obsolete following r16046 (ENH: Move
lastvalidlayout from qMRMLLayoutManager to vtkMRMLLayoutLogic)

* TargetWidget became obsolete following r15129 (ENH: Separate MRML
specific code of qSlicerLayoutManager into qMRMLLayoutWidget.)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24038 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutManager_p.h Diff File

master 9cb24a8c

2015-03-09 13:27:57

jcfr

Details Diff
STYLE: Remove unused methods from qMRMLLayoutManagerPrivate

This commit removes code that became obsolete following
r24017 (ENH: Add qMRMLLayoutViewFactory)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24037 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutManager.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLayoutManager_p.h Diff File

master b61ed629

2015-03-09 13:27:56

jcfr

Details Diff
BUG: Fix qMRMLLayoutManager::viewWidget method

This commit fixes a regression introduced by r24017 (ENH: Add qMRMLLayoutViewFactory)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24036 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest1.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLayoutManager.cxx Diff File

master 10e6634f

2015-03-09 03:23:47

lassoan

Details Diff
BUG: Fixed crash on application exit

Fixes failing atlas tests on the dashboard.

The problem was that vtkMRMLModelDisplayableManager unregistered vtkMRMLSelection singleton node in the destructor that it did not register before (therefore causing crash due to double-delete later when the true owners of the object unregistered).


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24035 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File

master 185e35a2

2015-03-09 03:23:21

lassoan

Details Diff
COMP: Added back Q_ASSERT for catching errors during tests

Use null-pointer check to prevent crash in release mode but added back Q_ASSERT to trigger a test error during test runs.
Fixed typo.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24034 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLROIWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File

master 35942a29

2015-03-08 23:24:18

lassoan

Details Diff
ENH: Added null pointer check

With the check Slicer fails gracefully (logs the error and does not update the invalid scene model item) instead of crashing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24033 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File

master 266ccb8d

2015-03-08 23:00:01

lassoan

Details Diff
ENH: Use Start/EndModify instead of manually calling InvokePendingModifiedEvent

Replaced obsolete DisabledModifiedEventOn/Off, InvokePendingModifiedEvent combination by Start/EndModify (it is simpler and works for nested Start/EndModify)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24032 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkThreeDViewInteractorStyle.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLROIWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLVolumeInfoWidget.cxx Diff File
mod - Modules/Loadable/CropVolume/MRML/vtkMRMLCropVolumeParametersNode.cxx Diff File
mod - Modules/Loadable/MultiVolumeRendering/MRML/vtkMRMLMultiVolumeRenderingDisplayNode.cxx Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/Logic/vtkMRMLTractographyInteractiveSeedingNode.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumeRenderingScenarioNode.cxx Diff File

master b465887a

2015-03-08 13:18:12

lassoan

Details Diff
BUG: Fixed markup custom modification event notifications

Fixes http://www.na-mic.org/Bug/view.php?id=3961 (markups RemoveAllItems not working properly) and many other update issues.

Problem:
StartModify/EndModify mechanism works well for Modified() event compression. Such mechanism is desirable for custom, more specific modified events, too (such as when markups are added, removed, modified).
For example, the same mechanism was implemented for TransformModified and for MarkupAddedEvent, MarkupRemovedEvent, etc.

Solution:
To reduce code duplication and the chance of making mistakes (e.g., Markup modification event compression was implemented incorrectly), the mechanism is now available for custom modified events.
Usage is very simple instead of calling vtkMRMLNode::InvokeEvent on has to call vtkMRMLNode::InvokeCustomModifiedEvent. InvokeCustomModifiedEvent behaves the same way as InvokeEvent by default,
but if DisableModifiedEvent is enabled then InvokeCustomModifiedEvent only emits the event when EndModify is called (after invoking the pending standard Modified event).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24031 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLLinearTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.h Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File

master d3c834e9

2015-03-08 00:34:56

lassoan

Details Diff
BUG: Fixed crash in CropVolumeSelfTest

vtkImageData observer was not removed when vtkMRMLScalarVolumeNode::SetAndObserveImageData(NULL) was called.
This caused crash when Modified() was called on the vtkImageData because the target object of the observation (vtkTrivialProducer) is deleted by this->SetImageDataConnection(0).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24030 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 78 79 80 81 82 83 84 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last