Changesets: Import 2017-06-07 23:51:09

master 40dfec71

2015-03-17 03:49:28

jcfr

Details Diff
STYLE: Fix typo in configuration message displaying organization domain/name

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24079 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master d8cc4f62

2015-03-17 03:14:51

jcfr

Details Diff
ENH: Pass organization domain and name to Slicer inner build

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24078 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master e01c1f4e

2015-03-17 03:14:50

jcfr

Details Diff
COMP: SlicerCPack: Find additional dependencies quietly

If the external project is a python package, it is not expected to
provide a Config file.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24077 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerCPack.cmake Diff File

master ca6f8e7e

2015-03-17 00:02:58

jcfr

Details Diff
ENH: Check if SlicerApp application name is not already defined

This allows to define custom values in SlicerOverwriteDefaultOptions.cmake

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24076 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master 56cb5bcb

2015-03-16 23:23:19

jcfr

Details Diff
ENH: Check if Slicer major/minor/patch version are not already defined

This allows to define custom values in SlicerOverwriteDefaultOptions.cmake

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24075 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master 79023d6c

2015-03-16 23:06:26

jcfr

Details Diff
ENH: Check if organization and domain name are not already defined

This allows to define custom values in SlicerOverwriteDefaultOptions.cmake

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24074 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master e06bd998

2015-03-16 18:57:11

jcfr

Details Diff
STYLE: Tweak SlicerBlockFindQtAndCheckVersion to display main project name

As it was done in r23926 for the top-level CMakeLists.txt
and SlicerMacroBuildBaseQtLibrary, this commit also updates the
Slicer custom findQt module to display Slicer_MAIN_PROJECT_APPLICATION_NAME
if used from the Slicer source directory or the CMake PROJECT_NAME if used
from outside (case of extension).

Co-authored-by: Sergey Aleshin <4memph@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24073 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockFindQtAndCheckVersion.cmake Diff File

master 218a70d7

2015-03-16 18:57:09

jcfr

Details Diff
BUG: Keep NodeIDs cache up-to-date when importing Singleton node

This commit avoids the error message like [1] (displayed by running
'Abdominal_Atlas_2012') from being printed by ensuring
modified event associated with the import of singleton are invoked
after the NodeIDs cache is updated.

[1] GetNodeByID: Node is in the scene, but its ID is missing from the NodeIDs cache: vtkMRMLClipModelsNode1

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24072 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File

master e08c354c

2015-03-16 18:57:07

jcfr

Details Diff
COMP: Ensure vtkMRMLScene can be compiled with MRMLSCENE_VERBOSE set to 1

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24071 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File

master 5ca7d0f5

2015-03-14 20:51:33

jcfr

Details Diff
BUG: Support restoring of a sceneview not having a camera

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24070 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLCameraDisplayableManager.cxx Diff File
mod - Modules/Loadable/SceneViews/CMakeLists.txt Diff File
add - Modules/Loadable/SceneViews/Testing/CMakeLists.txt Diff File
add - Modules/Loadable/SceneViews/Testing/Data/Input/SceneViewWithoutCamera.mrml Diff File
add - Modules/Loadable/SceneViews/Testing/Python/CMakeLists.txt Diff File

master c8ae568c

2015-03-14 20:51:29

jcfr

Details Diff
STYLE: Remove unused code

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24069 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File

master 99ad263a

2015-03-14 20:51:27

jcfr

Details Diff
BUG: Fix py_RSNA2012ProstateDemo test

Ensure all view widgets are created when switching to a sceneview
with a different layout.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24068 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx Diff File

master 524a0b76

2015-03-13 22:49:03

jcfr

Details Diff
ENH: Update SetAndObserveObject to display a warning if setting same object

This commit updates "SetAndObserveObject" to display a warning
if setting the same node again. The behavior is now consistent with
the function "SetAndObserveObjectEvents".

The function slicer logics and display node are also
updated to avoid such warning.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24067 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkObserverManager.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File

master 402e4844

2015-03-13 22:49:01

jcfr

Details Diff
ENH: Update SetAndObserveObjectEvents to match SetAndObserveObject

Both function now returns if trying to set the same node.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24066 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkObserverManager.cxx Diff File

master 52160c28

2015-03-13 22:48:59

jcfr

Details Diff
BUG: Fix MRML warning "Setting the same object should be a no-op."

This commit fixes warning reported in a lot of test (for example py_RSNA2012ProstateDemo)

Warning: In /home/jcfr/Projects/Slicer/Libs/MRML/Core/vtkObserverManager.cxx, line 131
vtkObserverManager (0x65dcff0): Setting the same object should be a no-op.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24065 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File

master fce79105

2015-03-13 14:25:44

jcfr

Details Diff
STYLE: Fix typo in qSlicerCoreCommandOptions.cxx

From: Francois Budin <fbudin@unc.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24064 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreCommandOptions.cxx Diff File

master 3c4b8fc3

2015-03-13 11:05:14

fedorov

Details Diff
ENH: Updated revision number for MultiVolumeImporter

Explicit import of re is apparently needed on some systems. See
https://github.com/fedorov/MultiVolumeImporter/issues/10.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24063 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 8b89ecdb

2015-03-13 10:26:48

jcfr

Details Diff
STYLE: Display module loading stats only once

Since (1) following r24059 (ENH: Write all info to the log file as
formatted log messages), module stats are displayed using qDebug() and
(2) following r24052 , module stats are displayed if verboseModuleDiscovery is
enabled, this commit revert r24052 and ensure stats are displayed once.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24062 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 738a74a9

2015-03-12 16:10:10

fedorov

Details Diff
BUG: Replaced re with fnmatch

regular expression fails to match expressions with special characters. Structures created for volume nodes containing parentheses and brackets would not show up in structures table.
fnmatch can match expressions containing these characters.

ENH: Left zero padding for structure numbers

Without left zero padding sorting the structure table based on structure number
is not as it is expected.

ENH: Resize per-structure table columns based on contens not fixed values.

ENH: Add new label for a structure only if it is not in the scene.

In the current behavior if one structure exist, adding the same structure will create duplicate labels.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24061 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

master 65d60065

2015-03-12 11:18:07

lassoan

Details Diff
ENH: Improve performance of node delete

When a node was deleted and it had a display or storage node then the nodes were deleted in a BatchProcess operation.
Entering/exiting BatchProcess is a very expensive operation (many modules re-parse the whole scene and resets displayable managers) and causes the screen to flicker as the layout is refreshed, which is not justified if only a few nodes are deleted.

Changed the code to only apply batch processing if more than 10 nodes are impacted.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24060 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Data/Logic/vtkSlicerDataModuleLogic.cxx Diff File

master 472a723e

2015-03-12 09:34:10

lassoan

Details Diff
ENH: Write all info to the log file as formatted log messages

Writing unstructured raw text data to the log file breaks automatic log formatting and analysis.
To fix this, use logging functions instead of appending raw data to the log file.
Removed appendToLogFile to discourage developers from writing unformatted raw data to the log file.


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24059 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.h Diff File

master 1c7e55b9

2015-03-11 09:52:15

jcfr

Details Diff
BUG: Support loading of SliceViewAnnotation if loadable module are disabled

This commit tweak SliceViewAnnotation to detect if 'vtkPVScalarBarActor'
is available independently of VTKv5, this will avoid runtime error when
starting Slicer with option "--disable-builtin-loadable-modules". This
option could be used to collect "startup time" performance stats as
detailed in [1]

[1] http://wiki.slicer.org/slicerWiki/index.php/Documentation/Labs/StartupTimeImprovement

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24058 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py Diff File

master 3340f0d0

2015-03-11 09:52:13

jcfr

Details Diff
BUG: Fix regression introduced when adding VTKv5 ViewAnnotation support

Following r23941 (COMP: Fix VTKv5 build conditionally disabling
DataProbe/Logic), the SliceViewAnnotation module was able to fallback
to use "vtkScalarBarActor" instead of "vtkPVScalarBarActor" if Slicer was
built against VTKv5. This commit fixes the runtime complaining that
"colorScalarBarMaxWidthSlider" is missing by explicitly specifying
the value "50" was originally specifified in r23612 (ENH: Add method
vtkMRMLSliceLogic::GetForegroundWindowLevelAndRange)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24057 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py Diff File

master 4f3dad0a

2015-03-10 23:48:00

jcfr

Details Diff
BUG: Fix slicer_nomainwindow_DisableModulesCommandLineOptionsTest

Fix failure introduced by r24050 (ENH: Display module loading stats only
if verbose module discovery is set.)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24056 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Cpp/CMakeLists.txt Diff File

master b99d038e

2015-03-10 23:47:57

jcfr

Details Diff
STYLE: Remove commented / unused code from Main.cxx

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24055 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 77 78 79 80 81 82 83 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last