Changesets: Import 2017-06-07 23:51:09

master 941fad8e

2015-04-03 20:42:23

jcfr

Details Diff
ENH: Add test illustrating issue 0003549 related to scripted module import

The test is currently passing but comment in the script explain which
behavior is really expected.

In a nutshell, scripted module shouldn't be executed in the global scope
but should instead be imported as module.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24154 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
add - Applications/SlicerApp/Testing/Python/ScriptedModuleDiscoveryTest.py Diff File
add - Applications/SlicerApp/Testing/Python/ScriptedModuleDiscoveryTest/ModuleA.py Diff File
add - Applications/SlicerApp/Testing/Python/ScriptedModuleDiscoveryTest/ModuleB.py Diff File

master 1ab77f50

2015-04-03 00:23:42

jcfr

Details Diff
ENH: Simplify DICOM plugin removing unneeded widget class.

This is made possible by previous commit (ENH: Extend module API
with "widgetRepresentationCreationEnabled" property)

Note that since the qSlicerScripedModule class can detect with a widget
class is available or not, there is no need to explicitly set
the "widgetRepresentationCreationEnabled" property.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24153 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMPlugins/DICOMDiffusionVolumePlugin.py Diff File
mod - Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py Diff File
mod - Modules/Scripted/DICOMPlugins/DICOMSlicerDataBundlePlugin.py Diff File

master 3a2091c9

2015-04-03 00:23:39

jcfr

Details Diff
ENH: Extend module API with "widgetRepresentationCreationEnabled" property

By default, (1) all modules are expected to be able to create
representations and (b) module with representation creation
disabled will be hidden (not visible in the module selector)
if the property was False at loading time.

In the case of scripted module, if not widget class could be found when
loading the main script, the property is set to False.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24152 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/Testing/Cxx/qSlicerAbstractCoreModuleTest1.cxx Diff File
mod - Base/QTCore/qSlicerAbstractCoreModule.cxx Diff File
mod - Base/QTCore/qSlicerAbstractCoreModule.h Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModule.cxx Diff File

master d2737dc4

2015-04-02 22:43:48

jcfr

Details Diff
STYLE: List attribute to export in ScriptedLoadableModule

This will allow to keep module namespace clean and will facilitate
introspection and access to relevant attribute.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24151 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/ScriptedLoadableModule.py Diff File

master 1d8eda98

2015-04-02 22:43:46

jcfr

Details Diff
BUG: Fix qSlicerScriptedLoadableModuleWidgetTest broken by previous commit

This commit fixes a regression introduced by previous
commit r24149 (BUG: Ensure "qSlicerScriptedUtils::executeFile()"
set "__file__" property.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24150 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerScriptedUtils.cxx Diff File

master f17c8acf

2015-04-02 15:44:30

jcfr

Details Diff
BUG: Ensure "qSlicerScriptedUtils::executeFile()" set "__file__" property.

This is a hack. Instead the "imp" module should be used as outline
in issue 0003549 (Import scripted module as python module).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24149 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/Testing/Python/qSlicerModuleGenericTest.py.in Diff File
mod - Base/QTCore/qSlicerScriptedUtils.cxx Diff File

master fcdc7091

2015-04-02 15:08:53

jcfr

Details Diff
STYLE: VectorToScalarVolume - Make sure all required object are imported

This will avoid issue when addressing issue 0003549 (Import scripted module as python
module )

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24148 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/VectorToScalarVolume/VectorToScalarVolume.py Diff File

master e794d99e

2015-04-02 15:07:14

jcfr

Details Diff
STYLE: Simplify scripted module introducing SlicerPythonCppAPI

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24147 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerScriptedFileWriter.cxx Diff File
mod - Base/QTCore/qSlicerScriptedUtils.cxx Diff File
mod - Base/QTCore/qSlicerScriptedUtils_p.h Diff File
mod - Base/QTGUI/qSlicerScriptedFileDialog.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModule.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModuleWidget.cxx Diff File

master bc4dd711

2015-04-02 15:07:11

jcfr

Details Diff
STYLE: Refactor code introducing qSlicerScriptedUtils::executeFile

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24146 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/CMakeLists.txt Diff File
add - Base/QTCore/qSlicerScriptedUtils.cxx Diff File
add - Base/QTCore/qSlicerScriptedUtils_p.h Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModule.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModuleWidget.cxx Diff File

master ae86bb68

2015-04-02 14:05:13

fedorov

Details Diff
ENH: update MultiVolumeImporter

Fix from jcfr@github: Rename lib module to 'MultiVolumeImporterLib'. This will avoid conflict when Slicer issue 0003549 (Import scripted module as python module) will be addressed.


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24145 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 7f471a37

2015-04-01 17:51:48

jcfr

Details Diff
BUG: Update LandmarkRegistration to fix failing generic test

This commit will fix "py_nomainwindow_qSlicerLandmarkRegistrationModuleGenericTest"

$ git shortlog c1c65ce..0bcbcce --no-merges
Jean-Christophe Fillion-Robin (1):
Fix generic test checking for cropVolume availability

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24144 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 00db367b

2015-04-01 17:02:56

jcfr

Details Diff
ENH: Adding label type column in Label Statistics

Reviewed-by: Steve Pieper <pieper@bwh.harvard.edu>
Tested-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Robin Weiss <robinweiss@uchicago.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24143 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/LabelStatistics/LabelStatistics.py Diff File

master 4c2c0b67

2015-04-01 15:05:00

lassoan

Details Diff
STYLE: Added comment explaining FD message handler usage

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24142 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 343696a5

2015-04-01 13:13:32

lassoan

Details Diff
ENH: Allow slicelets and Slicer tests to handle log messages

Two main applications:
* Errors are logged to file, which makes troubleshooting much easier.
* Errors can be captured during tests and the test can return with failure in case of unexpected errors occurred (work in progress).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24141 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master cb56152c

2015-04-01 08:54:38

lassoan

Details Diff
BUG: Fixed 0003876: All python modules fail after uninstalling an extension

Wrong PYTHONPATH setting was set in wrong format in qSlicerExtensionsManagerModelPrivate::removeExtensionPathFromLauncherSettings.
Fixed by updating the setting the same way as in qSlicerExtensionsManagerModelPrivate::addExtensionPathToLauncherSettings.

http://na-mic.org/Mantis/bug_view_advanced_page.php?bug_id=3876


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24140 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerExtensionsManagerModel.cxx Diff File

master afdfed66

2015-04-01 04:55:12

jcfr

Details Diff
STYLE: Fix compilation warnings

This commit fixes the following warnings:

* vtkAnnotationROIRepresentation2D.cxx:426: warning: missing braces around initializer for 'double [3]' [-Wmissing-braces]

* qMRMLSortFilterSubjectHierarchyProxyModel.cxx:80: warning: unused variable 'd' [-Wunused-variable]

* qSlicerApplication.cxx: In member function 'void qSlicerApplication::setupFileLogging()':
qSlicerApplication.cxx:740: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' [-Wformat]
qSlicerApplication.cxx:740: warning: format '%d' expects type 'int', but argument 3 has type 'size_t' [-Wformat]
Related article: http://stackoverflow.com/questions/2524611/how-to-print-size-t-variable-portably

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24139 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 02f44989

2015-04-01 04:55:10

jcfr

Details Diff
STYLE: Fix compilation warnings

This commit fixes the following warnings:

* vtkAnnotationROIRepresentation2D.cxx:426: warning: missing braces around initializer for 'double [3]' [-Wmissing-braces]

* qMRMLSortFilterSubjectHierarchyProxyModel.cxx:80: warning: unused variable 'd' [-Wunused-variable]

* qSlicerApplication.cxx: In member function 'void qSlicerApplication::setupFileLogging()':
qSlicerApplication.cxx:740: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' [-Wformat]
qSlicerApplication.cxx:740: warning: format '%d' expects type 'int', but argument 3 has type 'size_t' [-Wformat]

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24138 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSortFilterSubjectHierarchyProxyModel.cxx Diff File

master 869d0957

2015-04-01 03:01:45

jcfr

Details Diff
STYLE: Fix doxygen warning in vtkMRMLSubjectHierarchyNode

This commit fixes the following warnings:

/path/to/Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.h:76: Warning: The following parameters of vtkMRMLSubjectHierarchyNode::GetSubjectHierarchyNodeByUID(vtkMRMLScene *scene, const char *uidName, const char *uidValue) are not documented:
parameter 'scene'
parameter 'uidName'
/path/to/Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.h:80: Warning: The following parameters of vtkMRMLSubjectHierarchyNode::GetSubjectHierarchyNodeByUIDList(vtkMRMLScene *scene, const char *uidName, const char *uidValue) are not documented:
parameter 'scene'
parameter 'uidName'

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24137 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.h Diff File

master 50356333

2015-04-01 03:01:43

jcfr

Details Diff
STYLE: Update CTK to fix warning related to wrapping of CTKDICOM module

$ git shortlog 8011739..d72ab0c --no-merges
Jean-Christophe Fillion-Robin (1):
Workaround to fix HAVE_STAT redefined warning related to DICOM module wrapping

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24136 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 26b0c280

2015-04-01 02:00:15

jcfr

Details Diff
ENH: Update CTK to fix warning and include ctkButtonGroup tweaks

$ git shortlog 657853b..8011739 --no-merges
Jean-Christophe Fillion-Robin (1):
Fix -Wuninitialized in ctkDICOMTableManager

Julien Finet (2):
Preserve button ids in ctkButtonGroup
Add QButtonGroup::buttonToggled support

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24135 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 1f24696e

2015-03-31 23:15:45

jcfr

Details Diff
BUG: Fix py_mainwindow_RestoreSceneViewWithoutCamera test failing on windows

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24134 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SceneViews/Testing/Python/CMakeLists.txt Diff File

master 590eecc2

2015-03-31 16:13:22

jcfr

Details Diff
STYLE: itkMGHImageIO - Remove usage of reserved "__" prefix in header guard

This commit address clang warning "-Wreserved-id-macro"

Suggested-by: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24133 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MGHImageIO/itkMGHIOPlugin.h Diff File
mod - Libs/MGHImageIO/itkMGHIOWin32Header.h Diff File
mod - Libs/MGHImageIO/itkMGHImageIO.h Diff File

master 0783e45b

2015-03-30 23:05:04

jcfr

Details Diff
ENH: Added option for setting the layoutManager in the main application

It is useful for slicelets, where the main window is not created and this the slicer.app.layoutManager() is not set.

Example for setting up a layout manager in a slicelet:

layoutWidget = slicer.qMRMLLayoutWidget()
layoutManager = slicer.qSlicerLayoutManager()
layoutManager.setMRMLScene(slicer.mrmlScene)
layoutManager.setScriptedDisplayableManagerDirectory(slicer.app.slicerHome + "/bin/Python/mrmlDisplayableManager")
layoutWidget.setLayoutManager(layoutManager)
slicer.app.setLayoutManager(layoutManager)
layoutWidget.setLayout(slicer.vtkMRMLLayoutNode.SlicerLayoutFourUpView)

somelayout.addWidget(layoutWidget)

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24132 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.h Diff File
mod - Base/QTGUI/qSlicerLayoutManager.h Diff File
mod - Modules/Scripted/Editor/Editor.py Diff File

master 75650086

2015-03-30 23:05:01

jcfr

Details Diff
STYLE: Refactor qMRMLLayoutManager introducing "setLayoutManager()"

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24131 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLayoutWidget.h Diff File

master ec83b238

2015-03-30 16:02:22

pieper

Details Diff
ENH: include updated LandmarkRegistration

Fixes startup issue due to local refinement plugins
not being included in the package. (Fixes from Jim
Miller and Andras Lasso)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24130 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 74 75 76 77 78 79 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last