Changesets: Import 2017-06-07 23:51:09

master d09b492c

2015-04-18 01:05:23

jcfr

Details Diff
STYLE: Fix doxygen comment associated with displayTemporaryPathAndExit()

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24179 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreCommandOptions.h Diff File

master 42aca939

2015-04-18 01:05:21

jcfr

Details Diff
STYLE: Mark qSlicerCommandOptions readonly Qt properties as CONSTANT

From Qt documentation:

The presence of the CONSTANT attribute indicates that the property value
is constant. For a given object instance, the READ method of a constant
property must return the same value every time it is called. This constant
value may be different for different instances of the object. A constant
property cannot have a WRITE method or a NOTIFY signal.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24178 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreCommandOptions.h Diff File
mod - Base/QTGUI/qSlicerCommandOptions.h Diff File

master f30b13df

2015-04-18 01:05:19

jcfr

Details Diff
STYLE: Nicely pad information logged at startup.

After this commit:

// --------------
Session start time .......: 2015-04-17 17:40:37
Slicer version ...........: 4.4.0-2015-04-13 (revision 24173) linux-amd64 - not installed
Operating system .........: Linux / 3.13.0-45-generic / #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 - 64-bit
Memory ...................: 7975 MB physical, 0 MB virtual
CPU ......................: GenuineIntel 1.199 MHz, 1 cores
Developer mode enabled ...: no
Prefer executable CLI ....: no
Additional module paths ..: (none)
// --------------

Before this commit:

// --------------
Session start time: 2015-04-17 17:40:37
Slicer version: 4.4.0-2015-04-13 (revision 24173) linux-amd64 - not installed
Operating system: Linux / 3.13.0-45-generic / #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 - 64-bit
Memory: 7975 MB physical, 0 MB virtual
CPU: GenuineIntel 1.199 MHz, 1 cores
Developer mode enabled: no
Prefer executable CLI: no
Additional module paths: (none)
// --------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24177 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 471b6a03

2015-04-18 01:05:17

jcfr

Details Diff
STYLE: Fix indent in qSlicerApplication

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24176 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master 2186b8fc

2015-04-17 13:14:11

lassoan

Details Diff
BUG: Fixed orphaned views displayed in secondary layout widgets


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24175 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx Diff File

master de983dc4

2015-04-16 19:13:45

jcfr

Details Diff
BUG: Fix generation of additional launcher settings

This commit ensures the file doesn't include extra spaces. These
were causing problem when parsing setting file using ConfigParser
python module used in slicer_wiki_extension_module_listing.py [1]

[1] https://github.com/Slicer/slicer-wiki-scripts/blob/ee52ed3b08346c04a3e2e09a309bae7f33578e4f/slicer_wiki_extension_module_listing.py#L728-L757

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24174 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockAdditionalLauncherSettings.cmake Diff File

master 9ce34175

2015-04-13 11:07:19

jcfr

Details Diff
BUG: Prevent crash in vtkSlicerApplicationLogic checking pointer validity

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24173 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File

master 4d5742b5

2015-04-13 11:07:18

jcfr

Details Diff
STYLE: Simplify memory management in vtkSlicerApplicationLogic

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24172 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File

master 3eac9c7b

2015-04-13 11:07:16

jcfr

Details Diff
STYLE: Simplify code in vtkMRMLVolumeArchetypeStorageNode

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24171 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLVolumeArchetypeStorageNode.cxx Diff File

master 67e7ba17

2015-04-13 11:07:15

jcfr

Details Diff
STYLE: Fix comment in vtkMRMLLabelMapVolumeDisplayNode

From: Csaba Pinter <csaba.pinter@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24170 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLLabelMapVolumeDisplayNode.h Diff File

master dd5f758d

2015-04-13 11:07:13

jcfr

Details Diff
STYLE: Fix indentation in vtkSlicerApplicationLogic

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24169 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File

master 2925a016

2015-04-09 23:14:46

jcfr

Details Diff
COMP: Fix build of tcl on Windows 32-bit (See 0003984)

This commit fixes regression introduced by r23702 (BUG: Create zip
archive and move tcl binaries onto slicer.kitware.com)

Suggested-by: Christopher Mullins <christopherrmullins@gmail.com>
Tested-by: Sharp, Gregory C. <GCSHARP@mgh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24168 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_tcl.cmake Diff File

master 3c400add

2015-04-09 14:04:03

lassoan

Details Diff
ENH: Make ExtensionWizard available without SSL support

If Slicer was built without SSL support, the ExtensionWizard module was not available (due to missing httplib.HTTPSConnection).
Fixed by changing the behavior so that if no SSL is available then only github integration is disabled.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24167 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Utilities/Scripts/SlicerWizard/ExtensionWizard.py Diff File

master 840153bc

2015-04-09 04:15:27

jcfr

Details Diff
STYLE: Fix typos in qSlicerLoadableModule doxygen comments

From: Sergey Aleshin <4memph@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24166 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerLoadableModule.h Diff File

master d2b2f111

2015-04-09 03:23:42

jcfr

Details Diff
STYLE: Fix typo in qSlicerVolumeRenderingModuleWidget

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24165 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Widgets/qSlicerVolumeRenderingModuleWidget.cxx Diff File

master 170ee5ba

2015-04-09 03:14:24

jcfr

Details Diff
ENH: Update LandmarkRegistration to show warning if plugin failed to be loaded

See pieper/LandmarkRegistration@13d7b32

Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date: Wed Apr 8 00:20:27 2015 -0400

Display a warning when a built-in registration plugin failed to be loaded.

For example, if Slicer is build without SimpleITK support, the following
is displayed:

8<----8<----8<----8<----8<----8<----8<----8<----
[...]
Number of registered modules: 139
Registration: Failed to import 'LocalSimpleITK' plugin: No module named SimpleITK
Number of instantiated modules: 139
[...]
8<----8<----8<----8<----8<----8<----8<----8<----

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24164 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 50462e12

2015-04-09 02:39:37

jcfr

Details Diff
STYLE: Fix position of DataProbe display using monospace font and fixed width

This commit refactor and simplify the DataProbe widget to ensure the
display of viewer properties and layer information is displayed at the
same location.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Sergey Aleshin <4memph@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24163 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbe.py Diff File

master 99bf36ae

2015-04-08 22:12:42

jcfr

Details Diff
STYLE: Remove unused forward declarations from qSlicerAppMainWindow

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24162 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.h Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow_p.h Diff File

master 01ddc62c

2015-04-08 22:12:39

jcfr

Details Diff
ENH: Extend ModulePanel API to control if Help&Ack section is visible

This commit adds the property allowing to programmatically show/hide
the Help & Acknowledgment collapsible button within the ModulePanel
widget.

If the current module doesn't have a help string, the section will remain
hidden.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Sergey Aleshin <4memph@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24161 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/Testing/Cxx/qSlicerModulePanelTest1.cxx Diff File
mod - Base/QTGUI/qSlicerModulePanel.cxx Diff File
mod - Base/QTGUI/qSlicerModulePanel.h Diff File
mod - Modules/Core/Testing/qSlicerModulePanelTest2.cxx Diff File

master 1fa7c65b

2015-04-07 11:09:03

jcfr

Details Diff
BUG: Update CTK to fix python interactor regression

$ git shortlog 16aa095..d6171b8 --no-merges
Andras Lasso (2):
ctkConsole: Do not allow moving before the interactive position
ctkConsole: Added direct backspace key handling

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24160 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master c7979fd2

2015-04-05 13:35:41

lassoan

Details Diff
ENH: Added logging of Python console user input

If the user type anything into the Python console then it is logged at debug level.
It makes debugging/troubleshooting easier.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24159 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.h Diff File

master d9e24235

2015-04-05 09:48:22

lassoan

Details Diff
ENH: Do not build doc in VisualStudio when F7 is pressed

If doxygen was installed then cpp-doc was always re-built when "Build Solution" (F7) was used in Visual Studio, taking several minutes.
The change only effects the Visual Studio IDE and is independent from the inclusion of the doc target in ALL target.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24158 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Utilities/Doxygen/CMakeLists.txt Diff File

master 18286437

2015-04-04 21:20:00

jcfr

Details Diff
BUG: Update CTK to fix qMRMLSliceControllerWidgetEventTranslatorPlayerTest1

$ git shortlog 2ecb028..16aa095 --no-merges
Eric Heim (1):
Add support for python wrapping when building against Qt5

Jean-Christophe Fillion-Robin (1):
Fix qMRMLSliceControllerWidgetEventTranslatorPlayerTest1 on MacOSX

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24157 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 305acb62

2015-04-04 21:00:08

jcfr

Details Diff
BUG: Update CTK to fix python interactor keyboard shortcuts

$ git shortlog d72ab0c..2ecb028 --no-merges
Andras Lasso (3):
BUG: Fixed Console Shift+Home behavior
BUG: Fixed more keyboard shortcuts in console
ENH: Removed low-level key processing from ctkConsolePrivate::keyPressEvent

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24156 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master e5cf5fec

2015-04-03 20:42:28

jcfr

Details Diff
ENH: Fixes 0003549. Import scripted module as python module

This will allow each scripted module to defined top-level variables that
will not clobber each other.

For example, if we consider these two modules:

8<----8<----8<----8<----8<----8<----8<----8<----
File: ModuleA.py

FOO = 1

class ModuleA(ScriptedLoadableModule):
def __init__(self, parent):
ModuleA.__init__(self, parent)
[...]
def doSomething(self):
if FOO == 1:
[...]
else:
[...]
8<----8<----8<----8<----8<----8<----8<----8<----

8<----8<----8<----8<----8<----8<----8<----8<----
File: ModuleB.py

FOO = 2

class ModuleB(ScriptedLoadableModule):
def __init__(self, parent):
ModuleB.__init__(self, parent)
[...]
def doSomething(self):
if FOO == 1:
[...]
else:
[...]
8<----8<----8<----8<----8<----8<----8<----8<----

Assuming ModuleA, and then ModuleB are imported. Before this commit,
both scripts were executed in the __main__ scope and FOO variable would
have the value associated with the last imported module.

After this commit, both module will see their own copy of the FOO
variable with the expected value.

It also avoid the hack when we explicitly save/set/restore
both "__name__" and "__file__" variable.

Changes to "DICOMScalarVolumePlugin" fixes the test failing test
"py_RSNAVisTutorial" and "py_SubjectHierarchyGenericSelfTest". It basically
fixes the following error by ensuring all object are imported:

//--------------
test_SubjectHierarchyGenericSelfTest_FullTest1 (SubjectHierarchyGenericSelfTest.SubjectHierarchyGenericSelfTestTest) ... Traceback (most recent call last):
File "/path/to/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/DICOMLib/DICOMWidgets.py", line 615, in getLoadablesFromFileLists
loadablesByPlugin[plugin] = plugin.examineForImport(fileLists)
File "/path/to/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/DICOMScalarVolumePlugin.py", line 47, in examineForImport
loadablesForFiles = self.examineFiles(files)
File "/path/to/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/DICOMScalarVolumePlugin.py", line 71, in examineFiles
loadable = DICOMLib.DICOMLoadable()
NameError: global name 'DICOMLib' is not defined
//--------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24155 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/ScriptedModuleDiscoveryTest.py Diff File
add - Applications/SlicerApp/Testing/Python/ScriptedModuleDiscoveryTest/ModuleC_WithoutWidget.py Diff File
add - Applications/SlicerApp/Testing/Python/ScriptedModuleDiscoveryTest/ModuleD_WithFileDialog_WithoutWidget.py Diff File
add - Applications/SlicerApp/Testing/Python/ScriptedModuleDiscoveryTest/ModuleE_WithFileWriter_WithoutWidget.py Diff File
mod - Base/QTCore/qSlicerScriptedFileWriter.cxx Diff File
mod - Base/QTCore/qSlicerScriptedUtils.cxx Diff File
mod - Base/QTCore/qSlicerScriptedUtils_p.h Diff File
mod - Base/QTGUI/qSlicerScriptedFileDialog.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModule.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModuleWidget.cxx Diff File
mod - Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 73 74 75 76 77 78 79 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last