Changesets: Import 2017-06-07 23:51:09
|
master 7b816afd 2015-05-10 22:51:36 Details Diff |
ENH: Fix ownership management for subject hierarchy plugin registration git-svn-id: http://svn.slicer.org/Slicer4/trunk@24229 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyModuleWidgetsPythonQtDecorators.h | Diff File | ||
| mod - Modules/Scripted/DICOM/DICOM.py | Diff File | ||
|
master 9b7171d0 2015-05-10 22:51:34 Details Diff |
ENH: Update CTK to include new PythonQt C++/Python ownership tracking feature This will allow to greatly simplify python code by avoiding the need to explicitly keep reference to object that are expected to be own by cpp. From updated Python Qt documentation: 8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<---- Source: PythonQtDoc.h Ownership Ownership management In PythonQt, each wrapped C++ object is either owned by Python or C++. When an object is created via a Python constructor, it is owned by Python by default. When an object is returned from a C++ API (e.g. a slot), it is owned by C++ by default. Since the Qt API contains various APIs that pass the ownership from/to other C++ objects, PythonQt needs to keep track of such API calls. This is achieved by annotating arguments and return values in wrapper slots with magic templates: - PythonQtPassOwnershipToCPP - PythonQtPassOwnershipToPython - PythonQtNewOwnerOfThis These annotation templates work for since C++ pointer types. In addition to that, they work for QList<AnyObject*>, to pass the ownership for each object in the list. 8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<---- $ git shortlog e771b4a..fd3a2b1 --no-merges Jean-Christophe Fillion-Robin (1): Update to PythonQt 3.0 Marco Nolden (1): Make BuildUrl more robust for file urls Sascha Zelzer (3): Correctly rethrow exceptions and improve error messages. Fix regression making sure the Qt4 moc considers target include paths. Introduced another framework option for controlling the plugin start options. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24228 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master 9803016b 2015-05-10 22:51:32 Details Diff |
ENH: Simplify DICOM subject hierarchy plugin registration By ensuring qSlicerSubjectHierarchyPluginHandler::instance() is wrapped, this commit simplify the registration code by avoiding the creation of an extra qSlicerSubjectHierarchyPluginHandler object. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24227 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| add - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyModuleWidgetsPythonQtDecorators.h | Diff File | ||
| mod - Modules/Scripted/DICOM/DICOM.py | Diff File | ||
|
master 220575a5 2015-05-10 22:51:30 Details Diff |
ENH: Associated docstring with "slicer.(modules,moduleName)" python modules This commit introduces the help function "_createModule()". Note that module are now added to 'sys.modules' dictionary. This will allow call to "import slicer.modules" to succeed. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24226 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/slicer/__init__.py.in | Diff File | ||
|
master 839b4b19 2015-05-08 19:04:16 Details Diff |
BUG: fix tooltips on editor effect buttons Turns out that even though you can set the tooltip of a QToolButton it gets overridden by the tooltip associated with the QAction. So we set the QAction's tooltip instead. Thanks to Csaba for pointing out that the tooltips were broken. From: Steve Pieper <pieper@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24225 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/EditorLib/EditBox.py | Diff File | ||
|
master 6d0d2cbc 2015-05-08 16:43:51 Details Diff |
BUG: Fixed DICOM export crash Nodes added to subject hierarchy now have a default level of 'Series' unless explicitly specified (if level of a data node is not Series then it cannot be exported to DICOM); Fixed crash when auto-selecting node in the DICOM export window subject hierarchy tree, due to a mismatch in model of given selection index and the model of the tree. Fixed by removing the selection code, as selection is made automatically by setCurrentNode call (it was not like this before; for the record, fixing the mismatch crash is possible by calling mapFromSource function of the sort filter proxy model with the main model index as argument, and setting selection with the sort filter model index) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24224 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.cxx | Diff File | ||
| mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.cxx | Diff File | ||
| mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.h | Diff File | ||
| mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx | Diff File | ||
|
master 8bd82d4a 2015-05-08 16:11:16 Details Diff |
ENH: Adding ability to delete only the selected structure. From: Robin Weiss <robinweiss@uchicago.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24223 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/EditorLib/HelperBox.py | Diff File | ||
|
master c29f6224 2015-05-07 22:49:05 Details Diff |
BUG: Fix RSNA2012ProstateDemo (attempt 0000002) This commit completes the fix introduced in previous commit allowing the test to finish when using the provided scene and doing 5 iterations of scene view restore. In previous commit, a trimmed down scene file has been used. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24222 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx | Diff File | ||
|
master b3348c0b 2015-05-07 15:01:25 Details Diff |
BUG: Fix RSNA2012ProstateDemoTest This commit ensures vtkMRMLSliceLayerLogic::UpdateNodeReferences() can be called when setting a null scene. It fixes a regression introduced in r24216 (BUG: Fix qMRMLLayoutManagerTest2 - Setting new scene reset view node factories) where the scene of the "view widget to delete" is set to 0. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24221 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLayerLogicTest.cxx | Diff File | ||
| mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx | Diff File | ||
|
master 916777a4 2015-05-07 15:01:23 Details Diff |
STYLE: Add TEST_GET_OBJECT_* macros to vtkMRMLCoreTestingMacros.h file git-svn-id: http://svn.slicer.org/Slicer4/trunk@24220 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h | Diff File | ||
| mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest1.cxx | Diff File | ||
|
master f7c505f7 2015-05-07 15:01:21 Details Diff |
STYLE: Remove redundant and unused vtkMRMLSliceLogicTest.cxx file git-svn-id: http://svn.slicer.org/Slicer4/trunk@24219 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| rm - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest.cxx | Diff File | ||
|
master 1d4b4296 2015-05-07 01:13:58 Details Diff |
BUG: Fix crash in qMRMLMatrixWidget::setMRMLTransformNode git-svn-id: http://svn.slicer.org/Slicer4/trunk@24218 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/Testing/qMRMLMatrixWidgetTest1.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLMatrixWidget.cxx | Diff File | ||
|
master 4d1f5bae 2015-05-06 15:15:03 Details Diff |
STYLE: Explicitly identify layout node arrangements This commit (1) adds a comment clearly identifying deprecated layout arrangement and (2) update qMRMLLayoutManagerTest4 to also use the convenience test function "checkViewArrangement()" git-svn-id: http://svn.slicer.org/Slicer4/trunk@24217 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLLayoutNode.h | Diff File | ||
| mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest2.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest4.cxx | Diff File | ||
| add - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTestHelper.cxx | Diff File | ||
|
master 825aaddc 2015-05-06 15:15:01 Details Diff |
BUG: Fix qMRMLLayoutManagerTest2 - Setting new scene reset view node factories git-svn-id: http://svn.slicer.org/Slicer4/trunk@24216 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest2.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx | Diff File | ||
|
master 2118883d 2015-05-05 18:15:28 Details Diff |
BUG: Fix "orphan view" issue in layout manager The widget visibility is now set considering both the MappedInLayout and the Visibility view node properties. It fixes a regression re-introduced in r24209 (ENH: Update layout view factory to consider view node visibility property) that was originally fixed in r24175 (BUG: Fixed orphaned views displayed in secondary layout widgets). This commit also extends vtkMRMLAbstractViewNode API adding: * IsMappedInLayout() / SetMappedInLayout() * IsViewVisibleInLayout() Test "qMRMLLayoutManagerVisibilityTest" has also been updated to check the value returned by "IsMappedInLayout()", "IsViewVisibleInLayout()" and "GetVisibility()". Note also that functions "IsMappedInLayout()" and "SetMappedInLayout()" still set/get the "MappedInLayout" attribute. This was done to ensure existing code relying on its value would still work. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24215 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLAbstractViewNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLAbstractViewNode.h | Diff File | ||
| mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerVisibilityTest.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.h | Diff File | ||
|
master 2780c80f 2015-05-05 15:45:28 Details Diff |
ENH: Add function to explicitly set label outline state on all nodes From: Robin Weiss <robinweiss@uchicago.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24214 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/EditorLib/EditUtil.py | Diff File | ||
|
master 44328a78 2015-05-05 15:40:32 naucoin Details Diff |
STYLE: update Volumes documentation to include outline thickness Add a parameter description of the label outline thickness option for label map volume display. Issue 0002267 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24213 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/Documentation/Volumes.xml | Diff File | ||
|
master e046b72d 2015-05-02 20:38:11 Details Diff |
BUG: Fix vtkMRMLCameraDisplayableManagerTest1 This commit updates the baseline to acount for changes introduced in r24208 (BUG: Change default value for vtkMRMLAbstractViewNode Visibility property) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24212 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/DisplayableManager/Testing/Data/vtkMRMLCameraDisplayableManagerTest1.mrml | Diff File | ||
|
master 1d46c9fe 2015-05-02 03:35:22 Details Diff |
STYLE: Improve vtkMRMLNode apidox * Use \brief to ensure function description is included in listing. * Use \note and \warning git-svn-id: http://svn.slicer.org/Slicer4/trunk@24211 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLNode.h | Diff File | ||
|
master 5a8b2b7a 2015-05-02 03:35:20 Details Diff |
STYLE: Improve vtkMRMLScene apidox * Use \brief to ensure function description is included in listing. * Fix typo * Use \link to reference enum value declared in vtkMRMLScene git-svn-id: http://svn.slicer.org/Slicer4/trunk@24210 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLScene.h | Diff File | ||
|
master 0d758d2d 2015-05-01 23:34:19 Details Diff |
ENH: Update layout view factory to consider view node visibility property Calling SetVisibility on any view node mapped into a layout will show or hide the associated widget. This commit also introduces a new test named "qMRMLLayoutManagerVisibilityTest" git-svn-id: http://svn.slicer.org/Slicer4/trunk@24209 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLAbstractViewNode.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/Testing/CMakeLists.txt | Diff File | ||
| add - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerVisibilityTest.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLLayoutViewFactory.h | Diff File | ||
|
master f5208e93 2015-05-01 23:34:16 Details Diff |
BUG: Change default value for vtkMRMLAbstractViewNode Visibility property This commit fixes a regression introduced in r21034 (STYLE: Add abstract class for all view nodes) where default value of the visibility property (originally associated with vtkMRMLViewNode) has been changed from 1 to 0. This commit set the default value to 1. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24208 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLAbstractViewNode.cxx | Diff File | ||
|
master 1c08ec55 2015-05-01 14:44:45 Details Diff |
BUG: Editor: Ensure label map is updated each time a master volume is selected Before the commit, the following was failing: (1) Go to SampleData -> Load MRHead (2) Go to Editor -> Create GenericAnatomyColors label map (3) Go to SampleData -> Load CTACardio (4) Go to Editor -> Select CTACardio master volume -> Create GenericAnatomyColors label map (5) Select MRHead master volume, select CTACardio master volume -> Popup message with "Warning: Geometry of master and merge volumes do not match." -> Label map associated with CTACardio is not selected Note also that this problem is independent of commit r24202 (BUG: Pattern matching for label volume does not account for underscore) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24207 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/EditorLib/HelperBox.py | Diff File | ||
|
master 2a8dd102 2015-05-01 01:55:02 Details Diff |
BUG: Fixed SlicerApp-real.exe.exe filename on Windows Removed the double .exe extensions from the main application name. Before the fix: SlicerApp-real.exe.exe After the fix: SlicerApp-real.exe This commit fixes a regression introduced in r24024 (ENH: Add slicerMacroBuildAppLibrary and slicerMacroBuildApplication) where it was wrongly assumed that specifying executable extension when setting the OUTPUT_NAME target property was required. From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24206 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerMacroBuildApplication.cmake | Diff File | ||
|
master 6c9a77fd 2015-04-30 22:31:56 Details Diff |
ENH: Update CTK $ git shortlog b643fd8..e771b4a --no-merges Jean-Christophe Fillion-Robin (2): Do not override widget visibility if already set in a layout view factory Do not require QWidget in decorator generated by ctkWrapPythonQt Julien Finet (4): Fix compilation error with Qt < 5.2.1 Add Qt5 support for VTK. Add Qt5 support to QtTesting module Fix ctkFileDialogEventTranslatorPlayerTests Sascha Zelzer (6): Added application support and improved debugging mechanism. Fixed installing plug-ins via symbolic names. Fixed class / struct forward decls and incomplete type. Improved test output. Visual Studio seems to need the full class definition. During shutdown of the plugin framework, also stop all plug-ins. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24205 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
