Changesets: Import 2017-06-07 23:51:09
|
master b51b8c79 2015-07-07 13:53:11 naucoin Details Diff |
BUG: use smart pointers for new storage nodes From JC, use smart pointers for new storable node storage nodes being added to scene views. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24379 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx | Diff File | ||
|
master b62148ee 2015-07-07 13:53:07 naucoin Details Diff |
BUG: use smart pointers for leaking storage node Thanks to JC for pointing out a better way to manage the new scene view storage node, this change switches to using a smart pointer. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24378 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx | Diff File | ||
|
master 7718bca3 2015-07-07 13:53:04 naucoin Details Diff |
BUG: add missing storage nodes on scene view save This is an optional fix, the issue is fixed without it but it is something that I ran across while digging into the series of bugs that needed fixing. If you open up Slicer, add a fiducial and a downloaded sample data volume, then save a scene view, the scene view is missing storage nodes for those nodes since they haven't been saved yet. Then when you save the scene to disk, storage nodes are created (usually by the save data dialog) and added to the main scene. Now there's a mismatch between the nodes in the main scene, the scene view saved at the save to disk moment, and the old scene view. This change checks for storable nodes that are to go into a scene view and adds storage nodes for them to avoid that node mismatch. The reason it's optional is that on scene load, the storage nodes are not triggered to read (and they currently all point to the same file name anyway). The MRB-Scene View multiple saves and restores test passes without this, but it makes the mrml file more clean to have matching storage nodes in all scene views. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24377 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx | Diff File | ||
|
master 1440084b 2015-07-07 13:53:01 naucoin Details Diff |
BUG: avoid overwriting markup information on scene view restore When a scene view is created in a running Slicer, the fiducial list nodes in the scene views have correct per fiducial information (visibility, position, etc). When the scene is saved to disk, only one fiducial file is saved, the current one for the main scene. The scene view nodes do not hold per fiducial information now that all of that is saved to disk. The fiducials are now the same as volumes and models in terms of not supporting data that's saved to disk changing between scene views. For individual fiducials, this means: position, orientation, visibility, selected, locked, label, description, and the associated node ID When loading a scene from disk and restoring a scene view, previously the markups node in the Copy function would clear out the data that it had been populated with via the storage node read. This change checks if the scene view is restoring and the node in the scene view, from which the data is going to get copied, has no fiducials in it, and in that case, don't clear out the list. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24376 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx | Diff File | ||
|
master f07b0fbe 2015-07-07 13:52:58 naucoin Details Diff |
BUG: update test with more correct visibility toggles Digging into the missing fiducials data I realised that on MRB load and then scene view restore the individual fiducial visibility will not get saved/restored in scene views since that information is saved in the file on disk, only the list level visibility is saved. Updated the test to only test list level fiducial visibility. TBD: find a backward compatible way to move the per markup visibility into the markups display node. This behaviour is confusing since from a freshly started Slicer in which you create new scene views, the per markup visibility toggling does work (node copies are in memory), it will just cease to work once the scene is saved to disk and then re-opened. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24375 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/SlicerMRBMultipleSaveRestoreTest.py | Diff File | ||
|
master 43e94a5a 2015-07-07 13:52:54 naucoin Details Diff |
BUG: fix scene view storage leak on MRB save The new scene view storage node that was created to save a scene view snapshot for a new MRB wasn't being removed from the scene due to a variable scoping issue. Renamed the variable and stopped it from being hidden and remove it from the scene and delete as necessary. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24374 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx | Diff File | ||
|
master 17f2807b 2015-07-07 13:52:51 naucoin Details Diff |
BUG: update file list members when saving MRBs The file lists were not getting updated when volumes with multiple files listed were saved in the default format of nrrd. This change saves and restores the file list around MRB saving. Fixed the unique file name to not just append .nrrd to the end of the current file name. TODO: deal with the file lists in the storage nodes in the master scene view (problem when save a scene as mrml then save it to mrb). Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24373 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx | Diff File | ||
| mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.h | Diff File | ||
|
master 3fd97443 2015-07-07 13:52:48 naucoin Details Diff |
BUG: check for compressed file names Get the complete extension when files have paths that end in X.gz. This fixes bugs that came from multiple saves where a file might end up with the name brain.nii.nii.nii.nii.gz. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24372 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTGUI/qSlicerNodeWriter.cxx | Diff File | ||
| mod - Base/QTGUI/qSlicerSaveDataDialog.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLStorageNode.cxx | Diff File | ||
|
master 9d3738d1 2015-07-07 13:52:44 naucoin Details Diff |
BUG: remove unreferenced storage node after loading sample data When loading a sample data volume, the volume node stops observing it, but the storage node was still in the scene. This change removes the unneeded storage node to simplify scene saving debugging. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24371 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/SampleData/SampleData.py | Diff File | ||
|
master 64f2ebc2 2015-07-07 13:52:40 naucoin Details Diff |
BUG: adding a test to show MRB and scene view bug Set up a scene with a volume and a fiducial list. Save scene views. Save to MRB. Close scene, reload MRB, restore scene view, save to MRB. Reload the MRB and make sure that the volume and fiducial list are as expected - when this bug is not fixed, the fiducial list size will be zero at this point. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24370 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt | Diff File | ||
| add - Applications/SlicerApp/Testing/Python/SlicerMRBMultipleSaveRestoreTest.py | Diff File | ||
|
master ca9bdbef 2015-07-02 13:09:00 Details Diff |
BUG: Fix bug in vtkMRMLIGTLTrackingDataBundleNode::GetTransformNode() (See issue 4011) From: Junichi Tokuda <tokuda@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24369 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 3f51e45f 2015-07-02 10:15:25 Details Diff |
BUG: Revert "ENH: add support of DCMTK private dictionary" This reverts commit 1c20e6fc3adad65c72bc3bc3091e636b5e7080c0. For unknown reason, this commit appears to break the dashboard. The messages reported on dashboard are contradicting, since config and build errors are reported on the front page, but not for the Slicer4 project, see http://slicer.cdash.org/index.php?project=Slicer4&date=2015-07-01 Experiments trying to package Slicer on mac failed, with or without this commit, as documented in https://github.com/Slicer/Slicer/pull/299 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24368 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| rm - CMake/SlicerBlockInstallDCMTKResources.cmake | Diff File | ||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master 1c20e6fc 2015-06-30 17:21:28 Details Diff |
ENH: add support of DCMTK private dictionary See issue 4013 and related discussion here: http://slicer-devel.65872.n3.nabble.com/Enabling-support-for-DCMTK-private-dictionary-td4034305.html This change installs private.dic of DCMTK in a runtime location, and sets DCMDICTPATH launcher variable. This will allow for more robust interpretation of DICOM private tags based on the information contained in the DCMTK private dictionary. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24367 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| add - CMake/SlicerBlockInstallDCMTKResources.cmake | Diff File | ||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master 1736c01a 2015-06-30 13:52:52 Details Diff |
BUG: update MultiVolumeExplorer SHA This fixes missing 'import math' git-svn-id: http://svn.slicer.org/Slicer4/trunk@24366 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 62c4fc97 2015-06-27 22:45:49 Details Diff |
COMP: Fix pcre package Linux download error relocating file on midas. This commit is an attempt to fix the following download error happening on linux: // ----------------- CMake Error at PCRE-stamp/download-PCRE.cmake:27 (message): error: downloading 'http://downloads.sourceforge.net/project/pcre/pcre/8.12/pcre-8.12.tar.gz' failed status_code: 7 status_string: "couldn't connect to server" log: About to connect() to downloads.sourceforge.net port 80 (#0) Trying 216.34.181.59... connected Connected to downloads.sourceforge.net (216.34.181.59) port 80 (#0) GET /project/pcre/pcre/8.12/pcre-8.12.tar.gz HTTP/1.1 User-Agent: curl/7.16.1 Host: downloads.sourceforge.net Accept: */* HTTP/1.1 302 Found Server: nginx Date: Sat, 27 Jun 2015 03:14:40 GMT Content-Type: text/html; charset=UTF-8 Connection: close content-disposition: attachment; filename="pcre-8.12.tar.gz" Set-Cookie: sf_mirror_attempt="pcre:superb-dca2:pcre/8.12/pcre-8.12.tar.gz"; expires=120; Path=/ Location: http://superb-dca2.dl.sourceforge.net/project/pcre/pcre/8.12/pcre-8.12.tar.gz Content-Length: 337 Closing connection #0 Issue another request to this URL: 'http://superb-dca2.dl.sourceforge.net/project/pcre/pcre/8.12/pcre-8.12.tar.gz' About to connect() to superb-dca2.dl.sourceforge.net port 80 (#0) Trying 209.61.193.20... Connection timed out couldn't connect to host Closing connection #0 couldn't connect to server // ----------------- git-svn-id: http://svn.slicer.org/Slicer4/trunk@24365 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_PCRE.cmake | Diff File | ||
|
master 17d8def1 2015-06-27 22:01:25 Details Diff |
COMP: Fix compilation of Segment subject hierarchy plugin with python disabled This commit will fix the following error: //-------------- [ 54%] Building CXX object Modules/Loadable/SubjectHierarchy/Widgets/CMakeFiles/qSlicerSubjectHierarchyModuleWidgets.dir/qSlicerSubjectHierarchySegmentPlugin.cxx.o /Users/essert/DEV/Src/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchySegmentPlugin.cxx:59:10: fatal error: 'PythonQt.h' file not found #include "PythonQt.h" ^ 1 error generated. //-------------- Reported-by: Caroline Essert <essert@unistra.fr> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24364 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchySegmentPlugin.cxx | Diff File | ||
|
master cfd8f4b3 2015-06-26 14:47:09 Details Diff |
BUG: Update VTKv6 to include fix for vtkhdf5 libraries DLL manifest At the time of this commit the associated change hadn't been integrated in VTK master and were under review here: https://gitlab.kitware.com/jcfr/vtk/tree/fix-hdf5-manifest Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Date: Fri Jun 26 14:15:47 2015 -0400 Do not force manifest selection for vtkhdf5 libraries Following e16fac1, hdf5 libraries are build with -D_BIND_TO_CURRENT_VCLIBS_VERSION=1. When building VTK using VS2008, the result of this is that (1) VTK libraries all reference "9.0.21022.8" manifest expect the hdf5 ones that reference "9.0.30729.1" and (2) in some case prevent application built against VTK from starting. The problem can also be detected when running CMakeVerifyManifest.cmake against the application install tree. It basically returns a message similar to the following one: 8<----8<----8<----8<----8<----8<----8<---- ERROR: C:/Program Files/AwesomeApp 1.0.0/bin/vtkhdf5_hl-6.2.dll uses 9.0.30729.6161 not found in shipped manifests:[9.0.21022.8]. CMake Error at C:/D/Support/cmake-3.2.2-win32-x86/share/cmake-3.2/Modules/CMakeVerifyManifest.cmake:118 (message): This distribution embeds dll versions that it does not ship, and may not work on other machines. 8<----8<----8<----8<----8<----8<----8<---- Here are some more information copied from the convenience script allowing to patch the manifest from VS2008. Source: https://gist.github.com/jcfr/3c7bef3f8b32f9f6ad4b 8<----8<----8<----8<----8<----8<----8<----8<---- .SYNOPSIS Patch manifests in the redist folder of Visual Studio 9 (2008) .DESCRIPTION To avoid the dll hell associated with runtime libraries distribution. There are two approaches: (1) edit the manifest file to have "9.0.21022.8" from the "9.0.30729.XXX" that is there, you "trick" your executable into using the newer dlls. There appears to be no ill effects from this. The executables work, and you are using a newer version of the run time library. (2) add -D_BIND_TO_CURRENT_VCLIBS=1 to ALL files being compiled, then all of your executable files and dll files will refer to "9.0.30729.XXX" and you can use the redist files without any edits. However, you have to be careful here to recompile everything with this. By default the compiler will build for "9.0.21022.8". This script will consider approach (1). If not already done, this script will first backup the manifest files and then patch them. See: * http://www.kitware.com/blog/home/post/4 * http://stackoverflow.com/questions/8097733/how-to-distribute-c-run-time-crt-libraries 8<----8<----8<----8<----8<----8<----8<----8<---- git-svn-id: http://svn.slicer.org/Slicer4/trunk@24363 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_VTKv6.cmake | Diff File | ||
|
master fceeab83 2015-06-25 19:49:13 Details Diff |
COMP: Fix windows transforms module build error related to sqrt() Following the update of ITK in r24360, the version of sqrt() function accepting integer is probably not exposed anymore. This commit fixes the following error by using an explicit cast: // --------------------- 40>264>..\..\..\..\..\Slicer-1\Modules\Loadable\Transforms\qSlicerTransformsModuleWidget.cxx(447) : error C2668: 'sqrt' : ambiguous call to overloaded function 40>264> C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\include\math.h(581): could be 'long double sqrt(long double)' 40>264> C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\include\math.h(533): or 'float sqrt(float)' 40>264> C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\include\math.h(128): or 'double sqrt(double)' 40>264> while trying to match the argument list '(int)' // --------------------- git-svn-id: http://svn.slicer.org/Slicer4/trunk@24362 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx | Diff File | ||
|
master 7c886711 2015-06-25 19:32:58 Details Diff |
COMP: Update ITKv4 to fix MacOSX compilation issue. //------------------ commit 5f95aa6712c508a637a12faaea119d35e574208c Author: Bradley Lowekamp <blowekamp@mail.nih.gov> Date: Thu Jun 25 10:25:11 2015 -0400 COMP: Explicitly export SingleValuedNonLinearVnlOptimizerv4 Address the following linking issue: Undefined symbols for architecture x86_64: "typeinfo for itk::SingleValuedNonLinearVnlOptimizerv4", referenced from: typeinfo for itk::LBFGSOptimizerBasev4<vnl_lbfgsb> in libSimpleITKRegistration-0.9.a(sitkImageRegistrationMethod_CreateOptimizer.cxx.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) //------------------ git-svn-id: http://svn.slicer.org/Slicer4/trunk@24361 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_ITKv4.cmake | Diff File | ||
|
master 76f37070 2015-06-24 22:47:09 Details Diff |
ENH: Update to ITKv4.8rc2 $ git shortlog 38398fb..650d169 --no-merges Alexander Hewer (1): COMP: fixed error "Dunno about this gcc" for gcc 5.1 Arnaud Gelas (13): ENH: add MinimalPathExtraction as a remote module ENH: fix KWStyle errors for SubdivisionQuadEdgeMesh COMP: fix warning with non default template parameter for OutputImage COMP: missing ';' in itkSetClampMacro STYLE: no need to expose internal type DOC: add explanations about input and out filters COMP: missing include in IterativeTriangleCellSubdivision BUG: memory leaks when calling itk::Mesh::Graft DOC: Improve documentation for ParameterizationQuadEdgeMeshFilter BUG: not all combinations were actually test ENH: add an exception in BorderQuadEdgeMeshFilter if no boundaries COMP: fix CMake warning in ITKModuleHeaderTest BUG: fix memory leaks in BorderQuadEdgeMeshFilter using itk::AutoPointer Bill Lorensen (6): ENH: Update to KWStyle conformant version ENH: Add interpolate capability ENH: WikiExamples QuickView Update COMP: VTK AUTOINIT redefinition warnings COMP: Compiler hidden visibility on Mac compiler COMP: EventMacro backward compatibility Brad King (24): ENH: ExternalData: Allow local stores without any URL templates ENH: ExternalData: Warn on missing file instead of failing ENH: ExternalData: Add support for custom download scripts ENH: ExternalData: Add support for custom algorithm-to-URL mapping DOC: ExternalData: Update documentation to match CMake copy ENH: Teach UpdateThirdPartyFromUpstream to support spaces in path ENH: Improve UpdateThirdPartyFromUpstream for initial imports ENH: Require CMake 2.8.9 or greater ENH: Do not produce ITKGDCM library when using system GDCM ENH: Drop gdcm source subtree to prepare for fresh import ENH: Add script to update GDCM from upstream STYLE: Tell Git not to check whitespace in GDCM STYLE: Tell Git about larger files in GDCM COMP: Configure GDCM to build inside ITK COMP: Fix GDCM to handle older expat library COMP: Cleanup CMP0022 warnings in GDCM module COMP: Add missing include in GDCM source COMP: Teach GDCM to honor ITK_DYNAMIC_LOADING option ENH: KWSys: Tell Git not to export .gitattributes COMP: Remove cmake_minimum_required calls from GDCM COMP: Remove extra CMake policy settings in GDCM COMP: Use more standard SSE intrinsics in GDCM copy of OpenJPEG COMP: Fix GDCM std::accumulate initial value type ENH: Update version of CastXML built for wrapper generation Bradley Lowekamp (38): PERF: Use ImageAlgorithm::Copy in ImageSeriesWriter ENH: Refactor versor to matrix transform code DOC: Clarify that Scale Skew Versor does addition BUG: Correct Simularity3D Jacobian BUG: Ensure OptimizerParameters doesn't leak its helper PERF: Remove frequent dynamic allocations used with std::vector BUG: Restore IO support for BSplineDeformableTransform BUG: Replace std::cout message Warning marco BUG: Correct ExtractImageFilters Type macro DOC: Separately document IsNull and IsNotNull ENH: Modularize KWStyleTests BUG: Remove ExhaustiveOptimizer ivar which was unused STYLE: Update IOFDF to address KWStyle issues BUG: Fix undefined signed integer shift BUG: Fix IOFDFInDoxygenGroup test BUG: Update MGHImageIO for header guarder style BUG: Fix itkFDFImageIOTest link error on windows STYLE: Update SCIFIO for KWStyke failures BUG: Use base's NumberOfIterations for stopping condition PERF: Report progress for linear transform only at scanline completion BUG: Avoid underflow in gradient range calculation ENH: Use return by value for ImageAlgorithm::EnlargeRegionOverBox BUG: No exception for 0 parameter transforms COMP: Address conversion compilation warning ENH: Use PrinSelfObjectMacro BUG: Use module's libraries for linking header test. ENH: Add export specifications to FFT library COMP: Address conversion compilation warning COMP: This patch address linking errors with WrapITK DOC: Improving documentation for the names inputs of the ProcessObject BUG: Isolate CannyEdgeDetection's internal filter from external PERF: Refactor ExpandImageFilter loop ENH: Add AtmoicInt class, use TimeStamp & LightObject COMP: Address signed to unsigned comparison warning in AtomicInt Test ENH: Move IsPrime and GreatestPrimeFactor to compiled cxx file COMP: Add export missing export specifications BUG: Fix reading HDF5 images into different dimension. Revert selection "ENH: Add shared libraries for ITK libraries" Brian Helba (2): ENH: Add scripts for automated updating of ThirdParty libraries ENH: Make Vector construction from scalar value explicit Christopher Mullins (10): STYLE: Keep codesnippet lines under 80 characters. STYLE: Fix Latex blocks in documentation to include newlines. COMP: Fix clang warnings DOC: Fix Latex underscore for SoftwareGuide DOC: Use the dilated version of the FivePoints image COMP: Use c++11 noexcept declarator. COMP: Fix override warnings on clang with GPU module and MINC COMP: Fix clang override warnings for Review module. COMP: Fix more clang warnings in review module COMP: Fix more clang override warnings in Review module. Cyril Mory (3): BUG: Fixed itkWarpImageFilter wrong result in some cases ENH: Method to compute InputRequestedRegion in itkWarpImageFilter ENH: Moved some of itkWarpFilter from private to protected David Froger (2): ENH: Check regions in HDF5 streaming test BUG: Fix HDF5 write streaming test. Davis Vigneault (5): STYLE: Minor style and documentation changes to ITK examples. DOC: Minor changes and clarifications to the registration chapter of Book 2. STYLE: Minor wording and formatting changes to Software Guide Mesh examples. COMP: Build failure using EuclideanDistancePointMetric with mismatched meshes. STYLE: Minor typographical changes in ParameterizationQuadEdgeMeshFilter Dženan Zukić (3): ENH: adding reverse iteration test ENH: using scanline iterator instead of linear iterator DOC: Improve docs for ConnectedComponentImageFilter GDCM Upstream (1): GDCM 2015-04-29 (81e551fc) Gary JIA (1): BUG: Fix memory leak at GPUCommon Gaëtan Lehmann (21): BUG: fix extra carriage return in python callbacks ENH: use castxml in wrapping COMP: almost fix java build ENH: use modern cmake list operations in wrapping COMP: hide compiler warnings when building pcre and swig COMP: fix the IOFDF module name used in wrapping COMP: fix last python runtime warnings about unknown types COMP: fix undefined __float128 type with gcc BUG: reactivate PythonGetNameOfClass and fix the FDFImageIOFactory name COMP: fix warnings due to double MultipleValuedCostFunction wrapper BUG: fix ipython custom completion BUG: fix runtime information for cross correlation filters ENH: let the user choose the tradeoff between size and speed in fft operations ENH: update progress in ImageFileReader ENH: initialize the progress in ImageFileWriter BUG: fix extra line return in terminal progress display BUG: fix missing space before "done" in progress display ENH: pass ActualXDimensionIsOdd through the pipeline COMP: fixes for SizeGreatestPrimeFactor ENH: Add itkFFTPadImageFilter ENH: factorize shared code in itk::PadImageFilterBase Gert Wollny (1): COMP: defining ITK_USE_FLOAT_SPACE_PRECISION Hans Johnson (40): COMP: Add c++11 override designation COMP: Identify null pointer assignments STYLE: rm explicit void for parameterless function STYLE: Use ITK_NULLPTR to utilize c++11 features BUG: Incorrect addition of ITK_OVERRIDE COMP: Use STREQUAL instead of MATCH BUG: return type defaults to zero. BUG: ImageType, CofficientImageArray types missing DOC: Invalid doxygen return for void function. COMP: _Pragma suppress fltpnt equality warnings COMP: Allow exact floatpnt equality checks. COMP: Avoid floatpnt equality check COMP: Floatpnt equality for divisor COMP: Avoid unnecessary float pnt equality checks. PERF: Improve perf of ANTSNeighborhoodCorrelation BUG: Test depending on itkMesh.h in Common COMP: Make DCMTK header functions const Revert "COMP: VTK AUTOINIT redefinition warnings" COMP: VTK and ITK H5 build program collision COMP: Create out-of-line virtual method defintions COMP: Create out-of-line virtual method macros DOC: Clarify strange syntax for itk::MetaEvent COMP: Fix ENABLE_SHARED variable name STYLE: Remove outdated cmake version support STYLE: Move SymmetricEigenAnalysis to Deprecated COMP: Prefer modern CMake visibility settings STYLE: Use ITK_NOEXCEPTION macro ENH: Continue to deprecate ::Zero and ::One ENH: Avoid need for const_cast, ensure consistency BUG: Incorrect function signature COMP: Intel compiler warning suppression ENH: Add shared libraries for ITK libraries ENH: Remove unnecessary const_cast STYLE: Move utility TransformIOHelper to cxx file BUG: Missing ITKIOMINC_EXPORT on __Private() STYLE: Fixed AnalyzeObjectMap header guard style. COMP: Missing exports for templates ENH: Update MGHIO for consistency with ITK. BUG: Remove shared specifications from TransformIO STYLE: Use consistent names in template parameters Ivan Setiawan (2): BUG: Fix initial ImageTrueMax to the most negative value. BUG: Test case to verify fix of ImageTrueMax in MattesMI. Jan Bergmeier (1): DOC: Changed indices for steps in ExhaustiveOptimizer. Jon Haitz Legarreta (9): ENH: New test for the BinaryStatisticsKeepNObjectsImageFilter ENH: New test for the itkLabelShapeKeepNObjectsImageFilter ENH: Add test for itkShapeRelabelImageFilter ENH: Add test for the itkLabelStatisticsKeepNObjectsImageFilter ENH: Add test for itkBinaryShapeKeepNObjectsImageFilter ENH: Add test for itkLabelStatisticsOpeningImageFilter DOC: Correct documentation typo. ENH: Increase code coverage for itkCustomColormapFunction ENH: New test for the itkMetaGaussianConverter Julien Jomier (1): BUG: Output pointer origin is not set causing a memory access error. KWSys Robot (3): KWSys 2015-04-19 (4f39791b) KWSys 2015-05-12 (b1d560a0) KWSys 2015-05-18 (9a6b7c3f) Kevin H. Hobbs (1): COMP: new baseline for building against VTK master Marius Staring (2): BUG: workaround for 64bit VS2013 Release segfaults COMP: workaround for 64bit VS2013 Release ICE Matthew McCormick (142): ENH: Add BridgeNumPy Remote Module. COMP: Bump AnalyzeObjectMapIO to fix doxygen warning. STYLE: Style changes for itkGaussianDerivativeImageFunctionTest. ENH: Test GaussianDerivativeImageFunction with unsigned short. DOC: Add C++11 macros to doxygen configuration. ENH: Remove FindNUMARRAY.cmake. STYLE: Too many spaces before semi-colon in PCAShapeSignedDistanceFunction. COMP: Bump Wiki Examples revision to fix Doxygen warnings. COMP: Fix ITK_OVERRIDE update DebugMacro build errors. DOC: Updates to GettingStarted.txt. BUG: Remove Testing/Temporary/CTestCostData.txt. ENH: Update doxygen.config for Doxygen 1.8.9.1. ENH: Bump CMakeLists.txt version to 4.8.0. DOC: Rename duplicate doxygen section. Revert Doxygen version 1.8.9.1 to 1.8.5 config to clean up dashboard DOC: Fix Doxygen override, nullptr, noexcept definitions. DOC: Note that push access is not required to get patches merged. DOC: Clean up some wrapping comments. STYLE: Clean up inter-definition space for Image,ImageBase,ProcessObject. ENH: Fetch source tarball external data from midas3.kitware.com. BUG: Fix BridgeNumPy signed / unsigned short correspondance. DOC: Improve ImageScanlineIterator documentation. ENH: Add missing {Set,Get}Element methods to Array2D. BUG: Fix linking SmoothingRecursiveYvvGaussianFilter with install tree. BUG: Add CMake export code for ITK_USE_SYSTEM_GDCM. ENH: Pass CMAKE_GENERATOR to ExternalProject's. ENH: Update LLVM/Clang ExternalProject to 3.6.0. ENH: Update MetaIO License from Upstream. ENH: Bump MetaIO to latest upstream. COMP: Do not include tests/ directory in clang tarball. ENH: Add Azure Storage as ExternalData source. STYLE: Update SplitComponents module for KWStyle fixes. STYLE: Style fixes for LevelSetsv4 and related classes. BUG: Move MagnitudeAndPhaseToComplex filter wrapping to ITKImageIntensity. ENH: Document testModules.sh and move to Utilities/Maintenance BUG: Fix Python tests on Windows with Ninja generator. STYLE: Update IOSTL module for KWStyle test. BUG: Suppress wrapping type conversions warnings with MSVC. COMP: Address quoted MSVC variable in GDCM. BUG: WrapITK.pth should contain the lib/ directory with VS. COMP: Suppress swig build configure warning. ENH: Use CMAKE_CROSSCOMPILING_EMULATOR to run HDF5 detection. BUG: Do not use EXECUTABLE_OUTPUT_PATH for vcl tests. BUG: Do not enable floating point exceptions in tests with MinGW. DOC: Update KWStyle location. BUG: Add QuickViewTest baseline for Mac. ENH: MetaIO use UpdateThirdPartyFromUpstream.sh ENH: Arrange MetaIO sources for UpdateThirdPartyFromUpstream.sh. ENH: Add root snapshot commit support to UpdateThirdPartyFromUpstream.sh COMP: Do not try to generate tiff_fax3sm.c when cross compiling. COMP: Android does not currently have posix_memalign. COMP: The Android pwd.h passwd struct does not have a pw_gecos entry. COMP: Android does not have pthread_setcancelstate. COMP: Do not do __errno_location workaround on Android. COMP: Removed unused parameters in itkThreadPoolTest. BUG: Address detection of TransformReadWriteTest as executable. ENH: Set CMP0056 to NEW. COMP: Work around test file too big with x64_64-w64-mingw32. COMP: Increase itkMattesMutualInformationImageToIMageMetricv4Test tolerance. COMP: Address NumericTraits warning related to POWER8 char. BUG: Add new ResampleImageFilter9Test baseline for MinGW. BUG: Add MinGW baseline for VoronoiPartitioningImageFilterTest1. COMP: Fix vnl_sample.cxx for srand48 but no drand48. ENH: Add ITK_DYNAMIC_LOADING CMake option. COMP: Support S_IRUSR and S_IWUSR. COMP: Do not log swig configure output. BUG: NumericTraits< char > does not have Self typedef. ENH: Do not use TestBigEndian from CMAKE_ROOT. COMP: Use sizeof(void *) instead of sizeof(size_t) for address model. COMP: Do not use GCC demangling with emscripten. ENH: Use try_run to determine if double correction required. COMP: Suppress Swig configure output. COMP: Set CMP0058 to NEW. COMP: Add missing InternalLabelType. BUG: Specify absolute path to double-conversion-configure.h for install. DOC: Clarify the UpdateThirdPartyFromUpstream.sh commit message. COMP: Pass --quiet to swig's configure script. STYLE: Update HigherOrderAccurateGradient module for style fixes. ENH: Mark ITK_DYNAMIC_LOADING as an advanced CMake variable. COMP: Ignore swig-prefix warnings. BUG: GDCM set default ultrasound spacing when not found. COMP: Initialize arrays in itkCurvatureFlowFunction. COMP: Add itkIntTypes.h header for SizeValueType in itkVnlFFTCommon.h STYLE: Style fixes for RayCastHelper::CalcRayIntercepts COMP: Run the SWIG configure step in a CMake script. STYLE: Bump IOFDF module for style and cleanup. BUG: Fix DoxygenInGroup test from .zip release files. COMP: Do not wrap exotic QuadEdgeMesh CellInterface types. COMP: Remove FFTWGlobalConfiguration param doxygen keyword. COMP: Do not reference ::MetaEvent in itkMetaEvent.h docs. DOC: itkSymmetricEigenSystem is now in the ITKDeprecated module. BUG: Fix TestDriver executable for itkSymmetricEigenSystemTest. BUG: Use consistent SizeGreatestPrimeFactor in deconvolution tests. COMP: Use signed char in ImageToImageMetricv4 test. COMP: Do not include itkDynamicLoader in header tests. COMP: Include byteswap.h for Android in GDCM. COMP: Use signal.h instead of sys/signal.h in GDCM. COMP: Not all versions of Android have posix_memalign. COMP: Initialize variable in PointSetToListSampleAdaptorTest. COMP: Suppress getpwnam warning with static executables. COMP: Tighten LandmarkWarping2 lines for Software Guide. ENH: Allow skip of FloatPointExceptions implementation for absent fenv.h. COMP: Define feenableexcept for Emscripten. BUG: HDF5 do not force CMake CheckTypeSize on include. STYLE: Style fixes to itkVideoStream.e COMP: Ignore build warnings for libs unfound by emscripten. BUG: Run HDF5 H5detect in working directory with the executable. BUG: HDF5 use CMAKE_EXECUTABLE_SUFFIX. COMP: Work around Emscripten internal compiler crash in VideoStream. COMP: Use byteswap.h with GDCM with Emscripten. COMP: Recognize Emscripten in socket++. BUG: Remove HDF5's own internal CheckTypeSize.cmake. ENH: Enable cross-compiling of the wrapping. COMP: Missing semi-colon in FFT Hermitian filters. ENH: Add ExternalData_NO_SYMLINKS option. ENH: Mount local filesystem in the test driver for Emscripten. BUG: Do not install wrapping with CMAKE_PREFIX_PATH. ENH: Define CPACK_PACKAGE_CONTACT. ENH: Add post-commit hook for third party library patches. ENH: Pass the CastXML flags directly. STYLE: Rename GCC-XML references to CastXML. ENH: Send an error when CMAKE_CXX_COMPILER_TARGET is not set. ENH: Bump CastXML version for cross-compiling target fix. BUG: Use STRING type for PY_SITE_PACKAGES_PATH. BUG: Continue when IPython.get_ipython throws an AttributeError. ENH: Add ITK_USE_SYSTEM_LIBRARIES STYLE: Fix indentation in ITKSetStandardCompilerFlags.cmake. COMP: Do not enable ITK_HAVE_SYNC_BUILTINS with Emscripten. COMP: Fix MinGW ITK_HAVE_SYNC_BUILTINS detection. ENH: Split testing data tarball form source tarball. COMP: Do not use ITK_NULLPTR as sentinel. ENH: Use gold linker on Linux with GCC. COMP: Add try_compile check for gold linker. COMP: Do not build dsrc2c.c with -fvisibility-inlines-hidden. BUG: Remove shared specifications from IOTransformBase. BUG: Required GCC version for gold linker is 4.8.3. BUG: Fix ITKIOMINCExport.h capitalization. BUG: Add missing include directory required after MINC update. BUG: Bring in IOFDF license updates. COMP: Add missing HDF5 include for MINC. COMP: Add missing HDF5 include directory for ITKIOMINC. COMP: Fix itkVTKImageExport.h header name in VtkGlue.i. MetaIO Maintainers (2): MetaIO 2015-04-12 (b7969294) MetaIO 2015-04-21 (dc4f7d16) Michka Popoff (20): COMP: Use c++ style comments in pyBase.i ENH: Update to swig 3.0.3 STYLE: Cleanup up cmake files (if, endif, foreach, endforeach). ENH: Update to SWIG 3.0.5 COMP: Fix PythonReadDicomTagTest on OS X ENH: Improve wrapping for Vector image types ENH: Cleanup itkComposeImageFilter wrapping ENH: Setup correct wrapping of GradientRecursiveGaussianImageFilter ENH: Add Get/SetSigmaArray to GradientRecursiveGaussianImageFilter ENH: Add checks for base types when wrapping more complex types COMP: Fix DiffeomorphicDemonsRegistration Wrapping STYLE: Rename ITK_WRAP_DIMS to ITK_WRAP_IMAGE_DIMS ENH: Add ITK_WRAP_VECTOR_COMPONENTS option STYLE: Replace GCCXML by CASTXML BUG: Wrap FixedArray sizes also for vector components ENH: Wrap MersenneTwisterRandomVariateGenerator ENH: Wrap CustomColormapFunction ENH: Update to PCRE 8.37 ENH: Enable wrapping of 4 dimensional vectors ENH: Remove inline namespace fix for Wrapping Nick Tustison (11): ENH: Adding point set reg. capabilities for SyN. PERF: Tolerance for testing needs to be increased. BUG: Coverity divide by zero complaint. BUG: Metric evaluation had an incorrect sign. ENH: Making the point set type visible. BUG: Need to check if maxNorm == 0. BUG: Pixel type shouldn't be initialized with scalar. ENH: Cleaning up point set reg. in BSplineSyN ENH: Adding tangent space calculation for SyN methods. BUG: Added sampling only within the specified mask. BUG: Added sampling only within the specified mask. Niels Dekker (2): BUG: workaround for 64bit VS2013 Release segfault COMP: Fixed MSVC warnings, "warning D9025: overriding '/W1' with '/w'" Richard Beare (3): ENH: LabelErodeDilate as a remote module ENH: remote.cmake for parabolic morphology ENH: Use SHA for LabelErodeDilate module. Rolf Eike Beer (2): STYLE: ExternalData: Replace MATCHES with STREQUAL where possible STYLE: ExternalData: Clean up duplicate regex matches with CMAKE_MATCH_<n> Sean McBride (14): COMP: Changed KWStyle check for header include guard names COMP: Remove double underscore in header guards (.h & __itk*_h form) COMP: Remove double underscore in header guards (.hxx & __itk*_h form) COMP: Remove double underscore in header guards (.in & __itk*_h form) COMP: Remove remaining double underscore in header guards (__itk form) COMP: Remove unnecessary header guards in .cxx files COMP: Manually search for "__itk" and clean up double underscore usage COMP: fixed clang -Wkeyword-macro warning by removing invalid #undef COMP: Suppress clang -Wdocumentation-unknown-command false positive COMP: properly escape @ char in doxygen comments COMP: Escaped @ character in doxygen comments BUG: updated libminc SHA to newest COMP: Update MINC to upstream 85145dca36 BUG: updated MINC to a77da29 Ziv Yaniv (1): BUG: Versor initialized with null axis (0,0,0) did not throw exception. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24360 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_ITKv4.cmake | Diff File | ||
|
master 413c512a 2015-06-24 22:47:07 Details Diff |
STYLE: Remove of Slicer_ITKV3_COMPATIBILITY build option Since r23960 (ENH: Disable ITKv3 compatibility to enable 64-bit ids on windows), this option has been disabled by default. This commit simplifies the maintenance of the build system by removing the option. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24359 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMakeLists.txt | Diff File | ||
| mod - SuperBuild/External_ITKv4.cmake | Diff File | ||
|
master 33cdec01 2015-06-24 12:12:59 naucoin Details Diff |
ENH: signal end fiducial interaction in 3D Update the fiducial 3D displayable manager to throw the same end fiducial interaction event as the 2D manager, PointEndInteractionEvent git-svn-id: http://svn.slicer.org/Slicer4/trunk@24358 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager3D.cxx | Diff File | ||
|
master e50a2c67 2015-06-24 11:57:18 naucoin Details Diff |
ENH: remove unused Resolution setting on ruler node Remove the Resolution setting as it's only used inside the node, it has been superceded by the tick settings. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24357 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerNode.cxx | Diff File | ||
| mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerNode.h | Diff File | ||
| mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerStorageNode.cxx | Diff File | ||
|
master 0be06929 2015-06-24 09:27:21 naucoin Details Diff |
ENH: add utility method to display node in only 1 view Since the view node id logic is set up to be backward compatible (no view node id set means showing in all views), provide a convenience function, SetDisplayableOnlyInView, that reduces this operation to one call. It places the calls to remove all view node ids and add the new one inside of a disable modified events block to avoid flicker. Added testing. Issue 0003196 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24356 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLDisplayNode.h | Diff File | ||
|
master 6aaa218e 2015-06-24 09:13:10 Details Diff |
ENH: Update transforms module to support copy/paste of linear transforms. This commit improve the transforms module to allow user to copy/paste linear transforms to/from the clipboard. Matrix of size 2x2, 3x3 or 4x4 are supported. Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Tested-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Fixes 0004010 From: Adam Rankin <adam.rankin@gmail.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24355 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.h | Diff File | ||
