Changesets: Import 2017-06-07 23:51:09
|
master b6b6b995 2015-07-17 11:34:54 Details Diff |
BUG: Fix vtkMRMLColorTableNodeTest1 Following r24436 (BUG: Fix uninitialized value in vtkMRMLColorTableNode.), the property "NamesInitialised" is not explicitly set when calling "SetColor()". This commit explicitly calls "NamesInitialisedOn()" after setting the color. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24454 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLColorTableNodeTest1.cxx | Diff File | ||
|
master a6392c37 2015-07-17 11:34:52 Details Diff |
STYLE: Improve output of vtkMRMLColorTableNodeTest1 displaying line number git-svn-id: http://svn.slicer.org/Slicer4/trunk@24453 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLColorTableNodeTest1.cxx | Diff File | ||
|
master 306069a6 2015-07-17 09:14:10 Details Diff |
BUG: Fixed extension creation in version-controlled repository It was only possible to create extension in a non-version-controlled directory. The problem was that extension was created in repositoryRoot/extensionName directory but when an extension is opened in a version-controlled directory then the extension is expected to be found in repositoryRoot. Changed extension creation so that if it is created in a version-controlled directory then files are added to repositoryRoot (instead of repositoryRoot/extensionName). git-svn-id: http://svn.slicer.org/Slicer4/trunk@24452 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/ExtensionWizard/ExtensionWizard.py | Diff File | ||
| mod - Utilities/Scripts/SlicerWizard/TemplateManager.py | Diff File | ||
|
master 5ed5ba23 2015-07-17 02:51:14 Details Diff |
BUG: Fix memory leak in vtkMRMLScene This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was executed doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Run vtkMRMLSceneImportIDModelHierarchyConflictTest using using valgrind: valgrind --tool=memcheck --leak-check=yes ./bin/MRMLCoreCxxTests vtkMRMLSceneImportIDModelHierarchyConflictTest Valgrind error: ==17319== 18 bytes in 2 blocks are definitely lost in loss record 98 of 240 ==17319== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==17319== by 0x52DAB7D: vtkMRMLScene::SetLastLoadedVersion(char const*) (in /home/jcfr/Projects/Slicer-Debug/Slicer-build/bin/libMRMLCore.so) ==17319== by 0x52A9C29: vtkMRMLParser::StartElement(char const*, char const**) (vtkMRMLParser.cxx:47) ==17319== by 0x1A9BAC12: vtkXMLParserStartElement (vtkXMLParser.cxx:523) ==17319== by 0x1BE5A943: doContent (xmlparse.c:1641) ==17319== by 0x1BE59A10: contentProcessor (xmlparse.c:1331) ==17319== by 0x1BE5DCEF: doProlog (xmlparse.c:2669) ==17319== by 0x1BE5D48F: prologProcessor (xmlparse.c:2505) ==17319== by 0x1BE5D41C: prologInitProcessor (xmlparse.c:2494) ==17319== by 0x1BE592C2: vtk_expat_XML_ParseBuffer (xmlparse.c:1132) ==17319== by 0x1BE59218: vtk_expat_XML_Parse (xmlparse.c:1122) ==17319== by 0x1A9BAB4C: vtkXMLParser::ParseBuffer(char const*, unsigned int) (vtkXMLParser.cxx:496) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24451 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLScene.cxx | Diff File | ||
|
master f698ed7f 2015-07-17 02:51:12 Details Diff |
BUG: Fix memory leak in vtkMRMLSubjectHierarchyNode This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was executed doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python (3) Load MRHead.nrrd file, open subject hierarchy module (4) Exit Slicer and inspect valgrind log file Valgrind error: ==1972== 7 bytes in 1 blocks are definitely lost in loss record 25 of 2,618 ==1972== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==1972== by 0x10578B1E4: vtkMRMLSubjectHierarchyNode::SetOwnerPluginName(char const*) (vtkMRMLSubjectHierarchyNode.cxx:216) ==1972== by 0x1052F96B2: qSlicerSubjectHierarchyPluginHandler::findAndSetOwnerPluginForSubjectHierarchyNode(vtkMRMLSubjectHierarchyNode*) (qSlicerSubjectHierarchyPluginHandler.cxx:298) ==1972== by 0x1052ECB61: qSlicerSubjectHierarchyPluginLogic::onNodeAdded(vtkObject*, vtkObject*) (qSlicerSubjectHierarchyPluginLogic.cxx:248) ==1972== by 0x1053090F2: qSlicerSubjectHierarchyPluginLogic::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_qSlicerSubjectHierarchyPluginLogic.cxx:71) ==1972== by 0x20AE9DC9: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /home/jcfr/Support/qt-everywhere-opensource-release-build-4.8.6/lib/libQtCore.so.4.8.6) ==1972== by 0xA88A5A9: ctkVTKConnection::emitExecute(vtkObject*, vtkObject*) (moc_ctkVTKConnection.cxx:109) ==1972== by 0xA87B88B: ctkVTKConnectionPrivate::execute(vtkObject*, unsigned long, void*, void*) (ctkVTKConnection.cpp:418) ==1972== by 0xA87B615: ctkVTKConnectionPrivate::DoCallback(vtkObject*, unsigned long, void*, void*) (ctkVTKConnection.cpp:381) ==1972== by 0x28BF8D3E: vtkCallbackCommand::Execute(vtkObject*, unsigned long, void*) (vtkCallbackCommand.cxx:42) ==1972== by 0xE3DC3BA: vtkEventBroker::InvokeObservation(vtkObservation*, unsigned long, void*) (vtkEventBroker.cxx:838) ==1972== by 0xE3DBA10: vtkEventBroker::ProcessEvent(vtkObservation*, vtkObject*, unsigned long, void*) (vtkEventBroker.cxx:687) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24450 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.cxx | Diff File | ||
|
master 6628ff87 2015-07-17 02:51:10 Details Diff |
BUG: Fix uninitialized value issue in qMRMLTransformSliders This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was executed doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python (3) Load MRHead.nrrd file (4) Exit Slicer and inspect valgrind log file Valgrind error: ==1972== Conditional jump or move depends on uninitialised value(s) ==1972== at 0x5EB79E1: qMRMLTransformSliders::setTypeOfTransform(qMRMLTransformSliders::TransformType) (qMRMLTransformSliders.cxx:131) ==1972== by 0x5EB753C: qMRMLTransformSliders::qMRMLTransformSliders(QWidget*) (qMRMLTransformSliders.cxx:71) ==1972== by 0x10930B917: Ui_qSlicerTransformsModuleWidget::setupUi(qSlicerWidget*) (ui_qSlicerTransformsModuleWidget.h:163) ==1972== by 0x109307D16: qSlicerTransformsModuleWidget::setup() (qSlicerTransformsModuleWidget.cxx:117) ==1972== by 0x8E83A6A: qSlicerAbstractModuleRepresentation::setModule(qSlicerAbstractCoreModule*) (qSlicerAbstractModuleRepresentation.cxx:82) ==1972== by 0x8E73522: qSlicerAbstractCoreModule::createNewWidgetRepresentation() (qSlicerAbstractCoreModule.cxx:258) ==1972== by 0x8E733BB: qSlicerAbstractCoreModule::widgetRepresentation() (qSlicerAbstractCoreModule.cxx:226) ==1972== by 0x59554F6: qSlicerModulePanel::addModule(qSlicerAbstractCoreModule*) (qSlicerModulePanel.cxx:145) ==1972== by 0x595547C: qSlicerModulePanel::setModule(qSlicerAbstractCoreModule*) (qSlicerModulePanel.cxx:131) ==1972== by 0x59553BB: qSlicerModulePanel::setModule(QString const&) (qSlicerModulePanel.cxx:109) ==1972== by 0x59B025B: qSlicerModulePanel::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_qSlicerModulePanel.cxx:53) ==1972== by 0x20AE9DC9: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /home/jcfr/Support/qt-everywhere-opensource-release-build-4.8.6/lib/libQtCore.so.4.8.6) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24449 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLTransformSliders.cxx | Diff File | ||
|
master bddaad81 2015-07-17 02:51:08 Details Diff |
BUG: Fix uninitialized value issue in vtkNRRDReader This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was executed doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python (3) Load MRHead.nrrd file (4) Exit Slicer and inspect valgrind log file Valgrind error: ==581== Conditional jump or move depends on uninitialised value(s) ==581== at 0x1E7585AF: vtkNRRDReader::SetPointDataType(int) (in /home/jcfr/Projects/Slicer-Debug/Slicer-build/bin/libvtkTeem.so) ==581== by 0x1E74F0FF: vtkNRRDReader::ExecuteInformation() (vtkNRRDReader.cxx:346) ==581== by 0x23AD4531: vtkImageReader2::RequestInformation(vtkInformation*, vtkInformationVector**, vtkInformationVector*) (vtkImageReader2.cxx:484) ==581== by 0x291481B8: vtkImageAlgorithm::ProcessRequest(vtkInformation*, vtkInformationVector**, vtkInformationVector*) (vtkImageAlgorithm.cxx:109) ==581== by 0x2913BB9B: vtkExecutive::CallAlgorithm(vtkInformation*, int, vtkInformationVector**, vtkInformationVector*) (vtkExecutive.cxx:775) ==581== by 0x29134493: vtkDemandDrivenPipeline::ExecuteInformation(vtkInformation*, vtkInformationVector**, vtkInformationVector*) (vtkDemandDrivenPipeline.cxx:480) ==581== by 0x29159FCD: vtkStreamingDemandDrivenPipeline::ExecuteInformation(vtkInformation*, vtkInformationVector**, vtkInformationVector*) (vtkStreamingDemandDrivenPipeline.cxx:412) ==581== by 0x29133AF6: vtkDemandDrivenPipeline::ProcessRequest(vtkInformation*, vtkInformationVector**, vtkInformationVector*) (vtkDemandDrivenPipeline.cxx:237) ==581== by 0x29159D60: vtkStreamingDemandDrivenPipeline::ProcessRequest(vtkInformation*, vtkInformationVector**, vtkInformationVector*) (vtkStreamingDemandDrivenPipeline.cxx:335) ==581== by 0x2913407A: vtkDemandDrivenPipeline::UpdateInformation() (vtkDemandDrivenPipeline.cxx:405) ==581== by 0x29126865: vtkAlgorithm::UpdateInformation() (vtkAlgorithm.cxx:1478) ==581== by 0x1067960EC: vtkMRMLMultiVolumeStorageNode::ReadDataInternal(vtkMRMLNode*) (vtkMRMLMultiVolumeStorageNode.cxx:89) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24448 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/vtkTeem/vtkNRRDReader.cxx | Diff File | ||
|
master e9960dca 2015-07-17 01:01:03 Details Diff |
BUG: Fix memory leak in vtkMRMLDisplayNode This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==9195== 22 bytes in 1 blocks are definitely lost in loss record 407 of 2,311 ==9195== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9195== by 0xE443C13: vtkMRMLDisplayNode::SetActiveScalarName(char const*) (vtkMRMLDisplayNode.cxx:38) ==9195== by 0xE6A1650: vtkMRMLTransformDisplayNode::vtkMRMLTransformDisplayNode() (vtkMRMLTransformDisplayNode.cxx:62) ==9195== by 0xE6A153A: vtkMRMLTransformDisplayNode::New() (vtkMRMLTransformDisplayNode.cxx:50) ==9195== by 0xE5990EC: vtkSmartPointer<vtkMRMLTransformDisplayNode>::New() (vtkSmartPointer.h:117) ==9195== by 0xE582342: vtkMRMLScene::vtkMRMLScene() (vtkMRMLScene.cxx:201) ==9195== by 0xE58385A: vtkMRMLScene::New() (vtkMRMLScene.cxx:371) ==9195== by 0x5602843: vtkNew<vtkMRMLScene>::vtkNew() (vtkNew.h:66) ==9195== by 0x8E82E96: qSlicerCoreApplicationPrivate::init() (qSlicerCoreApplication.cxx:266) ==9195== by 0x59272A7: qSlicerApplicationPrivate::init() (qSlicerApplication.cxx:180) ==9195== by 0x5927FDF: qSlicerApplication::qSlicerApplication(int&, char**) (qSlicerApplication.cxx:319) ==9195== by 0x406039: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:125) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24447 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx | Diff File | ||
|
master a50000bf 2015-07-17 01:01:01 Details Diff |
BUG: Fix memory leak in vtkMRMLScene This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==9195== 12 bytes in 1 blocks are definitely lost in loss record 264 of 2,311 ==9195== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9195== by 0xE596033: vtkMRMLScene::SetVersion(char const*) (in /home/jcfr/Projects/Slicer-Debug/Slicer-build/bin/libMRMLCore.so) ==9195== by 0xE5816EE: vtkMRMLScene::vtkMRMLScene() (vtkMRMLScene.cxx:136) ==9195== by 0xE58385A: vtkMRMLScene::New() (vtkMRMLScene.cxx:371) ==9195== by 0x5602843: vtkNew<vtkMRMLScene>::vtkNew() (vtkNew.h:66) ==9195== by 0x8E82E96: qSlicerCoreApplicationPrivate::init() (qSlicerCoreApplication.cxx:266) ==9195== by 0x59272A7: qSlicerApplicationPrivate::init() (qSlicerApplication.cxx:180) ==9195== by 0x5927FDF: qSlicerApplication::qSlicerApplication(int&, char**) (qSlicerApplication.cxx:319) ==9195== by 0x406039: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:125) ==9195== by 0x406D30: main (Main.cxx:254) ==9195== ==9195== 12 bytes in 1 blocks are definitely lost in loss record 265 of 2,311 ==9195== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9195== by 0xE596033: vtkMRMLScene::SetVersion(char const*) (in /home/jcfr/Projects/Slicer-Debug/Slicer-build/bin/libMRMLCore.so) ==9195== by 0xE5816EE: vtkMRMLScene::vtkMRMLScene() (vtkMRMLScene.cxx:136) ==9195== by 0xE58385A: vtkMRMLScene::New() (vtkMRMLScene.cxx:371) ==9195== by 0x10A0C2EE4: vtkSlicerUnitsLogic::vtkSlicerUnitsLogic() (vtkSlicerUnitsLogic.cxx:44) ==9195== by 0x10A0C2E44: vtkSlicerUnitsLogic::New() (vtkSlicerUnitsLogic.cxx:39) ==9195== by 0x109C31C11: qSlicerUnitsModule::createLogic() (qSlicerUnitsModule.cxx:156) ==9195== by 0x8E71641: qSlicerAbstractCoreModule::logic() (qSlicerAbstractCoreModule.cxx:280) ==9195== by 0x8E70C2D: qSlicerAbstractCoreModule::initialize(vtkSlicerApplicationLogic*) (qSlicerAbstractCoreModule.cxx:99) ==9195== by 0x8EA2AB1: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:170) ==9195== by 0x8EA2963: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:157) ==9195== by 0x8EA2963: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:157) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24446 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLScene.cxx | Diff File | ||
|
master c1fdaf73 2015-07-17 01:00:59 Details Diff |
BUG: Fix memory leaks in SubjectHierarchy Register and Segment plugins Since QMenu constructor does not take a QObject as a parent, this commit introduces a QSharedPointer to manage the menu instance. This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==29339== 1,160 (40 direct, 1,120 indirect) bytes in 1 blocks are definitely lost in loss record 2,294 of 2,448 ==29339== at 0x4C2B0E0: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x10550A4D9: qSlicerSubjectHierarchySegmentPluginPrivate::init() (qSlicerSubjectHierarchySegmentPlugin.cxx:114) ==29339== by 0x10550A3E7: qSlicerSubjectHierarchySegmentPlugin::qSlicerSubjectHierarchySegmentPlugin(QObject*) (qSlicerSubjectHierarchySegmentPlugin.cxx:103) ==29339== by 0x1054F1217: qSlicerSubjectHierarchyPluginLogic::registerCorePlugins() (qSlicerSubjectHierarchyPluginLogic.cxx:139) ==29339== by 0x1054F0DFD: qSlicerSubjectHierarchyPluginLogic::qSlicerSubjectHierarchyPluginLogic(QWidget*) (qSlicerSubjectHierarchyPluginLogic.cxx:117) ==29339== by 0x1080E2F5C: qSlicerSubjectHierarchyModule::createLogic() (qSlicerSubjectHierarchyModule.cxx:137) ==29339== by 0x8E715C1: qSlicerAbstractCoreModule::logic() (qSlicerAbstractCoreModule.cxx:280) ==29339== by 0x8E70BAD: qSlicerAbstractCoreModule::initialize(vtkSlicerApplicationLogic*) (qSlicerAbstractCoreModule.cxx:99) ==29339== by 0x8EA2A19: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:170) ==29339== by 0x8EA2586: qSlicerModuleFactoryManager::loadModule(QString const&) (qSlicerModuleFactoryManager.cxx:110) ==29339== by 0x40672A: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:193) ==29339== by 0x406D30: main (Main.cxx:254) ==29339== ==29339== 1,176 (40 direct, 1,136 indirect) bytes in 1 blocks are definitely lost in loss record 2,296 of 2,448 ==29339== at 0x4C2B0E0: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x105507073: qSlicerSubjectHierarchyRegisterPluginPrivate::init() (qSlicerSubjectHierarchyRegisterPlugin.cxx:120) ==29339== by 0x105506EC1: qSlicerSubjectHierarchyRegisterPlugin::qSlicerSubjectHierarchyRegisterPlugin(QObject*) (qSlicerSubjectHierarchyRegisterPlugin.cxx:104) ==29339== by 0x1054F11ED: qSlicerSubjectHierarchyPluginLogic::registerCorePlugins() (qSlicerSubjectHierarchyPluginLogic.cxx:137) ==29339== by 0x1054F0DFD: qSlicerSubjectHierarchyPluginLogic::qSlicerSubjectHierarchyPluginLogic(QWidget*) (qSlicerSubjectHierarchyPluginLogic.cxx:117) ==29339== by 0x1080E2F5C: qSlicerSubjectHierarchyModule::createLogic() (qSlicerSubjectHierarchyModule.cxx:137) ==29339== by 0x8E715C1: qSlicerAbstractCoreModule::logic() (qSlicerAbstractCoreModule.cxx:280) ==29339== by 0x8E70BAD: qSlicerAbstractCoreModule::initialize(vtkSlicerApplicationLogic*) (qSlicerAbstractCoreModule.cxx:99) ==29339== by 0x8EA2A19: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:170) ==29339== by 0x8EA2586: qSlicerModuleFactoryManager::loadModule(QString const&) (qSlicerModuleFactoryManager.cxx:110) ==29339== by 0x40672A: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:193) ==29339== by 0x406D30: main (Main.cxx:254) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24445 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyRegisterPlugin.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchySegmentPlugin.cxx | Diff File | ||
|
master 1a25316a 2015-07-17 01:00:57 Details Diff |
BUG: Fix memory leaks in qSlicerAppMainWindow This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==29339== 5,172 (40 direct, 5,132 indirect) bytes in 1 blocks are definitely lost in loss record 2,404 of 2,448 ==29339== at 0x4C2B0E0: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x4E57C53: qSlicerAppMainWindowPrivate::setupUi(QMainWindow*) (qSlicerAppMainWindow.cxx:334) ==29339== by 0x4E56C59: qSlicerAppMainWindowPrivate::init() (qSlicerAppMainWindow.cxx:122) ==29339== by 0x4E5A98D: qSlicerAppMainWindow::qSlicerAppMainWindow(QWidget*) (qSlicerAppMainWindow.cxx:676) ==29339== by 0x406553: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:184) ==29339== by 0x406D30: main (Main.cxx:254) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24444 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx | Diff File | ||
|
master a45826fb 2015-07-17 01:00:55 Details Diff |
BUG: Fix memory leak in qMRMLCheckableNodeComboBox This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==29339== 474 (32 direct, 442 indirect) bytes in 1 blocks are definitely lost in loss record 2,158 of 2,448 ==29339== at 0x4C2B0E0: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x5E1AA09: qMRMLCheckableNodeComboBoxPrivate::init(QAbstractItemModel*) (qMRMLCheckableNodeComboBox.cxx:63) ==29339== by 0x5E5E445: qMRMLNodeComboBox::qMRMLNodeComboBox(qMRMLNodeComboBoxPrivate*, QWidget*) (qMRMLNodeComboBox.cxx:399) ==29339== by 0x5E1AB88: qMRMLCheckableNodeComboBox::qMRMLCheckableNodeComboBox(QWidget*) (qMRMLCheckableNodeComboBox.cxx:89) ==29339== by 0x5E2E712: qMRMLDisplayNodeViewComboBox::qMRMLDisplayNodeViewComboBox(QWidget*) (qMRMLDisplayNodeViewComboBox.cxx:74) ==29339== by 0x1046D9FDC: Ui_qSlicerMarkupsModule::setupUi(qSlicerWidget*) (ui_qSlicerMarkupsModule.h:472) ==29339== by 0x1046C4016: qSlicerMarkupsModuleWidgetPrivate::setupUi(qSlicerWidget*) (qSlicerMarkupsModuleWidget.cxx:135) ==29339== by 0x1046C6B55: qSlicerMarkupsModuleWidget::setup() (qSlicerMarkupsModuleWidget.cxx:464) ==29339== by 0x8E819EA: qSlicerAbstractModuleRepresentation::setModule(qSlicerAbstractCoreModule*) (qSlicerAbstractModuleRepresentation.cxx:82) ==29339== by 0x8E714A2: qSlicerAbstractCoreModule::createNewWidgetRepresentation() (qSlicerAbstractCoreModule.cxx:258) ==29339== by 0x8E7133B: qSlicerAbstractCoreModule::widgetRepresentation() (qSlicerAbstractCoreModule.cxx:226) ==29339== by 0x1046C224A: qSlicerMarkupsModule::setup() (qSlicerMarkupsModule.cxx:153) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24443 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLCheckableNodeComboBox.cxx | Diff File | ||
|
master 37939c85 2015-07-17 01:00:53 Details Diff |
BUG: Fix memory leak in qMRMLThreeDView removing unused code This commit removes code most likely inadvertently added during the refactoring done in r17602 (ENH: Add qMRMLThreeDWidget and qMRMLThreeDViewControllerWidget) This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==29339== 4,757 (48 direct, 4,709 indirect) bytes in 1 blocks are definitely lost in loss record 2,402 of 2,448 ==29339== at 0x4C2B0E0: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x5EAD8BC: qMRMLThreeDViewPrivate::init() (qMRMLThreeDView.cxx:80) ==29339== by 0x5EAE37C: qMRMLThreeDView::qMRMLThreeDView(QWidget*) (qMRMLThreeDView.cxx:227) ==29339== by 0x5EB59C6: qMRMLThreeDWidgetPrivate::init() (qMRMLThreeDWidget.cxx:84) ==29339== by 0x5EB5B76: qMRMLThreeDWidget::qMRMLThreeDWidget(QWidget*) (qMRMLThreeDWidget.cxx:102) ==29339== by 0x5E3E3C6: qMRMLLayoutThreeDViewFactory::createViewFromNode(vtkMRMLAbstractViewNode*) (qMRMLLayoutManager.cxx:76) ==29339== by 0x5E46804: qMRMLLayoutViewFactory::onViewNodeAdded(vtkMRMLAbstractViewNode*) (qMRMLLayoutViewFactory.cxx:373) ==29339== by 0x5E46A9A: qMRMLLayoutViewFactory::onSceneModified() (qMRMLLayoutViewFactory.cxx:423) ==29339== by 0x5E45FD2: qMRMLLayoutViewFactory::setMRMLScene(vtkMRMLScene*) (qMRMLLayoutViewFactory.cxx:255) ==29339== by 0x5E41C2A: qMRMLLayoutManager::setMRMLScene(vtkMRMLScene*) (qMRMLLayoutManager.cxx:838) ==29339== by 0x4E57B4D: qSlicerAppMainWindowPrivate::setupUi(QMainWindow*) (qSlicerAppMainWindow.cxx:320) ==29339== by 0x4E56C59: qSlicerAppMainWindowPrivate::init() (qSlicerAppMainWindow.cxx:122) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24442 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLThreeDView.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLThreeDView_p.h | Diff File | ||
|
master d8dafdfb 2015-07-17 01:00:51 Details Diff |
BUG: Fix memory leak in vtkMRMLLayoutNode This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==29339== 1,082 bytes in 1 blocks are definitely lost in loss record 2,290 of 2,448 ==29339== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0xE6E4563: vtkMRMLLayoutNode::SetCurrentLayoutDescription(char const*) (in /home/jcfr/Projects/Slicer-Debug/Slicer-build/bin/libMRMLCore.so) ==29339== by 0xE6E05B0: vtkMRMLLayoutNode::SetAndParseCurrentLayoutDescription(char const*) (vtkMRMLLayoutNode.cxx:285) ==29339== by 0xE6E04D6: vtkMRMLLayoutNode::UpdateCurrentLayoutDescription() (vtkMRMLLayoutNode.cxx:273) ==29339== by 0xE6DFB4C: vtkMRMLLayoutNode::SetViewArrangement(int) (vtkMRMLLayoutNode.cxx:203) ==29339== by 0x5E4212D: qMRMLLayoutManager::setLayout(int) (qMRMLLayoutManager.cxx:903) ==29339== by 0x4E59081: qSlicerAppMainWindowPrivate::readSettings() (qSlicerAppMainWindow.cxx:490) ==29339== by 0x4E56CDE: qSlicerAppMainWindowPrivate::init() (qSlicerAppMainWindow.cxx:127) ==29339== by 0x4E5A98D: qSlicerAppMainWindow::qSlicerAppMainWindow(QWidget*) (qSlicerAppMainWindow.cxx:676) ==29339== by 0x406553: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:184) ==29339== by 0x406D30: main (Main.cxx:254) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24441 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLLayoutNode.cxx | Diff File | ||
|
master 8fd2e920 2015-07-17 01:00:49 Details Diff |
BUG: Fix memory leak in vtkSlicerApplicationLogic This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==29339== 336 bytes in 1 blocks are possibly lost in loss record 2,088 of 2,448 ==29339== at 0x4C2CC70: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x4012E54: _dl_allocate_tls (dl-tls.c:296) ==29339== by 0x1E25BDA0: pthread_create@@GLIBC_2.2.5 (allocatestack.c:589) ==29339== by 0x18D6A33E: itk::MultiThreader::SpawnThread(void* (*)(void*), void*) (itkMultiThreaderPThreads.cxx:186) ==29339== by 0x9259575: vtkSlicerApplicationLogic::CreateProcessingThread() (vtkSlicerApplicationLogic.cxx:354) ==29339== by 0x8E82DC8: qSlicerCoreApplicationPrivate::init() (qSlicerCoreApplication.cxx:255) ==29339== by 0x59272A7: qSlicerApplicationPrivate::init() (qSlicerApplication.cxx:180) ==29339== by 0x5927FDF: qSlicerApplication::qSlicerApplication(int&, char**) (qSlicerApplication.cxx:319) ==29339== by 0x406039: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:125) ==29339== by 0x406D30: main (Main.cxx:254) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24440 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Logic/vtkSlicerApplicationLogic.cxx | Diff File | ||
| mod - Base/QTCore/qSlicerCoreApplication.cxx | Diff File | ||
|
master a064b4bc 2015-07-17 01:00:47 Details Diff |
BUG: Update VTK to include fix for memory leak in vtkSys SystemTools. See Slicer/VTK@4b46455 Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Date: Thu Jul 16 14:54:10 2015 -0400 KWSys-SystemTools: Fix memory leak in DetectFileType A more elaborated patch including update of the test case has been pushed upstream: http://review.source.kitware.com/#/c/20003 This commit fixes the leak found using valgrind memcheck tool: ==29339== 512 bytes in 2 blocks are definitely lost in loss record 2,179 of 2,448 ==29339== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x28396AB8: vtksys::SystemTools::DetectFileType(char const*, unsigned long, double) (SystemTools.cxx:4142) ==29339== by 0x1018F9229: vtkSlicerColorLogic::FindColorFiles(std::vector<std::string, std::allocator<std::string> > const&) (vtkSlicerColorLogic.cxx:177) ==29339== by 0x1018F86EA: vtkSlicerColorLogic::FindDefaultColorFiles() (vtkSlicerColorLogic.cxx:100) ==29339== by 0x9844613: vtkMRMLColorLogic::AddDefaultFileNodes() (vtkMRMLColorLogic.cxx:1016) ==29339== by 0x983DAF6: vtkMRMLColorLogic::AddDefaultColorNodes() (vtkMRMLColorLogic.cxx:144) ==29339== by 0x983D673: vtkMRMLColorLogic::OnMRMLSceneNewEvent() (vtkMRMLColorLogic.cxx:85) ==29339== by 0x983D629: vtkMRMLColorLogic::SetMRMLSceneInternal(vtkMRMLScene*) (vtkMRMLColorLogic.cxx:78) ==29339== by 0x982B4F9: vtkMRMLAbstractLogic::SetMRMLScene(vtkMRMLScene*) (vtkMRMLAbstractLogic.cxx:281) ==29339== by 0x8E70F0A: qSlicerAbstractCoreModule::setMRMLScene(vtkMRMLScene*) (qSlicerAbstractCoreModule.cxx:168) ==29339== by 0x101492780: qSlicerColorsModule::setMRMLScene(vtkMRMLScene*) (qSlicerColorsModule.cxx:132) ==29339== by 0x8EA2B1A: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:181) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24439 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_VTKv6.cmake | Diff File | ||
|
master 6fac40e3 2015-07-17 01:00:45 Details Diff |
BUG: Update CTK (include fix for memory leak in ctkDoubleSpinBox) Among other changes, it include fixes and improvement for: ctkColorPickerButton ctkDoubleSpinBox ctkVTKTextPropertyWidget ctkXNAT $ git shortlog 9e5af26..7bb708c --no-merges Andreas Fetzer (45): Initial commit Removed unused function declaration Added new class ctkXnatResourceFolder. Adapted documentation. Currently the remove() function does not modify the object on the server Added possibility to set a default file download path to ctkXnatSession. If the specified location does not exist its value will be set to the current working directory Since some of the ctkXnatObject support retrieving a last modification time (e.g. project) this function should be virtual so that is can be overwritten by the according subclasses Also check if path is empty Continued refactoring of the upload functions: Added convenience method for adding a resource to a xnatObject Enhanced xnatTreeBrowser so that resource creation and file upload can be tested Fixed build error and removed useless upload function from xnatTreeModel Some minor fixes. Added dirty flag to indicate whether a xnat object was modified Don't update the modified flag after an object was saved on the server and the ID was set afterwards cosmetic changes If a file with the given name already exits on the server set the overwrite flag to true Added rudimentary check whether the file upload was successful. Right now just the filesize is compared. Checksum would be better. Setting correct filename for upload Added file upload validation to saveImpl of ctkXnatFile Fixed iteration over md5 results Adapted add(child) function of ctkXnatObject Added function for adding a new child node to ctkXnatTreeModel Return resource folder after creation Added overwrite flag for file upload Use QXmlStreamReader instead of deprecated QXml module classes Some Qt5 adaptions Added tests for: Cleaned up code Fixed build error on Mac Removed unused modified flag again Further cleanup Fixed possible invalid directory path Improved check for valid directory path Removed function calls that were made for testing reasons Replaced for loop with iterators. Only add folder if it not exists Added refesh function to ctkXnatTreeModel Fixed crash which might happen if the xnatObject is null Added name and label getters to all XNAT folder objects Synchronize deleted objects as well Use iterator instead of foreach Fixed query parameters for httpPut Fixed build error on Mac OS X Added include for QScopedPointer and QObject Added include for QSharedPointer Benjamin BENEY (3): Add text size in ctkVTKTextPropertyWidget Change icon for invalid color in ctkColorPickerButton Fix ctkColorPickerButton build error Jean-Christophe Fillion-Robin (1): Fix memory leak associated with ctkDoubleSpinBox ensuring pimpl is deleted git-svn-id: http://svn.slicer.org/Slicer4/trunk@24438 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master 04c3069f 2015-07-17 01:00:43 Details Diff |
BUG: Fix memory leak in vtkMRMLSubjectHierarchyNode This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==29339== 6 bytes in 1 blocks are definitely lost in loss record 24 of 2,448 ==29339== at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x10599640D: vtkMRMLSubjectHierarchyNode::SetLevel(char const*) (in /home/jcfr/Projects/Slicer-Debug/Slicer-build/lib/Slicer-4.4/qt-loadable-modules/libvtkSlicerSubjectHierarchyModuleMRML.so) ==29339== by 0x10598C253: vtkMRMLSubjectHierarchyNode::vtkMRMLSubjectHierarchyNode() (vtkMRMLSubjectHierarchyNode.cxx:60) ==29339== by 0x10598C144: vtkMRMLSubjectHierarchyNode::New() (vtkMRMLSubjectHierarchyNode.cxx:52) ==29339== by 0x108325A18: vtkSmartPointer<vtkMRMLSubjectHierarchyNode>::New() (vtkSmartPointer.h:117) ==29339== by 0x1083235AC: vtkSlicerSubjectHierarchyModuleLogic::RegisterNodes() (vtkSlicerSubjectHierarchyModuleLogic.cxx:73) ==29339== by 0x982B519: vtkMRMLAbstractLogic::SetMRMLScene(vtkMRMLScene*) (vtkMRMLAbstractLogic.cxx:285) ==29339== by 0x8E70F0A: qSlicerAbstractCoreModule::setMRMLScene(vtkMRMLScene*) (qSlicerAbstractCoreModule.cxx:168) ==29339== by 0x8EA2B1A: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:181) ==29339== by 0x8EA2586: qSlicerModuleFactoryManager::loadModule(QString const&) (qSlicerModuleFactoryManager.cxx:110) ==29339== by 0x40672A: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:193) ==29339== by 0x406D30: main (Main.cxx:254) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24437 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.cxx | Diff File | ||
|
master 3dba92ad 2015-07-17 01:00:41 Details Diff |
BUG: Fix uninitialized value in vtkMRMLColorTableNode. Within vtkMRMLColorTableStorageNode::ReadDataInternal(), the method vtkMRMLColorTableNode::SetColor() is called iteratively for all entries to initialize the color names. In the same time, within SetColor(), the method SetNamesFromColors() is also called. This last call to SetNamesFromColors() is the problematic one. Indeed, it attempts to initialize the color name for all entries while color values are being set. Since all color names are explicitly initialized, this commit removes the call to "SetNamesFromColors()" from "SetColor()" function. This commit fixes the error(s) reported below by valgrind memcheck tool. Valgrind was used on Ubuntu 14.04 against a Debug build of Slicer. It was exected doing the following: (1) Start a terminal with the appropriate environment: ./Slicer --gnome-terminal (2) Start Slicer using valgrind: valgrind --log-file=2015-07-16-Slicer-memcheck.txt --tool=memcheck --leak-check=yes ./bin/SlicerApp-real --disable-python --disable-cli-modules (3) Exit Slicer and inspect valgrind log file Valgrind error: ==17091== Conditional jump or move depends on uninitialised value(s) ==17091== at 0x2A67C4E7: __printf_fp (printf_fp.c:400) ==17091== by 0x2A67B792: vfprintf (vfprintf.c:1660) ==17091== by 0x2A69F578: vsnprintf (vsnprintf.c:119) ==17091== by 0x2A196E0F: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19) ==17091== by 0x2A19D263: std::ostreambuf_iterator<char, std::char_traits<char> > std::num_put<char, std::ostreambuf_iterator<char, std::char_traits<char> > >::_M_insert_float<double>(std::ostreambuf_iterator<char, std::char_traits<char> >, std::ios_base&, char, char, double) const (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19) ==17091== by 0x2A19D54F: std::num_put<char, std::ostreambuf_iterator<char, std::char_traits<char> > >::do_put(std::ostreambuf_iterator<char, std::char_traits<char> >, std::ios_base&, char, double) const (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19) ==17091== by 0x2A1A8AF4: std::ostream& std::ostream::_M_insert<double>(double) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19) ==17091== by 0xDB0E07B: vtkMRMLColorNode::SetNameFromColor(int) (vtkMRMLColorNode.cxx:312) ==17091== by 0xDB0DEBD: vtkMRMLColorNode::SetNamesFromColors() (vtkMRMLColorNode.cxx:295) ==17091== by 0xDB1CF37: vtkMRMLColorTableNode::SetColor(int, char const*, double, double, double, double) (vtkMRMLColorTableNode.cxx:1301) ==17091== by 0xDB1F84D: vtkMRMLColorTableStorageNode::ReadDataInternal(vtkMRMLNode*) (vtkMRMLColorTableStorageNode.cxx:146) ==17091== by 0xDCDE6D5: vtkMRMLStorageNode::ReadData(vtkMRMLNode*, bool) (vtkMRMLStorageNode.cxx:1067) ==17091== Uninitialised value was created by a heap allocation ==17091== at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==17091== by 0x299257A3: vtkDataArrayTemplate<unsigned char>::Allocate(long long, long long) (vtkDataArrayTemplate.txx:137) ==17091== by 0x29928227: vtkDataArrayTemplate<unsigned char>::SetNumberOfValues(long long) (vtkDataArrayTemplate.txx:921) ==17091== by 0x29925A27: vtkDataArrayTemplate<unsigned char>::SetNumberOfTuples(long long) (vtkDataArrayTemplate.txx:355) ==17091== by 0x2986995A: vtkLookupTable::SetNumberOfTableValues(long long) (vtkLookupTable.cxx:1045) ==17091== by 0xDB1C6B5: vtkMRMLColorTableNode::SetNumberOfColors(int) (vtkMRMLColorTableNode.cxx:1241) ==17091== by 0xDB1F783: vtkMRMLColorTableStorageNode::ReadDataInternal(vtkMRMLNode*) (vtkMRMLColorTableStorageNode.cxx:137) ==17091== by 0xDCDE6D5: vtkMRMLStorageNode::ReadData(vtkMRMLNode*, bool) (vtkMRMLStorageNode.cxx:1067) ==17091== by 0xC9CD058: vtkMRMLColorLogic::CreateFileNode(char const*) (vtkMRMLColorLogic.cxx:730) ==17091== by 0xC9CC104: vtkMRMLColorLogic::CreateFreeSurferFileNode(char const*) (vtkMRMLColorLogic.cxx:593) ==17091== by 0xC9CE463: vtkMRMLColorLogic::AddFreeSurferFileNode(vtkMRMLFreeSurferProceduralColorNode*) (vtkMRMLColorLogic.cxx:863) ==17091== by 0xC9CF282: vtkMRMLColorLogic::AddFreeSurferNodes() (vtkMRMLColorLogic.cxx:987) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24436 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLColorTableNode.cxx | Diff File | ||
| mod - Libs/MRML/Logic/vtkMRMLColorLogic.cxx | Diff File | ||
|
master f992c028 2015-07-17 01:00:38 Details Diff |
STYLE: Improve output of vtkMRMLColorLogicTest1 displaying line number git-svn-id: http://svn.slicer.org/Slicer4/trunk@24435 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest1.cxx | Diff File | ||
|
master a90d64e4 2015-07-16 13:29:45 Details Diff |
ENH: Allow qMRMLNodeComboBox base name setting for each node type git-svn-id: http://svn.slicer.org/Slicer4/trunk@24434 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest4.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLNodeComboBox.h | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLNodeFactory.cxx | Diff File | ||
|
master 41453562 2015-07-16 00:34:07 Details Diff |
BUG: Fix uninitialized value in vtkSlicerVolumesLogic. This commit fix the following error reported by valgrind memcheck tool: ==1290== ==1290== Conditional jump or move depends on uninitialised value(s) ==1290== at 0x3E5C64FA: vtkSlicerVolumesLogic::SetCompareVolumeGeometryEpsilon(double) (vtkSlicerVolumesLogic.cxx:1042) ==1290== by 0x3E5C35BE: vtkSlicerVolumesLogic::vtkSlicerVolumesLogic() (vtkSlicerVolumesLogic.cxx:472) ==1290== by 0x3E5C22B4: vtkSlicerVolumesLogic::New() (vtkSlicerVolumesLogic.cxx:279) ==1290== by 0x436D557F: qSlicerVolumesModule::createLogic() (qSlicerVolumesModule.cxx:167) ==1290== by 0x5D60DC1: qSlicerAbstractCoreModule::logic() (qSlicerAbstractCoreModule.cxx:280) ==1290== by 0x5D603AD: qSlicerAbstractCoreModule::initialize(vtkSlicerApplicationLogic*) (qSlicerAbstractCoreModule.cxx:99) ==1290== by 0x5D928A7: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:170) ==1290== by 0x5D92759: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:157) ==1290== by 0x5D92414: qSlicerModuleFactoryManager::loadModule(QString const&) (qSlicerModuleFactoryManager.cxx:110) ==1290== by 0x406B81: (anonymous namespace)::SlicerAppMain(int, char**) (Main.cxx:231) ==1290== by 0x407213: main (Main.cxx:292) ==1290== git-svn-id: http://svn.slicer.org/Slicer4/trunk@24433 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx | Diff File | ||
|
master 0ff04434 2015-07-15 17:25:13 Details Diff |
BUG: Update SimpleFilters with patches for LabelMapVolume node changes. 48b7873 Remove input based automatic LabelMap output restriction. c90a778 Replace LabelMap checkbox with option in output combo box d3f3bf1 Restore support for label map volumes as input a560064 Correct nodeType to be a list of one element. 2f392a5 Update to use new MRMLLabelmapNode From: Bradley Lowekamp <blowekamp@mail.nih.gov> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24432 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 656bb7e0 2015-07-15 16:51:22 Details Diff |
ENH: Creating Qt designer plugin for qSlicerSimpleMarkupsWidget From: Matthew Holden <mholden8@cs.queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24431 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/Widgets/DesignerPlugins/CMakeLists.txt | Diff File | ||
| mod - Modules/Loadable/Markups/Widgets/DesignerPlugins/qSlicerMarkupsModuleWidgetsPlugin.h | Diff File | ||
| add - Modules/Loadable/Markups/Widgets/DesignerPlugins/qSlicerSimpleMarkupsWidgetPlugin.cxx | Diff File | ||
| add - Modules/Loadable/Markups/Widgets/DesignerPlugins/qSlicerSimpleMarkupsWidgetPlugin.h | Diff File | ||
|
master 07122581 2015-07-15 16:51:20 Details Diff |
BUG: Allow qSlicerSimpleMarkupsWidget to be instantiated without Slicer app From: Matthew Holden <mholden8@cs.queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24430 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx | Diff File | ||
