Changesets: Import 2017-06-07 23:51:09
|
master 50fd3ed5 2016-01-19 12:34:44 Details Diff |
BUG: Fix ResampleScalarVectorDWIVolume tests removing usage of dynamic_cast. This commit fixes a regression introduced by InsightSoftwareConsortium/ITK@d1e9fe2 (BUG: Ensure Transform IO factories are registered once.) and integrated in r24836 (ENH: Update ITKv4 to v4.9.0 release branch). Following this ITK commit, the ITKIO transform libraries are build as shared and dynamic_cast can NOT be used with templated classes that are instantiated in a translation unit different than the one where they are defined. It will work only if the classes are explicitly instantiated and exported. To workaround the issue, code that was relying on dynamic_cast is updated to (1) ensure the objects are of the right type doing string comparison and (2) then use static_cast instead of dynamic_cast. This commit fixes the following tests compiled using gcc 4.4.3 and executed on Ubuntu 10.04: ResampleScalarVectorDWIVolumeBSplineInterpolationTest ResampleScalarVectorDWIVolumeBSplineWSInterpolationTest ResampleScalarVectorDWIVolumeRotationAndAffineTest ResampleScalarVectorDWIVolumeRotationNNTest git-svn-id: http://svn.slicer.org/Slicer4/trunk@24880 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/ResampleScalarVectorDWIVolume/ResampleScalarVectorDWIVolume.cxx | Diff File | ||
|
master 799041a3 2016-01-19 12:34:42 Details Diff |
STYLE: ResampleScalarVectorDWIVolume: Remove unused conversion to float. Since the transform reader is of type double, transform are always read as double independently of the type (double or float) reported in the transform file, this commit removes the corresponding code in "SetTransformAndOrder" function. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24879 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/ResampleScalarVectorDWIVolume/ResampleScalarVectorDWIVolume.cxx | Diff File | ||
|
master e3fac411 2016-01-19 12:34:40 Details Diff |
BUG: Fix ResampleDTI tests removing usage of dynamic_cast. This commit fixes a regression introduced by r24836 (ENH: Update ITKv4 to v4.9.0 release branch). Following the ITK update, the ITKIO transform libraries are build as shared and dynamic_cast can NOT be used with classes that are not explicitly instantiated and exported. Following this ITK commit, the ITKIO transform libraries are build as shared and dynamic_cast can NOT be used with templated classes that are instantiated in a translation unit different than the one where they are defined. It will work only if the classes are explicitly instantiated and exported. To workaround the issue, code that was relying on dynamic_cast is updated to (1) ensure the objects are of the right type doing string comparison and (2) then use static_cast instead of dynamic_cast. See InsightSoftwareConsortium/ITK@d1e9fe2 and see http://stackoverflow.com/questions/8024010/why-do-template-class-functions-have-to-be-declared-in-the-same-translation-unit This commit fixes the following tests compiled using gcc 4.4.3 and executed on Ubuntu 10.04: ResampleDTIVolumeRotationNNTest ResampleDTIVolume2RigidTransformsLinearTest ResampleDTIVolumeBSplineWSInterpolationTest ResampleDTIVolumeBSplineInterpolationTest git-svn-id: http://svn.slicer.org/Slicer4/trunk@24878 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/ResampleDTIVolume/ResampleDTIVolume.cxx | Diff File | ||
|
master 471cbdb8 2016-01-19 12:34:38 Details Diff |
BUG: ResampleDTIVolume: Fix "GetNameOfClass()" of itkDiffusion3D classes. This commit adds "itkTypeMacro" to all itkDiffusion3D classes so that method GetNameOfClass() returns the name of the class instead of "Object". git-svn-id: http://svn.slicer.org/Slicer4/trunk@24877 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DAbsCorrection.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DAffineTransform.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DBSplineInterpolateImageFunction.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DExtended.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DFSAffineTransform.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunction.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunctionReimplementation.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DLinearInterpolateFunction.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DMatrix3x3Transform.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestCorrection.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestNeighborInterpolateFunction.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNonRigidTransform.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DPPDAffineTransform.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRead.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DResample.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRigidTransform.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DTransform.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWindowedSincInterpolateImageFunction.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWrite.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DZeroCorrection.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkSeparateComponentsOfADiffusionTensorImage.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkTransformDeformationFieldFilter.h | Diff File | ||
| mod - Modules/CLI/ResampleDTIVolume/itkWarpTransform3D.h | Diff File | ||
|
master 77d114da 2016-01-19 12:34:32 Details Diff |
STYLE: ResampleDTIVolume: Remove unused conversion to float transform. Since the transform reader is of type double, transform are always read as double independently of the type (double or float) reported in the transform file, this commit removes the corresponding code in "SetTransformAndOrder" function. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24876 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/ResampleDTIVolume/ResampleDTIVolume.cxx | Diff File | ||
|
master 12743c6f 2016-01-19 12:34:30 Details Diff |
BUG: Fix transform tests by not using dynamic_cast in vtkITKTransformConverter This commit fixes a regression introduced by InsightSoftwareConsortium/ITK@d1e9fe2 (BUG: Ensure Transform IO factories are registered once.) and integrated in r24836 (ENH: Update ITKv4 to v4.9.0 release branch). Following this ITK commit, the ITKIO transform libraries are build as shared and dynamic_cast can NOT be used with templated classes that are instantiated in a translation unit different than the one where they are defined. It will work only if the classes are explicitly instantiated and exported. To workaround the issue, code that was relying on dynamic_cast is updated to (1) ensure the objects are of the right type doing string comparison and (2) then use static_cast instead of dynamic_cast. See InsightSoftwareConsortium/ITK@d1e9fe2 and see http://stackoverflow.com/questions/8024010/why-do-template-class-functions-have-to-be-declared-in-the-same-translation-unit This commit fixes the following tests: vtkSlicerTransformLogicTest1 vtkMRMLNonlinearTransformNodeTest1 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24875 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkITKTransformConverter.h | Diff File | ||
|
master fedf3cd9 2016-01-19 12:34:28 Details Diff |
STYLE: Refactor vtkITKTransformConverter to consistently template over type This commit introduces the template function "ReadFromTransformFile()" allowing to test reading of float or double transforms avoiding dynamic_cast from "TransformBaseTemplate<float>*" to "TransformBaseTemplate<double>*". It also: * renames typedefs used for conversion from VTK to ITK to explicitly include the "Double" suffix. * update ReadFromITKv3BSplineTransformFile() function to read ITKv3 transform as double. Suggested-by: Matt McCormick <matt.mccormick@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24874 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkITKTransformConverter.h | Diff File | ||
| mod - Libs/MRML/Core/vtkITKTransformInverse.h | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.cxx | Diff File | ||
|
master 9d1855b8 2016-01-18 15:01:08 Details Diff |
ENH: Hide subject hierarchy nodes by default If subject hierarchy was enabled it made working in Data module very difficult due to the many SH nodes that showed up for every supported data node. Now the SH nodes are by default hidden, but can be shown by checking show hidden nodes. Testing was performed and no issues were found regarding this change. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24873 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSortFilterSubjectHierarchyProxyModel.cxx | Diff File | ||
|
master 9ef07534 2016-01-16 15:56:28 Details Diff |
BUG: Fixed regression for handling external layout managers The regression was introduced in rev24418 that broke the slicelet support for slice view annotations introduced in rev24259. Added two safety checks to avoid errors. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24872 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py | Diff File | ||
|
master c88f824f 2016-01-16 00:33:35 Details Diff |
BUG: Prevent changing window/level while adding markup point Users often accidentally changed window/level of the image when added markup points (because they accidentally dragged the mouse when clicked with the left button). Now we only change window/level in default mode (vtkMRMLInteractionNode::ViewTransform). git-svn-id: http://svn.slicer.org/Slicer4/trunk@24871 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/DisplayableManager/vtkSliceViewInteractorStyle.cxx | Diff File | ||
| mod - Libs/MRML/DisplayableManager/vtkSliceViewInteractorStyle.h | Diff File | ||
|
master 5feacf7e 2016-01-14 22:59:41 Details Diff |
BUG: Fixed export in LabelStatistics Updated file that was accidentally missed in the previous commit. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24870 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/LabelStatistics/CMakeLists.txt | Diff File | ||
|
master d593fa2c 2016-01-14 22:57:20 Details Diff |
BUG: Fixed export in LabelStatistics Updated file that was accidentally missed in the previous commit. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24869 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/LabelStatistics/LabelStatistics.py | Diff File | ||
|
master 054337a7 2016-01-14 10:36:32 Details Diff |
BUG: Fixed export in LabelStatistics Also updated LabelStatistics to use the standard scripted module template: now the module is reloadable, has an icon, and code parts were removed that were already available in the module base classes. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24868 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| add - Modules/Scripted/LabelStatistics/Resources/Icons/LabelStatistics.png | Diff File | ||
| add - Modules/Scripted/LabelStatistics/Testing/CMakeLists.txt | Diff File | ||
| add - Modules/Scripted/LabelStatistics/Testing/Python/CMakeLists.txt | Diff File | ||
|
master 7a44ad25 2016-01-13 16:43:00 Details Diff |
ENH: update DCMTK hash The DCMTK update fixes incorrect bit packing order, which would render invalid any segmentation object created with its API. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24867 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master 99afc850 2016-01-13 16:36:07 Details Diff |
BUG: 0004127 need to check transforms when checking geometry match http://www.na-mic.org/Bug/view.php?id=4127 From: Steve Pieper <pieper@isomics.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24866 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx | Diff File | ||
| mod - Modules/Scripted/LabelStatistics/LabelStatistics.py | Diff File | ||
|
master d254fdfb 2016-01-12 12:38:36 Details Diff |
BUG: Fixed SH node creation if there are multiple series node for the same series UID In some cases there might be multiple subject hierarchy nodes for the same DICOM series, for example if a series contains instances that load to different node types that cannot be simply added under one series folder node. This can happen if for one type the node corresponds to the series, but in the other to the instances, like segmentation nodes vs markup nodes under a folder node. Fixed SubjectHierarchyGenericSelfTest that failed due to empty scene object in scene model git-svn-id: http://svn.slicer.org/Slicer4/trunk@24865 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyGenericSelfTest.py | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx | Diff File | ||
|
master 3eb19c2c 2016-01-10 21:47:45 Details Diff |
ENH: Update ITK cherry-picking "BridgeOpenCV" and "CentOS build" fixes $ git shortlog 51760b2..619f991 --no-merges Matthew McCormick (2): ENH: Allow ITKVideoBridgeOpenCV to be built externally. COMP: Add export specification for itk::ResourceProbe. Sean McBride (1): DOC: Update some woefully out-of-date GDCM comments, and typos Seun Odutola (1): BUG: Improved itkAnalyzeImageIO to handle case insensitive extensions git-svn-id: http://svn.slicer.org/Slicer4/trunk@24864 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_ITKv4.cmake | Diff File | ||
|
master 674c9a47 2016-01-10 21:33:53 Details Diff |
STYLE: Ensure MRML testing data can be found by SlicerDMRI. This commit workarounds a regression introduced in r24855 (ENH: Add SlicerDMRI remote module). Ultimately, testing data required by SlicerDMRI remote module tests should be either explicitly copied into the remote module source tree or downloaded using ExternalData. This is tracked by SlicerDMRI/SlicerDMRI#18. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24863 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/CMakeLists.txt | Diff File | ||
|
master 1391f4f7 2016-01-08 18:00:33 Details Diff |
STYLE: Refactor vtkSlicerVolumesLogicTest1 From: Alexis Girault <alexis.girault@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24862 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/Testing/Cxx/vtkSlicerVolumesLogicTest1.cxx | Diff File | ||
|
master 2525fc24 2016-01-08 18:00:30 Details Diff |
BUG: Fix display node copy in CloneVolume Motivation : If a volume is rendered through the Volume Rendering volume module then cropped through the Crop Volume module, it is not possible to display the volume rendering of the cropped volume: the original volume would be displayed instead. Reason : In the Crop Volume module, the method `vtkSlicerVolumesLogic::CloneVolume` was called. The volume and its first display node were cloned using `vtkMRMLVolumeNode::CopyWithScene`, but the remaining display nodes were ignored. This was resulting in having a cloned volume with references to the original volume display nodes. In the case above, the display node of type vtkMRMLVolumeRenderingDisplayNode was the same for the cropped and original volumes, referencing the original volume for both of them. Fix : In this commit only the first display node is cloned, and the other display nodes are removed. Cloning a vtkMRMLVolumeRenderingDisplayNode would not be as straightforward as copying a vtkMRMLVolumeDisplayNode since the display node itself has a VolumeNodeID, a ROINodeID and a VolumePropertyNodeID that would need to be created/updated. This fixes the issue 4109: http://na-mic.org/Mantis/view.php?id=4109 From: Alexis Girault <alexis.girault@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24861 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx | Diff File | ||
|
master bdbaeca7 2016-01-08 14:38:48 Details Diff |
STYLE: qMRMLTableView: Simplify code introducing "Run Check macros. Reviewed-by: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24860 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLTableView.cxx | Diff File | ||
|
master 53383ba1 2016-01-08 14:38:46 Details Diff |
STYLE: qMRMLTableView: Use Q_FUNC_INFO instead of hardcoded function name See http://doc.qt.io/qt-4.8/qtglobal.html#Q_FUNC_INFO Reviewed-by: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24859 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLTableView.cxx | Diff File | ||
|
master e22e2e3c 2016-01-08 14:38:43 Details Diff |
STYLE: qMRMLTableView: Prefer function instead of macro For sake of consistency with the rest of the code base, this commit remove the macro introduced in r24783 (ENH: Added support for Tables) and instead use a function. Reviewed-by: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24858 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLTableView.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLTableView_p.h | Diff File | ||
|
master 5d4ae92c 2016-01-08 14:15:25 Details Diff |
STYLE: CLIEvent testing This is a test that shows how Slicer handles CLI events. Note that this only reflects how the application works now. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24857 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| add - Applications/SlicerApp/Testing/Python/CLIEventTest.py | Diff File | ||
| mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt | Diff File | ||
| mod - Base/QTCLI/Testing/CLIModule4Test.xml | Diff File | ||
|
master 2b512c8d 2016-01-08 14:15:23 Details Diff |
COMP: Ensure CLI tests pass independently of Slicer_BUILD_CLI This commit updates the tests introduced in r24834 (BUG: Fix CLI running issues and add tests to prevent future regression). by using "CLI4Test" instead of "ThresholdScalarVolume". This ensures that the tests "TwoCLIsInARowTest" and "TwoCLIsInParallelTest" always work if Slicer_BUILD_CLI_SUPPORT is ON and Slicer_BUILD_CLI is OFF. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24856 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt | Diff File | ||
| mod - Applications/SlicerApp/Testing/Python/TwoCLIsInARowTest.py | Diff File | ||
| mod - Applications/SlicerApp/Testing/Python/TwoCLIsInParallelTest.py | Diff File | ||
