Changesets: Import 2017-06-07 23:51:09

master 3d8c0a80

2016-03-21 18:53:47

jcfr

Details Diff
STYLE: SlicerExtensionPackageAndUploadTarget: Display location of log

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24980 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerExtensionPackageAndUploadTarget.cmake Diff File

master 57cf4d70

2016-03-21 18:53:45

jcfr

Details Diff
STYLE: SlicerExtensionPackageAndUploadTarget: Improve documentation

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24979 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerExtensionPackageAndUploadTarget.cmake Diff File

master 2dc8e7da

2016-03-21 18:53:43

jcfr

Details Diff
STYLE: Remove unneeded check for "ctest_upload" command

This code is now required anymore since the CMake minimum required
version (2.8.9) provided the command.

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24978 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerDashboardDriverScript.cmake Diff File
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File

master e95cfd6e

2016-03-21 18:48:40

jcfr

Details Diff
COMP: Fix -Wnarrowing and -Wunused-variable warnings

/path/to/Slicer/Modules/Loadable/Tables/qSlicerTablesModuleWidget.cxx: In member function ‘void qSlicerTablesModuleWidget::onMRMLTableNodeModified(vtkObject*)’:
/path/to/Slicer/Modules/Loadable/Tables/qSlicerTablesModuleWidget.cxx:167:21: warning: unused variable ‘tableNode’ [-Wunused-variable]
vtkMRMLTableNode* tableNode = vtkMRMLTableNode::SafeDownCast(caller);
^

/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLOrientationMarkerDisplayableManager.cxx: In member function ‘void vtkMRMLOrientationMarkerDisplayableManager::vtkInternal::UpdateMarkerSize()’:
/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLOrientationMarkerDisplayableManager.cxx:511:38: warning: narrowing conversion of ‘(maxX - minX)’ from ‘double’ to ‘int’ inside { } is ill-formed in C++11 [-Wnarrowing]
int rendererSizeInPixels[2] = {maxX-minX, maxY-minY};
^
/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLOrientationMarkerDisplayableManager.cxx:511:49: warning: narrowing conversion of ‘(maxY - minY)’ from ‘double’ to ‘int’ inside { } is ill-formed in C++11 [-Wnarrowing]
int rendererSizeInPixels[2] = {maxX-minX, maxY-minY};
^
/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx: In member function ‘void vtkMRMLRulerDisplayableManager::vtkInternal::UpdateRuler()’:
/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx:289:42: warning: narrowing conversion of ‘(maxX - minX)’ from ‘double’ to ‘int’ inside { } is ill-formed in C++11 [-Wnarrowing]
int rendererSizeInPixels[2] = {maxX-minX, maxY-minY};
^
/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx:289:53: warning: narrowing conversion of ‘(maxY - minY)’ from ‘double’ to ‘int’ inside { } is ill-formed in C++11 [-Wnarrowing]
int rendererSizeInPixels[2] = {maxX-minX, maxY-minY};
^

/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx: In member function ‘void vtkMRMLRulerDisplayableManager::vtkInternal::SetupRuler()’:
/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx:213:13: warning: unused variable ‘numberOfTickLines’ [-Wunused-variable]
const int numberOfTickLines = 11;
^

/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx:281:15: warning: unused variable ‘viewport’ [-Wunused-variable]
double* viewport = this->MarkerRenderer->GetViewport();
^

/path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx:338:79: warning: narrowing conversion of ‘rulerLineMarginPixel’ from ‘int’ to ‘double’ inside { } is ill-formed in C++11 [-Wnarrowing]
double pointOrigin[3] = {double(viewWidthPixel)/2.0, rulerLineMarginPixel, 0};

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24977 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLOrientationMarkerDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLRulerDisplayableManager.cxx Diff File
mod - Modules/Loadable/Tables/qSlicerTablesModuleWidget.cxx Diff File

master 901b1bbb

2016-03-21 18:48:38

jcfr

Details Diff
COMP: Fix -Wunused-parameter warning in vtkMRMLScene test

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24976 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLSceneImportIDModelHierarchyParentIDConflictTest.cxx Diff File

master d250196c

2016-03-21 18:48:36

jcfr

Details Diff
COMP: vtkITK: Fix -Wsign-compare and -Wmaybe-uninitialized warnings

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24975 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkLevelTracingImageFilter.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAffineImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationHelper.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkInitialImageToImageRegistrationMethod.txx Diff File

master 8694c131

2016-03-21 18:48:33

jcfr

Details Diff
ENH: Modernizing vcl_ to std::

In all supported compilers, the need for vcl_ specialized
functions has been removed. there is no longer a need
to have these overrides, and code is easier to read
and easier to maintain without these specializations.

The vcl_* definitions can now be greatly simplified.
After removing specializations for early non-conformant
c++ compilers the end result was that only the
std:: version of the functions could ever be
used by the compiler.

ITK_SCRIPT=ITK/Utilities/Maintenance/VCL_ModernizeNaming.py
SRC_BASE_DIR=$(pwd)
for ext in ".h" ".cxx" ".cpp" ".hxx" ".hpp" ".txx"; do
find ${SRC_BASE_DIR} -type f -name "*${ext}" \ -exec python ${ITK_SCRIPT} {} \;
done

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24974 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.h Diff File
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.txx Diff File
mod - Libs/vtkITK/vtkITKNumericTraits.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarityLandmarkBasedTransformInitializer.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageRegionMomentsCalculator.txx Diff File
mod - Modules/CLI/N4ITKBiasFieldCorrection/N4ITKBiasFieldCorrection.cxx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DFSAffineTransform.txx Diff File

master 63f4b9ba

2016-03-18 13:41:00

pieper

Details Diff
BUG: 0004162 check return value of zlib compression

Make sure there is a valid compressed buffer before using the
results.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24973 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/Logic/vtkImageStash.cxx Diff File
mod - Modules/Scripted/EditorLib/Logic/vtkImageStash.h Diff File

master ff72ded7

2016-03-17 15:50:21

pinter

Details Diff
ENH: Added GetNodeReferenceRoles to MRML node to get list of references

Also minor changes in qMRMLTableModel to make it more readable, and set Modified event when checkbox is changed in boolean column.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24972 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File
mod - Libs/MRML/Widgets/qMRMLTableModel.cxx Diff File

master 846a6547

2016-03-15 12:50:40

pinter

Details Diff
ENH: Implemented storage for special boolean column type in vtkMRMLTableNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24971 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLTableStorageNode.cxx Diff File

master c0bca601

2016-03-14 17:54:48

pinter

Details Diff
ENH: Add special column type in qMRMLTableView to display checkboxes for boolean values

If a vtkBitArray is added as a column to vtkMRMLTableNode, then qMRMLTableView shows a checkbox instead of 0/1 text to make it easier to edit.
In the future color, position, and other data will possibly be added as further types. The mentioned two will be the same value type (double array), so will need to specify not just type but display option too.
qMRMLTableItemDelegate that will deliver this functionality is removed form the repository (it was temporarily added in the previous commit so that it can be accessed and uesd later).
Commented out lines were removed from other classes. Having commented code in the repository makes no sense: the repository itself can be used as a history, no need for three year old comments to make the code harder to read.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24970 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLTableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableNode.h Diff File
mod - Libs/MRML/Widgets/CMakeLists.txt Diff File
mod - Libs/MRML/Widgets/qMRMLColorModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLItemDelegate.cxx Diff File
rm - Libs/MRML/Widgets/qMRMLTableItemDelegate.cxx Diff File
rm - Libs/MRML/Widgets/qMRMLTableItemDelegate.h Diff File
mod - Libs/MRML/Widgets/qMRMLTableModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLTableModel.h Diff File

master b6360317

2016-03-14 17:47:58

pinter

Details Diff
ENH: Added delegate temporarily for qMRMLTableView

Will be removed in next commit. Created to enable special editing of vtkMRMLTableNode cells in qMRMLTableView. This will be useful later for color editing, or if a better solution will be found for checkboxes. This delegate shows a checkbox in the center of the table cell (by default it is on the left), but only allows editing after double click. Thus this will be replaced by simple Qt mechanism with the checkbox on the left.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24969 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/CMakeLists.txt Diff File
add - Libs/MRML/Widgets/qMRMLTableItemDelegate.cxx Diff File
add - Libs/MRML/Widgets/qMRMLTableItemDelegate.h Diff File

master fc584fa9

2016-03-10 20:11:06

jcfr

Details Diff
ENH: Update qMRMLChartView to expose jqplot marker size and line width options

Exposes two new options from jqplot:

* 'size' allows to select the size of the marker
* 'lineWidth' allows to select the width of a line.

This allows to change these options when using qMRMLChartView. Both
properties should be set with a string containing an integer (greater
than 0).

From: Francois Budin <francois.budin@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24968 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLChartNode.h Diff File
mod - Libs/MRML/Widgets/qMRMLChartView.cxx Diff File

master 6c3b4017

2016-03-10 15:12:41

pinter

Details Diff
BUG: Fixed table view Qt designer plugin

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24967 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/DesignerPlugins/CMakeLists.txt Diff File
mod - Libs/MRML/Widgets/DesignerPlugins/qMRMLTableViewPlugin.h Diff File
mod - Libs/MRML/Widgets/DesignerPlugins/qMRMLWidgetsPlugin.h Diff File

master b9c3c641

2016-03-10 15:08:56

jcfr

Details Diff
COMP: Extension: Generate CTestConfig for both top-level and inner build dir

This commit ensures that extension with a superbuild structure but without
a CTestConfig file in their source tree can be built.

Reviewed-by: Nicole Aucoin <nicole@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24966 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File

master 97f63eef

2016-03-10 14:24:07

pinter

Details Diff
BUG: Fixed class name criteria mode for findChildren

See http://slicer-devel.65872.n3.nabble.com/Changing-the-behavior-of-slicer-util-findChildren-td4036266.html

From: Jorge Onieva

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24965 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File

master b33f87bb

2016-03-10 13:09:30

jcfr

Details Diff
BUG: Update BRAINSTools to fix mask checks

This should resolve the regression introduced in r24963 that caused failing
EMSegment test. The problem was identified and solution proposed by @jcfr

$ git shortlog 29d203c...16526a5 --no-merges
Andrey Fedorov (1):
BUG: fix mask checks for centerOfROI initializer

From: Andrey Fedorov <fedorov@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24964 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master a6f34123

2016-03-09 15:42:59

jcfr

Details Diff
BUG: Update BRAINSTools to include BRAINSFit fix for centerOfROI initializer

Tested-by: Hans Johnson <hans-johnson@uiowa.edu>

$ git shortlog e257e62...29d203c --no-merges
Alexander Leinoff (5):
COMP: BCD should only request VTK when building GUI
COMP: CompareImageFilter should only use VTK when building GUI
BUG: Replaces all baselines for BCDTests
BUG: Fixes typo in previous commit
BUG: Fixes version check in top level CMAKELists.txt

Ali Ghayoor (13):
ENH: Upgrade vnl_powell to itkPowellOptimizerv4 in BCD
ENH: Write the debug image based on requested debug level
ENH: BCD can process input images with different dynamic range
ENH: Change tolerance and step size for Powell optimizer
BUG: Fixed a bug in BABC when a low debugLevel requested
ENH: New parameters for multimodal segmentation in BABC
ENH: Updated purePlugsThreshold value for AutoWorkup
BUG: fixed a bug in BABC denoise filtering
ENH: Initialize a matrix variable
ENH: remove an intermediate variable to avoid extra memory usage
BUG: defined an orderedmap class for BABC
STYLE: Cleanup unnecessary if statement
ENH: Prevent holes in created brain mask by ROIAutoFilter

Andrey Fedorov (2):
BUG: fix centerOfROI initializer
ENH: adjust restriction on the required registration phases

Hans J. Johnson (40):
ENH: Update ITK, ANTS, and teem
STYLE: Remove MinSizeRel option
COMP: Resolve clang static analysis warnings
BUG: Compilation error fixed due to typo.
ENH: Update external tools support.
COMP: Improve coverage by using removeIntensityOutliers flag.
COMP: Force C++11 compliance testing
COMP: Added compatibility testing with apple and CXX11
BUG: Nipype now reqires invert_initial_moving_transform to be set
ENH: Selection of denoising filter improved.
ENH: Changed options to reflect current processing
ENH: Updated ANTs for improved DenoiseImage
BUG: The Rician noise model fails for DenoiseImage
ENH: Added key files for new denoised gaussian images.
ENH: Use denoised images for atlas reference
ENH: Add atlas images to reference atlas.
ENH: Fine-tune denoising options in BAW.
BUG: Need to work around nipype bug
ENH: Use denoised t1 from atlas for registration
ENH: Return to using Rician de-noising from ANTs
BUG: Error in respecting the NSLOTS variable
PERF: Constrain memory usage for KNN phase
PERF: Update ABC workflow to reflect memory with KNN
BUG: Serialize printing from threaded sections
STYLE: Print table consistently
BUG: Need to pass all denoised images into BRAINSABC
STYLE: Make usage of variable names consistent
STYLE: Cleanup unsuded ComputeLabels references
BUG: Internal ordering for dictionary missed first element
BUG: This is an unsatisfactory solution
BUG: Fix to allow all allocated slots to be used
ENH: Consolidate and syncronize different ANTs run parameters
BUG: Fix running of ANTs consistently
ENH: Add N4 bias correction after denoising
BUG: Missing ',' in python list.
ENH: Improve error reporting for improper input
STYLE: Uniformly describe registration parameters.
PERF: New AntsJointFusion is well multithreaded
ENH: Add automatic image unwrapping
BUG: Fix mismatched function parameter calls.

Jean-Christophe Fillion-Robin (1):
COMP: Force CMAKE_CONFIGURATION_TYPES only when using multi-config generator

Regina Kim (7):
BUG: Fix Landmark Workflow
ENH: Update antsDenoise IO specification
ENH: Rewording to JointFusion from MALF
ENH: Linear Regression Rescaling
ENH: JointFusion Update for T2
ENH: Add JointFusion masking option
ENH: 1.5 Tesla T2-w excluded from JointFusion

From: Andrey Fedorov <fedorov@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24963 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 83809a20

2016-03-08 23:32:18

jcfr

Details Diff
STYLE: Rename Build Dir in PreventInSourceBuilds

Make the name used as the build directory consistent with line 22.

From: Alexis Girault <agirault@users.noreply.github.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24962 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/PreventInSourceBuilds.cmake Diff File

master 786d2ea1

2016-03-08 17:45:21

lassoan

Details Diff
ENH: Made view axis labels configurable

For some applications standard left/right, posterior/anterior, inferior/superior axis labels are not optimal. For example for eye image analysis temporal/nasal labels are more appropriate than left/right.
Labels may have to be view-specific, e.g., show standard labels on a large overview image and show custom labels in a view that shows a small segmented structure.

Implemented solution:
* vtkMRMLAbstractViewNode stores axis labels (SetAxisLabel/GetAxisLabel methods can be used to set/get the labels)
* vtkMRMLViewDisplayableManager and vtkMRMLOrientationMarkerDisplayableManager read labels from vtkMRMLAbstractViewNode instead of using hard-coded strings to show in Cube and Axes orientation markers and 3D cube labels
* DataProbe read labels from vtkMRMLAbstractViewNode instead of using hard-coded string

No user interface is implemented, as this is an advanced feature for module developers. Example use:

sliceNode = slicer.mrmlScene.GetNodeByID('vtkMRMLSliceNodeRed')
sliceNode.SetOrientationMarkerType(slicer.vtkMRMLAbstractViewNode.OrientationMarkerTypeAxes)
sliceNode.SetOrientationMarkerSize(slicer.vtkMRMLAbstractViewNode.OrientationMarkerSizeLarge)
sliceNode.SetAxisLabel(0,'Proximal')
sliceNode.SetAxisLabel(1,'Distal')

viewNode = slicer.mrmlScene.GetNodeByID('vtkMRMLViewNode1')
viewNode.SetOrientationMarkerType(slicer.vtkMRMLAbstractViewNode.OrientationMarkerTypeAxes)
viewNode.SetOrientationMarkerSize(slicer.vtkMRMLAbstractViewNode.OrientationMarkerSizeLarge)
viewNode.SetAxisLabel(0,'Proximal')
viewNode.SetAxisLabel(1,'Distal')


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24961 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLAbstractViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLAbstractViewNode.h Diff File
mod - Libs/MRML/DisplayableManager/Testing/Data/vtkMRMLCameraDisplayableManagerTest1.mrml Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLOrientationMarkerDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLViewDisplayableManager.cxx Diff File
mod - Modules/Scripted/DataProbe/DataProbe.py Diff File

master e8fb6dc8

2016-03-08 07:23:39

lassoan

Details Diff
ENH: Added method for adding custom volume rendering preset


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24960 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Logic/Testing/Cxx/vtkSlicerVolumeRenderingLogicAddFromFileTest.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Logic/Testing/Cxx/vtkSlicerVolumeRenderingLogicTest.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.h Diff File
mod - Modules/Loadable/VolumeRendering/Widgets/qSlicerPresetComboBox.cxx Diff File

master 76a68dff

2016-03-07 21:38:18

lassoan

Details Diff
STYLE: Removed unused files

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24959 3bd1e089-480b-0410-8dfb-8563597acbee
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerVolumePropertyWidget.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerVolumePropertyWidget.h Diff File

master d6a29ec5

2016-03-04 13:50:25

lassoan

Details Diff
ENH: Added 3D Table view to layouts

3D Table view consists of a 3D view and a table with a vertical divider.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24958 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Resources/UI/qSlicerAppMainWindow.ui Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLLayoutNode.h Diff File
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.cxx Diff File
add - Libs/MRML/Widgets/Resources/Icons/Layout3DTableView.png Diff File
mod - Libs/MRML/Widgets/Resources/qMRMLWidgets.qrc Diff File
mod - Modules/Loadable/Tables/SubjectHierarchyPlugins/qSlicerSubjectHierarchyTablesPlugin.cxx Diff File

master 4bf5af4e

2016-03-03 12:48:36

jcfr

Details Diff
ENH: slicer.util.findChildren: Change behavior to an "and" filter

As discussed in [1], this commit changes the behavior so that *ALL*
parameters (name, text, title and className) are considered when checking
a descendant widget. Prior to this change, the widget was considered
"matched" as soon as the *FIRST* non-False parameter was matching.

[1] http://slicer-devel.65872.n3.nabble.com/Changing-the-behavior-of-slicer-util-findChildren-td4036266.html

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: jonieva <jorgeonieva@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24957 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File

master 52b12fa0

2016-03-03 12:00:12

jcfr

Details Diff
ENH: Add include directories in slicerMacroBuildApplication

The slicerMacroBuildApplication was not including the
SLICERAPP_INCLUDE_DIRECTORIES defined in the macro by
the INCLUDE_DIRECTORIES argument.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Alexis Girault <alexis.girault@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24956 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroBuildApplication.cmake Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 41 42 43 44 45 46 47 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last