Changesets: Import 2017-06-07 23:51:09

master 0afe15b5

2014-06-24 11:30:06

finetjul

Details Diff
BUG: Fix VTK6 support for vtkImageIslandFilter

Closes 0003746

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23367 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 8404d94f

2014-06-23 13:57:45

pohl

Details Diff
BUG: Added Test 6 to expose crash of vtkImageIslandFilter due to VTK6 transition

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23366 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 688476cf

2014-06-23 12:36:03

finetjul

Details Diff
COMP: Remove vtkImageLabelPropagation::AllocateScalarsOutput

declaration in VTKv6.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23365 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 0498e9c2

2014-06-23 11:35:19

finetjul

Details Diff
BUG: Fix vtkImageLabelPropagation VTK 6 support

Fixes vtkSlicerCommonInterfaceTest1

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23364 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master c1ce7f3d

2014-06-23 11:35:17

finetjul

Details Diff
BUG: Remove pipeline error in VTK6 with DiffusionTensorDisplayNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23363 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScalarVolumeDisplayNode.cxx Diff File

master 33050e87

2014-06-22 22:56:51

jcfr

Details Diff
COMP: Ensure variable expected by fixup script are set.

This commit fixes a regression introduced by commit r23355 moving
call to find_package where they are needed. By moving the find_package call
from the top-level CMakeLists.txt, variable exepcted by fixup script were
not set anymore.

It updates SlicerCPack to call find_package and ensure
variables *_LIBRARY_DIRS expected by the fixup script are set.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23362 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerCPack.cmake Diff File

master 2cb719f3

2014-06-22 17:23:37

jcfr

Details Diff
BUG: Consider inner build dir when checking for max root directory length.

This commit introduces the convenience CMake module "PreventDirWithTooManyChars"
and update code to account for length of the inner build subdirectory.

It means if the maximum length of the top-level build directory is 40,
assuming the inner build directory is "Slicer-build", the check in
the inner build will expect a path of length 53.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23361 3bd1e089-480b-0410-8dfb-8563597acbee
add - CMake/PreventDirWithTooManyChars.cmake Diff File
mod - CMakeLists.txt Diff File

master 114526a2

2014-06-22 17:23:35

jcfr

Details Diff
COMP: Ensure PreventDirWithSpaces CMake variables is passed to inner project.

This commit ensures that spaces can be used in either source or build
directory when configuring Slicer inner project. This is done by passing
down the variable ${PROJECT_NAME}_SKIP_DIR_WITH_SPACES_CHECK

This commit also documents and simplifies usage of
"PreventDirWithSpaces" CMake module.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23360 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/PreventDirWithSpaces.cmake Diff File
mod - CMakeLists.txt Diff File

master 603f5f04

2014-06-22 12:31:49

finetjul

Details Diff
BUG: Do not update scalar image pipeline if there is no input image

That would generate pipeline errors with the diffusion tensor display node.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23359 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScalarVolumeDisplayNode.cxx Diff File

master 2ad3af41

2014-06-22 11:44:02

jcfr

Details Diff
COMP: Fix "RCC No resources warning" by removing empty resource files.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23358 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/CMakeLists.txt Diff File
mod - Modules/Core/CMakeLists.txt Diff File
rm - Modules/Core/Resources/qSlicerModulesCore.qrc Diff File
mod - Modules/Loadable/Models/Widgets/CMakeLists.txt Diff File
rm - Modules/Loadable/Models/Widgets/Resources/qSlicerModelsModuleWidgets.qrc Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/CMakeLists.txt Diff File
rm - Modules/Loadable/TractographyInteractiveSeeding/Resources/qSlicerTractographyInteractiveSeedingModule.qrc Diff File

master c5a498e1

2014-06-22 02:38:33

jcfr

Details Diff
COMP: Fix build error related to missing curl/curl.h

This commit fixes build error introduced by commit r23355 by moving the use
of "curl/curl.h" into the private implementation. That way, it won't be
required for user of the "vtkHTTPHandler" class to know about CURL, it
will be an implementation details.

Build error were occurring only windows because curl wasn't installed on the
system and the header wasn't found in default location.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23357 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/RemoteIO/vtkHTTPHandler.cxx Diff File
mod - Libs/RemoteIO/vtkHTTPHandler.h Diff File

master 685fea01

2014-06-21 12:20:05

jcfr

Details Diff
COMP: Find qRestAPI package only where required.

This commits moved the discovery of the qRestAPI module in both QTCore
library and DataStore remote module.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23356 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/CMakeLists.txt Diff File
mod - CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File

master 76be4eeb

2014-06-21 12:20:03

jcfr

Details Diff
COMP: Find LibArchive/CURL/OpenIGTLink/ZLIB package where required.

This commit complements commit r23350 and will help reducing the number
of parameters passed to the compiler/linker. See 0003741

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23355 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/CMakeLists.txt Diff File
mod - CMakeLists.txt Diff File
mod - Libs/MRML/Logic/CMakeLists.txt Diff File
mod - Libs/RemoteIO/CMakeLists.txt Diff File
mod - Modules/Remote/CMakeLists.txt Diff File

master d57a7cc7

2014-06-21 12:19:59

jcfr

Details Diff
STYLE: FiberBundleLabelSelect - Clean up CMakeLists.txt

This commit removes reference to empty variable vtkTeem_LIB_DIR, additionally
vtkTeem being a target this is not needed.

Change *_(BINARY|SOURCE)_DIR with their *_INCLUDE_DIRS equivalent

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23354 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/FiberBundleLabelSelect/CMakeLists.txt Diff File

master 211b7e68

2014-06-20 22:17:55

jcfr

Details Diff
COMP: On MacOSX, waiting issue 0003741 is *really* solved uses VTK 5.10

It turns out that the test build I initiated managed to go way beyond
the original stopping point [See r23344]. That said, there are still
the same issue when building SubjectHierarchy, Annotations module ...

This commits reverts back to VTK 5.10 for MacOSX.

The solution gonna be to continue the work initiated in [1] and
remove the top level call to "find_package()" and instead have
every Slicer libraries/modules including his set of direct dependencies.

[1] http://massmail.spl.harvard.edu/public-archives/slicer-devel/2014/015671.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23353 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master dcf78181

2014-06-20 22:07:09

jcfr

Details Diff
COMP: Re-enable VTKv6 on MacOSX.

Since following commit r23350, issue 0003741 is resolved, this commit
re-enables VTKv6 on MacOSX.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23352 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master ac54c640

2014-06-20 21:47:41

jcfr

Details Diff
COMP: SlicerExecutionModel - Update to explicitly support ITKv4

//-------------
$ git shortlog 865e2a771..ecb58ad --no-merges
Jean-Christophe Fillion-Robin (1):
COMP: Update GenerateCLP and ModuleDescriptionParser to use ITKv4
//-------------

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23351 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File

master 3619c674

2014-06-20 21:47:38

jcfr

Details Diff
COMP: Specify minimum set of VTKv6 libraries. Fixes 0003741

The VTK utility: Utilities/Maintenance/WhatModulesVTK.py discovers
which modules are used in a project. This patch modifies the Slicer
CMakeLists.txt file to only load the vtk modules used by Slicer. This
should reduce the number of libraries being linked.

This commit also updates CTK project including a patch reducing
the number of library associated with CTKImageProcessingITKCore library.

// ----------------
$ git shortlog 48ef9aeb8..282abc7 --no-merges
Jean-Christophe Fillion-Robin (1):
CTKImageProcessingITKCore - With ITKv4, link only to the required libraries
// ----------------

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Bill Lorensen <bill.lorensen@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23350 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - SuperBuild/External_CTK.cmake Diff File

master 6d4e2968

2014-06-20 09:37:28

finetjul

Details Diff
BUG: Fixes auto level for DTI images

* CalculateAutoLevel was not called in VTK 6 when the image was modified
* CalculateAutoLevel was aborting with Diffusion tensor display node
because the scalar image data did not have a Scalars array
* Also use GetDisplayScalarRange() in qSlicerScalarVolumeDisplayWidget

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23349 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScalarVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeDisplayNode.cxx Diff File
mod - Modules/Loadable/Volumes/Widgets/qSlicerScalarVolumeDisplayWidget.cxx Diff File

master 2eb3938d

2014-06-20 09:37:25

finetjul

Details Diff
BUG: Fix vtkITKImageToImageFilter for VTK 6

The pipeline of filters was broken.

Fixes DiffusionWeightedVolumeMaskingTest

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23348 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/vtkITKImageToImageFilter.h Diff File

master 94085a6e

2014-06-20 09:37:23

finetjul

Details Diff
BUG: Fix vtkTeemEstimateDiffusionTensor

* The nrrd reader did not properly propagate the scalar type to the
pipeline on time.
* vtkTeemEstimateDiffusionTensor did not use a proper pipeline of filters
for the baseline and averagedwi outputs.

Fixes DWIToDTIEstimationTest and DiffusionTensorScalarMeasurementsTest

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23347 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkNRRDReader.cxx Diff File
mod - Libs/vtkTeem/vtkNRRDWriter.cxx Diff File
mod - Libs/vtkTeem/vtkTeemEstimateDiffusionTensor.cxx Diff File
mod - Libs/vtkTeem/vtkTeemEstimateDiffusionTensor.h Diff File
mod - Libs/vtkTeem/vtkTensorMask.cxx Diff File
mod - Modules/CLI/DWIToDTIEstimation/DWIToDTIEstimation.cxx Diff File

master 2ca4318b

2014-06-20 09:37:20

finetjul

Details Diff
STYLE: Fix 80 char limit in vtkMRMLDiffusionTensorVolumeDisplayNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23346 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorVolumeDisplayNode.cxx Diff File
mod - Libs/vtkITK/vtkITKNewOtsuThresholdImageFilter.h Diff File

master 3887ef6e

2014-06-19 16:11:58

pohl

Details Diff
BUG: Fixed bug with respect to Image inhomogeneity; included vtkImageLabelPropagation in SlicerCommonInterFaceTest1 so it would fail as this is also the reason for EMSegCL_Task_MRIHumanBrainFullParcellation_BRAINS_small failing

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23345 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 2ec6b84f

2014-06-18 19:03:39

jcfr

Details Diff
COMP: On MacOSX, waiting issue 0003741 is solved uses VTK 5.10

As illustrated in the bug report [1], the maximum number of linked libraries
is reached on MacOSX 10.6 (see below for an example of message) but there
are no problem on MacOSX 10.8 (at least when targeting 10.9).

// ---------
ld: warning: duplicate dylib /path/to ...
[...]
ld: warning: duplicate dylib /path/to ...
two level namespace mach-o files can link with at most 253 dylibs, this link would use 287 dylibs
// ---------

Waiting we come up with a solution or understand better the scope of the
problem, this commit force the VTK version to 5.10.

[1] http://na-mic.org/Mantis/view.php?id=3741

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23344 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master 9015d1db

2014-06-18 11:02:14

jcfr

Details Diff
COMP: Fix Slicer build warnings

This commit addresses two types of warnings:
- unused variable warnings
- RCC: Warning: No resources in '/path/to/foo.qrc

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23343 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIModule.cxx Diff File
mod - CMake/SlicerMacroBuildModuleQtLibrary.cmake Diff File
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 105 106 107 108 109 110 111 ... 120 ... 130 ... 133 134 135  Next  Last