Changesets: Slicer

Search Browse Back to Index

1999-expose-dcmtk-dir-to-built-in-module 5c7a4168

2012-05-02 19:55:04

finetjul

Details Diff 		BUG: vtkMRMLDisplayableNode intermediate state was caught by Model displayable manager

When a null node ID was set to the displayable node, the DisplayNodeIDs had its element erased, and while unobserving the display node (vtkMRMLDisplayableNode::SetAndObserveNthDisplayNode(n,0)), DisplayModifiedEvent was fired and caught by the model displayable manager before the DisplayNodes element was erased from the list.
In the displayable manager, GetDisplayNodes() was called which fired an assert as the lists DisplayNodeIDs and DisplayNodes had a different size.
For the sake of testing, GetInternalDisplayNodes is exposed to check the internal values of the displayable node.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19984 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.h Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module dd9a3e16

2012-05-02 19:23:13

benjamin.long

Details Diff 		ENH: Serialized qttesting unit test to provide potentials failed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19983 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/CMakeLists.txt Diff File

1999-expose-dcmtk-dir-to-built-in-module 0bf5367f

2012-05-02 18:39:27

jcfr

Details Diff 		COMP: Continuous extension build system also consider Slicer revision updates.

To summarize, the continuous build system now consider two possible updates:
1) Update associated with ExtensionsIndex git repository
2) Change of version associated with Slicer itself

The task (2) is achieved by extracting the revision from vtkSlicerConfigure.h
header file.

moving forward a mechanism preventing the build of extension if Slicer itself
isn't fully build should probably be implemented.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19982 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerExtensionsDashboardDriverScript.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module a45eb5bb

2012-05-02 18:39:25

jcfr

Details Diff 		COMP: Ensure extension template dashboard script downloads driver script

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19981 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerExtensionsDashboardScript.TEMPLATE.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module 351f2dde

2012-05-02 18:35:42

benjamin.long

Details Diff 		BUG: Fix QtTesting unit tests, but not the serialize issue.

Please note that those tests can failed because they are not serialized
yet.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19980 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/CMakeLists.txt Diff File
rm - Libs/MRML/Widgets/Testing/qMRMLCaptureToolBarEventTranslatorPlayerTest1.cxx Diff File
rm - Libs/MRML/Widgets/Testing/qMRMLCaptureToolBarEventTranslatorPlayerTest1.xml Diff File
rm - Libs/MRML/Widgets/Testing/qMRMLLayoutWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceControllerWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetEventTranslatorPlayerTest1.xml Diff File
mod - SuperBuild/External_CTK.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module 9db3d21f

2012-05-02 15:39:10

lassoan

Details Diff 		BUG: Exclude TclTk .SVN files (36MB, 1600 files) from the installation package. It slightly decreases the installer package size and installation time.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19979 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockInstallTcl.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module c3c1db20

2012-05-02 14:31:59

vrnova

Details Diff 		ENH: Adding test for the module

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19978 3bd1e089-480b-0410-8dfb-8563597acbee
add - Modules/CLI/ConnectedComponent/Data/Baseline/CTHeadAxialLabel.nrrd Diff File
add - Modules/CLI/ConnectedComponent/Data/Baseline/CTHeadAxialLabelTest.nrrd Diff File
add - Modules/CLI/ConnectedComponent/Testing/CMakeLists.txt Diff File
add - Modules/CLI/ConnectedComponent/Testing/ConnectedComponentTest.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module 6ba60266

2012-05-02 11:43:21

finetjul

Details Diff 		BUG: Fix bugs in vtkMRMLDisplayableNode

Previous version of vtkMRMLDisplayableNode didn't handle correctly:
- DisplayNodes list synchronization with DisplayNodeIDs list
- sometimes the ID could removed from the DisplayNodeIDs list but not in DisplayNodes list
- DisplayModifiedEvent was not fired every time a display node was set
- Some methods where clearing the display node list for no good reason (e.g. UpdateScene)
- Too many ModifiedEvent could be fired when processing each node ID in a loop (solution is to use Start/EndModify())
- Code was not factorized (AddReferencedNodeID was called at multiple locations, clear() and erase() were done at different locations)
- ...

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19977 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLLinearTransformNodeEventsTest.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLModelNode.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module 443c35b5

2012-05-02 09:49:07

jcfr

Details Diff 		COMP: Remove empty directory. Using git-svn option --rmdir would avoid this commit.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19976 3bd1e089-480b-0410-8dfb-8563597acbee
rm - Applications/SlicerQT/Testing/Python/SlicerQtTestingDTITutorial.py Diff File
rm - Applications/SlicerQT/Testing/QtTesting/UnitTest_DTI_DWI.xml Diff File

1999-expose-dcmtk-dir-to-built-in-module 3d8f0601

2012-05-01 21:04:45

finetjul

Details Diff 		ENH: Add option in settings to enable QtTesting. Off by default

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19975 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Base/QTGUI/CMakeLists.txt Diff File
add - Base/QTGUI/Resources/UI/qSlicerSettingsQtTestingPanel.ui Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerCommandOptions.cxx Diff File
add - Base/QTGUI/qSlicerSettingsQtTestingPanel.cxx Diff File
add - Base/QTGUI/qSlicerSettingsQtTestingPanel.h Diff File

1999-expose-dcmtk-dir-to-built-in-module 9d6056b7

2012-05-01 19:54:58

jcfr

Details Diff 		BUG: Ensure that QtTesting project is found when building extensions

This will fix link issue associated with extension:

//--------
Scanning dependencies of target ConfigureAdditionalLauncherSettings
[ 4%] Configuring: AdditionalLauncherSettings.ini
[ 4%] Built target ConfigureAdditionalLauncherSettings
Scanning dependencies of target vtkSlicerLoadableExtensionTemplateModuleLogic
[ 8%] Building CXX object Logic/CMakeFiles/vtkSlicerLoadableExtensionTemplateModuleLogic.dir/vtkSlicerLoadableExtensionTemplateLogic.cxx.o
c++: --no-undefined: linker input file unused because linking not done
Linking CXX shared library ../lib/Slicer-4.1/qt-loadable-modules/libvtkSlicerLoadableExtensionTemplateModuleLogic.so
/usr/bin/ld: cannot find -lQtTesting
//--------

See http://slicer.cdash.org/viewBuildError.php?buildid=17278

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19974 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerConfig.cmake.in Diff File
mod - CMake/SlicerGenerateSlicerConfig.cmake Diff File
mod - CMake/UseSlicer.cmake.in Diff File

1999-expose-dcmtk-dir-to-built-in-module c70f20ab

2012-05-01 19:30:04

benjamin.long

Details Diff 		BUG: Fix qtTesting tests when slicer use qtTesting.

Bug fix in CTK, commit:
8b399aea484ef6fca0eef26b7f59f0d00f6a7b05

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19973 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerQT/Testing/QtTesting/UnitTest_DTI_DWI.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLCaptureToolBarEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLCheckableNodeComboBoxEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLClipNodeWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLCollapsibleButtonEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorListViewEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetEventTranslatorPlayerTest2.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorTableComboBoxEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorTableViewEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLDisplayNodeWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLabelComboBoxEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLinearTransformSliderEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLListWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLMatrixWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNavigationViewEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLROIWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLRangeWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLScalarInvariantComboBoxEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLScalarInvariantComboBoxEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceControllerWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLThreeDViewControllerWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLThreeDWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLTransformSlidersEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLTreeViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLTreeViewEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLTreeViewEventTranslatorPlayerTest2.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeInfoWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetEventTranslatorPlayerTest1.xml Diff File
mod - SuperBuild/External_CTK.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module 6a19e2f5

2012-04-30 20:11:16

jcfr

Details Diff 		BUG: Make sure more than one PythonQt module could be loaded in a given directory.

In case the regular expression doesn't match, the other filename should
be considered.

This is a follow up of r19695

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19972 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File

1999-expose-dcmtk-dir-to-built-in-module 994ad05e

2012-04-30 20:11:14

jcfr

Details Diff 		COMP: Provide a mechanism to overwrite the auto-discovered Slicer_WC_REVISION

Such mechanism allows to overwrite the discovered Slicer_WC_REVISION
and build extensions against an expected revision associated with
a Slicer release.

While the core functionality (API/ABI) of slicer wouldn't be modified by a
newer Slicer revision, the extension build system could be improved or
fixed by a more recent set of patches. In that specific case, the option
Slicer_FORCED_WC_REVISION could be used.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19971 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module 69509e42

2012-04-30 20:11:12

jcfr

Details Diff 		ENH: Extensions build system now support ExtensionsIndex git repository

The "ExtensionsIndex" repository is a dedicated git repository used to
host extension description files. The associated integration branches
are "master", "4.1", ...

When Slicer 4.2 will be released, the integration branch 4.2 will be created.
This later one will host the extensions developed for this specific release.

The "master" branch will host the bleeding edge extensions build against
the bleeding edge Slicer.

In a nutshell, the extensions build system can be used in two ways:
"Inside" a slicer build tree
or
"Outside" a slicer build tree

"Inside": This is done by enabling option Slicer_BUILD_EXTENSIONS (and optionally Slicer_UPLOAD_EXTENSIONS)
when building Slicer.

"Outside": This is done by building the project located in "Slicer/Extensions/CMake"

The advantage of doing an "Outside" build is that the continuous integration associated
with extensions will be fast (systematic configure/build of Slicer isn't required)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19970 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/CMakeLists.txt Diff File
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtensions.cmake Diff File
mod - Extensions/CMake/SlicerBlockUploadExtension.cmake Diff File
mod - Extensions/CMake/SlicerExtensionsDashboardDriverScript.cmake Diff File
mod - Extensions/CMake/SlicerExtensionsDashboardScript.TEMPLATE.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module 0b2f68f4

2012-04-30 20:11:10

jcfr

Details Diff 		COMP: Associate repository type and revision to extension build name

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19969 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module 02c6ca47

2012-04-30 20:11:08

jcfr

Details Diff 		BUG: Ensure site name associated with extension build is systematically lower cased

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19968 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module cb7d696d

2012-04-30 20:11:07

jcfr

Details Diff 		STYLE: Re-organize and document CMake code associated with driver script template

git-svn-id: http://svn.slicer.org/Slicer4/trunk@19967 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerDashboardScript.TEMPLATE.cmake Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 54 55 56 57