Changesets: Slicer

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 55d36392

2016-04-24 20:06:22

jcfr

Details Diff
ENH: Update SlicerExecutionModel version

$ git shortlog 112076b..b2c78c7 --no-merges
Hans Johnson (5):
COMP: KWSYS removed support for pre-C++98 in 2015
ENH: Exceptions should be caught by reference
STYLE: Prefere initialization to assignment
STYLE: Remove unused function WriteLines
STYLE: Remove unused variable 'elements'

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25027 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup e5a32d5f

2016-04-24 20:06:20

jcfr

Details Diff
ENH: Update ITK version

$ git shortlog 84ba36b..9fa8f63 --no-merges
Andrey Fedorov (2):
BUG: Add missing itk_expat_mangle.h install target
BUG: fix typo in file name

Bill Lorensen (5):
ENH: Bump wiki examples version, new remote module process
ENH: Bump wiki examples version, new remote module process
STYLE: SuperClass should be Superclass
COMP: Resolve clang linkage issue
BUG: Valgrind detected an invalid read

Bradley Lowekamp (18):
ENH: Update Insight Journal handle links to https
ENH: Adding const qualifier to results
BUG: Adding missing const qualifier for GetConfusionMatrix method
BUG: Use Set/GetMacros, fix const correctness and PrintSelf.
ENH: added inlined Zero and one values for integer NumericTraits
ENH: Use constexpr for floating point NumericTraits
ENH: Make NumericTraits functions constexpr for intrinsic
BUG: Add definition of static constexpr NumericTrait members
BUG: Declared static constexpr members need to be defined as constexpr
ENH: ITK_CONSTEXPR_FUNC implies inline
BUG: Addressing VS10 and VS11 NumericTraits linkage issue
BUG: Use LargestPossible region for BSpline domain
BUG: Remove errant file
COMP: Address warning about this usage in initializer list
ENH: Prefer ZeroValue function over variable
STYLE: Use consistent path for try_compiles binary directory
BUG: Don't use "=" in cmake variable name
ENH: Test address of NumericTraits One and Zero constexpr

Davis Vigneault (2):
ENH: Add Ternary Operator Image Filter
STYLE: Prefer static cast

Francois Budin (3):
PERF: Simplify itkTemplate New() input type identification.
ENH: Avoid template type specification for image reader in Python wrapping
BUG: Missing IOPixelType strings in ImageIOBase

GCC-XML Upstream (1):
ENH: pygccxml v1.7.3 (reduced)

Hans Johnson (23):
COMP: Provide VXL backward compatible includes
COMP: ITK requires legacy methods
ENH: Need propagate ITK_LIBRARY_PROPERTIES
ENH: Added UpdateFromUpstream.sh for VNL
ENH: Manual copy from vxl/master
STYLE: vnl_math_[min|max] -> std::[min|max]
STYLE: Text files should end with a newline
COMP: Prefer C++11 constexpr when possible
COMP: Prefer C++11 constexpr when possible
ENH: Simplify std:: math function definitions
COMP: Error in constexpr usage
COMP: Add const to previous const variables
COMP: SizeValueType can has different definition for itkArray
ENH: Added utility for modernizing vcl_ to std::
ENH: Reference vnl_math.h constants directly
ENH: Avoid using vnl_math_ functions
COMP: Missing symbol for itkStaticConstMacro
COMP: Function override missing in BioCell
ENH: Convert vcl_ to std::
BUG: Windows vcl_snprintf failures addressed
COMP: Disabmiguate function calls to SetData
ENH: Provided static code API for external applications
COMP: Remove possible type conversion warnings

Hyun Jae Kang (9):
COMP: Fixed the compiler error of ITK on Mingw-w64
COMP: Temporarily suppress the warning messages of data-conversion on VS14
COMP: Put back the disappeared option of "BUILD EXAMPLES".
BUG: Fix segmentation faults on mingw-W64 x86_64.
BUG: Fix the failed test of itkCastImageFilterTest on mingw-w64 compiler.
COMP: Fixed the cmake configuration for ITK_WRAP_DOC
COMP: Fixed the warning messages on VS14.
COMP: Add a missing head file at itkNumericTraitsStdVector.h
COMP: Fix the wraning message of data-conversion

Jean-Christophe Fillion-Robin (2):
STYLE: UseITK: Document static registration of ITK IO factories. See 0003393
COMP: Fix Slicer MacOSX extension packaging setting CMP0042 policy to OLD

Jon Haitz Legarreta (5):
COMP: Delete unused variable compiler warning.
ENH: Refactored itkBioCellTest
ENH: Exercise non-tested itk::Math methods.
ENH: Improve MersenneTwister class and test.
ENH: Improve itkFEMLoadPoint coverage.

KWSys Robot (1):
KWSys 2016-03-09 (36d8666f)

Lucas Gandel (6):
ENH: Add TubeTK as a remote module
COMP: Fix external module testing
COMP: Fix git protocol setup
ENH: Update TubeTK remote module
ENH: Conditionally add testing for External Modules
BUG: Fix call to std::max() with different variable types

Matthew McCormick (43):
BUG: Update MIDAS url for https in archive testing data script.
STYLE: Use PixelType and ImageType in Python tests.
ENH: Avoid template type specification in Python wrapping.
COMP: Do not use has_key in itkTemplate New.
DOC: Emphasize that push access is not required to contribute patches.
ENH: Download SWIG and PCRE from midas3.kitware.com.
COMP: Ignore build warning from KWStyle's boost.
BUG: Remove Azure ExternalData resource.
BUG: ExternalData downloads from midas3.kitware.com only supports https.
BUG: slicer.kitware.com/midas3/ ExternalData will not support http.
ENH: Update the VNL README-ITK.txt subtree commit revision.
BUG: Mark VXL internal CMake variables as advanced.
BUG: Run itk_module_target on itknetlib.
DOC: Direct patches for VXL upstream to the GitHub repository.
BUG: Run itk_module_target on itknetlib.
COMP: Account for removal of vcl_* from upstream VXL.
COMP: Remove itkTypeMacro from BioCellHelper.
COMP: Convert itkBioCellTest arguments from double to int.
COMP: Turn off BUILD_DOCUMENTATION for VNL.
BUG: Install VXL config files to backwards-compatible locations.
ENH: Remove vcl_complex from the wrapping.
BUG: Install vnl_export.h and vnl_algo_export.h to previous locations.
BUG: midas3.kitware.com only supports the https protocol.
BUG: ImageIOBase SetDimensions should take SizeValueType.
ENH: Add wrapping for ImagePCAShapeModelEstimator.
COMP: Do not specify COMPONENTS with find_package(VTK.
DOC: Fix FFTW warning grammar.
COMP: Build against system HDF5 1.8.16.
ENH: Set a default CMAKE_BUILD_TYPE when building a module externally
COMP: Make initial HDF5 discovery of 1.8.16 quiet.
ENH: Use hidden symbol visibility for the CPython extension modules.
ENH: Turn on CMAKE_POSITION_INDEPENDENT_CODE by default.
BUG: FEMLoadPoint uninitialized value in the constructor.
BUG: Fix wrapping of complex types in VNL.
ENH: Bump CMakeLists.txt version 4.9.1.
COMP: Address ITKCommon Python submodule order.
BUG: Extend ExternalData_TIMEOUT_ABSOLUTE to 900 seconds.
BUG: Do not run KWStyle Git config on a release tarball.
COMP: Ambiguous RGBPixel access in CustomColormapFunction.
BUG: Prevent division by zero in PhasedArray3DSpecialCoordinatesImage.
BUG: Initialize azimuth and elevation to pi/2 in PhasedArray3D.
BUG: Increase MaskLabel backwards compatibility in N4 bias correction.
ENH: Deprecate MaskLabel in N4BiasFieldCorrectionImageFilter.

Michka Popoff (8):
ENH: Wrap RayCastInterpolateImageFunction
ENH: Wrap RayCastInterpolateImageFunction
COMP: Remove debug output after vcl_complex removal from wrapping
ENH: Consolidate .idx file generation with swig .i generation.
ENH: Update UpdatepygccxmlFromUpstream.sh script
COMP: Set CastXML path and name for pygccxml 1.7.3
COMP: Fix RayCastInterpolateImageFunction wrapping for image dim 2
ENH: Use argparse instead of optparse in igenerator.py

Nick Tustison (1):
ENH: Making the mask usage consistent with ITK.

Sean McBride (6):
BUG: Fixed off-by-1 error found by ASan
COMP: Fixed clang -Wcomma warning
COMP: Introduce ITK_FALLTHROUGH, to suppress switch fall through warnings
COMP: Fixed -Wwritable-strings warnings
COMP: Fixed remaining -Wcomma warnings
ENH: switch gdcm to release branch, not release-2-4

Sumedha Singla (1):
BUG: Fixed the test itkHDF5ImageIOTest

VXL Maintainers (8):
VNL 2015-11-22 (ea1d60fb)
VNL 2016-03-02 (cb31149e)
VNL 2016-03-13 (ae34f0fc)
VNL 2016-03-15 (751698ab)
VNL 2016-03-19 (df10fefa)
VNL 2016-03-25 (f0040231)
VNL 2016-03-30 (88f50849)
VNL 2016-04-22 (0ed18124)

Vladimir S. FONOV (1):
MINC 2016-02-24 (8632513e)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25026 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 3823acc1

2016-04-24 19:15:11

jcfr

Details Diff
STYLE: Re-generate templates using SlicerGenerateExtensionTemplates

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25025 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CLIExtensionTemplate.s4ext Diff File
mod - Extensions/LoadableExtensionTemplate.s4ext Diff File
mod - Extensions/ScriptedLoadableExtensionTemplate.s4ext Diff File
mod - Extensions/Testing/CLIExtensionTemplate/CLIExtensionTemplate.png Diff File
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CLIModuleTemplate.cxx Diff File
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CLIModuleTemplate.xml Diff File
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/CLIExtensionTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableExtensionTemplate.png Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableModuleTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableModuleTemplate/Logic/vtkSlicerLoadableModuleTemplateLogic.cxx Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableModuleTemplate/Logic/vtkSlicerLoadableModuleTemplateLogic.h Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableModuleTemplate/Widgets/CMakeLists.txt Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableModuleTemplate/qSlicerLoadableModuleTemplateModule.cxx Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableModuleTemplate/qSlicerLoadableModuleTemplateModuleWidget.cxx Diff File
mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/ScriptedLoadableExtensionTemplate.png Diff File
mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/ScriptedLoadableModuleTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/ScriptedLoadableModuleTemplate/ScriptedLoadableModuleTemplate.py Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 265b5d2a

2016-04-24 19:15:01

jcfr

Details Diff
ENH: Add convenience target SlicerGenerateExtensionTemplates

This target, available on unix, allows to re-generate the extensions
templates in Extensions Testing directory using the extension wizard.

It also adds the extension wizard option --localExtensionsDir allowing
to explicitly mark an extension as a "local".

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25024 3bd1e089-480b-0410-8dfb-8563597acbee
add - CMake/SlicerExtensionTemplatesGenerator.cmake Diff File
mod - Utilities/Scripts/SlicerWizard/ExtensionDescription.py Diff File
mod - Utilities/Scripts/SlicerWizard/ExtensionWizard.py Diff File
mod - Utilities/Scripts/SlicerWizard/Utilities.py Diff File
mod - Utilities/Templates/CMakeLists.txt Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 02c8996b

2016-04-24 19:14:57

jcfr

Details Diff
BUG: Return EXIT_FAILURE when encountering an unknown pixel component type.

Also create a more informative error message.

From: Matt McCormick <matt.mccormick@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25023 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CLIModuleTemplate.cxx Diff File
mod - Utilities/Templates/Modules/CLI/TemplateKey.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup fa3dc674

2016-04-24 19:14:53

jcfr

Details Diff
STYLE: Declare typedef's next to where they are used.

The code is easier to read when related statements are clustered together.

From: Matt McCormick <matt.mccormick@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25022 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CLIModuleTemplate.cxx Diff File
mod - Utilities/Templates/Modules/CLI/TemplateKey.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup f4a5ae05

2016-04-24 19:14:50

jcfr

Details Diff
STYLE: Used a named variable for Dimension in CLIModuleTemplate.

When reading the code, we now know what "3" refers to.

From: Matt McCormick <matt.mccormick@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25021 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CLIModuleTemplate.cxx Diff File
mod - Utilities/Templates/Modules/CLI/TemplateKey.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup f1f3d910

2016-04-24 19:14:47

jcfr

Details Diff
STYLE: Use more literate TPixel in CLIModuleTemplate CLI.

When reading the template argument, we immediately know what it is.

From: Matt McCormick <matt.mccormick@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25020 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CLIModuleTemplate.cxx Diff File
mod - Utilities/Templates/Modules/CLI/TemplateKey.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup e21dad0e

2016-04-24 19:14:44

jcfr

Details Diff
BUG: Used signed char instead of char in CLIModuleTemplate.cxx

The 'signed char' type is different from the 'char' type. On some systems, 'char'
can be unsigned. Use 'signed char' as intended.

From: Matt McCormick <matt.mccormick@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25019 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/CLIExtensionTemplate/CLIModuleTemplate/CLIModuleTemplate.cxx Diff File
mod - Utilities/Templates/Modules/CLI/TemplateKey.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 563dd575

2016-04-22 18:34:27

naucoin

Details Diff
STYLE: Update Models module documentation.

This patch updates the documentation file for the Display and Clipping
sections of the Models module.
Added documentation for the the View drop down and the additions to the
Scalars section.
Changed string-enumerations in Material Presets and Clipping to parameters
as they were not showing up on the wiki page.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@25018 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Documentation/Models.xml Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 6ca2a9ed

2016-04-22 15:17:20

pinter

Details Diff
BUG: Fixed crash when node name not specified when creating subject hierarchy

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25017 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup b38bdd72

2016-04-20 00:18:51

jcfr

Details Diff
STYLE: Ensure extension wizard & build system generate identical .s4ext files

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Jean-Baptiste VIMORT <jb.vimort@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25016 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Utilities/Scripts/SlicerWizard/ExtensionDescription.py Diff File
mod - Utilities/Scripts/SlicerWizard/ExtensionWizard.py Diff File
mod - Utilities/Templates/CMakeLists.txt Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 02283af9

2016-04-20 00:18:49

jcfr

Details Diff
STYLE: ExtensionWizard: Refactor code to conditionally add templates

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Jean-Baptiste VIMORT <jb.vimort@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25015 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Utilities/Scripts/SlicerWizard/ExtensionWizard.py Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 749448e5

2016-04-20 00:18:48

jcfr

Details Diff
STYLE: Generate description file using template file

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Jean-Baptiste VIMORT <jb.vimort@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25014 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerFunctionGenerateExtensionDescription.cmake Diff File
add - Utilities/Templates/Extensions/extension_description.s4ext.in Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup bd066759

2016-04-19 18:23:48

naucoin

Details Diff
BUG: Update extensions build system to set dependency DIR with sub directory

Reported-by: Nicole Aucoin <nicole@bwh.harvard.edu>

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25013 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtensions.cmake Diff File
mod - Extensions/CMake/SlicerBlockUploadExtension.cmake Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup d42346ef

2016-04-17 22:21:38

lassoan

Details Diff
ENH: Improved API for getting editable VTK transform from node

It is now simpler to ask for a transform that can be modified (it can be indicated with an extra optional flag).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25012 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerTransformLogic.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLNonlinearTransformNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.h Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 67d600c3

2016-04-16 01:48:49

lassoan

Details Diff
ENH: Made displayed node type configurable in qMRMLNodeComboBox

Configuration is useful for cases when a more specific type name is preferred (e.g., instead of the generic "Create new SubjectHierarchy" option, a module can set up the widget to show "Create new Measurements").

Added methods:
Q_INVOKABLE void setNodeTypeLabel(const QString& label, const QString& nodeType);
Q_INVOKABLE QString nodeTypeLabel(const QString& nodeType)const;

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25011 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest1.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.h Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox_p.h Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup deb25ede

2016-04-14 09:35:59

pieper

Details Diff
ENH: add an svg logo for times when you need vector resolution

This file was converted from pdf of files at this page:

https://www.slicer.org/slicerWiki/index.php/Slicer3:Slicer3Brand

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25010 3bd1e089-480b-0410-8dfb-8563597acbee
add - Resources/Logos/3DSlicerLogo-HorizontalF.svg Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 177e6a86

2016-04-14 09:35:57

pieper

Details Diff
BUG:two bugs are fixed, SetSendBlock and IGTLUnitAppend

From: leochan2009 <leochan2009@hotmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25009 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLink.cmake Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup e7a33703

2016-04-13 12:39:57

lassoan

Details Diff
BUG: Fixed subject hierarchy node naming tests

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25008 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyCorePluginsSelfTest.py Diff File
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyGenericSelfTest.py Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Testing/Cxx/vtkSlicerSubjectHierarchyModuleLogicTest.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 89313026

2016-04-12 11:09:55

lassoan

Details Diff
ENH: Fixed subject hierarchy folder node names in DICOM plugin

Removed unnecessary postfix.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25007 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOMLib/DICOMPlugin.py Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 9a3ae538

2016-04-12 11:07:05

lassoan

Details Diff
ENH: Fixed subject hierarchy folder node names

If a subject hierarchy node is associated with a data node then their names are synchronized; and to avoid name conflict, the subject hierarchy node gets a _SubjectHierarchy postfix in its name.

If there is no associated data node then the postfix is not necessary and it's confusing when it is shown to the user (e.g., when the user is asked to select a SubjectHierarchy folder).

This commit changes the behavior so that _SubjectHierarchy is only added if a data node is specified.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25006 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Modules/Loadable/Markups/Widgets/qSlicerMarkupsPlaceWidget.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyCloneNodePlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup 2e735ae9

2016-04-12 02:27:26

jcfr

Details Diff
COMP: Fix "-Wunused-parameter" and "-Wparentheses" warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25005 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerAbstractModuleRepresentation.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup e6c57dd1

2016-04-11 16:14:00

jcfr

Details Diff
ENH: Hide symbols in the CLI modules.

Update SlicerExecutionModule to incorporate
Slicer/SlicerExecutionModel@8d607ff93a3be76274d9cedfb9f1148a6cdb6968
which hides non-CLI symbols so only ModuleEntryPoint, etc. are available in
the CLI shared libraries.

This results in the following `lib/Slicer-4.5/cli-modules` size improvements,
Slicer start-up time improvements, and reduction in
GradientAnisotropicDiffusionLib symbols:

```
MinSizeRel: no hidden | MinSizeRel: hidden | Release: no hidden | Release: hidden
---------------------------------------------------------------------------------
size (MB) 104 89 119 107
start-up time (sec) 20.2 16.2 20.0 18.7
example cli symbols 2593 328 2342 322
```

From: Matt McCormick <matt.mccormick@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25004 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File

490-qMRMLSceneHierarchyModel-avoid-extra-scene-lookup c031a49f

2016-04-11 00:57:13

lassoan

Details Diff
BUG: Fixed edit properties option in node selectors

Fixes http://www.na-mic.org/Bug/view.php?id=2109

Now any module can associate a MRML node type with a module (instead of having a hardcoded list of modules
in qSlicerApplication) and when switching to a module, the chosen node is selected as active node.
Associations can be added by calling qSlicerApplication::registerNodeModule().
Multiple modules can be associated with the same MRML node type.

The best module for a specific node instance is determined run-time, by calling
qSlicerAbstractModuleWidget::nodeEditable() for each candidate and choosing
the one that has the highest confidence in handling the node.
This mechanism is used for selecting the CLI module that corresponds to a specific CLI module parameter node.
This mechanism is also used for switching to volume rendering module if a volume rendering clipping ROI node
is selected for editing (instead of switching to the Annotations module).
The most suitable module's qSlicerAbstractModuleWidget::setEditedNode() method is called to select the currently edited node.
qSlicerAbstractModuleWidget::nodeEditable() and qSlicerAbstractModuleWidget::setEditedNode() methods can be overridden
in scripted loadable modules as well.

As edited node selection is now possible using a clean, unified method call, it is no longer necessary
to access GUI widgets directly. Therefore, almost all editProperties() method calls in subject hierarchy plugins were
removed (replaced by a common implementation in the base class). This new, simplified method fixes robustness issues
of using node name filters for selecting a node in model hierarchy, inability to choose annotation hierarchy nodes, etc.

qSlicerAbstractModuleWidget::setEditedNode(vtkMRMLNode* node, QString role, QString context) has two extra (optional)
arguments. Role can be used to specify additional nodes for a module (e.g., if there are multiple inputs for a module
then role argument can select between them). Context can be used for specifying a sub-selection within a node (for
example, Segment Editor module can be activated for a selected segment - specified by 'context' - of a specific
segmentation node - specified by 'node').

Fixed code review errors (typos and API simplification).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25003 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIModule.cxx Diff File
mod - Base/QTCLI/qSlicerCLIModule.h Diff File
mod - Base/QTCLI/qSlicerCLIModuleWidget.cxx Diff File
mod - Base/QTCLI/qSlicerCLIModuleWidget.h Diff File
mod - Base/QTCore/qSlicerAbstractCoreModule.cxx Diff File
mod - Base/QTCore/qSlicerAbstractCoreModule.h Diff File
mod - Base/QTCore/qSlicerAbstractModuleFactoryManager.cxx Diff File
mod - Base/QTCore/qSlicerAbstractModuleRepresentation.cxx Diff File
mod - Base/QTCore/qSlicerAbstractModuleRepresentation.h Diff File
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File
mod - Base/QTCore/qSlicerCoreApplication.h Diff File
mod - Base/QTCore/qSlicerCoreApplication_p.h Diff File
mod - Base/QTGUI/Testing/Cxx/qSlicerScriptedLoadableModuleWidgetTest.cxx Diff File
mod - Base/QTGUI/Testing/Data/Input/qSlicerScriptedLoadableModuleNewStyleTest.py Diff File
mod - Base/QTGUI/Testing/Data/Input/qSlicerScriptedLoadableModuleNewStyleTestWidget.py Diff File
mod - Base/QTGUI/Testing/Data/Input/qSlicerScriptedLoadableModuleTest.py Diff File
mod - Base/QTGUI/Testing/Data/Input/qSlicerScriptedLoadableModuleTestWidget.py Diff File
mod - Base/QTGUI/qSlicerAbstractModuleWidget.cxx Diff File
mod - Base/QTGUI/qSlicerAbstractModuleWidget.h Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.h Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModule.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModule.h Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModuleWidget.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModuleWidget.h Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.h Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleWidget.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleWidget.h Diff File
mod - Modules/Loadable/Annotations/qSlicerAnnotationsModule.cxx Diff File
mod - Modules/Loadable/Annotations/qSlicerAnnotationsModule.h Diff File
mod - Modules/Loadable/Cameras/qSlicerCamerasModule.cxx Diff File
mod - Modules/Loadable/Cameras/qSlicerCamerasModule.h Diff File
mod - Modules/Loadable/Cameras/qSlicerCamerasModuleWidget.cxx Diff File
mod - Modules/Loadable/Cameras/qSlicerCamerasModuleWidget.h Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModule.cxx Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModule.h Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.cxx Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.h Diff File
mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModule.cxx Diff File
mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModule.h Diff File
mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.cxx Diff File
mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.h Diff File
mod - Modules/Loadable/Markups/SubjectHierarchyPlugins/qSlicerSubjectHierarchyMarkupsPlugin.cxx Diff File
mod - Modules/Loadable/Markups/SubjectHierarchyPlugins/qSlicerSubjectHierarchyMarkupsPlugin.h Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModule.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModule.h Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h Diff File
mod - Modules/Loadable/Models/SubjectHierarchyPlugins/qSlicerSubjectHierarchyModelsPlugin.cxx Diff File
mod - Modules/Loadable/Models/SubjectHierarchyPlugins/qSlicerSubjectHierarchyModelsPlugin.h Diff File
mod - Modules/Loadable/Models/qSlicerModelsModule.cxx Diff File
mod - Modules/Loadable/Models/qSlicerModelsModule.h Diff File
mod - Modules/Loadable/Models/qSlicerModelsModuleWidget.cxx Diff File
mod - Modules/Loadable/Models/qSlicerModelsModuleWidget.h Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModule.cxx Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModule.h Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModuleWidget.cxx Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModuleWidget.h Diff File
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx Diff File
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.h Diff File
mod - Modules/Loadable/SceneViews/SubjectHierarchyPlugins/qSlicerSubjectHierarchySceneViewsPlugin.cxx Diff File
mod - Modules/Loadable/SceneViews/SubjectHierarchyPlugins/qSlicerSubjectHierarchySceneViewsPlugin.h Diff File
mod - Modules/Loadable/SceneViews/qSlicerSceneViewsModule.cxx Diff File
mod - Modules/Loadable/SceneViews/qSlicerSceneViewsModule.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyAbstractPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyDefaultPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyDefaultPlugin.h Diff File
mod - Modules/Loadable/Tables/SubjectHierarchyPlugins/qSlicerSubjectHierarchyTablesPlugin.cxx Diff File
mod - Modules/Loadable/Tables/SubjectHierarchyPlugins/qSlicerSubjectHierarchyTablesPlugin.h Diff File
mod - Modules/Loadable/Tables/qSlicerTablesModule.cxx Diff File
mod - Modules/Loadable/Tables/qSlicerTablesModule.h Diff File
mod - Modules/Loadable/Tables/qSlicerTablesModuleWidget.cxx Diff File
mod - Modules/Loadable/Tables/qSlicerTablesModuleWidget.h Diff File
mod - Modules/Loadable/Transforms/SubjectHierarchyPlugins/qSlicerSubjectHierarchyTransformsPlugin.cxx Diff File
mod - Modules/Loadable/Transforms/SubjectHierarchyPlugins/qSlicerSubjectHierarchyTransformsPlugin.h Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModule.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModule.h Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.h Diff File
mod - Modules/Loadable/VolumeRendering/Widgets/qSlicerVolumeRenderingModuleWidget.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Widgets/qSlicerVolumeRenderingModuleWidget.h Diff File
mod - Modules/Loadable/VolumeRendering/qSlicerVolumeRenderingModule.cxx Diff File
mod - Modules/Loadable/VolumeRendering/qSlicerVolumeRenderingModule.h Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyLabelMapsPlugin.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyLabelMapsPlugin.h Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.h Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModule.cxx Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModule.h Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModuleWidget.cxx Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModuleWidget.h Diff File
 First  Prev  1 2 3 4 5 ... 10 ... 20 ... 30 ... 40 ... 50 ... 55 56 57  Next  Last