Changesets: Import 2017-06-07 23:51:09

master b32401f7

2017-06-03 21:21:21

lassoan

Details Diff
ENH: SampleData module loads all data sets from Midas

Also added showing of loading status on the status bar, as the log window is not always visible in lower resolution screens.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26072 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File
mod - Modules/Scripted/SampleData/SampleData.py Diff File

master 0f353b3f

2017-06-03 08:39:55

lassoan

Details Diff
BUG: Changed sample data URLs

URL for sample data hosted on Slicer wiki is changed - update SampleData module accordingly.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26071 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/SampleData/SampleData.py Diff File

master ad1f8742

2017-06-02 11:58:19

lassoan

Details Diff
BUG: Prevent FreeSurfer overlay load from custom extensions

Revert change of allowing loading of FreeSurfer scalar overlays from custom extensions.
It interfered with the logic that determined what reader to use for loading model nodes.

Users may use composite file extensions that end with a standard extension.
For example, instead of lh.meanthickness_contrl these would all work:
lh.contrl.mean.thickness, lh.mean_contrl.thickness, lh_mean_contrl.thickness.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26070 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLFreeSurferModelOverlayStorageNode.cxx Diff File

master 29e20012

2017-06-02 11:19:13

jcfr

Details Diff
ENH: BuildSystem: Update DCMTK repo to support source download behind proxy

See https://discourse.slicer.org/t/slicer-compile-behind-proxy-clone-into-dcmtk-through-http/423

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26069 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_DCMTK.cmake Diff File

master c7f1d096

2017-06-02 08:48:03

lassoan

Details Diff
ENH: Fixed loading of FreeSurfer overlays with custom extensions

Loading of FreeSurfer scalar overlays from files were offered on the GUI for any file extensions,
but an internal check prevented loading from files with non-standard file extension (for example,
loading from lh.thickness worked but loading from lh.meanthickness_contrl did not).

Solved by assuming that overlays with custom file extensions can be read by vtkFSSurfaceScalarReader.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26068 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLFreeSurferModelOverlayStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLFreeSurferModelOverlayStorageNode.h Diff File

master 4927a223

2017-06-02 08:47:59

lassoan

Details Diff
COMP: Fixed build warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26067 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerVisibilityTest.cxx Diff File

master d1401490

2017-06-01 12:32:28

lassoan

Details Diff
ENH: Segmentation master representation is not changed during import

When a model or lablemap node was imported into segmentation node and the master representation
did not match the type of the imported node, the master representation of the segmentation was changed.
This behavior was not desirable, because it forced temporarily switching representation of all the nodes
in the existing segmentation to something else, resulting in some potential loss of details.

Changed behavior so that the imported node representation is changed during import (existing
segments in the segmentation node are not changed in any way).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26066 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Logic/vtkSlicerSegmentationsModuleLogic.cxx Diff File
mod - Modules/Loadable/Segmentations/Resources/UI/qSlicerSegmentationsModule.ui Diff File
mod - Modules/Loadable/Segmentations/qSlicerSegmentationsModuleWidget.cxx Diff File
mod - Modules/Loadable/Segmentations/qSlicerSegmentationsModuleWidget.h Diff File

master 1b1b2209

2017-06-01 12:32:21

lassoan

Details Diff
ENH: Added 'Crop to reference image geometry' segmentation conversion option

If 'Crop to reference image geometry' is enabled, then when closed surfaces are converted to labelmaps,
the extent of the generated labelmap will be restriced to the reference image extent.
It is useful for importing large models that have irrelevant parts outside the reference image.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26065 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkClosedSurfaceToBinaryLabelmapConversionRule.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkClosedSurfaceToBinaryLabelmapConversionRule.h Diff File

master b89fe71e

2017-06-01 12:32:06

lassoan

Details Diff
BUG: Fixed crosshair centered jump mode

When user translated a slice view, SliceOrigin was shifted and the crosshair did not appear in the center of the viewer.
When centering the viewer, SlicerOrigin has to be reset to (0,0,0).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26064 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSliceNode.cxx Diff File

master 15d79468

2017-06-01 10:53:50

pinter

Details Diff
ENH: Simplified subject hierarchy node resolving process

Subject hierarchy node resolving happens when a second subject hierarchy node appears in the scene - usually when a scene is imported. Then merging of the new SH nodes into the first one happens, after which the new (and now empty) SH nodes are removed. It has been possible to observe items added when resolving using SubjectHierarchyItemResolvedEvent, but it was too complicated, as Add and Resolve basically mean the same operation, just in different states. Now SubjectHierarchyItemAddedEvent is invoked as usual when resolving, but it is now possible to get notified about resolving operations using SubjectHierarchyStartResolveEvent and SubjectHierarchyEndResolveEvent. This also allows processing after scene import without using a timer.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26063 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginHandler.cxx Diff File

master acf259aa

2017-05-31 11:58:46

lassoan

Details Diff
BUG: Removed memory leaks using GetNodesByClass from Python

GetNodesByClass creates a new collection that the caller has to take ownership of (the caller will have to delete).
Python automatically adds a reference, so we have to call UnRegister to remove the extra reference.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26062 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/sitkUtils.py Diff File
mod - Libs/MRML/Core/Documentation/generate_default_color_node_property_table.py Diff File
mod - Modules/Scripted/DICOMLib/DICOMExportScene.py Diff File
mod - Modules/Scripted/EditorLib/LabelStructureListWidget.py Diff File

master ef7d83d3

2017-05-30 17:56:45

pieper

Details Diff
BUG: 0003776 warning dialog gave useless/misleading information

The fuzzy compare of image geometry looks at the difference
between two values, but the printing of the warning set the
precision based on the whole number including the digits
left of the decimal point. The result was a message that showed
identical numbers and reported them as different (understandably
confusing).

https://www.na-mic.org/Bug/view.php?id=3776

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26061 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File

master dac2a3d6

2017-05-30 16:19:49

lassoan

Details Diff
ENH: Updated EMSegment to use external iterators for shared collections

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26060 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master ff4a605e

2017-05-30 14:39:17

lassoan

Details Diff
BUG: Removed all iteratorless traverse of shared collections

Collections have convenience functions for traversing it without the need for creating an iterator,
using InitTraversal() and GetNextItemAsObject(). These functions use an internal iterator stored in the collection.

Problem:

When a collection is traversed using the internal iterator by multiple functions at the same time, the behavior will be incorrect.

For collections that can be accessed by multiple objects, it is almost impossible to make sure that only one function will use
the internal iterator at a time. Therefore, shared collections must be traversed using external iterators.

For example, this error caused a bug in View Controllers module: it only showed the first slice view controller (while there were three). The problem was that View Controllers module iterated through the nodes using the internal iterator and internally a method was called that asked for a list of nodes by classname, which used the same internal iterator.

Solution:

- Replaced all instances of shared collection traversal with internal iterator.
- Made vtkMRMLScene's InitTraversal, GetNextNode, and GetNextNodeByClass methods deprecated (they are still functional,
but log a warning when they are called).
- Added vtkMRMLScene::GetFirstNodeByClass convenience function and modified functions that used InitTraversal/GetNextNodeByClass
or GetNthNodeByClass(0, ...) to use this function.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26059 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SlicerRestoreSceneViewCrashIssue3445.py Diff File
mod - Base/QTCore/qSlicerSlicer2SceneReader.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableHierarchyNodeDisplayPropertiesTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneAddSingletonTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest2.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeImportSceneTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLTransformableNodeOnNodeReferenceAddTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLTransformableNodeReferenceSaveImportTest.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCameraNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLCameraDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLChartViewTest.py Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetTest1.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleReportDialog.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/qMRMLSceneAnnotationModelAndAnnotationTreeWidgetTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationAngleNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationControlPointsNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationFiducialNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationLinesNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationRulerNodeTest1.cxx Diff File
mod - Modules/Loadable/Cameras/Testing/Cxx/vtkSlicerCamerasModuleLogicCopyImportedCamerasTest.cxx Diff File
mod - Modules/Loadable/Colors/Testing/Cxx/qSlicerColorsModuleWidgetTest1.cxx Diff File
mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager3D.cxx Diff File
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.cxx Diff File
mod - Modules/Loadable/Models/Testing/Cxx/qSlicerModelsModuleWidgetTestScene.cxx Diff File
mod - Modules/Loadable/Models/Widgets/Testing/Cxx/qMRMLModelDisplayNodeWidgetTest2.cxx Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModuleWidget.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyChartsPlugin.cxx Diff File
mod - Modules/Loadable/Tables/SubjectHierarchyPlugins/qSlicerSubjectHierarchyTablesPlugin.cxx Diff File
mod - Modules/Loadable/Transforms/Widgets/qMRMLTransformInfoWidget.cxx Diff File
mod - Modules/Loadable/ViewControllers/qSlicerViewControllersModuleWidget.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Testing/Cxx/vtkMRMLVolumePropertyNodeTest1.cxx Diff File
mod - Modules/Scripted/DataProbe/DataProbe.py Diff File
mod - Modules/Scripted/EditorLib/LabelStructureListWidget.py Diff File
mod - Modules/Scripted/LabelStatistics/LabelStatistics.py Diff File
mod - Modules/Scripted/PerformanceTests/PerformanceTests.py Diff File

master 8bfbfc58

2017-05-29 21:57:28

lassoan

Details Diff
BUG: Fixed go to home module shortcut

The shortcut has to be added to a menu to make the shortcut action trigger signal connected to qSlicerAppMainWindow.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26058 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Resources/UI/qSlicerAppMainWindow.ui Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.h Diff File

master 55909cf8

2017-05-29 16:42:55

jcfr

Details Diff
ENH: cmake: Add FindVcvars CMake module

This module allows to look up path of 'vcvars(32|64|amd64).bat' scripts.

It will facilitate the building of Slicer extension including python
modules having compilation steps.

It is being contributed to upstream CMake as
https://gitlab.kitware.com/cmake/cmake/merge_requests/899

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26057 3bd1e089-480b-0410-8dfb-8563597acbee
add - CMake/FindVcvars.cmake Diff File

master cebb0e92

2017-05-29 16:42:54

jcfr

Details Diff
ENH: cmake: Allow use of GenerateProjectDescription_Step in extension

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26056 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/UseSlicer.cmake.in Diff File

master 900fc739

2017-05-29 16:42:52

jcfr

Details Diff
ENH: cmake: Check package availability when building against system python

This commit implements the check looking for required python modules
when building against system version of python.

For example, assuming that all required packages are installed in
a python virtual environment named "slicer":

$ cmake -DQT_QMAKE_EXECUTABLE:FILEPATH=/path/to/bin/qmake \
-DCMAKE_BUILD_TYPE:STRING=Release \
-DSlicer_USE_SYSTEM_python:BOOL=1 \
../Slicer

would output text like this one:

[...]
-- SuperBuild - python-pyparsing => Requires python[INCLUDED],
-- SuperBuild - python-pyparsing[OK] (SYSTEM)
-- PYPARSING_PATH: /home/jcfr/.virtualenvs/slicer/local/lib/python2.7/site-packages
-- PYPARSING_VERSION: 2.2.0
-- SuperBuild - python-packaging[OK] (SYSTEM)
-- PACKAGING_PATH: /home/jcfr/.virtualenvs/slicer/local/lib/python2.7/site-packages/packaging
-- PACKAGING_VERSION: 16.8
-- SuperBuild - python-six => Requires python[INCLUDED],
-- SuperBuild - python-six[OK] (SYSTEM)
-- SIX_PATH: /home/jcfr/.virtualenvs/slicer/local/lib/python2.7/site-packages
-- SIX_VERSION: 1.10.0
[...]

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26055 3bd1e089-480b-0410-8dfb-8563597acbee
add - CMake/ExternalProjectDependencyForPython.cmake Diff File
mod - CMake/UseSlicer.cmake.in Diff File
mod - CMakeLists.txt Diff File
mod - SuperBuild/External_NUMPY.cmake Diff File
mod - SuperBuild/External_python-GitPython.cmake Diff File
mod - SuperBuild/External_python-PyGithub.cmake Diff File
mod - SuperBuild/External_python-appdirs.cmake Diff File
mod - SuperBuild/External_python-chardet.cmake Diff File
mod - SuperBuild/External_python-couchdb.cmake Diff File
mod - SuperBuild/External_python-gitdb.cmake Diff File
mod - SuperBuild/External_python-nose.cmake Diff File
mod - SuperBuild/External_python-packaging.cmake Diff File
mod - SuperBuild/External_python-pip.cmake Diff File
mod - SuperBuild/External_python-pydicom.cmake Diff File
mod - SuperBuild/External_python-pyparsing.cmake Diff File
mod - SuperBuild/External_python-setuptools.cmake Diff File
mod - SuperBuild/External_python-six.cmake Diff File
mod - SuperBuild/External_python-smmap.cmake Diff File
mod - SuperBuild/External_python-wheel.cmake Diff File
mod - SuperBuild/External_python.cmake Diff File

master 389b8fbe

2017-05-27 11:34:11

lassoan

Details Diff
BUG: Fixed locking of checkable table columns

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26054 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLTableModel.cxx Diff File

master e30fef25

2017-05-27 11:10:29

lassoan

Details Diff
ENH: Improved table node

- Changed table schema column name: "name" column in table schema looked like a regular property, it was not obvious that it refers to column name.
"columnName" is now used instead, to make the reference more explicit.
- Fixed copy-paste of bit type cells displayed as (checkboxes)
- Updated documentation
- Improved log messages and fixed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26053 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/TestData/table.schema.csv Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLTableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTableStorageNode.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLTableModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLTableView.cxx Diff File

master 6910a59e

2017-05-26 21:11:23

lassoan

Details Diff
ENH: Added schema file support for defining table column properties

Data type, default value, long name, description, unit, and any number of custom properties can now be defined for each column in a vtkMRMLTableNode.

Long name, description, and unit are shown in table view.
Data type is used for creating numeric arrays when reading the table.csv
Default value is used for initializing values in new rows.

Properties are stored in a schema file, which is a CSV or TSV file with the composite file extension .schema.csv (or .schema.csv or .schema.txt) with the same base filename as the data table file.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26052 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/CMakeLists.txt Diff File
mod - Libs/MRML/Core/Testing/TestData/table.csv Diff File
add - Libs/MRML/Core/Testing/TestData/table.schema.csv Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLTableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLTableStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTableStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableStorageNode.h Diff File
mod - Libs/MRML/Widgets/qMRMLTableModel.cxx Diff File
mod - Modules/Loadable/Tables/Logic/vtkSlicerTablesLogic.cxx Diff File
mod - Modules/Loadable/Tables/Logic/vtkSlicerTablesLogic.h Diff File
mod - Modules/Loadable/Tables/Testing/Cxx/vtkSlicerTablesLogicAddFileTest.cxx Diff File
mod - Modules/Loadable/Tables/Testing/Python/TablesSelfTest.py Diff File
mod - Modules/Loadable/Tables/qSlicerTablesReader.cxx Diff File

master f7c1e39f

2017-05-26 14:51:46

pinter

Details Diff
BUG: Fixed various subject hierarchy issues

- When the subject hierarchy node was removed programmatically, then subject hierarchy was not rebuilt, and became unusable. It's because vtkCommand::Delete was not called when removing it from python, as a reference from the console was still around, so vtkMRMLScene::NodeRemovedEvent is observed instead. Also plugin logic explicitly rebuilds the new subject hierarchy node when the original one was removed
- Added checks and removed unnecessary calls to remove unnecessary warning messages

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26051 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyComboBox.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyModel.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginHandler.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginHandler.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.h Diff File
mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModule.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.cxx Diff File

master 5b50bc97

2017-05-26 11:07:04

lassoan

Details Diff
BUG: Removed CLI tests from install package

They caused printing of these warning messages:
When loading module "CLIEventTest" , the dependency "CLI4Test" failed to be loaded.
When loading module "TwoCLIsInARowTest" , the dependency "CLI4Test" failed to be loaded.
When loading module "TwoCLIsInParallelTest" , the dependency "CLI4Test" failed to be loaded.

The problem was that the testing CLI modules that they required was not included in the package. It makes the most sense to not include these low-level tests in the installation package at all.

Note that Slicer tests that are run with --disable-cli-modules may still print similar messages for scripted or loadable modules that rely on CLI modules.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26050 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File

master 1612d69d

2017-05-26 10:34:34

pinter

Details Diff
BUG: Fixed failing subject hierarchy generic tests

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26049 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginHandler.cxx Diff File

master d31c06c9

2017-05-25 18:03:03

jcfr

Details Diff
COMP: BuildSystem: Ensure extension can find CTKAppLauncherLib

Fix regression introduced in r26042 (ENH: Add support for reading
launcher setting using CTKAppLauncherLib)

Reported-by: Isaiah Norton <inorton@bwh.harvard.edu>
Tested-by: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26048 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerGenerateSlicerConfig.cmake Diff File
1 2 3 4 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last