View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004286Slicer4Module VolumeRenderingpublic2016-10-24 16:062016-10-24 23:59
Reporterinorton Assigned Tolassoan  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionFixed in VersionSlicer 4.7.0 
Summary0004286: Volume Rendering should allow use of all, and only, available VRAM
Description

~The Volume Rendering module currently hard-codes VRAM choices [1], with a maximum selectable value of 16GB.~

However due to logic in [1], the maximum usable value is 2GB.

Additionally, the VRAM selector would ideally only offer selection up to the maximum real VRAM available on the user GPU.

[1] https://github.com/Slicer/Slicer/blob/667198538265dd619b77988b43da4f8393d15875/Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx#L282-L332

TagsNo tags attached.

Activities

pieper

pieper

2016-10-24 16:13

administrator   ~0014220

The gui was recently updated but not the logic.

https://github.com/Slicer/Slicer/commit/3358134308171ee3bb260e163956bebdd04fc2c2
pieper

pieper

2016-10-24 16:35

administrator   ~0014221

Reminder sent to: lassoan

Adding Andras to the discussion
lassoan

lassoan

2016-10-24 16:41

developer   ~0014222

I'll fix this.
lassoan

lassoan

2016-10-24 23:27

developer   ~0014224

Fixed in r25477 by allowing setting larger fixed values (without any top limit). In the GUI there is still a limit - 16GB - that should be enough for a good while.
lassoan

lassoan

2016-10-24 23:28

developer   ~0014225

Determining maximum GPU memory size may be tricky (there can be multiple GPUs, different kinds of memory - dedicated, shared, etc), so hardcoding used memory size is not that unreasonable.

The current default GPU memory size of 256MB (specified in vtkMRMLVolumeRenderingDisplayableManager::DefaultGPUMemorySize) could be raised though, maybe 512MB would be a good choice, as most medical images would entirely fit and most cards nowadays have this much memory (at least shared).
inorton

inorton

2016-10-24 23:59

developer   ~0014226

Thanks!

Issue History

Date Modified Username Field Change
2016-10-24 16:06 inorton New Issue
2016-10-24 16:06 inorton Status new => assigned
2016-10-24 16:06 inorton Assigned To => finetjul
2016-10-24 16:13 pieper Note Added: 0014220
2016-10-24 16:19 inorton Description Updated View Revisions
2016-10-24 16:35 pieper Note Added: 0014221
2016-10-24 16:41 lassoan Note Added: 0014222
2016-10-24 23:27 lassoan Note Added: 0014224
2016-10-24 23:27 lassoan Status assigned => resolved
2016-10-24 23:27 lassoan Fixed in Version => Slicer 4.7.0
2016-10-24 23:27 lassoan Resolution open => fixed
2016-10-24 23:27 lassoan Assigned To finetjul => lassoan
2016-10-24 23:28 lassoan Note Added: 0014225
2016-10-24 23:59 inorton Note Added: 0014226
2016-10-24 23:59 inorton Status resolved => closed