View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003972Slicer4Core: Base Codepublic2015-03-02 09:592018-03-02 11:06
Reporteruser731Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.4.0 
Target VersionSlicer 4.5.0-1Fixed in VersionSlicer 4.5.0-1 
Summary0003972: Packaging does not include system libraries
Description

On windows for example, the packaging does not include the redistributable libraries.

Since https://github.com/Slicer/Slicer/commit/deb57c4f5579761160cd816598c518366b1df2f6 (issue 0002397 / commit r23158 [1]), Slicer uses the CMake components to make its package. However, the InstallRequiredSystemLibraries.cmake
(https://github.com/Slicer/Slicer/blob/master/CMake/SlicerCPack.cmake#L47) does not uses components (yet) and the system libraries are labelled as "Unspecified".
They are consequently not installed by Slicer since it installs only the "Runtime"
libraries.

[1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23158

Additional Information

Pull request to come.

TagsNo tags attached.

Activities

user731

2015-03-02 10:19

  ~0012949

See pull request here: https://github.com/Slicer/Slicer/pull/240

user731

2015-03-02 13:40

  ~0012953

Fixed in revision: r24010

Related Changesets

Import 2017-06-07 23:51:09: master 0d6d4872

2015-03-02 18:18:33

johan.andruejol

Details Diff 		COMP: Fix redistributable system libraries in packaging. Fixes 0003972

This commit fixes a regression introduced by r23158 (Explicitly installs
the needed component and skips the development component if not explicitly
requested.). When Slicer switched to using component for packaging, the VS
redistributable libraries were not included anymore in the package. This
is explained by the fact the CMake module "InstallRequiredSystemLibraries"
does not support components.

Waiting the issue reported on CMake bug tracker [1] is resolved and the
minimum required CMake version is updated, this commit duplicates the logic
installing the redistributable libraries specifying the "RuntimeLibraries"
component.

[1] http://www.cmake.org/Bug/view.php?id=15428)

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24010 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerCPack.cmake Diff File

Issue History

Date Modified Username Field Change
2015-03-02 09:59 user731 New Issue
2015-03-02 09:59 user731 Status new => assigned
2015-03-02 09:59 user731 Assigned To => jcfr
2015-03-02 10:12 jcfr Target Version => Slicer 4.4.1
2015-03-02 10:15 user731 Description Updated
2015-03-02 10:19 user731 Note Added: 0012949
2015-03-02 10:20 jcfr Description Updated
2015-03-02 13:40 user731 Note Added: 0012953
2015-03-02 13:45 jcfr Status assigned => resolved
2015-03-02 13:45 jcfr Fixed in Version => Slicer 4.4.1
2015-03-02 13:45 jcfr Resolution open => fixed
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1
2015-09-09 08:29 jcfr Target Version Slicer 4.4.1 => Slicer 4.5.0-1
2017-06-10 08:51 johan.andruejol Changeset attached => Slicer master 0d6d4872
2018-03-02 11:06 jcfr Status resolved => closed