View Issue Details

IDProjectCategoryView StatusLast Update
0002397Slicer4Core: Packagingpublic2017-06-10 08:51
Reporterlassoan Assigned Tojcfr  
PriorityhighSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0002397: Remove lib and h files from the Slicer package
Description

Currently there are 40MB .lib and .h files in the installed Slicer tree. If the only reason to include these files is to allow people to theoretically link the libs to their C++ programs then probably we should remove these files.

The probability of making these libraries work with another program (most likely built with slightly different compiler version and options) is very low.

TagsNo tags attached.

Relationships

duplicate of 0002637 acknowledgedjcfr Include all Python header files with nightly binary build 
related to 0003455 acknowledgedalexy Contribute patch to teem project - Add option to skip install of dev files 

Activities

jcfr

jcfr

2013-08-30 20:27

administrator   ~0009759

Inspecting the package there is only the header associated with teem.

jcfr

jcfr

2013-10-21 12:46

administrator   ~0010206

Fixed in r22636
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22636

lassoan

lassoan

2013-10-29 12:46

developer   ~0010237

The latest nightly package (Slicer 4.3.1-2013-10-28 (Win64)) still contains 90MB of .lib and .h files. Nothing should require these files and after removing them everything seems to work just fine.

jcfr

jcfr

2014-04-08 14:00

administrator   ~0011557

Related commits:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23052
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23060

jcfr

jcfr

2014-05-12 23:15

administrator   ~0011742

Last edited: 2014-05-15 14:05

Fixed in r23158, r23157
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23158
and http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23157

Current package size is:

Linux: 242 MB
MacOSX: 221 MB
Windows: 162 MB

After this commit:

Linux: 239 MB
MacOSX: 218 MB
Windows: 156 MB

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014575

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 384fadb2

2013-10-21 16:43:02

jcfr

Details Diff
COMP: Do not install teem development files.

Fixes 0002397

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22636 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerCPack.cmake Diff File

Import 2017-06-07 23:51:09: master deb57c4f

2014-05-13 03:07:08

jcfr

Details Diff
ENH: Reduce package size by not installing export libraries. Fixes 0002397

This commit explicitly installs the needed component and skips the
development component if not explicitly requested.

Since on DLL platform, export libraries (.lib) are considered as archive [1]
and are associated with the development component, they won't be installed
in the package.

[1] http://www.cmake.org/cmake/help/v2.8.12/cmake.html#command:install

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23158 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerCPack.cmake Diff File

Issue History

Date Modified Username Field Change
2012-08-14 11:31 lassoan New Issue
2012-08-14 11:31 lassoan Status new => assigned
2012-08-14 11:31 lassoan Assigned To => jcfr
2012-08-22 05:41 jcfr Target Version => Slicer 4.3.0
2013-08-30 20:26 jcfr Target Version Slicer 4.3.0 => Slicer 4.3.1
2013-08-30 20:27 jcfr Note Added: 0009759
2013-08-30 20:42 jcfr Relationship added duplicate of 0002637
2013-10-01 11:34 jcfr Target Version Slicer 4.3.1 => Slicer 4.3.2
2013-10-21 12:44 jcfr Relationship added related to 0003455
2013-10-21 12:46 jcfr Note Added: 0010206
2013-10-21 12:46 jcfr Status assigned => resolved
2013-10-21 12:46 jcfr Fixed in Version => Slicer 4.3.2
2013-10-21 12:46 jcfr Resolution open => fixed
2013-10-21 12:46 jcfr Tag Attached: ToBeBackported
2013-10-29 12:46 lassoan Note Added: 0010237
2013-10-29 12:46 lassoan Status resolved => assigned
2014-03-06 10:15 nicole Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-06 10:17 nicole Fixed in Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-07 10:57 jcfr Tag Detached: ToBeBackported
2014-03-07 11:59 jcfr Priority normal => high
2014-04-08 14:00 jcfr Note Added: 0011557
2014-05-12 23:15 jcfr Note Added: 0011742
2014-05-12 23:15 jcfr Status assigned => resolved
2014-05-15 14:05 jcfr Note Edited: 0011742
2014-09-17 22:57 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 384fadb2
2017-06-07 23:27 jcfr Note Added: 0014575
2017-06-10 08:51 jcfr Changeset attached => Slicer master deb57c4f