View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003910Slicer4Core: Building (CMake, Superbuild)public2014-12-01 19:232018-03-02 11:06
Reporterjcfr Assigned Topinter  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.5.0-1Fixed in VersionSlicer 4.5.0-1 
Summary0003910: Fix compilation warnings in DICOM export code
Description

/home/jchris/Projects/Slicer-2/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx: In member function ‘void qSlicerSubjectHierarchyParseLocalDataPlugin::createHierarchyFromLoadedDirectoryStructure()’:
/home/jchris/Projects/Slicer-2/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx:224:89: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (unsigned int componentIndex=0; componentIndex<loadedFilePaths[nodeIndex].count(); ++componentIndex)
^
/home/jchris/Projects/Slicer-2/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx:234:68: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
else if (componentIndex < loadedFilePaths[nodeIndex].count()-1)

/home/jchris/Projects/Slicer-2/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.cxx:180:6: warning: unused parameter ‘node’ [-Wunused-parameter]
void qSlicerDICOMExportDialog::onCurrentNodeChanged(vtkMRMLNode* node)
^

/home/jchris/Projects/Slicer-2/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx: In member function ‘void qSlicerDICOMTagEditorWidget::commitChangesToNodes()’:
/home/jchris/Projects/Slicer-2/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx:526:77: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (unsigned int row=d->topSeriesHeaderRow(); row<d->TagsTable->rowCount(); ++row)
^
/home/jchris/Projects/Slicer-2/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx:556:67: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int row=d->StudyTagsHeaderRow+1; row<d->topSeriesHeaderRow(); ++row)
^
/home/jchris/Projects/Slicer-2/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx:572:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int row=1; row<d->StudyTagsHeaderRow; ++row)
^
/home/jchris/Projects/Slicer-2/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx: In member function ‘void qSlicerDICOMTagEditorWidget::tagsTableCellChanged(int, int)’:
/home/jchris/Projects/Slicer-2/Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx:592:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (row < d->topSeriesHeaderRow())

TagsNo tags attached.

Relationships

related to 0003163 closednicole Export from DICOM browser 

Activities

pinter

pinter

2014-12-02 05:12

developer   ~0012743

Thanks, I'll fix these.
pinter

pinter

2014-12-02 10:45

developer   ~0012754

Last edited: 2014-12-02 10:45

Fixed in
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23812
Have not double checked on Linux, but these were pretty straightforward warnings

Related Changesets

Import 2017-06-07 23:51:09: master 27cb942a

2014-12-02 14:06:17

pinter

Details Diff 		COMP: Fixed linux build warnings

Also fix Subject Hierarchy failing python self tests.

Fixes 0003910

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23812 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyCorePluginsSelfTest.py Diff File
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyGenericSelfTest.py Diff File
mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx Diff File
mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.cxx Diff File
mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMTagEditorWidget.cxx Diff File

Issue History

Date Modified Username Field Change
2014-12-01 19:23 jcfr New Issue
2014-12-01 19:23 jcfr Status new => assigned
2014-12-01 19:23 jcfr Assigned To => jcfr
2014-12-01 19:24 jcfr Assigned To jcfr => pinter
2014-12-01 19:24 jcfr Relationship added related to 0003163
2014-12-01 19:24 jcfr Target Version => Slicer 4.4.1
2014-12-01 19:24 jcfr Description Updated
2014-12-02 05:12 pinter Note Added: 0012743
2014-12-02 05:12 pinter Status assigned => acknowledged
2014-12-02 10:45 pinter Note Added: 0012754
2014-12-02 10:45 pinter Status acknowledged => resolved
2014-12-02 10:45 pinter Fixed in Version => Slicer 4.4.1
2014-12-02 10:45 pinter Resolution open => fixed
2014-12-02 10:45 pinter Note Edited: 0012754
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1
2015-09-09 08:29 jcfr Target Version Slicer 4.4.1 => Slicer 4.5.0-1
2017-06-10 08:51 pinter Changeset attached => Slicer master 27cb942a
2018-03-02 11:06 jcfr Status resolved => closed