View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003388Slicer4Core: MRMLpublic2013-09-10 18:542014-03-06 10:17
Reporterjcfr Assigned Toalexy  
PrioritynormalSeveritytrivialReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionSlicer 4.3.0 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003388: Review how mrml reference are observed in vtkMRMLTransformableNode and vtkMRMLDisplayableNode
Description

(1) https://github.com/Slicer/Slicer/blob/f20eb2dbd6a398d82709a12addca3df5e83ee9c2/Libs/MRML/Core/vtkMRMLTransformableNode.cxx#L132-L155

(2) https://github.com/Slicer/Slicer/blob/f20eb2dbd6a398d82709a12addca3df5e83ee9c2/Libs/MRML/Core/vtkMRMLDisplayableNode.h#L77-L96

Which one of these two approaches should be recommended ?

TagsNo tags attached.

Relationships

related to 0003241 closedjcfr Transforms are not applied to volumes when scene is read from a file 
related to 0003436 closedalexy moving a model outside a transform node does not update display 

Activities

alexy

alexy

2013-09-27 10:20

developer   ~0010099

Added observer events parameter to the vtkMRMLNode::AddNodeReferenceRole() method, so that the events can be set only once in subclasses. Added observed events to DisplayableNode and TransformableNode. Simplified and unified reference implementation in TransformableNode.

At revision: 22523
jcfr

jcfr

2013-09-27 13:39

administrator   ~0010101

Following r22523, test "vtkMRMLNodeTest1" is now failing.

See http://slicer.cdash.org/testDetails.php?test=4480308&build=155371

If fails because when referenceRole is null. See: https://github.com/Slicer/Slicer/blob/ad3ac24d55450360f99b47d70d332e6e42bd8bab/Libs/MRML/Core/vtkMRMLNode.cxx#L1171-1188

You could locally run MRML related tests doing:

ctest -C Release -L "MRML(Core|Logic|Widgets|Displayable)"

or independently:

ctest -C Release -L MRMLCore

ctest -C Release -L MRMLLogic

ctest -C Release -L MRMLWidgets

...
alexy

alexy

2013-09-27 14:57

developer   ~0010103

Fixed crash in test when referenceRole is 0
At revision: 22527
jcfr

jcfr

2014-03-06 05:25

administrator   ~0011214

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2013-09-10 18:54 jcfr New Issue
2013-09-10 18:54 jcfr Status new => assigned
2013-09-10 18:54 jcfr Assigned To => alexy
2013-09-10 18:54 jcfr Target Version => Slicer 4.3.1
2013-09-10 18:54 jcfr Relationship added related to 0003241
2013-09-17 12:15 jcfr Target Version Slicer 4.3.1 => Slicer 4.3.2
2013-09-27 10:20 alexy Note Added: 0010099
2013-09-27 10:20 alexy Status assigned => resolved
2013-09-27 10:20 alexy Resolution open => fixed
2013-09-27 13:39 jcfr Note Added: 0010101
2013-09-27 13:39 jcfr Status resolved => assigned
2013-09-27 14:57 alexy Note Added: 0010103
2013-09-27 14:57 alexy Status assigned => resolved
2013-10-05 06:07 alexy Relationship added related to 0003436
2013-10-21 05:59 jcfr Fixed in Version => Slicer 4.3.2
2014-03-06 05:25 jcfr Note Added: 0011214
2014-03-06 05:28 jcfr Status resolved => closed
2014-03-06 10:16 nicole Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-06 10:17 nicole Fixed in Version Slicer 4.3.2 => Slicer 4.4.0