View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003241Slicer4Core: Base Codepublic2013-07-23 15:312017-06-07 23:27
Reporterlassoan Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003241: Transforms are not applied to volumes when scene is read from a file
Description

How to reproduce:

  • Download MRHead example
  • Apply a linear transform (don't harden)
  • Save scene, restart Slicer, load scene
  • Modify the linear transform in the transforms module
  • When the transform is modified using the module GUI, the The MRHead volume doesn't move

Tested on Slicer 4.2.0-2013-07-20 (Win64)

TagsNo tags attached.

Relationships

related to 0003072 closedalexy Transforms are not applied to any node 
related to 0003133 closedalexy TransformModifiedEvent is not fired anymore when new TransformNode is set 
related to 0003112 closedalexy problem calling SetAndObserveNthNodeReferenceID for transfom nodes 
related to 0003020 closedjcfr Modifying the transform matrix of a linear transform does not change file status to "Modified" 
related to 0003388 closedalexy Review how mrml reference are observed in vtkMRMLTransformableNode and vtkMRMLDisplayableNode 

Activities

yuzheng

yuzheng

2013-08-27 08:28

developer   ~0009616

Last edited: 2013-08-27 10:13

Fix is pushed here: https://github.com/yuzhengZ/Slicer/commit/deb391f78cbb57c4756564e785be24e008ac5275
jcfr

jcfr

2013-08-27 15:07

administrator   ~0009653

Fixed in r22343
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22343
jcfr

jcfr

2013-09-03 12:44

administrator   ~0009867

Reminder sent to: alexy

Hi Alex, could you review what "yuzheng" did. Thks
lassoan

lassoan

2013-09-03 16:36

developer   ~0009882

The problem is not reproducible anymore (tested Slicer-4.2.2-2013-08-28 on Win7, 64-bit).
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014605

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file f20eb2db

2013-08-27 19:06:53

jcfr

Details Diff 		BUG: 3241 Fix transform not applied to volume when scene is read from a file

When a scene is loaded, vtkMRMLScene::UpdateNodeReferences doesn't handle event registration.
Except for vtkCommand::ModifiedEvent, any other events need to be registered via OnNodeReferenceAdded API.
Fixes 0003241

From: Yuzheng Zhou <yuzheng.zhou@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22343 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/CMakeLists.txt Diff File
add - Libs/MRML/Core/Testing/vtkMRMLTransformableNodeOnNodeReferenceAddTest.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.h Diff File

Issue History

Date Modified Username Field Change
2013-07-23 15:31 lassoan New Issue
2013-07-23 15:31 lassoan Status new => assigned
2013-07-23 15:31 lassoan Assigned To => jcfr
2013-07-23 20:29 jcfr Relationship added related to 0002980
2013-07-23 20:29 jcfr Assigned To jcfr => yuzheng
2013-07-23 20:29 jcfr Target Version => Slicer 4.3.0
2013-08-19 11:59 jcfr Relationship added related to 0003303
2013-08-20 10:03 yuzheng Relationship deleted related to 0002980
2013-08-20 10:04 yuzheng Relationship added related to 0003072
2013-08-20 10:05 yuzheng Relationship added related to 0003133
2013-08-20 10:05 yuzheng Relationship added related to 0003112
2013-08-20 10:06 yuzheng Relationship deleted related to 0003303
2013-08-27 08:28 yuzheng Note Added: 0009616
2013-08-27 10:13 yuzheng Note Edited: 0009616
2013-08-27 15:07 jcfr Note Added: 0009653
2013-08-27 15:07 jcfr Status assigned => resolved
2013-08-27 15:07 jcfr Fixed in Version => Slicer 4.3.0
2013-08-27 15:07 jcfr Resolution open => fixed
2013-09-02 20:16 jcfr Relationship added related to 0003020
2013-09-03 12:44 jcfr Note Added: 0009867
2013-09-03 16:36 lassoan Note Added: 0009882
2013-09-03 16:36 lassoan Status resolved => closed
2013-09-10 18:54 jcfr Relationship added related to 0003388
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file f20eb2db
2017-06-07 23:27 jcfr Note Added: 0014605
2017-06-07 23:27 jcfr Assigned To yuzheng => jcfr