View Issue Details

IDProjectCategoryView StatusLast Update
0003293Slicer4Core: Base Codepublic2017-06-07 23:27
Reporterspujol Assigned Tojcfr  
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003293: Favorite modules
Description

I selected the three modules: Scene Views, Volumes and Tractography Display as favorite modules in the Application Settings window.

However, when I re-start Slicer, only Scene Views and Volumes show up as favorite modules in the top banner. Can modules that do not have an icon (e.g. Tractography Display) still be listed as favorite modules ? Should all modules have an icon ?

TagsNo tags attached.

Relationships

duplicate of 0002161 closedcrmullin Adding CLI modules to favorite modules list does not work 
related to 0002942 closedjcfr Python scripted modules not detected by the before/after module selection arrows 

Activities

2013-08-15 13:12

 

2013-08-15 13:13

 

3293-Default-icon-Color.png (416,473 bytes)
3293-Default-icon-Color.png (416,473 bytes)

2013-08-15 13:13

 

jcfr

jcfr

2013-08-15 13:15

administrator   ~0009480

Ron: I think that we should enforce that every module get an icon. In particular the core modules.

Jc: If no icon is provided, I was thinking to associate this icon with all modules (CLI, loadable, ... ): https://github.com/Slicer/Slicer/blob/master/Base/QTGUI/Resources/Icons/Extension.png

Steve: Makes perfect sense to me. (or if you prefer: +1)

Julien: I tried once to give an icon to all the modules, but it made the list quite cluttered.
You probably would have to run some experimentations, maybe a more transparent version of the icon could be better.
(and to be even more picky, the color should probably be part of the Human Interface style guide color scheme (but I'm not sure it's still valid)).

Jc: Let me know what you think of the following experiments (see attached files)

Ron: LightGreen looks good.

2013-08-15 13:38

 

2013-08-15 13:38

 

Extension.png (4,844 bytes)
Extension.png (4,844 bytes)

2013-08-15 13:38

 

Extension-LightGreen.png (6,570 bytes)
Extension-LightGreen.png (6,570 bytes)

2013-08-15 13:38

 

ExtensionLightGreen2.png (6,687 bytes)
ExtensionLightGreen2.png (6,687 bytes)
jcfr

jcfr

2013-08-15 14:39

administrator   ~0009481

Fixed in r22288
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22288

2013-08-18 13:15

 

2013-08-18 13:15

 

Extension-SlicerBlue.png (6,151 bytes)
Extension-SlicerBlue.png (6,151 bytes)
jcfr

jcfr

2013-08-18 13:16

administrator   ~0009499

See r22291 - http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22291

BUG: Update default module icon color

Commit r22288 associated a default icon with all modules. Then, as
suggested by Wendy Plesniak this commit changes the icon color to
be "SlicerBlue".

See 0003293

Co-authored-by: Wendy Plesniak <wjp@bwh.harvard.edu>

jcfr

jcfr

2014-03-06 04:56

administrator   ~0010824

Closing resolved issues that have not been updated in more than 3 months

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014620

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file dd0d76a9

2013-08-15 18:38:49

jcfr

Details Diff
BUG: Associate default icon with all modules.

Doing so will allow module to be added to the module toolbar by updating
the list of favorite modules in the application settings.

Fixes 0003293

Co-authored-by: Julien Finet <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22288 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/Resources/Icons/Extension.png Diff File
mod - Base/QTGUI/qSlicerAbstractModule.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModule.cxx Diff File

Issue History

Date Modified Username Field Change
2013-08-13 07:18 spujol New Issue
2013-08-13 07:18 spujol Status new => assigned
2013-08-13 07:18 spujol Assigned To => jcfr
2013-08-15 13:12 jcfr Target Version => Slicer 4.3.0
2013-08-15 13:12 jcfr File Added: 3293-Default-icon-Black-and-white.png
2013-08-15 13:13 jcfr File Added: 3293-Default-icon-Color.png
2013-08-15 13:13 jcfr File Added: 3293-Default-icon-LightGreen.png.png
2013-08-15 13:15 jcfr Note Added: 0009480
2013-08-15 13:38 jcfr File Added: 3293-Default-icon-LightGreen.png2.png
2013-08-15 13:38 jcfr File Added: Extension.png
2013-08-15 13:38 jcfr File Added: Extension-LightGreen.png
2013-08-15 13:38 jcfr File Added: ExtensionLightGreen2.png
2013-08-15 14:39 jcfr Note Added: 0009481
2013-08-15 14:39 jcfr Status assigned => resolved
2013-08-15 14:39 jcfr Fixed in Version => Slicer 4.3.0
2013-08-15 14:39 jcfr Resolution open => fixed
2013-08-18 13:15 jcfr File Added: 3293-Default-icon-SlicerBlue.png
2013-08-18 13:15 jcfr File Added: Extension-SlicerBlue.png
2013-08-18 13:16 jcfr Note Added: 0009499
2013-08-30 13:33 jcfr Relationship added duplicate of 0002161
2013-09-03 05:36 jcfr Relationship added related to 0002942
2014-03-06 04:56 jcfr Note Added: 0010824
2014-03-06 04:58 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file dd0d76a9
2017-06-07 23:27 jcfr Note Added: 0014620