View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003266 | Slicer4 | Core: Base Code | public | 2013-07-31 08:37 | 2014-03-06 05:23 |
Reporter | jcfr | Assigned To | finetjul | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0003266: Check that CTK topic "ctkvalueproxy" do not cause issue | ||||
Description | From Julien: The first part of the "dimensionality" problem (0001694, 0002973, 0002480...) is already part of Slicer 4.3: The second part is to be able to change the order of magnitude of the values displayed to the user. This second part According to the release schedule (see [1]) , to the value of the feature and to the potential impact on the code Note that if the user does not play with the units, it should not bring too much regression (part 0000002 comes primarily // -------------------------------------------- I think we should remain conservative and focus on the issue currently targeted for 4.3. To help us take a final decision, few questions / remarks:
| ||||
Tags | No tags attached. | ||||
I found two issues related to the CTK topic ctkvalueproxy. 1) It introduces lots of "Single Step ... is out of bounds" warning messages in Slicer's output when Slicer starts, a volume is loaded, etc. 2) It fixed the original issue 0002973, but when user types a small number with higher precision than currently displayed number, the displayed value in other fields are still not correct.
|
|
Reminder sent to: finetjul Hi Julien, Could you have a look at note 9309 ? Thanks |
|
1) I'll fix it soon |
|
What about setting the number of decimals doing something like: this->setDecimals(16); |
|
Because it will enforce 16 decimals no matter what. |
|
But it would at least be accurate and allow us to move forward with the other issues. When done, we could then address the issue of decoupling displayed value from internal value. An other option would be to display the truncated value in a label, and when the user click on the "link" we would popup a value editor with full precision. |
|
I would prefer subsolution 2) (edit in a popup) rather than subsolution1) |
|
Please try https://github.com/finetjul/Slicer/commit/14a1b7743244e3d9d665ae1497327e41f2fe7a85 |
|
Nice work! The issues in note 0009309 have been fixed. |
|
Fixed in r22281 |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2013-07-31 08:37 | jcfr | New Issue | |
2013-07-31 08:37 | jcfr | Status | new => assigned |
2013-07-31 08:37 | jcfr | Assigned To | => jcfr |
2013-07-31 08:38 | jcfr | Target Version | => Slicer 4.3.0 |
2013-07-31 08:38 | jcfr | Relationship added | related to 0003261 |
2013-07-31 11:04 | yuzheng | Note Added: 0009309 | |
2013-07-31 18:39 | jcfr | Assigned To | jcfr => yuzheng |
2013-07-31 18:40 | jcfr | Note Added: 0009313 | |
2013-08-01 07:00 | finetjul | Note Added: 0009328 | |
2013-08-01 07:36 | jcfr | Note Added: 0009329 | |
2013-08-01 07:40 | jcfr | Note Edited: 0009329 | |
2013-08-01 07:55 | finetjul | Note Added: 0009331 | |
2013-08-02 08:06 | jcfr | Note Added: 0009355 | |
2013-08-02 08:21 | finetjul | Note Added: 0009358 | |
2013-08-07 07:14 | yuzheng | Assigned To | yuzheng => finetjul |
2013-08-07 11:43 | finetjul | Note Added: 0009424 | |
2013-08-08 09:50 | yuzheng | Note Added: 0009430 | |
2013-08-08 09:55 | yuzheng | Note Edited: 0009430 | |
2013-08-09 11:52 | finetjul | Note Added: 0009447 | |
2013-08-09 11:52 | finetjul | Status | assigned => resolved |
2013-08-09 11:52 | finetjul | Fixed in Version | => Slicer 4.3.0 |
2013-08-09 11:52 | finetjul | Resolution | open => fixed |
2014-03-06 05:21 | jcfr | Note Added: 0011162 | |
2014-03-06 05:23 | jcfr | Status | resolved => closed |