View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003046Slicer4Core: MRMLpublic2013-04-04 06:162014-03-06 06:16
Reporterpinter Assigned Toalexy  
PriorityurgentSeveritymajorReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003046: Getting the TransformNodeID from vtkMRMLTransformableNode returns the StorageNodeID
Description

The member variables TransformNodeReferenceRole and TransformNodeReferenceRererenceMRMLAttributeName are supposed to be "transform" and "transformNodeRef" instead of "storage" and "storageNodeRef".

This causes bugs in applications that rely on the transformable property.

Additional Information

JC's comment about the issue:

@Alex: While removing the std::string was good, I would suggest you re-add member allowing to reference the role type using a class member: TRANSFORM_NODE_REFERENCE_ROLE, ... Using string directly is a regression.

For an example, look here: https://www.assembla.com/code/slicerrt/subversion/nodes/728/trunk/SlicerRt/src/PatientHierarchy/Logic/vtkSlicerPatientHierarchyModuleLogic.h#ln48

TagsNo tags attached.

Relationships

related to 0003047 closedalexy transforms don't trigger re-render on change 

Activities

alexy

alexy

2013-04-04 08:01

developer   ~0008309

Fixed copy-paste error, use "transform" rather than "storage"
At revision: 21861
pinter

pinter

2013-04-04 08:11

developer   ~0008310

I will set the status as closed once it is confirmed whether the const char* member constants are not needed.
alexy

alexy

2013-04-04 09:50

developer   ~0008311

Fixed in http://na-mic.org/Bug/view.php?id=3046

Issue History

Date Modified Username Field Change
2013-04-04 06:16 pinter New Issue
2013-04-04 06:16 pinter Status new => assigned
2013-04-04 06:16 pinter Assigned To => alexy
2013-04-04 08:01 alexy Note Added: 0008309
2013-04-04 08:01 alexy Status assigned => resolved
2013-04-04 08:01 alexy Resolution open => fixed
2013-04-04 08:11 pinter Note Added: 0008310
2013-04-04 09:45 pieper Relationship added related to 0003047
2013-04-04 09:50 alexy Note Added: 0008311
2013-04-04 09:53 pinter Status resolved => closed
2013-04-04 09:53 pinter Fixed in Version => Slicer 4.3.0
2014-03-06 06:16 jcfr Target Version => Slicer 4.3.0