View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003020Slicer4Core: Base Codepublic2013-03-17 08:032014-03-06 05:02
Reporterimphead Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003020: Modifying the transform matrix of a linear transform does not change file status to "Modified"
Description

Here's another situation that can easily lead to data loss:

Transforms->Active Transforms->Create new Linear Transform (LinearTransform_3 is saved)
Save->Save (in Save Scene and Unsaved Data)
Transforms->Transform Matrix-> change an entry!

Now, in the Save Scene dialog LinearTransform_3 is marked as "Not Modified", which is not what I'd expect.

TagsNo tags attached.

Relationships

duplicate of 0003303 closedjcfr Transform file doesn't show has modified after updating the transform 
related to 0003241 closedjcfr Transforms are not applied to volumes when scene is read from a file 

Activities

jcfr

jcfr

2013-03-19 10:23

administrator   ~0008151

Will be discussed during March 19th 2013 Developer Hangout. See http://www.slicer.org/slicerWiki/index.php/Developer_Meetings/20130319
jcfr

jcfr

2013-03-19 12:17

administrator   ~0008166

Reminder sent to: finetjul

Hi Julien, do you think this could be related to the change you did regarding the SaveDialog / Modified time ?
finetjul

finetjul

2013-03-19 12:28

administrator   ~0008168

Jc, the described workflow was never "working". The issue can be reproduced in Slicer 3.

Note to developer:
Investigate what goes wrong in <code>vtkMRMLTransformNode::GetModifiedSinceRead()</code>
I suspect that changing the matrix directly does not call Modified() on the vtkMatrix itself. (Then it means the issue would be in ctkVTKMatrixWidget)
jcfr

jcfr

2013-03-19 13:23

administrator   ~0008173

@Alex: Based on your investigation, if it turns out to be a CTK issue, you could submit a pull request. See http://www.commontk.org/index.php/Contributing_to_CTK
jcfr

jcfr

2013-09-02 20:18

administrator   ~0009806

Fixed in r22308
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=22308
jcfr

jcfr

2014-03-06 05:00

administrator   ~0010857

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2013-03-17 08:03 imphead New Issue
2013-03-17 08:03 imphead Status new => assigned
2013-03-17 08:03 imphead Assigned To => jcfr
2013-03-19 10:23 jcfr Note Added: 0008151
2013-03-19 12:17 jcfr Note Added: 0008166
2013-03-19 12:28 finetjul Note Added: 0008168
2013-03-19 13:18 jcfr Target Version => Slicer 4.3.0
2013-03-19 13:23 jcfr Note Added: 0008173
2013-09-02 20:16 jcfr Relationship added related to 0003303
2013-09-02 20:16 jcfr Relationship added related to 0003241
2013-09-02 20:17 jcfr Relationship replaced duplicate of 0003303
2013-09-02 20:18 jcfr Note Added: 0009806
2013-09-02 20:18 jcfr Status assigned => resolved
2013-09-02 20:18 jcfr Fixed in Version => Slicer 4.3.0
2013-09-02 20:18 jcfr Resolution open => fixed
2014-03-06 05:00 jcfr Note Added: 0010857
2014-03-06 05:02 jcfr Status resolved => closed