View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002983 | Slicer4 | Module DICOM | public | 2013-02-26 05:24 | 2017-06-07 23:27 |
Reporter | pinter | Assigned To | pieper | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.2.2-1 | ||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0002983: DICOM browser doesn't show up on clicking the DCM button when DICOM module is active | ||||
Description | When clicking the DCM button (file icon with double purple arrows on the left side of the toolbar) when any but the DICOM module is active, then the browser pops up. But when the DICOM module is active (for example just closing the browser or importing or deleting a patient, which operations close the browser), the DCM button does nothing. This is inconsistent and probably confuses some users (I know how it works and still, I keep pressing the DCM button in vain). | ||||
Tags | No tags attached. | ||||
Yes - agreed. Don't yet know how the module can get signals from the toolbar (except by a fragile hack...) But will think about it. |
|
Sorry about the duplicate, looking at the issue names I could not found an obvious instance of this one. |
|
No problem - just wanted to add the link for future reference. |
|
I took another look and I think we can do this by having the module connect to the actionLoadDICOM from the qSlicerAppMainWindow and then raise the browser in response. |
|
Revision http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21777 fixes this issue. The DICOM browser now appears on clicking the DCM buttoneven if the DICOM module is active. |
|
I discovered a minor problem. When I click on a new patient/study/series in the table, the DICOM browser window jumps back to a default position. |
|
Hi Csaba - good catch - can you try again with r21782? If that's not the fix I may need more info to reproduce. -Steve |
|
I'd say this is all set - Csaba, can you close if you agree? |
|
Unfortunately I still have the same issue on Windows (with r21782). It's as simple to reproduce as to open the DICOM browser, drag it away a bit, then clicking the DCM button again. |
|
I saw the fixes in rev21782, so I updated and tried rev21787. Unfortunately the DICOM browser still jumps to the default position. |
|
Hi Csaba - I can't seem to replicate this on either windows or mac - tried my local build and the windows download. Can you try again and let me know if it still happens for you? Here's what I tried:
Do you see something different? |
|
Hi Csaba - Do you still see the moving behavior of the dicom browswer you mentioned in the note? -Steve |
|
Yes, it still jumps under Windows 7 64 bit using revision 21839. If I do the same steps as you did, then on step 3 (click the DCM button) it always jumps back to the position where it was when exiting the DICOM browser the last time. Trying to clarify:
|
|
Ah - I see the difference. I wasn't closing it in between. |
|
Today I reverted to the last revision that worked perfectly on windows (21787 on March 9), and I don't have this jumping issue with this version. Steve, please wait with this issue until the Slicer build is fixed on Windows, so that I can try it with an actually working non-hacked one. It is possible that it is actually all good now. |
|
Today I tried with the latest version on Windows, and it works as expected. Thank you, Steve for the fix (and your patience :) )! |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Slicer: 2145-support-for-installing-extension-from-file 2e642dcd 2013-02-28 16:18:39 Details Diff |
BUG: 0002983 and 0002206 fix position of the dicom popup Detect when the window is already open so it doesn't get repositioned more than once. Also keep track of when you have applied the settings geometry and then don't apply the standard placement in that case. git-svn-id: http://svn.slicer.org/Slicer4/trunk@21782 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Modules/Scripted/DICOM/DICOMLib/DICOMWidgets.py | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-02-26 05:24 | pinter | New Issue | |
2013-02-26 05:24 | pinter | Status | new => assigned |
2013-02-26 05:24 | pinter | Assigned To | => pieper |
2013-02-26 10:58 | pieper | Note Added: 0008051 | |
2013-02-26 10:58 | pieper | Status | assigned => acknowledged |
2013-02-26 10:58 | pieper | Relationship added | duplicate of 0002206 |
2013-02-26 11:01 | pinter | Note Added: 0008052 | |
2013-02-26 13:01 | pieper | Note Added: 0008055 | |
2013-02-26 13:12 | jcfr | Target Version | => Slicer 4.3.0 |
2013-02-27 03:05 | pieper | Note Added: 0008057 | |
2013-02-28 05:56 | pinter | Note Added: 0008070 | |
2013-02-28 05:56 | pinter | Status | acknowledged => closed |
2013-02-28 05:56 | pinter | Resolution | open => fixed |
2013-02-28 05:56 | pinter | Fixed in Version | => Slicer 4.3.0 |
2013-02-28 10:05 | pinter | Note Added: 0008071 | |
2013-02-28 10:05 | pinter | Status | closed => assigned |
2013-02-28 11:19 | pieper | Note Added: 0008072 | |
2013-03-05 02:34 | pieper | Note Added: 0008085 | |
2013-03-05 02:34 | pieper | Status | assigned => resolved |
2013-03-05 06:02 | pinter | Note Added: 0008086 | |
2013-03-05 06:02 | pinter | Status | resolved => assigned |
2013-03-06 04:50 | pinter | Note Added: 0008089 | |
2013-03-10 11:00 | pieper | Note Added: 0008105 | |
2013-03-25 13:47 | pieper | Note Added: 0008236 | |
2013-03-25 13:47 | pieper | Status | assigned => feedback |
2013-03-25 14:32 | pinter | Note Added: 0008238 | |
2013-03-25 14:34 | pieper | Note Added: 0008239 | |
2013-03-25 14:34 | pieper | Status | feedback => acknowledged |
2013-03-27 13:06 | pinter | Note Added: 0008253 | |
2013-04-04 06:23 | pinter | Note Added: 0008308 | |
2013-04-04 06:23 | pinter | Status | acknowledged => closed |
2013-07-04 13:56 | pieper | Note Added: 0008849 | |
2013-07-04 13:56 | pieper | Status | closed => resolved |
2014-03-06 05:15 | jcfr | Note Added: 0011095 | |
2014-03-06 05:16 | jcfr | Status | resolved => closed |
2017-06-07 23:27 | pieper | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file 2e642dcd |