View Issue Details

IDProjectCategoryView StatusLast Update
0002983Slicer4Module DICOMpublic2017-06-07 23:27
Reporterpinter Assigned Topieper  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002983: DICOM browser doesn't show up on clicking the DCM button when DICOM module is active
Description

When clicking the DCM button (file icon with double purple arrows on the left side of the toolbar) when any but the DICOM module is active, then the browser pops up. But when the DICOM module is active (for example just closing the browser or importing or deleting a patient, which operations close the browser), the DCM button does nothing. This is inconsistent and probably confuses some users (I know how it works and still, I keep pressing the DCM button in vain).

TagsNo tags attached.

Relationships

duplicate of 0002206 closedpieper Streamline the way the DICOM dialog is opened 

Activities

pieper

pieper

2013-02-26 10:58

administrator   ~0008051

Yes - agreed. Don't yet know how the module can get signals from the toolbar (except by a fragile hack...) But will think about it.

pinter

pinter

2013-02-26 11:01

developer   ~0008052

Sorry about the duplicate, looking at the issue names I could not found an obvious instance of this one.

pieper

pieper

2013-02-26 13:01

administrator   ~0008055

No problem - just wanted to add the link for future reference.

pieper

pieper

2013-02-27 03:05

administrator   ~0008057

I took another look and I think we can do this by having the module connect to the actionLoadDICOM from the qSlicerAppMainWindow and then raise the browser in response.

pinter

pinter

2013-02-28 05:56

developer   ~0008070

Revision http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21777 fixes this issue. The DICOM browser now appears on clicking the DCM buttoneven if the DICOM module is active.
Thank you, Steve!

pinter

pinter

2013-02-28 10:05

developer   ~0008071

I discovered a minor problem. When I click on a new patient/study/series in the table, the DICOM browser window jumps back to a default position.

pieper

pieper

2013-02-28 11:19

administrator   ~0008072

Hi Csaba - good catch - can you try again with r21782? If that's not the fix I may need more info to reproduce. -Steve

pieper

pieper

2013-03-05 02:34

administrator   ~0008085

I'd say this is all set - Csaba, can you close if you agree?

pinter

pinter

2013-03-05 06:02

developer   ~0008086

Unfortunately I still have the same issue on Windows (with r21782). It's as simple to reproduce as to open the DICOM browser, drag it away a bit, then clicking the DCM button again.
If there is anything I can try or do, please let me know!

pinter

pinter

2013-03-06 04:50

developer   ~0008089

I saw the fixes in rev21782, so I updated and tried rev21787. Unfortunately the DICOM browser still jumps to the default position.

pieper

pieper

2013-03-10 11:00

administrator   ~0008105

Hi Csaba -

I can't seem to replicate this on either windows or mac - tried my local build and the windows download. Can you try again and let me know if it still happens for you?

Here's what I tried:

  • enter dicom module, browser shows
  • move the browser
  • click the DCM button on tool bar, no change
  • exit dicom module and click tool bar DCM button again and browser comes back to where it was

Do you see something different?

pieper

pieper

2013-03-25 13:47

administrator   ~0008236

Hi Csaba -

Do you still see the moving behavior of the dicom browswer you mentioned in the note?

-Steve

pinter

pinter

2013-03-25 14:32

developer   ~0008238

Yes, it still jumps under Windows 7 64 bit using revision 21839.

If I do the same steps as you did, then on step 3 (click the DCM button) it always jumps back to the position where it was when exiting the DICOM browser the last time. Trying to clarify:

  • Open DICOM module, the browser appears on position A
  • Move the browser to position B
  • Click DCM button, the browser jumps back to position A
  • Move the browser to position C
  • Change to a different module (e.g. Models)
  • Click DCM button, the browser jumps to position C
  • Move the browser to position D
  • Click DCM button, the browser jumps back to position C !
pieper

pieper

2013-03-25 14:34

administrator   ~0008239

Ah - I see the difference. I wasn't closing it in between.

pinter

pinter

2013-03-27 13:06

developer   ~0008253

Today I reverted to the last revision that worked perfectly on windows (21787 on March 9), and I don't have this jumping issue with this version.

Steve, please wait with this issue until the Slicer build is fixed on Windows, so that I can try it with an actually working non-hacked one. It is possible that it is actually all good now.

pinter

pinter

2013-04-04 06:23

developer   ~0008308

Today I tried with the latest version on Windows, and it works as expected.

Thank you, Steve for the fix (and your patience :) )!

pieper

pieper

2013-07-04 13:56

administrator   ~0008849

http://svn.slicer.org/Slicer4/trunk@21777

jcfr

jcfr

2014-03-06 05:15

administrator   ~0011095

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 2e642dcd

2013-02-28 16:18:39

pieper

Details Diff
BUG: 0002983 and 0002206 fix position of the dicom popup

Detect when the window is already open so it doesn't get repositioned
more than once. Also keep track of when you have applied the
settings geometry and then don't apply the standard placement
in that case.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21782 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOM/DICOMLib/DICOMWidgets.py Diff File

Issue History

Date Modified Username Field Change
2013-02-26 05:24 pinter New Issue
2013-02-26 05:24 pinter Status new => assigned
2013-02-26 05:24 pinter Assigned To => pieper
2013-02-26 10:58 pieper Note Added: 0008051
2013-02-26 10:58 pieper Status assigned => acknowledged
2013-02-26 10:58 pieper Relationship added duplicate of 0002206
2013-02-26 11:01 pinter Note Added: 0008052
2013-02-26 13:01 pieper Note Added: 0008055
2013-02-26 13:12 jcfr Target Version => Slicer 4.3.0
2013-02-27 03:05 pieper Note Added: 0008057
2013-02-28 05:56 pinter Note Added: 0008070
2013-02-28 05:56 pinter Status acknowledged => closed
2013-02-28 05:56 pinter Resolution open => fixed
2013-02-28 05:56 pinter Fixed in Version => Slicer 4.3.0
2013-02-28 10:05 pinter Note Added: 0008071
2013-02-28 10:05 pinter Status closed => assigned
2013-02-28 11:19 pieper Note Added: 0008072
2013-03-05 02:34 pieper Note Added: 0008085
2013-03-05 02:34 pieper Status assigned => resolved
2013-03-05 06:02 pinter Note Added: 0008086
2013-03-05 06:02 pinter Status resolved => assigned
2013-03-06 04:50 pinter Note Added: 0008089
2013-03-10 11:00 pieper Note Added: 0008105
2013-03-25 13:47 pieper Note Added: 0008236
2013-03-25 13:47 pieper Status assigned => feedback
2013-03-25 14:32 pinter Note Added: 0008238
2013-03-25 14:34 pieper Note Added: 0008239
2013-03-25 14:34 pieper Status feedback => acknowledged
2013-03-27 13:06 pinter Note Added: 0008253
2013-04-04 06:23 pinter Note Added: 0008308
2013-04-04 06:23 pinter Status acknowledged => closed
2013-07-04 13:56 pieper Note Added: 0008849
2013-07-04 13:56 pieper Status closed => resolved
2014-03-06 05:15 jcfr Note Added: 0011095
2014-03-06 05:16 jcfr Status resolved => closed
2017-06-07 23:27 pieper Changeset attached => Slicer 2145-support-for-installing-extension-from-file 2e642dcd