View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002980Slicer4Core: Base Codepublic2013-02-25 06:212017-06-07 23:27
Reporterfedorov Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002980: Volumes not marked as modified on Save after hardening parent transform
Description

reproducible in Feb 23 nightly with MRHEad sample data. To reproduce load the volume, create arbitrary tfm, place the volume under the transform, harden, save data.

TagsNo tags attached.

Relationships

related to 0003260 closedjcfr Volumes not marked as modified on Save after volume image spacing/origin is changed 
related to 0003246 closedjcfr Annotation not marked as modified on Save when it is changed 
related to 0003303 closedjcfr Transform file doesn't show has modified after updating the transform 

Activities

imphead

imphead

2013-03-16 17:52

reporter   ~0008133

I've noticed this too. I lost data. I'd vote to fix this for 4.3!
jcfr

jcfr

2013-03-19 10:23

administrator   ~0008148

Will be discussed during March 19th 2013 Developer Hangout. See http://www.slicer.org/slicerWiki/index.php/Developer_Meetings/20130319
jcfr

jcfr

2013-07-12 11:37

administrator   ~0009028

To reproduce:

  1. Load MRHead SampleData
  2. Go to Data module -> Right click "insert transform"
  3. Move volume under transform
  4. Right click on volume -> Harden transform
jcfr

jcfr

2013-07-23 13:48

administrator   ~0009179

For reference: http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/IO#ModifiedSinceRead
yuzheng

yuzheng

2013-07-30 11:14

developer   ~0009279

Last edited: 2013-08-12 09:08

updated code here: https://github.com/yuzhengZ/Slicer/commit/622e46794bb232b20365cc405a29ab8691240f16

The factoring work for JKToRASDirection is in another commit: https://github.com/yuzhengZ/Slicer/commit/a90f9de56ea1a4cafd0bb7410c6a406e760e68ec
jcfr

jcfr

2013-08-19 11:56

administrator   ~0009521

Fixed in r22297
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22297
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014612

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 85cb847a

2013-08-19 15:53:38

jcfr

Details Diff 		BUG: Fix "volume not marked as modified on save after harden transform".

Also, fix "annotations not marked as modified on save after they are changed" and "volume not marked as modified on save after volume origin or spacing is changed". Anytime a vtkMRMLStorableNode property that is saved in file is modified, the StorableModifiedTime time stamp must be modified.
Fixes 0002980
Fixes 0003246
Fixes 0003260

From: Yuzheng Zhou <yuzheng.zhou@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22297 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLLinearTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.h Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationControlPointsNode.cxx Diff File

Issue History

Date Modified Username Field Change
2013-02-25 06:21 fedorov New Issue
2013-02-25 06:21 fedorov Status new => assigned
2013-02-25 06:21 fedorov Assigned To => jcfr
2013-03-16 17:52 imphead Note Added: 0008133
2013-03-19 10:23 jcfr Note Added: 0008148
2013-07-11 09:18 jcfr Assigned To jcfr => yuzheng
2013-07-11 09:18 jcfr Target Version => Slicer 4.3.0
2013-07-12 11:37 jcfr Note Added: 0009028
2013-07-23 13:48 jcfr Note Added: 0009179
2013-07-23 20:29 jcfr Relationship added related to 0003241
2013-07-24 10:26 yuzheng Relationship added related to 0003246
2013-07-30 11:08 yuzheng Relationship added related to 0003260
2013-07-30 11:14 yuzheng Note Added: 0009279
2013-07-31 08:30 jcfr Relationship added related to 0002790
2013-07-31 08:30 jcfr Relationship deleted related to 0002790
2013-08-12 07:23 yuzheng Note Edited: 0009279
2013-08-12 09:08 yuzheng Note Edited: 0009279
2013-08-19 11:56 jcfr Note Added: 0009521
2013-08-19 11:56 jcfr Status assigned => resolved
2013-08-19 11:56 jcfr Fixed in Version => Slicer 4.3.0
2013-08-19 11:56 jcfr Resolution open => fixed
2013-08-19 11:58 jcfr Relationship added related to 0003303
2013-08-19 15:31 fedorov Status resolved => closed
2013-08-20 10:03 yuzheng Relationship deleted related to 0003241
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 85cb847a
2017-06-07 23:27 jcfr Note Added: 0014612
2017-06-07 23:27 jcfr Assigned To yuzheng => jcfr