View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003246Slicer4Module Annotationspublic2013-07-24 10:262017-06-07 23:27
Reporteryuzheng Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003246: Annotation not marked as modified on Save when it is changed
Description

Reproducible in July 23 nightly with MRHEad sample data.

To reproduce:

  1. Load MRHead SampleData
  2. Click the "Fiducials" button on the "mouse interaction" panel to add a fiducal point on the image
  3. Save data
  4. Modify the fiducial point and Save data

The same bug exists for "Ruler" and "ROI" annotations.

TagsNo tags attached.

Relationships

related to 0002980 closedjcfr Volumes not marked as modified on Save after hardening parent transform 
related to 0003303 closedjcfr Transform file doesn't show has modified after updating the transform 

Activities

yuzheng

yuzheng

2013-07-30 11:13

developer   ~0009278

Last edited: 2013-08-12 10:24

Fix is here: https://github.com/yuzhengZ/Slicer/commit/622e46794bb232b20365cc405a29ab8691240f16
jcfr

jcfr

2013-08-19 11:55

administrator   ~0009519

Fixed in r22297
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22297
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014613

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 85cb847a

2013-08-19 15:53:38

jcfr

Details Diff 		BUG: Fix "volume not marked as modified on save after harden transform".

Also, fix "annotations not marked as modified on save after they are changed" and "volume not marked as modified on save after volume origin or spacing is changed". Anytime a vtkMRMLStorableNode property that is saved in file is modified, the StorableModifiedTime time stamp must be modified.
Fixes 0002980
Fixes 0003246
Fixes 0003260

From: Yuzheng Zhou <yuzheng.zhou@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22297 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLLinearTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.h Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationControlPointsNode.cxx Diff File

Issue History

Date Modified Username Field Change
2013-07-24 10:26 yuzheng New Issue
2013-07-24 10:26 yuzheng Status new => assigned
2013-07-24 10:26 yuzheng Assigned To => nicole
2013-07-24 10:26 yuzheng Relationship added related to 0002980
2013-07-24 10:30 yuzheng Assigned To nicole => yuzheng
2013-07-24 10:30 yuzheng Description Updated
2013-07-30 11:13 yuzheng Note Added: 0009278
2013-08-07 07:36 yuzheng Target Version => Slicer 4.3.0
2013-08-12 10:24 yuzheng Note Edited: 0009278
2013-08-19 11:55 jcfr Note Added: 0009519
2013-08-19 11:55 jcfr Status assigned => resolved
2013-08-19 11:55 jcfr Fixed in Version => Slicer 4.3.0
2013-08-19 11:55 jcfr Resolution open => fixed
2013-08-19 11:59 jcfr Relationship added related to 0003303
2013-09-04 07:27 yuzheng Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 85cb847a
2017-06-07 23:27 jcfr Note Added: 0014613
2017-06-07 23:27 jcfr Assigned To yuzheng => jcfr