0002840: when add new hierarchy nodes, they're collapsed in the tree view by default - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0002840	Slicer4	Core: GUI	public	2012-12-21 13:55	2013-02-12 09:40

Reporter	nicole	Assigned To	sankhesh
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Platform	linux	OS		OS Version
Product Version
Target Version	Slicer 4.3.0	Fixed in Version	Slicer 4.3.0

Summary	0002840: when add new hierarchy nodes, they're collapsed in the tree view by default
Description	After seeing the changes to resolve the model hierarchy expand/collapse bug: http://www.na-mic.org/Bug/view.php?id=2557 I tried taking out the explit call to setMRMLScene that was triggering an expand to depth of 2 in the Annotations module to try and fix bug http://www.na-mic.org/Bug/view.php?id=1735. Once annotations are in the tree and in hierarchies, the expand/collapse state is maintained, but when the hierarchy nodes are first added, they're collapsed by default, so the user has to expand them. This also happens when you're manually adding heirarchies in the Models module (though it ony becomes apparent when you drop a model into the hierarchy).
Steps To Reproduce	Go to the Models module. Load a model Right click on the Scene, select Insert Hierarchy Drag a model into the new hierarchy Hierarchy is collapsed, it should be expanded by default
Additional Information	Expanded on the displayable hierarchy node defaults to 1 in MRML/Core. Julien made a convincing argument to not have the state of the Expanded variable on the hierarchies get updated when the tree elements are expanded or collapsed, using the checkbox in the models module to illustrate the node stat, while the +/- signs in the tree show the tree state. The annotations module doesn't use that column in its scene model as it currently doesn't support the same apply to all nodes in the hierarchy functionality that the models do, so I need the tree to at least expand new hierarchies to make the user experience more friendly.
Tags	No tags attached.

sankhesh 2012-12-24 14:29 developer ~0007576	Pushed fix: https://github.com/sankhesh/Slicer/commit/3d18e7fe68c95d9ce1b9c9088ef7eb161f64b841 Kindly review and test.

nicole 2012-12-26 05:49 administrator ~0007582	That works perfectly for the Models module GUI, thanks! I'll replicate it in the Annotations module.

sankhesh 2012-12-26 06:36 developer ~0007583	Fixed in r21530 ( http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21530 )

Date Modified	Username	Field	Change
2012-12-21 13:55	nicole	New Issue
2012-12-21 13:55	nicole	Status	new => assigned
2012-12-21 13:55	nicole	Assigned To	=> sankhesh
2012-12-24 14:29	sankhesh	Note Added: 0007576
2012-12-24 14:30	sankhesh	Status	assigned => feedback
2012-12-26 05:49	nicole	Note Added: 0007582
2012-12-26 06:36	sankhesh	Note Added: 0007583
2012-12-26 06:36	sankhesh	Status	feedback => resolved
2012-12-26 06:36	sankhesh	Fixed in Version	=> Slicer 4.2.3
2012-12-26 06:36	sankhesh	Resolution	open => fixed
2012-12-26 06:36	sankhesh	Status	resolved => closed
2012-12-26 11:54	nicole	Relationship added	related to 0001735
2013-02-12 09:40	jcfr	Fixed in Version	Slicer 4.2.3 => Slicer 4.3.0